Commit Graph

3546 Commits

Author SHA1 Message Date
Maxime Beauchemin
94cb20cf96
Apply SQL_QUERY_MUTATOR to explore & dashboard (#5493)
* Apply SQL_QUERY_MUTATOR kn explore & dashboard

* Add unit test
2018-07-26 15:20:23 -07:00
Maxime Beauchemin
e22fcb9abf
[sql lab] fix Hive 'Transport' not open issue (#5494) 2018-07-26 15:18:49 -07:00
Maxime Beauchemin
41286b7545
[sql lab] extract Hive error messages (#5495)
* [sql lab] extract Hive error messages

So pyhive returns an exception object with a stringified thrift error
object. This PR uses a regex to extract the errorMessage portion of that
string.

* Unit test
2018-07-26 15:17:55 -07:00
JamshedRahman
54fba0f39c Visualization Unicode bug fix (#5387)
* Visualization Unicode bug fix

* Fix the build (#5403)

The travis build has been failing for 2 reasons recently
* pylint takes > 10 minutes without outputing
* bad merge confict auto resolve in controls.jsx

* Visualization Unicode bug fix
2018-07-26 13:18:35 -07:00
Grace Guo
7ff02c0050
[migration] bug fix in dashboard migration (bebcf3fed1fe_) (#5497)
fix a bug in handle empty rows
2018-07-26 13:15:09 -07:00
Yoon
3df82d9da6 Modify Athena connection description (#5492) 2018-07-25 23:12:14 -07:00
Beto Dealmeida
dfb6147715 Remove is-react dep (#5478) 2018-07-25 11:02:50 -07:00
Grace Guo
3f2fc8f413
retire dashboard v1 (js and python) (#5418) 2018-07-24 15:23:30 -07:00
Grace Guo
fd2d4b0e58
Migrate dashboard positions data from v1 to v2 format (#5463)
* Migrate dashboard positions data from v1 to v2 format

* UPDATING.md

* rebase onto master
2018-07-24 15:14:11 -07:00
John Bodley
bfcc3a633b [migration] Fix migration 3dda56f1c (#5471) 2018-07-24 14:05:00 -07:00
timifasubaa
bea0a0aa15 fix migration 3dda56f1c (#5468)
* fix migration 3dda56f1c

* add isodate to setup.py:
2018-07-23 16:27:41 -07:00
Maxime Beauchemin
fee5023269
Move flake8-related packages deps to reqs-dev.txt (#5460)
* Move flake8-related packages deps to reqs-dev.txt

My VIM which is integrated with flake8 wouldn't match the output from
travis and would often miss things related to the flake8 plugins
installed using Tox.

By moving this to requirements-dev.txt, we can expect developers would
have the proper configuration locally and get matching results with
Travis when running flake8 or in their IDEs if its integrated with
flake8..

* merging migratinos

* sorting packages

* Specify folder for flake8 processing

* pin pycodestyle==2.3.1

* merge db migrations
2018-07-23 12:29:21 -07:00
Maxime Beauchemin
a11e47f694
Add row_limit control to line chart (#5426)
Somehow it's not possible to set the row_limit for a line chart,
resulting to a 10k cap in our environment. In some cases the user may
want more than that.
2018-07-23 11:54:12 -07:00
Ville Brofeldt
a165aec822 Fix broken dedup and remove redundant db_spec logic (#5467)
* Fix broken dedup and remove redundant db_spec logic

* Add test case
2018-07-23 10:41:38 -07:00
Maxime Beauchemin
971e9f0993
Fix the build by merging both db migrations heads (#5464) 2018-07-23 09:43:09 -07:00
John Bodley
7fcc2af68f
[sql] Correct SQL parameter formatting (#5178) 2018-07-21 12:01:26 -07:00
Maxime Beauchemin
6e7b5879be
Clarify title when importing a table (#5454)
The flow to import a table definition in Superset is confusing, user may
think they are creating a table or what not. This makes the flow a bit
more clear.
2018-07-21 10:39:41 -07:00
George
0d5443e392 Add week granularity for Clickhouse (#5455) 2018-07-21 09:53:21 -07:00
Andre Lesa
c545fdf589 Added Zambia geojson up to district level. (#5436) 2018-07-20 15:46:41 -07:00
gbates101
90decbc5db Migrated to click (#5410)
* Migrate flask_script to the Flask built-in click.

Flask 0.11 is the built-in integration of the click command line interface.
Flask-Migrate support for the new Flask CLI based on Click after Release 2.0.0.

* Resolved merge conflicts.

* Fixed issue introduced from bad merge.

* Fixed flake8 errors, added build to excluded flake8 stuff.

* * Moved the FlaskGroup declaration to the driver script.
* Moved shell context definition to cli.py
* Switched shell context definition to use decorator.
* Moved create_app definition to cli.py
* Fixed InvocationError with a wrapped function

* Added extra newlines between functions

* Removed flask-script dependency.
2018-07-20 15:26:33 -07:00
Ville Brofeldt
670b145b1e Add Snowflake connection string instructions (#5443) 2018-07-20 15:19:18 -07:00
Beto Dealmeida
83e1e2c0fe Time filter fixes (#5448)
* Fixes for the new time filter

* Fix dashboard

* Trigger tests
2018-07-20 15:15:33 -07:00
timifasubaa
41447e8b3b
remove limiting at the display level (#5413) 2018-07-19 17:36:03 -07:00
Vishal Jagtap
6441f69271 Typo fixes in viz.py and CONTRIBUTING.md (#5432) 2018-07-19 16:45:56 -07:00
Maxime Beauchemin
99ce7b79fa
Add pylint back as a tox env (#5416) 2018-07-18 15:55:01 -07:00
Maxime Beauchemin
5be0e69d1b
Avoid expensive select_star on dashboard bootstrap data (#5424)
The dashboard page bootstrap data currently attempts to generate the
`SELECT` statement with column name details for each table represented
in the dash. This means it calls the database(s) and waits for column
details prior to returning any HTML.

This makes the default select_star property generate a simple
`SELECT *` with no column details instead, which doesn't require
interogating the DBs.
2018-07-18 15:54:47 -07:00
Vishal Jagtap
b0b04b319b Fixed typos in currently modified files (#5419) 2018-07-18 08:32:47 -07:00
timifasubaa
7f8eaee18d
allow selection of dbs where csv can be uploaded to (#5393) 2018-07-17 15:38:16 -07:00
Maxime Beauchemin
73ec526913
Fix db migration 3dda56f1c4c6 (#5415) 2018-07-17 15:30:18 -07:00
Chris Williams
8b7aaec19d
[webpack 4] third time's the charm ;) (#5370)
* [perf] add webpack 4 + SplitChunks + lazy load visualizations (#5240)

* [webpack] setup lazy loading for all visualizations

* [lazy-load] push renderVis function to <Chart /> state

* no mapbox token

* [lazy loading] use native webpack import func to fix chunk names, add babel-plugin-syntax-dynamic-import, fix rebase bug.

* fix geojson import, undefined t, and fix async css bug

* [lazy load] actually add babel-plugin-syntax-dynamic-import

* [webpack] working dev version of webpack v4

* [webpack 4] fix url issues, use mini-css-extract-plugin and webpack-assets-manifest plugins

* [webpack 4] use splitchunks for all files, update templates to multi-file entrypoints

* [webpack 4] multiple theme entry files for markup vis css, don't uglify mapbox

* [webpack 4] lint python manifest changes, update yarn lock.

* [webpack 4] fix tests with babel-plugin-dynamic-import-node

* [webpack 4] only use 'dynamic-import-node' plugin in tests, update <Chart /> vis promise when vis type changes

* [webpack 4] clean up package.json and yarn.lock after rebase

* [webpack 4] lint?

* [webpack 4] lint for real

* [webpack 4][istanbul] ignore visualizations/index.js

* [webpack 4] fix rebase bug, update dashboard/deprecated/chart/Chart.jsx to use vis promises.

* [webpack 4] lint and test

* [webpack 4] yarn.lock
2018-07-17 13:55:03 -07:00
Beto Dealmeida
75cf5e198f Fix time filter in dashboard v2 (#5412) 2018-07-17 13:38:33 -07:00
Chris Williams
7670e0c565
allow 7 tabs, remove 'slice_' prefix in logs (#5411) 2018-07-17 13:20:19 -07:00
Beto Dealmeida
7b4e6c7455 Time shift difference (#5177)
* Allow different comparisons when using time shift

* Remove test code

* Remove lead/trail NaN and improve code

* Add headers/subheader

* Update yarn

* Migration script

* Fix migration

* Small fixes

* Trigger tests

* Fix lint

* Fix javascript
2018-07-16 16:30:11 -07:00
timifasubaa
f8a6e09220
[sqllab] Fix sqllab limit regex issue with sqlparse (#5295)
* include items after limit to the modified query

* use sqlparse
2018-07-16 15:27:30 -07:00
Beto Dealmeida
c445ef8c43 Explore to SQL Lab (#5101)
* WIP

* Working version

* Clean code

* Fix lint

* Fix unit test; show only for sqla

* Working on UX

* Dropdown working 66%

* Working but needs CSS

* Fixed table

* Fix lint

* Fix unit test

* Fix languages path

* Fixes

* Fix Javascript lint
2018-07-16 15:00:48 -07:00
Maxime Beauchemin
48317fd8f9
[big_number] tooltip shows in the wrong place (#5404) 2018-07-16 14:59:14 -07:00
Beto Dealmeida
4fa416347d Make time filter more usable (#4981)
* Initial work

* WIP

* WIP

* Working

* WIP

* Still WIP

* Frontend done

* Working version

* Migration working

* Migration working

* Fix freeform rerender

* Remove jquery

* Fix filter

* Unit tests and lint

* Fix py.test

* Improve unit tests

* Ensure freeform is computed at init

* Fix lint

* Trying to fix pyfreeze error

* Remove freezegun

* Address comments

* Use tabs instead of pills

* Regroup options

* WIP

* Change type when clicking calendar

* Fix CSS

* Fix JS lint
2018-07-16 14:27:40 -07:00
Grace Guo
0d10cc569d
[Table Viz] columns not match with group_by control (#5329) 2018-07-16 14:06:29 -07:00
Maxime Beauchemin
709f056445
[bugfix] make MetricsControl work with DECK visualizations (#5376)
* [bugfix] make MetricsControl work with DECK visualizations

* Add unit tests
2018-07-16 13:42:07 -07:00
Hugh A. Miles II
e79bb92a40
Add IS NOT NULL and IS NULL as filter options (#5375)
* wip

* disable value selector on IS NOT NULL or NOT NULL

* remove this
2018-07-16 13:29:55 -07:00
Maxime Beauchemin
996304aba9
Make Pypi upload support markdown (#5352)
Moving to using Twine to upload to pypi and fixing up the markdown
support so that the page on Pypi looks like the README on Github.

This has been tested on the 0.26 branch starting 0.26.3
2018-07-16 12:27:57 -07:00
Ville Brofeldt
bd475879a4 Fix display limit in sql lab (#5392)
* Fix display limit in sql lab

* Add redundant variable from config.py

* Fix test config

* Change to SQL_MAX_ROW

* Remove last remaining occurence of DISPLAY_SQL_MAX_ROW
2018-07-16 11:58:21 -07:00
Maxime Beauchemin
2eeff2ae0b Fix the build (#5403)
The travis build has been failing for 2 reasons recently
* pylint takes > 10 minutes without outputing
* bad merge confict auto resolve in controls.jsx
2018-07-16 11:46:13 -07:00
timifasubaa
22b7c2db62
quote hive column names (#5368) 2018-07-13 15:51:16 -07:00
Chris Williams
19ac6e1231
get rid of global notify (#5355)
* [toasts] get rid of notify globals, refactor messageToasts for use by entire app

* [remove notify] use arrow func in ajax call

* fix lint + tests

* actually fix tests from messageToast refactor

* add 'test:one' npm script

* debugger

* [toasts] convert bootstrap flash messages to toasts in explore + sqllab

* [toasts][tests] import from right file
2018-07-12 11:50:25 -07:00
Maxime Beauchemin
f9352af80e
[pie] improvements to pie charts (#5236)
Pie chart was using `limit` instead of `row_limit` which didn't work.

Also set a lower default limit to 25 to prevent the chart from getting
super crowded.

Unrelated drive-by fix of setting "percentage metric" to default to `[]`
2018-07-12 10:33:11 -04:00
Maxime Beauchemin
0ca426a6fa
Set control 'percent_metrics's default to [] (#5357) 2018-07-12 10:32:00 -04:00
JamshedRahman
cafde1536f Adding Druid Time Granularities (#5379)
* Adding Druid Time Granularities

* fixed a linter error
2018-07-12 10:19:50 -04:00
Hugh A. Miles II
cd2414b19e Set ignore NaN as true for TableViz (#5371)
* set ignore NaN as true for TableViz

* linting
2018-07-11 11:20:45 -04:00
Grace Guo
6b15592dd0
[dashboard] should use forceV2Edit property name (#5362) 2018-07-08 22:11:24 -07:00