* Add drill-to-detail modal.
* Include additional filters from dashboard context in request.
* Set page cache size to be approximately equal to memory usage of Samples pane.
* Update getDatasourceSamples signature.
* One-line import/export.
* Fix incorrect argument order in getDatasourceSamples invocation.
* Fix height of modal.
* Disable option in chart menu unless feature flag is set.
* Open modal on right-click.
* Fix double requests on modal open, controls disappearing on filter update.
* Show formattedVal in clearable filter tag.
* Set force=false for all requests.
* Rearrange/refactor DrillDetailPane.
* Reset page index on reload.
* Fix endless re-requests on request failure.
* Fix modal layout issues.
* updates to allow insertion of workspace home sidescroll/table UI
* fix types
* fix User type import
* add welcome message to ui registry
* add extra fields to individual chart/query GET results (for workspace home required info)
* update list view card to support a subtitle
* add id to individual chart fetch
* update chart api test
* another test fix
* fix saved query test
* update extension types + insert point
* fix typing
* fix type name
* feat: Adds drill to detail context menu for ECharts visualizations
* Rebases and adds time grain
* Fixes selected gauge values
* Fixes Treemap edge click
* Adds right click to big number trendline
* Address some comments
* Moving entire split save btn PR
* Addressed review comments
* Remove arbitrary div from ErrorBoundary in Chart
* Added accidentally removed comment
* Fix act errors in SaveQuery tests
* Fix SaveDatasetActionButton test
* SaveDatasetModal test almost working
* SaveDatasetModal tests all passing
* Clean SaveDatasetModal test
* Fix create chart button and SaveDatasetModal text in SQL Lab
* Fix untitled dataset name on SaveDatasetModal in explore
* Fix styling on split save button
* feat(dashboard): Use react-router for transition to Explore + cmd click to open in new tab
* Update tooltip
* Add a feature flag
* Update edit chart onclick event
* Fix lint
* Fix tests
* Change feature flag name
* Add tooltip to Edit chart
* add flow for dbconnmodal to datasetmodal
* fix bug
* second part
* fix dataset to sql lab
* fix lint
* more lint
* add key value
* fix type
* add new styling
* remove undefined from types
* Save Dataset Modal:
- Use our Select component as substitute of the Autocomplete one so options are loaded initially without the user having to trigger a search and we are mosre consistent with the rest of the app
- Changing datasetId to lowercase so when custom props get into the DOM we don't get warning related to invalid formatting
- We extracted the dropdown out of the radio because it causes invalid click handling when an option is selected
- Updated tests
* Save Dataset Modal:
- Update missing test for DatasourceControl
* Save Dataset Modal:
- Remove conditional from load options function since only guest users dont have userId, and if that is the case they wont reach this part of the application
* Save Dataset Modal:
- Remove unused comment
* Save Dataset Modal:
- Add getPopupContainer as prop for Select component
* Save Dataset Modal:
- Add tests for our new getPopupContainer prop in Select component. So if passed it gets called.
* Save Dataset Modal:
- use lowercased property when calling post form data
* Save Dataset Modal:
- Update tests so there is no need to define a null returning func
* Save Dataset Modal:
- Including getPopupContainer from PickedSelectProps instead
- Updating definition in SelectFilterPlugin
* chore: Restructure explore redux state
* fixes
* fix tests
* add new tests
* Fix type
* Address comments
* Fix bug
* Fix import
* Add new test
* Move unsaved chart id to a constant
* Add todo
* fix(home): make to update the css style of links
* fix(home): make to fix lint issue
* fix(home): make to remove underline when tab is active
* fix(homes): make to fix the issue of tab
* fix(home): make to move styles to a tag
* move postForm to superset client
* lint
* fix lint
* fix type
* update tests
* add tests
* add test for form submit
* add test for request form
* lint
* fix test
* fix tests
* more tests
* more tests
* test
* lint
* more test for postForm
* lint
* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* update tests
* remove useless test
* make test cover happy
* make test cover happy
* make test cover happy
* make codecov happy
* make codecov happy
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* fix(cosmetic): cannot find m-r-10 class in superset.less
* fix: remove .m-r-10 class and use emotion instead
* Update superset-frontend/src/components/Datasource/CollectionTable.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/components/Datasource/DatasourceEditor.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* add icons
* Implement fast viz switcher component
* Remove unnecessary keys from ControlsPanelContainer
* Rename icons
* Add unit tests
* Add licenses
* Fix test
* Change BigNumberWithTrendline to BigNumber
* fix test
* fix test
* Add currently rendered viz tile
* Move View all charts to the right side
* Add license
* Fix imports
* Fix e2e test
* feat(echarts): [feature-parity] support extra control
* add extra control for plugin
* refactor: extract ExtraControl
* fix: lint
* fix some problems
* more changes that didn't make it into the last commit somehow.
* Allow modals to be short, but reach a max height and scroll
* now with template literals
* fix(chart & alert): make to show metrics properly
* fix(chart & alert): make to remove duplicate metrics
* fix(chart & alert): make to restore metrics control alert slice
* fix(chart & alert): make to fix lint issue
* add BUSINESS_TYPE_ADDONS to config with example callback
* Removing uneeded whitespace
* [Work in progress] Modifying cidr function to allow for single ip and adding port outline
* Added test REST endpoint, added some more ports
I've thrown in a test.py script as well that will try to connect to the
business_type endpoint.
* Moving code from config.py into the business api
Very simple api is exposed that will allow someone to call a checkport
endpoint and get back a response.
* Removing commented out bits.
* Adding fucntion dict back to the config
* Moving business_type endpoint to charts
* Adding schema for get endpoint
* Removing imports, updating docstring, fixing typo
Just some small changes as described in the title. I've updated the
test.py as well so it functions with the endpoint changes.
* Adding translation dict
* Fixing ops
* Adding check for list
* Modifying changes to add quotes where needed
Also changed BusinessTypeResponse to resp.
* Adding in some code to call the filter config
If a column starts with "cidr_" it will call the code in config.py to
try to translate the filter. Nothing is changed in the JSON being
executed, just some information is dumped to console.
* Porting Ryan's changes
* Adding migration script (as per Ryan's PR)
* Fixing typo
* Prettier fixes
* [CLDN-1043] Adding rough version of filter changes for business types
* fix down migration
* Fixing bugs after merge
* adding functionality to appy filters in back end
* Fixing linting issues
* fix down revision
* Changing conversion callback to handle multiple values at once
* Adding string representation of values
* Code cleanup plus fixing debouce to only be called once for each entry
* Removing non needed logginh
* Changing operator list to use sting values
* Using text value operators
* Removing clear operator call
* Moving business type endpoints
* fix down revision
* Adding port functions
* update migration
* fix bad rebase and add ff
* implement validator
* dont add invalid values to response
* [CLDN-1205] Added a new exception type for a business type translation error. Added the error message in the display_value field within the business type response. Modified the IP and Port business types to populate the error message field in the response if an error occurs
* [CLDN-1205] Added meaningful error message for port translation errors
* Removing status field from businesstype Response and adding in error message
* [CLDN-1205] Added check to make sure the port business type is within the valid range of ports, if it is not, it will populate the error message
* [CLDN-1205] Fixed the if statement that checks to see if the string_value is in the valid range of port numbers. It did not corrently verify this before now.
* [CLDN-1205] Fixed an error where it was trying to use string_value in <= statements. I just casted string_value to an integer if it is numeric, which allows <= operators to be used on it
* [CLDN-1207] Added unit tests for the cidr_func and port_translation_func functions which are located in /superset/config.py
* [CLDN-1207] removed the assertRaises line as it does not work with the cidr_func and port_translation_func functions
* [CLDN-1207] Added the skeleton of the test_cidr_translate_filter_func unit test, still need to update what the expected response from the function will be.
* [CLDN-1207] Added the remainder of the back-end unit tests for the business types
* [CLDN-1207] Fixed the syntax error which caused the test_cidr_translate_filter_func_NOT_IN_double unit test to fail
* [CLDN-1207] Removed the logging that was added for debugging purposes
* [CLDN-1207] Formatted the commands_tests.py file to make it nicer to look at/read through
* [CLDN-1207] Fixed the code so that it conformed to the pylint requirements (i.e., pylint no longer complains about the code in commands_tests.py)
* [CLDN-1207] Modified some of the docstrings so they made better use of the 100 character per line, line limit
* [CLDN-1207] Added the beginnings of the unit tests for the
business types API
* [CLDN-1207] Added a comment to the top of the commands_tests.py file explaining how to run the unit tests. This prevents the next person who tries to run them from having to waste time trying the different forms of testing that Superset supports (e.g., pytest, tox, etc.)
* [CLDN-1207] Added a grammar fix to the comments describing how to run the unit tests
* [CLDN-1207] Modified the description of the business_type API endpoints as they did not represent what the API was actually doing
* [CLDN-1207] Added further instructions on how to run the unit tests that are within the business_type/api_tests.py file
* add request validation
* disable request if business type missing
* [CLDN-1207] Unit tests for the business type API are now working, however, they need to be modified to make use of @mock as we don't want to have to run the server to be able to run the unit tests
* Removing businesss types deffinitons from config
* Adding select to only show valid business types
* Fixed Enzyme tests
* Added scalfolding for selecting filter dropdown
* Adding intigration tests
* fix revision
* fix typos and unnecessary requests
* break out useBusinessTypes
* Added front-end RTL unit tests for the business type API endpoint
* Fixed error from unit tests
* Added a unit test to ensure the operator list is updated after a business type API response is received
* Removing elect compoenet for business types
* Adding feature flag and allowing saving when no business type present
* fixing useEffect hooks
* Adding feature flag to model
* Changing behavior such that an empty string returns a default response
* add form validation
* Modified comments in unit test as command to run test has changed
* Modified comments in unit test as filename to run test has changed
* Modified the api_tests.py file to conform to the linting requirements
* Changed the name of one of the tests to reflect what the test is actually testing
* Added cypress back to the package.json
* Added informative comments
* Updated comments in files as well as removed imports which were not being used
* Changes made by npm run prettier
* Fixed spelling mistakes
* Updated models.py to remove placeholder comments used in development
* Added feature flag mocking in unit test
* Fixing open api failure
* Fixing business types to pass unit tests
* Reverting unsafe connections back to false
* Removing print statement
* Adding business tpye to export test
* setting default feature flag to false for business type
* Reverting pre commit
* Reverting pre commit and running pre commit
* Reverting pre commit and running pre commit
* Fixing formatting
* Adding license
* Fixing Linting
* Protecting api enpoints
* updating model
* Fixing code path when business type exists
* Linting
* Linting
* Fixing linting
* Fixing spelling
* Fixing schemas
* Fixing app import
* fixing item render
* Added RTL test to make sure business type operator list is updated after API response
* Fixing linting
* fix migration
* Changing unit tests
* Fixing import and DB migration after rebase
* Renaming to advanced types
* Fixing Linting
* More renaming
* Removing uneeded change
* Fixing linting and test errors
* Removing unused imports
* linting
* Adding more detailed name for migration
* Moving files to plugins
* more renaming
* Fixing schema name
* Disabling feature flag that should not be enabled by default
* Adding extra cehck
* NameChange
* formatting
* Fixing equals check
* Moveing all advanced type classes and types to one file, and converting tests to functional
* Adding advanced type to test and fix linitng
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Dan Parent <daniel.parent@cse-cst.gc.ca>
Co-authored-by: GITHUB_USERNAME <EMAIL>
Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com>
* feat(explore): Show confirmation modal if user exits Explore without saving changes
* Fix calling cleanup func unnecessarily
* Fix comparing AdhocMetric instance with JSON object
* Replace sliceFormData with the initial form data
* fix(column-header-tooltip): make that hide the tooltip when the cloumn header is turncated
* fix(column-header-tooltip): fix lint
* fix(column-header-tooltip): make to dynamic tooltip header in FilterTable
* fix(column-header-tooltip): make to fix the lint issue
* fix(column-header-tooltip): make to remove the tooltip option
* fix(column-header-tooltip): make to add test and storybook for dynamic tooltip
* fix(column-header-tooltip): make to fix lint
* fix(db & connection): make to show/hide the password when only creating db connection
* fix(db & connection): make to fix unit test of Database Modal
* fix(import): make to add the error alert
* fix(import): make to add licence
* fix(import): make to create ErrorAlert component and use errorMessage spelling
* feat: add empty states to sqlab editor and select
* add suggestions and test
* update type
* lint fix and add suggestions
* fix typo
* run lint
* remove unused code
* fix test
* remove redux for propagation and other suggestions
* add t
* lint
* fix text and remove code
* ts and fix t in p
* fix spelling
* remove unused prop
* add fn to prop change state
* remove unused code
* remove unused types
* update code and test
* fix lint
* fix ts
* update ts
* add type export and fix test
* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* remove handlerror and unused code
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* feat(explore): Move save button to header, run button to bottom of control panel
* Make the tabs sticky
* Add error icon to Data tab
* Show message when creating chart and all controls are filled correctly
* Add tests and storybook
* Fix tests
* Disable save button when control have errors
* Fix types
* Apply code review comments
* Replace styled with css
* Remove unused import
* rebase
* more progress
* Fix unintended changes
* DB import goes to step 3
* debugging
* DB list refreshing properly
* import screens flowing properly
* Code cleanup
* Fixed back button on import flow
* Remove import db tooltip test
* Fix test
* Password field resets properly
* Changed import modal state dictators and removed unneeded comment
* Removed unneeded param pass and corrected modal spelling
* Fixed typos
* Changed file to fileList
* Clarified import footer comment
* Cleaned passwordNeededField and confirmOverwriteField state checks
* debugging
* Import state flow fixed
* Removed unneeded importModal check in unreachable area
* Fixed import db footer behavior when pressing back on step 2
* Import db button now at 14px
* Removed animation from import db button
* Fixed doble-loading successToast
* Fixed errored import behavior
* Updated import password check info box text
* Connect button disables while importing db is loading
* Connect button disables while overwrite confirmation is still needed
* Connect button disables while password confirmation is still needed
* Removed gray line under upload filename
* Hide trashcan icon on import filename
* Modal scroll behavior fixed for importing filename
* Changed errored to failed
* RTL testing for db import
* Move chart header to top of the page
* Implement truncating and dynamic input
* fix typing
* Prevent cmd+z undoing changes when not in edit mode
* Fix tests, add missing types
* Show changed title in altered
* feat(explore): SQL popover in datasource panel
* Fix acequire not defined
* Rebase and fix tests
* Disable highlighting gutter
* Use ace-build acequire instead of brace
* feat(dashboard): Implement empty states in empty tabs
* Change button to in text link
* Add edit dashboard button to dashboard empty state
* Add tests
* Fix test
* feat(explore): Move chart actions to a dropdown menu
* Fix tests and add some new ones
* Add background color to embed code button
* Fix cypress tests
* Move copy permalink to actions menu
* Remove unused function
* Move share by email above embed code
* Fix test
* Fix test
* Fix test
* Fix test
* Fix test
* fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart
* fix(export-add): make to setup the default error message
* fix(report-add): make to allow the errorMessage undefined in LabeledErrorBoundInput component
* fix(fonts): Import all necessary font packages
* Make html tags themable
* Set bold font weight to 600, add medium font weight to theme
* Replace hard coded font weights with theme variables
* Change some font weight light elements to normal
* Fix tests
* Fix bug in pivot table
* Address code review comments
* wip
* feat: make 401 responses configurable in SupersetClient
* sort
* guest unauthorized handler
* add toast container to embedded app
* add option for toast presenter to go at the top
* remove confusing comms logging
* lint
* Update superset-frontend/src/embedded/index.tsx
* type correction
* remove ENABLE_REACT_CRUD_VIEWS feature flag
* docs
* deal with problematic tests
* empty test suite
* skip test
* test conditions changed
* removing the tests instead of skipping
* make that the comma can be added by removing it from token separators in select component.
* fix(explore comma): add the allowTokenSeperators props into Select
* fix(explore comma): make to allow to customize the token separators in Select.
* fix(explore comma): make to add the unit test and story book.
* fix(explore comma): make to fix the lint
* fix(explore comma): make to fix the spell & add tokenSeparatprs props to PickedSelectProps
* Update Select.tsx
* fix(explore comma): make to run lint fix
* fix: allow to select <NULL> in a native filter single mode
* fix lint issue
* Update superset-frontend/src/components/Select/utils.ts
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* fix
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* fix(altered-modal): make all text fields wrap
* fix(altered-modal): limit the wrap text in particular column
* fix(altered-modal): make to update the unit test
* fix(altered-modal): make to fix the type of columnsForWrapText
* fix(alerted-modal): make to fix the type of columnsForWrapTest with string type
* fix(15849): Removed the tooltip from CopyToClipboard button in sqllab
* chore(sqllab): added props for tooltip in CopyToClipboard component
* fix(sqllab): Added arg to storybook and refactor the component
* fix(sqllab): added a test case for hideTooltip
* fix(delete-modal): Changed the color of the help text with grayScale.dark1 in DeleteModal
* Update superset-frontend/src/components/DeleteModal/index.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* fix errors with rison and useQueryParams
* add test for encode/decode
* add rison link and make test case more readable
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* add sorting for query results grid and add natural order sort
* modify tests for natural/original order state
* clean up setState
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
* feat(dashboard): Implement empty states for dashboard
* Add empty state to native filters
* Add missing license
* Remove redundant string types from EmptyState
* chore: fix misspelling of button
* changed QuerySearch/index.jsx to index.tsx
* updated Query type at src/SqlLab/types.ts/Query and extended it into QueryTable
* updated defaultQueryLimit to be optional at ResultSetProps of superset-frontend/src/SqlLab/components/ResultSet/index.tsx
* moved statusAttributes into useMemo hook so that it will not make the dependencies of useMemo Hook change on every render and statusAttributes is only used within useMomo hook
* reset package-lock.json and package.json at frontend
* Acquired redux rootestate type for SqlLab, to be used at useSelector(state)
* updated query to be Query type and added a comment for q.status on line 178
* updated queryTable for typescript conversion
* updated actions type on QueryHistory and QuerySearch
* updated type for actions in SouthPane
* created type for SqlLab redux
Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* feat(dashboard): embedded dashboard UI configuration (#17175) (#17450)
* setup embedded provider
* update ui configuration
* fix test
* feat: Guest token (for embedded dashboard auth) (#17517)
* generate an embed token
* improve existing tests
* add some auth setup, and rename token
* fix the stuff for compatibility with external request loaders
* docs, standard jwt claims, tweaks
* black
* lint
* tests, and safer token decoding
* linting
* type annotation
* prettier
* add feature flag
* quiet pylint
* apparently typing is a problem again
* Make guest role name configurable
* fake being a non-anonymous user
* just one log entry
* customizable algo
* lint
* lint again
* 403 works now!
* get guest token from header instead of cookie
* Revert "403 works now!"
This reverts commit df2f49a6d4.
* fix tests
* Revert "Revert "403 works now!""
This reverts commit 883dff38f1.
* rename method
* correct import
* feat: entry for embedded dashboard (#17529)
* create entry for embedded dashboard in webpack
* add cookies
* lint
* token message handshake
* guestTokenHeaderName
* use setupClient instead of calling configure
* rename the webpack chunk
* simplified handshake
* embedded entrypoint: render a proper app
* make the embedded page accept anonymous connections
* format
* lint
* fix test
# Conflicts:
# superset-frontend/src/embedded/index.tsx
# superset/views/core.py
* lint
* Update superset-frontend/src/embedded/index.tsx
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* comment out origins checks
* move embedded for core to dashboard
* pylint
* isort
Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* feat: Authorizing guest access to embedded dashboards (#17757)
* helper methods and dashboard access
* guest token dashboard authz
* adjust csrf exempt list
* eums don't work that way
* Remove unnecessary import
* move row level security tests to their own file
* a bit of refactoring
* add guest token security tests
* refactor tests
* clean imports
* variable names can be too long apparently
* missing argument to get_user_roles
* don't redefine builtins
* remove unused imports
* fix test import
* default to global user when getting roles
* missing import
* mock it
* test get_user_roles
* infer g.user for ease of tests
* remove redundant check
* tests for guest user security manager fns
* use algo to get rid of warning messages
* tweaking access checks
* fix guest token security tests
* missing imports
* more tests
* more testing and also some small refactoring
* move validation out of parsing
* fix dashboard access check again
* add more test
Co-authored-by: Lily Kuang <lily@preset.io>
* feat: Row Level Security rules for guest tokens (#17836)
* helper methods and dashboard access
* guest token dashboard authz
* adjust csrf exempt list
* eums don't work that way
* Remove unnecessary import
* move row level security tests to their own file
* a bit of refactoring
* add guest token security tests
* refactor tests
* clean imports
* variable names can be too long apparently
* missing argument to get_user_roles
* don't redefine builtins
* remove unused imports
* fix test import
* default to global user when getting roles
* missing import
* mock it
* test get_user_roles
* infer g.user for ease of tests
* remove redundant check
* tests for guest user security manager fns
* use algo to get rid of warning messages
* tweaking access checks
* fix guest token security tests
* missing imports
* more tests
* more testing and also some small refactoring
* move validation out of parsing
* fix dashboard access check again
* rls rules for guest tokens
* test guest token rls rules
* more flexible rls rules
* lint
* fix tests
* fix test
* defaults
* fix some tests
* fix some tests
* lint
Co-authored-by: Lily Kuang <lily@preset.io>
* SupersetClient guest token test
* Apply suggestions from code review
Co-authored-by: Lily Kuang <lily@preset.io>
Co-authored-by: Lily Kuang <lily@preset.io>