Commit Graph

4985 Commits

Author SHA1 Message Date
AAfghahi f89ba0c7c1
beginning the reducer (#20945) 2022-08-05 11:53:55 -04:00
Kamil Gabryjelski 9350bbafee
fix(explore): Replace url search params only if current page is Explore (#20972)
* fix(explore): Replace url search params only if current page is Explore

* Add unit test
2022-08-05 16:59:52 +02:00
Sam Faber-Manning 226712d831
feat: add 'dashboard.nav.right' extension to registry (#20835)
* add 'dashboard.nav.right' extension to registry

* add test
2022-08-04 15:24:34 -07:00
Lyndsi Kay Williams d42cf4e4c9
fix: Columns not passing properly from SQL Lab to Explore (#20975)
* debugging columns

* Clean up code

* Fix test
2022-08-04 14:59:50 -04:00
Phillip Kelley-Dotson fa416fa130
fix: remove extra line for link (#20959)
* fix: remove extra line for link

* add space
2022-08-04 13:29:07 -04:00
AAfghahi eb5369f2a6
fix: No back button in save dataset modal (#20964)
* back button fix

* fixed test
2022-08-03 21:29:11 -04:00
Kamil Gabryjelski e4fc5564ce
fix: Explore scrolled down when navigating from dashboard (#20962) 2022-08-03 21:55:52 +02:00
Antonio Rivero Martinez aa53c10312
Big Number Viz: (#20946)
- When the value is zero we still render the percent change and suffix if present
2022-08-03 23:12:56 +08:00
EugeneTorap 96a63bcbfe
fix: Use SPA Dataset link in Chart and Dashboard (#20941)
* Use SPA Dataset link in Chart and Dashboard

* Validate datasourceUrl

* Show datasourceName when datasourceUrl is undefined
2022-08-03 09:09:33 +02:00
Jesse Yang ac585821d8
fix(sqllab): tracking url and error alert padding (#20937) 2022-08-02 14:55:41 -07:00
Stephen Liu 7beda3bbdb
chore: change Sort-by and Sort-Descending controls for Bar Chart v2 (#20868) 2022-08-02 14:36:21 -06:00
Antonio Rivero Martinez 9362e27ce2
fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627)
* Time Series Chart:

-Apache echarts has this option as false by default for time axis, so we need to override it for our charts so it's uto determined and not fixed to hidden.
- Add AxisType enum so we stop comparing agains raw strings when checking xAxis type

* Time Series Chart:

- set the showMaxLabel option directly without using merge

* Time Series Chart:

 - Rename the property to showMaxLabel as it was originally
2022-08-02 14:35:41 -06:00
Antonio Rivero Martinez e2206a7151
Annotations: (#20720)
- Fix scrollbar when removing annotations
2022-08-02 14:31:48 -06:00
Diego Medina fe581a3640
fix: adjust timeseries grid right offset to match the rest (#20933) 2022-08-02 14:19:49 -06:00
Diego Medina dd353ca86a
feat: Add resize drag handle to Dataset SQL fields (#20670)
* feat: Add resize drag handle to Dataset SQL fields

* PR comments
2022-08-02 14:13:14 -06:00
AAfghahi 460b213057
feat: Creating dataset/add route (#20869)
* beginning of routing

* elizabeth review

* changed folder layout

* Update superset-frontend/src/views/CRUD/data/dataset/DatasetPage/index.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Update superset-frontend/src/views/CRUD/data/dataset/DatasetPage/RightPanel/index.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-08-01 16:59:40 -04:00
Lyndsi Kay Williams 8a04536f9d
feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)
* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
2022-08-01 14:36:34 -05:00
Kamil Gabryjelski 6ec164e6a9
feat: Use SPA navigation from datasets list to Explore (#20890)
* feat: Use SPA navigation from datasets list to Explore

* fix lint

* Fix lint

* Fix type

* Make external links work without protocols

* add comment
2022-08-01 16:45:07 +02:00
Kamil Gabryjelski 90e2d82a38
fix(dashboard): Incorrect scopes of cross filters (#20927) 2022-08-01 13:39:42 +02:00
Hugh A. Miles II 67e3dc7c7b
hide modal after overwrite (#20924) 2022-07-29 19:18:11 -04:00
Eric Briscoe 1a8c28db3d
Fixes issue where type query datasource had incorrect time controls when datasource type was 'query' (#20923) 2022-07-29 18:14:03 -04:00
Hugh A. Miles II 0d8889dc9c
fix: Save dataset + chart when Chart source is Query (#20880)
* feat: save dataset savemodal

* fix lint

* add comments

* enable chart power query

* clean up

* added test

* fix overwrite

* add proper error messaging for save datasetModal

* lint

* fix ts lint

* fix

* Disables Save button while network call is in progress, removing second Chart saved toast message

* change naming

* err

* Update superset-frontend/src/explore/components/SaveModal.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Update SaveModal.tsx

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-07-29 17:30:28 -04:00
dependabot[bot] adf1f5cccf
chore(deps): bump terser from 4.6.3 to 4.8.1 in /superset-frontend (#20787)
Bumps [terser](https://github.com/terser/terser) from 4.6.3 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-29 10:48:15 -06:00
Jesse Yang 5ae0e83b8a
fix(sqllab): hide tracking url when fetching (#20905) 2022-07-29 08:47:53 -07:00
Cody Leff e7acb1a79d
chore(explore): update Explore icons and icon colors (#20612)
* Update Explore icons and icon colors.

* Change shade of blue and make blue only appear when fields have never been filled in.

* Fix Cypress test.

* Update non-error validation color from blue to yellow.

* Unpack ternary.

* Replace direct AntD imports with our Icons component.
2022-07-29 09:05:15 -06:00
Cody Leff 90460f1333
Unskip Cypress test. (#20915) 2022-07-29 11:38:04 -03:00
Just[in]Do it! 3f124d9d67
fix(plugin-chart-pivot-table): Invalid Formats Date Fields (#20909)
When a custom date field value converted in a string format, some aggregators truncated to the first four digits.
 This is caused by the parseFloat function which converts to first matched number rather than NaN(Not-A-Number) value.
 This commit replaces the parseFloat by Number wrapper to handle this case correctly.
2022-07-28 22:56:08 -07:00
Cody Leff d50784dd80
feat(dashboard): Add thumbnails to dashboard edit draggable chart list (#20528)
* Add chart thumbnails to dashboard edit draggable charts.

* Reorganize hierarchy and add tests.

* Incorporate review suggestions.

* Update design and add tooltips.

* Fix missing thumbnails.

* Fix tests.

* Fix moving viz type label.

* Convert AddSliceCard to TS, update hierarchy.
2022-07-28 10:46:13 -06:00
cccs-RyanK fe91974163
chore: Remove unecessary code from async and sync select components (#20690)
* Created AsyncSelect Component
Changed files to reference AsyncSelect if needed

* modified import of AsyncSelect, removed async tests and prefixes from select tests

* fixed various import and lint warnings

* fixing lint errors

* fixed frontend test errors

* fixed alertreportmodel tests

* removed accidental import

* fixed lint errors

* updated async select

* removed code from select component

* fixed select test

* fixed async label value and select initial values

* cleaned up async test

* fixed lint errors

* minor fixes to sync select component

* removed unecessary variables and fixed linting

* fixed npm test errors

* fixed linting issues

* fixed showSearch and storybook

* fixed linting
2022-07-28 10:09:37 -03:00
Antonio Rivero Martinez 07ce33d142
Reports: (#20753)
- dashboardInfo might be an empty object, in which case we must use the chart info instead so the resourceId is not undefined
2022-07-27 12:33:13 -06:00
Antonio Rivero Martinez 234c44626d
TableChart: (#20833)
- Handle resize properly when only the scrollbar is changing so it doesn't get stuck into an infinite loop.
2022-07-27 12:32:34 -06:00
Antonio Rivero Martinez 99085d583d
fix(viz): Header scrolling for Time Table in dashboard (#20874)
* TimeTable:

- Increase the z-index so the sparkline doesn't overlap when scrolling in the dashboard

* Time TAble:

- Remove testing label
2022-07-27 12:24:47 -06:00
Jesse Yang 77db0651d8
feat(sql lab): display presto and trino tracking url (#20799) 2022-07-26 20:20:08 -07:00
Phillip Kelley-Dotson 2f3e11db66
feat: blankstate metrics columns (#20755)
* add POC ExploreMixin

* Working POC
> columns are loading into page

* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Visual updates to explore datasource panel

* Temporarily make Query icon visible

* Remove Query icon visibility

* Removed isValidDatasourceType check

* Added Query preview Modal from DatasourceControl if the data source type is Query [41493]

Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component

* > fix integration point with frontend
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working

* Adjusts conditional logic approach to be extensible for additional types from DatasourceTypes options

* refactor

* set field for sql

* Fixes issue where Missing query parameters error was showing in datasourcePanel

* add query_language

* fix ds main_dttm

* Fixes issue where menu.tsx was blocking access to redux debugging for SqlLab and Explore

* Fixes issue where database id was not available to save query as dataset, adds default metric when chart source is query

* oops

* fix pre-commit to 50 errors now

* fix circuliar dep

* Disables showing Metrics section in DatasourcePanel when Query is the datasource

A follow on separate effort will enable having a default Count metric when Query is the datasource type

* adds condition to use query.columns if query.results is not present enable saving query as a dataset

* down to 26 now

* patch for pre-commit

* one more pre-commit

* added explore_json error

* added error messages

* add for metrics

* add text for columns

* add model open/close method

* add propogation and methods

* change link to span

* lint fix

* Fixes frontend lint and TypeScript errors unit test fixes will be next commit

* Aditional TypeScript error fix

* Fixes unit test failure

* fix some types

* added frontend piece

* fix type

* Fixes bad import caused by merge from master and removes duplicate showSaveDatasetModal check

* Fixes for DartasourceControl Test Suite

* Fix lint error

* Fixes unit test issues due to array instead of a component being passed to modal footer

* Fixes unit test failure for DatasourceControl and simplifies getDatasourceTitle based on PR comment

* fix ts

* pylint

* core_test fix

* Fixes line error post merge from master

* fixed from master

* fixed from master

* Fixes issue where Overwrite dataset does not work due to userid error

SPA refractor changed Redux structure that is used when in explore (which is now within SPA).  user object is at the root of the store now for anything under SPA.

* Resolves TypeScript errors with changes made for SPA merging in and changes needed for overwriting dataset from SaveDatasetModal

* fix: top right panel view query functionality

* remove unneeded code from core.py

* working samples endpoint for query

* add owner check

* update FE for it

* handle columns are dict vs object

* fix exceptions

* fix fe lint

* fix test

* add tab_name to payload

* Enables use of tab name from Query

* fix cypress test

* save columns on execution

* fix frontend build test

* remove parathesis around columns

* changing column types

* fixing samples that has literal_columns

* address comments

* add changes

* fix path

* fix merge

* fix types

* remove console

* add type

* fix linting

* update to enum

* fix test

* remove explore from buttons

* fix logic

* fix logic

* oops

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-07-26 14:32:30 -04:00
Geido a69f016bca
chore: Feature flag for embedding charts (#20804)
* Add EMBEDDABLE_CHARTS feature flag

* Pretty

* Update test
2022-07-26 17:55:44 +03:00
Yongjie Zhao cb9ae38361
fix: switch form_data between different datasource (#20867) 2022-07-26 22:13:17 +08:00
Geido 76f573a4ea
chore: Ignore Applitools by default when running Cypress tests (#20789)
* Exclude applitools by default

* Remove unnecessary check

* Trim
2022-07-26 16:57:45 +03:00
Kamil Gabryjelski 46deb79f50
fix: Fix chart title truncating when Chrome is zoomed out (#20847) 2022-07-26 10:21:17 +02:00
Yongjie Zhao 55a89dfac9
feat: a simple LRUCache in frontend (#20842) 2022-07-26 15:02:10 +08:00
Kamil Gabryjelski 5c2c2e8040
feat(explore): UX changes in fast viz switcher (#20848)
* feat(explore): UX changes in fast viz switcher

* Fix test
2022-07-26 08:44:17 +02:00
Diego Medina 5d107b86ab
fix: explore warnings cleanup (#20864) 2022-07-26 13:28:50 +08:00
Geido 6b0c3032b2
chore: Update color scheme when deleted or changed (#20589)
* feat(explore): Use v1/explore endpoint data instead of bootstrapData

* Add tests

* Fix ci

* Remove redundant dependency

* Use form_data_key in cypress tests

* Add auth headers to for data request

* Address comments

* Remove displaying danger toast

* Conditionally add auth headers

* Address comments

* Fix typing bug

* fix

* Fix opening dataset

* Fix sqllab chart create

* Run queries in parallel

* Fallback to default color scheme

* Fix dashboard id autofill

* Fix lint

* Fix test

* Fix hydrate action

* Update dashboard colors

* Add color scheme domain

* Add check for default scheme

* Make me pretty

* Clean up

* Nit

* Clean up

* Pretty

* Fix missing sequential

* Lint

* Enhance test

* Lint

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-07-25 18:50:49 -04:00
Hugh A. Miles II 3de641c3ae
change buttons to be only save and overwrite (#20851) 2022-07-25 18:18:17 -04:00
Srini Kadamati c4564a91dc
chore: add databricks logo (#20849)
* chore: add databricks logo

* added databricks logo to Readme
2022-07-25 16:05:50 -04:00
Kamil Gabryjelski e3c6380258
chore: Change Button background color from primary.dark1 to primary.base (#20846) 2022-07-25 18:02:14 +02:00
Kamil Gabryjelski 0945d4a2f4
feat: Pass dashboard context to explore through local storage (#20743)
* feat: Pass dashboard context to explore through local storage

* Remove console log

* Remove unused local storage keys

* Fix lint

* Fix link

* Fix UT

* fix lint

* fix prettier

* Fix bug

* Fix bug with some sample dashboards

* Roll back unnecessary change

* style fix

* Add comments

* Fix lint

* Address code review comments

* Fix
2022-07-25 16:44:43 +02:00
Stephen Liu 9bf7ed58cd
fix(plugin-chart-echarts): bar chart overflow (#20805) 2022-07-23 14:20:00 +08:00
Stephen Liu 557cf4b739
fix(dashboard): add toast if JSON metadata is invalid (#20823) 2022-07-23 14:14:28 +08:00
rizacavus 4ffa3c22d1
feat: Add Türkiye Map to Country Map (#20801) 2022-07-23 08:33:56 +08:00
AAfghahi 7495cdbfe0
feat: Create Chart onClick Functionality (#20809)
* explore results button

* addresing hugh comments

* changed datatype to query

* addresing eric comments
2022-07-22 12:53:01 -04:00