Kamil Gabryjelski
0945d4a2f4
feat: Pass dashboard context to explore through local storage ( #20743 )
...
* feat: Pass dashboard context to explore through local storage
* Remove console log
* Remove unused local storage keys
* Fix lint
* Fix link
* Fix UT
* fix lint
* fix prettier
* Fix bug
* Fix bug with some sample dashboards
* Roll back unnecessary change
* style fix
* Add comments
* Fix lint
* Address code review comments
* Fix
2022-07-25 16:44:43 +02:00
Michael S. Molina
3311128c5e
fix: Reverts #20749 and #20645 ( #20796 )
...
* Revert "fix: Error when saving datasource from Explore (#20749 )"
This reverts commit 92f3621c75
.
* Revert "refactor: Unify shared datasources reducers and actions (#20645 )"
This reverts commit 2a705406e1
.
2022-07-20 17:03:19 -03:00
Just[in]Do it!
1debacaaca
feat(dashboard): Make FilterBar width resizable ( #20778 )
...
* Add Resizable panel in DashboardBuilder to adjust the width for FiltersPanel
* store the adjusted width for individual dashboard in localStorage to memorize the state
* migrate DashboardBuilder test code by testing-library and jest
2022-07-20 09:56:55 -07:00
Cody Leff
84d4302628
fix(explore): Fix chart standalone URL for report/thumbnail generation ( #20673 )
...
* Update explore URLs.
* More URL fixes.
* Make frontend accept true/false query params case-insensitively.
* Fix URL mistake.
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-07-19 13:53:55 -03:00
Michael S. Molina
2a705406e1
refactor: Unify shared datasources reducers and actions ( #20645 )
...
* refactor: Unify shared datasources reducers and actions
* Removes column_types
* Adjusts hydrateExplore
* Revert "Removes column_types"
This reverts commit 096bbf7826
.
* Fixes test
2022-07-13 13:03:36 -03:00
Cody Leff
edb1383bf8
chore(dashboard): Resolve form_data vs. formData in dashboard redux state
2022-06-30 18:49:18 +08:00
Kamil Gabryjelski
c7f1c7d5bd
chore: Restructure explore redux state ( #20448 )
...
* chore: Restructure explore redux state
* fixes
* fix tests
* add new tests
* Fix type
* Address comments
* Fix bug
* Fix import
* Add new test
* Move unsaved chart id to a constant
* Add todo
2022-06-24 15:26:07 +02:00
Yongjie Zhao
9fad26fa19
fix: suppress translation warning in jest ( #20404 )
2022-06-21 20:38:58 +08:00
Evan Rusackas
76b4a14d30
chore(config): Migrating `ENABLE_JAVASCRIPT_CONTROLS` from app config to a feature flag ( #19113 )
...
* first pass migrating config to ff
* nixing a console log from testing
* adding an entry to `UPDATING.md`
* linting ✨
* Adding ENABLE_JAVASCRIPT_CONTROLS to FEATURE_FLAGS.md
* no longer in need of state!
* Turning the flag back off
* linting... le sigh
* and more linting...
2022-03-14 08:54:02 -06:00
Kamil Gabryjelski
3c1fb944c1
perf(dashboard): Improve performance of complex dashboards ( #19064 )
...
* perf(dashboard): Improve performance of filter indicators
* Improve perf of cross filters
* Rename old function
* Fix undefined
* fix type
* fix tests
* fix undefined
* Address code review comments
* Address code review comments
2022-03-09 22:39:58 +01:00
Michael S. Molina
04a36d5c92
chore: Moves Chart to the components folder ( #19029 )
2022-03-08 08:57:29 -03:00
Michael S. Molina
06e1e4285e
feat: Adds support to multiple dependencies to the native filters ( #18793 )
...
* chore(native-filters): Remove cascading popovers from filter bar
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-03-04 13:06:10 -03:00
Michael S. Molina
48a80950de
feat: Improve state key generation for dashboards and charts ( #18576 )
...
* feat: Improve state key generation for dashboards and charts
2022-02-14 17:09:06 -03:00
Adam Dobrawy
7c69a1bc60
chore: improve React import reference consistency ( #18608 )
2022-02-10 21:03:16 -08:00
simcha90
bcad1acec2
feat: Dynamic dashboard component ( #17208 )
...
* fix:fix get permission function
* feat: dynamic loading of dashboard components
* fix: revert image
* fix: fix py
* fix: fix py
* fix: pass state to dynamic component
* lint: add typing
* lint: fix lint
* lint: fix lint
* refactor: re-run pipeline
* fix: fix CR notes
* fix: fix CR notes
* move types and interfaces to core
* reorder exports
* rename Scope and Target
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-09 17:44:40 +02:00
Michael S. Molina
4b61c76742
fix: Explore long URL problem ( #18181 )
...
* fix: Explore long URL problem
* Fixes lint problems
* Fixes default value
* Removes duplicated test
* Fixes share menu items
* Fixes tests
* Debounces form_data updates
* Rewrites debounce function
* Moves history update outside the functional component
* Mocks lodash function in tests
* Fixes Cypress test
* Fixes Cypress test #2
2022-01-28 17:42:16 -03:00
Michael S. Molina
647bbf1ea1
chore: Moves spec files to the src folder - iteration 10 ( #17902 )
...
* chore: Moves spec files to the src folder - iteration 10
* Fixes test
* Fixes lint problem
* Uses styledMount in test
2022-01-07 15:24:15 -03:00
Michael S. Molina
bb7e979142
chore: Moves spec files to the src folder - iteration 9 ( #17901 )
2022-01-07 15:23:57 -03:00
Michael S. Molina
e6ef7da758
chore: Moves spec files to the src folder - iteration 8 ( #17899 )
...
* chore: Moves spec files to the src folder - iteration 8
* Fixes tests
2022-01-07 09:25:45 -03:00
Phillip Kelley-Dotson
cfd851aa13
fix: replace datamask with key from new key value api ( #17680 )
...
* afirst stage to ccheck to get initial datamask
* clean up code and update typescript
* remove consoles
* fix ts and update copy dashboard url
* use key when one doesn't exists
* lint clean up
* fix errors
* add suggested changes
* remove line
* add tests and add changes for copydashboard
* fix lint
* fix lint
* fix lint
* Update superset-frontend/src/dashboard/components/Header/index.jsx
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* add timeout
* fix test
* fix test, add qs to cypress and add suggestions
* add suggestions
* fix lint
* more suggested changes for backwards comapat
* fix lint
* cleanup naming and add qs parse to tests
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* more changes and fix lint
* remove nativefiler param
* fix path
* remove con
* simplify logic
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-12-21 09:08:48 -08:00
Beto Dealmeida
63d9693f21
feat: add main datetime column to dataset editor ( #17739 )
...
* feat: add main dttm col to dataset editor
* Add tests
2021-12-14 14:47:08 -08:00
Geido
12bd1fcde5
fix: Save properties after applying changes in Dashboard ( #17570 )
...
* Refactor PropertiesModal
* Update json_metadata fully
* Clean up
* Verify values
* Catch changed to metadata
* Always updated dashboard info on update
* Avoid unnecessary fetches
* Formt
* Fix copy dashboards
* Fixes onUpdate onCopy handlers
* Pylint
* Update tests
* Clean up
* Handle data on show
* Change Save to Apply
* Update Cypress save test
* Update Cypress edit prop test
* Update PropertiesModal test
* Fix duplicate request with cross filters
* Improve code style
* Fix typo
* Lint
2021-12-09 10:03:07 -07:00
Corbin Robb
f476ba23a2
fix(select): select component sort functionality on certain options ( #17638 )
...
* fix: Select component sort function sorting by label instead of value on numbers
* fix: change select component default sorting to sort by the initial index rather than a property like value or label
* fix: select sorting add sortOptions to select components using sortByProperty
* fix: change select component back, add order to options coming in from SelectControl
* fix: select component options intitial sort bug
* fix: add test cases for select fix
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-12-09 11:40:25 -05:00
Kamil Gabryjelski
07e8837093
feat(explore): export csv data pivoted for Pivot Table [ID-9] ( #17512 )
...
* feat(explore): export csv data pivoted for Pivot Table
* Implement dropdown with download csv options
* Change label to "Original"
* Add tests
* Add form data to query context
* Add form data to query context generator
* Explicitly make form_data optional
2021-12-03 12:42:28 +01:00
Yongjie Zhao
3c41ff68a4
refactor(monorepo): move superset-ui to superset(stage 2) ( #17552 )
2021-11-30 08:29:57 +08:00
Ajay M
9576478a5d
feat(dashboard): Add divider component in native filters ( #17410 )
...
* Tests are working, type errors are fixed
* Fix filterset
* add license header to the new file
* fix test
* PR comments
* Linting
* test fix
* small fix
2021-11-23 16:13:56 -08:00
Yongjie Zhao
9070b6b19c
refactor(monorepo): stage 1 ( #17427 )
...
* skip geojson in pre-commit
update prettier
* update package.json
update package.json
u package
pkg
pkg2
* lint main repo 2
lint main repo
lint
* lintrc
lintrc 2
lintrc2
lintrc 3
lintrc
* fix import
* refresh lock file
* fix break line make @ts-ignore invalid
* update rat-excludes
rat-excludes
update rat-excludes
* update eslintrc.js
* lint lint lint
2021-11-17 15:31:36 +08:00
Elizabeth Thompson
71e3fa1bf3
use full resultType with csv download on chart in dashboard ( #17431 )
2021-11-15 09:57:05 -08:00
Geido
ee7c34b5b3
Make color scheme optional ( #17357 )
2021-11-05 19:09:59 +02:00
Geido
59a6502efe
fix: Color consistency ( #17089 )
...
* Update label colors on the fly
* Clean up
* Improve getFormDataWithExtraFilters
* Improve code structure
* Remove labelColors from formData
* Exclude label_colors from URL
* Refactor color scheme implementation
* Clean up
* Refactor and simplify
* Fix lint
* Remove unnecessary ColorMapControl
* Lint
* Give json color scheme precedence
* Add label_colors prop in metadata
* Separate owners and dashboard meta requests
* Remove label_colors control
* bump superset-ui 0.18.19
* Fix end of file
* Update tests
* Fix lint
* Update Cypress
* Update setColorScheme method
* Use Antd modal body
2021-11-03 19:22:38 +02:00
Ajay M
65f1644208
feat(dashboard): Add description to the native filter ( #17025 )
...
* Adding description works
* Add some tests
* Fix tests
* Styled look good
* Tests successful
* Address PR comments
* fix a test
2021-10-27 11:45:31 -07:00
Michael S. Molina
e32acd22fd
chore: Moves the datasource components to the components folder ( #17130 )
2021-10-20 08:13:24 -03:00
simcha90
37944e18d6
feat(Filter-sets): connect to api ( #17055 )
...
* fix:fix get permission function
* feat: filtersets new
* feat: connect filter sets to api
* lint: fix lint
* doc: add comment
2021-10-17 09:56:54 +03:00
Ajay M
9e6d5fc775
feat(dashboard): Let users re-arrange native filters ( #16154 )
...
* feat. flag: ON
* refactor filter tabs
* WIP
* Drag and Rearrange, styling
* refactoring dnd code
* Add apache license header
* Fix bug reported during PR review
* Minor fix on remove
* turn off filters
* Fix status
* Fix a test
* Address PR comments
* iSort fixes
* Add type key to the new filters
* Fix wrong attribute
* indent
* PR comments
* PR comments
* Fix failing tests
* Styling
* Fix remove filter
* Fix the drag issue
* Save works
* fix
* Write tests
* Style changes
* New Icon
* Grab & Grabbing Cursor
* Commented out code
* Fix tests, fix CI
* Fix failing tests
* Fix test
* Style fixes
* portal nodes dependency
* More style fixes
* PR comments
* add unique ids to collapse panels
* Filter removal bug fixed
* PR comments
* Fix test warnings
* delete filter tabs
* Fix the breaking test
* Fix warnings
* Fix the weird bug on cancel
* refactor
* Fix broken scope
2021-10-15 16:56:33 -07:00
Hugh A. Miles II
959fd763a8
fix: Owners selection in dataset edit UX ( #17063 )
...
* boilerplate
* update owner select component
* this is working
* update onchange
* refactorig
* you need to useMemo or things break
* update test
* prettier
* move logic into bootstrap data endpoint
* address concerns
* oops
* oops
* fix test
2021-10-12 20:27:56 -04:00
Evan Rusackas
5f73ca85d5
feat(linting): restrict direct use of supersetTheme in favor of ThemeProvider ( #17001 )
...
* feat: restrict direct use of supersetTheme
* allowing a couple of safe instances of supersetTheme
2021-10-07 08:26:57 -06:00
Elizabeth Thompson
5866d5ebb0
fix: Revert "fix: RBAC hide right menu ( #16902 )" ( #16968 )
...
* Revert "fix: RBAC hide right menu (#16902 )"
This reverts commit 87baac7650
.
* fix failing test
2021-10-04 19:18:12 -07:00
Geido
3f0756f637
chore: Select component refactoring - SelectControl - Iteration 5 ( #16510 )
...
* Refactor Select DatasourceEditor
* Fire onChange with allowNewOptions
* Clean up
* Refactor Select in AnnotationLayer
* Handle on clear
* Update tests
* Refactor Select in SpatialControl
* Show search
* Refactor Select in FilterBox
* Remove search where unnecessary
* Update SelectControl - WIP
* Refactor Controls
* Update SelectControl tests
* Clean up
* Test allowNewOptions false
* Use SelectControl AnnotationLayer
* Use SelectControl SpatialControl
* Clean up
* Render custom label
* Show search
* Implement filterOption
* Improve filterOption
* Update Cypress
* Update Cypress table test
* Use value for defaultValue
* Merge with latest changes
* Reconcile with latest Select changes
* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Revert changes to test
* Call onPopoverClear when v value is undefined
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-04 18:24:41 +03:00
Michael S. Molina
1ab36c94f3
chore: Moves spec files to the src folder - iteration 7 ( #16943 )
2021-10-04 10:56:49 -03:00
Michael S. Molina
028f6c0d3f
chore: Moves spec files to the src folder - iteration 6 ( #16935 )
2021-10-04 10:56:30 -03:00
Ville Brofeldt
a07c9d591b
fix(dashboard): recursive parent on dashboard components ( #16933 )
...
* fix(dashboard): don't add recursive parents on wrapper component
* add test
* refine logic and add new test
2021-10-01 08:13:38 -07:00
Michael S. Molina
90f711f45c
chore: Moves spec files to the src folder - iteration 5 ( #16927 )
2021-10-01 11:24:41 -03:00
Geido
271ec6ec75
chore: Select component refactoring - SaveModal - Iteration 5 ( #16446 )
...
* Refactor Select
* Fix Cypress
* Reconcile with master
* Use onChange over onSelect
* Reconcile with latest changes
* Update Cypress
* Update Cypress test
* Fix lint
2021-09-27 18:14:58 +03:00
Geido
913df18075
chore: Select component refactoring - MetricControl - Iteration 5 ( #16423 )
...
* Refactor Select
* Render saved metric option
* Update tests
* Fix Cypress and ariaLabels
* Fix lint
* Lint Cypress
* Reconcile with latest Select changes
2021-09-27 17:25:51 +03:00
Ville Brofeldt
a3413197de
chore: upgrade to Node 16 ( #16809 )
...
* chore: upgrade to Node 16
* add docs
* fix test
2021-09-25 07:26:35 +02:00
Lyndsi Kay Williams
63aadd3fe4
test: RTL overhaul - hackathon ( #16626 )
...
* CachedLabel_spec fully converted to RTL
* ColumnTypeLabel_spec fully converted to RTL
* MissingChart_spec fully converted to RTL
* RefreshIntervalModal_spec mostly converted to RTL
* HoverMenu_spec mostly converted to RTL
* ResizableContainer_spec fully converted to RTL
* ResizableHandle_spec fully converted to RTL
* AggregateOption_spec fully converted to RTL
* CheckboxControl_spec fully converted to RTL
* ColorPickerControl_spec to RTL
* Finished converting ColorPickerControl_spec to RTL/TS, also converted RefreshIntervalModal_spec to TS
* Added unknown type to ColumnTypeLabelProps
* Fixed ColumnTypeLabel_spec
2021-09-22 11:37:35 -07:00
Michael S. Molina
9b17e86b44
chore: Moves messageToasts to the components folder ( #14431 )
...
* chore: Moves messageToasts to the components folder
* Rebases
2021-09-22 07:44:54 -03:00
Michael S. Molina
596e1cdf9b
refactor: Changes the DatabaseSelector and TableSelector to use the new Select component ( #16483 )
2021-09-22 07:43:46 -03:00
Elizabeth Thompson
f032cc254c
fix shared query ( #16753 )
2021-09-21 09:38:23 -07:00
simcha90
668ae23f28
feat: Tabs in column ( #16593 )
...
* fix:fix get permission function
* feat: add tabs inside column
* lint: fix lint
* test: fix test
* test: fix tests
* test: fix tests
* fix: pass onChangeTab function through layout
2021-09-13 09:02:29 +03:00