- Adds plugin:jest-dom/recommended to ESLint plugins list to enforce tests best practices
- Moves import @testing-library/jest-dom/extend-expect; from setup.ts to testing-library.tsx to avoid matchers collision
- Adds @testing-library/user-event to help simulate users events
* Fix Save button disabled until clause is switched
* Fix 'undefined undefined' when sql query is empty
* fix test
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
* first attempts at dynamic plugin loading
* dynamic import working for explore
* memoize appropriately
* add a backend for dynamic plugins
* hack at getting dynamic plugins working with dashboards
* more work on making it work, + feature flag
* lint
* actions to fix explore state when plugins load
* handle dynamic control panel, functionify ExploreViewContainer
* fix: rearrange migrations branch
* fix: name and key as strings with length 50
* bundle url length 2000
* bundle url to text
for some reason not supported on my sql
* fix: too long varchart
* fix: pre-commit typing
* fix: licenses
* fix: add slice container was not initing feature flags
* fix: undo linting issue
* fix: adjust down revision again
* fix: adjust down revision again
* isort
* pylint
* god damn linters
* remove unnecessary(?) loading message
* only log non-standard errors
* testing
* python is terrible
* see above commit message
* fix imports in DynamicPluginProvider
* fix
* shift migration forward
* lint
* fix form data calculations to handle missing control config
* temp commit - waiting for superset-ui changes and crud fixes
* remove unnecessary todo
* use new superset-ui shared module function
* fetch the plugins instead of hardcoding the test one
* migration sort
* remove duplicated import statement
* format
* try moving the import 🙄
* copy
* fix frontend tests
* safe access
* comment out dead code
* isort
* disable pylint on necessary lines
* use @superset-ui/logging instead of console
* remove temp code
* rearrange some code
* try triggering mouseover in cypress before click
* use loading spinner instead of text
* trying to fix cypress
* attempt cypress fix
* customize permissions
* update package lock
* only admins can write to plugins by default
* better copy
* disable flaky tests
* use makeApi
* flaky tests
* cleanup code
* flaaaakkkyyyyyy
* dry
Co-authored-by: amitNielsen <amit.miran@nielsen.com>
* wip: filter create modal
* add a feature flag
* automatic changes to package lock
* wip
* filter sidebar and basic state management
* move create button to the sidebar
* first step for edit filterconfig
* partially fix tests...
* edits to types and comments
* respect feature flag on the filter sidebar
* add filterconfig form
* get input state working
* feat: tree filter scopes UI
* fix: turn on flag
* sticky filter bar
* stop preferring default export
* feat: finish filter scoping
* fix: under toggle
* fix: title
* fix: add licence
* refactor: update TS
* fix: fix on reopen modal + validation
* new filter bar menu
* adding, but commenting out, bulk scoping action
* adding some placeholder buttons and styles therefor
* feat: add filter chart
* add relative path to package.json
* update modal
* a little input styling... just getting warmed up
* Revert "feat: add filter chart"
This reverts commit b1302d35b6.
* Revert "add relative path to package.json"
This reverts commit 26a7b40e18.
* https package lock idk
* feat: add filter chart
* add relative path to package.json
* flexboxes all the way down
* dynamically generate groupby and datasource in select control
* big wip
* fix target column name
* no importing nonexistent things
* styles and name editing
* Add hook for retrieval of all filter states
* start with a new filter when clicking add filter
* handle removed filters gracefully
* fix incorrect default filter configuration
* add fields to useAllFilterState
* add redux for filterconfigs
* add support for native_filters
* remove consoles
* improve filter removal
* unbreak infinite loop
* basic sidebar toggling working!
* collapsing and menu working more smoothly
* linting
* make dataset and column inputs work
* save filter values properly
* add dashboard event for filter updates
* guarded
* apply filters properly
* fix schema
* making New Filter button a link
* gridunits ftw
* centering modal
* tis not a button anymore! nixing type.
* plus and collapse buttons instead of "more" menu
* updating full size filter icons
* adding icons to filter collapsing/expanding
* turning off animation, but leaving class-based animation css
* fix linting error
* fix native filters for legacy charts
* updates test
* no individual apply buttons
* fix bugs with filter config modal
* remove redundant code
* switch to the filter with validation errors on submit
* separate form validation
* switch config button from add to edit
* update tests
* oops forgot to add the fancy new useChangeEffect hook
* comments and code reorganization
* rename native_filters to extr_form_data and move hook
* disable native filters in viz selector
* add cascading
* implement new extra form data api
* cleanup
* updates tests
* bump npm packages
* fix bad merge on package.json + lock
* lint
* replace in and not in with uppercase
* lint
* lint
* lint
* lint
* bulk test fix
* Sort select input alphabetically
* Change type for sorting elements
* fix rest of unit tests
* make filter operators all uppercase
* Hide Filter bar when there are no filters
* Show edit button for dashboard owners only
* Add visible argument to filters toggle function to avoid future regression
* Improve Toggle filters bar function
* lint
* fix js lint + set createNewOnOpen
* Handle setting extra form data in Filter Bar instead of Filter Control
* Add Handle apply filter function to Apply button
* Allow applying changes instantly
* Fix types
* remove console logs
* Add Error Boundary component to Filter bar and Filter Config Modal
* fix jest tests
* update native filters tests to pass
* reset cypress baseUrl
* remove unnecessary field
* cleanup: remove unused state fields
* move unrelated types to an appropriate location
* remove misplaced resource fetch error logic
* fix cascadeParentIds error
* fix cypress password
* initial attempt at fixing scope issue
* fix bad merge
* fix lint
* trying out makeApi for saving filters
* remove unused import
* fix test
* silence bad test
* add native-filter feat flag config
* oops fix here
* remove space
* Update superset-frontend/src/common/components/index.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
Co-authored-by: Evan Rusackas <evan@preset.io>
* use styledMount in tests
* comment
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigurationLink.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* address PR feedback
* fix package lock
* null guards
* Fix charts resizing
* fix cypress tests
* add in nativefilters to form data
* fix lint and test
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Simcha Shats <simcha.shats@nielsen.com>
Co-authored-by: amitNielsen <amit.miran@nielsen.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Implement saved metrics
* Fix bug in sql editor
* Fix unit tests
* Fix outlines in popovers
* Add types for saved metrics
* Add translations
* Move savedMetricType to a separate file
* update to datsource tab
* second update
* style updates
* update style and fix metrics bug
* updates to datsource panel
* backgrounds and borders
* more updates
* shuffling some paddings around
* more updates
* moving some more paddings around!
* Fixing sidebar width
* using Global to adjust body layout
* update test and fix bug
* removing hotkeys
* layout fixes for short content, simplifying some class names
* more styles
* add tooltip to collapse and div clickable
* more updates
* more updates for styles and add list component
* update from comments
* vising cosmetic issue with line-wrapping drop down caret on controls sections
* controls area scrolling properly again.
* change lists to old list and updates from comments
* border radius from theme
* add length field and updates from comments
* more changes from comments
* integrate health with new control
* change callapse back from stylsheet more udpates
* substitution string
* more substitution strings
* fix tests
* datasource alignment
* taking margin off the search input
* update input to flex
* fix lint
* adjusting column/metric label stylng
* fixing scrollable area layout, one more color variable
* simplifying some styles
* nixing a bad left margin
* Using gridunit for padding
* using gridUnit for padding
* define types for datsource panel
* fixing a padding issue
Co-authored-by: Evan Rusackas <evan@preset.io>
* Migrate react-select to Antd select in Metrics popover
* Fix tests
* Migrate react-select to Antd select in Filters popover
* Migrate SelectControl to Antd Select
* Add label with number of options left
* feat: add hook for dataset health check
* add event log
* optimize datasource json data like certified data
* add unit test
* fix review comments
* extra code review comments
* Removes hard coded colors
Removes hard coded colors defined in src/components/styles.ts. The colors defined in this file were used only in the Select component so they were migrated to src/components/Select/styles.tsx and ajusted to conform to the theme colors.
* Use theme context for Select styles
* Includes Theme Provider in tests with Select
* upgrade redux and react-redux, adjust types
* first round of test fixes
* fix rest of unit tests
* lint
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
* Upgrade react-split
* Implement split on ExploreChartPanel
* Implement tabs with collapse
* Fix run query button
* Fix copy to clipboard button
* Move table controls to separate file
* Make component more generic to handle samples
* Remove samples from DisplayQueryButton
* Move data tables to separate file
* Make split dynamically controlled
* Fix unit test
* Fix arrow not centered
* fixup! Fix arrow not centered
* Change copy button paddings
* Use translations
* Fix grammar in a comment
* Fix imports
* Use grid units
* Convert new files to typescript
* Fix after rebase
* Remove forceRender
* Fix big_number test
* Delay making request until panel is opened
* White background in south panel
* fixup! White background in south panel
* Lint fix
* Lint fix
* Remove redundant prop types
* Remove console log
* Delay loading samples until user switches tab
* Add debounce to filter input
* Use gridUnit for gutter sizes
* Change types object to Record<string, any>
* Refactor tooltip in ColumnElement
* Refactor tooltip for Button
* Remove redundant import
* Refactor tooltip in SqlEditor
* Increase line height in tooltip so that the text is centered
* Refactor tooltip in Link
* Refactor tooltip in AdhocMetricEditPopoverTitle
* Refactor tooltip from ControlHeader
* Refactor tooltip in DateFilterControl
* Refactor tooltip in VizTypeControl
* fixup! Refactor tooltip in AdhocMetricEditPopoverTitle
* Refactor tooltip in QueryAndSaveBtns
* fixup! Refactor tooltip in DateFilterControl
* Refactor tooltip in CopyToClipboard, fix cursor pointer
* Refactor tooltip in TooltipWrapper
* Refactor tooltip in Field/DatasourceEditor
* Remove redundant import
* Fix typing for placement prop
* Decrease margin in ColumnElement divider
* Change default export to named
* Move SqlLab Tooltip styles to Emotion
* Fix tests
* Fix paste not working in Metrics and Filter inputs
* Use noOp instead of empty function
* Use default Select component instead of OnPasteSelect
* Revert onPaste override
