Commit Graph

1067 Commits

Author SHA1 Message Date
michellethomas
91db008d72
fix: accept null groupby in form data for timeseries table viz (#13086)
* Allowing timeseries table groupby to be null in form data

* Check truthiness for is_group_by

Co-authored-by: michelle_thomas <michelle.thomas@airbnb.com>
2021-02-17 13:45:39 -08:00
simcha90
5cbe2ac760
feat(filters-set): basic implementation for managing user filter sets (#13031)
* feat: POC adding filters set feature

* lint: fix TS

* fix: fix FF name

* refactor: fix CR notes

* fix: fix update values in filter bar
2021-02-17 21:06:12 +02:00
simcha90
450215549f
fix: cross filter functionality (#13178) 2021-02-17 20:59:37 +02:00
David Aaron Suddjian
e01015f792
fix: handle lack of dynamic plugins (#13141)
* handle lack of plugins

* clearer logic
2021-02-17 20:08:43 +02:00
Lily Kuang
e1bb7f4364
fix(alert/report): bulk select mode should be deactivated (#12977)
* close bulk delete when switch between alert and report

* update test for alert/report list
2021-02-17 09:45:00 -08:00
simcha90
ad2aed5a68
fix(native-filters): Apply range filter (#13164)
* refactor: update range build query

* fix: apply range filter filtering

* fix: range resize action

* refactor: fix CR notes
2021-02-17 16:08:33 +02:00
simcha90
9c9becc3d5
fix: correct apply of native filter scopes (#13165) 2021-02-17 11:24:14 +02:00
David Aaron Suddjian
189aced320
refactor: remove deprecated chart.edit_url field from frontend usage (#13142) 2021-02-16 19:54:43 -08:00
Kamil Gabryjelski
da478531b2
Fix chart panel overflowing (#13154) 2021-02-17 09:37:35 +08:00
ʈᵃᵢ
c787f46f10
perf: add lazy loading along react-router routes and router links in menu (#13087) 2021-02-16 14:48:35 -08:00
ʈᵃᵢ
8b40bf695f
style: table sort icon alignment (#13139) 2021-02-16 11:23:40 -08:00
Lily Kuang
f10dbbe0ac
fix(alert/report): add/edit modal issue (#12955)
* fix alert modal

* add test for edit modal
2021-02-16 11:18:39 -08:00
Kamil Gabryjelski
44723eabbe
fix(explore): Certificate icon not displaying for certified metrics (#13133)
* Fix certificate icon not displaying for certified metrics

* Remove redundant function

* Fix grammar mistake
2021-02-16 08:56:19 -08:00
Michael S. Molina
981deaaa22
Change test environment to jsdom (#13149) 2021-02-16 08:48:16 -08:00
simcha90
5aa38ef929
feat(native-filters): enable filter indicator and make datasource optional (#13148)
* refactor: continue decouple native filters

* refactor(native-filters): decouple native filter parms from config modal

* lint: fix TS errors

* lint: fix TS errors

* refactor: update filter badge

* refactor: rename ant filters

* test: fix tests

* test: fix tests

* refactor: remove 18 from dataset
2021-02-16 16:12:35 +02:00
Jesse Yang
c9f76d58f0
chore: upgrade to npm 7 and superset-ui 0.17.9 (#13100) 2021-02-15 09:45:29 -10:00
Jesse Yang
613945a200
fix(FilterBox): treat empty defaultValues as null (#13109)
* fix(FilterBox): treat empty defaultValues as null

* Add a unit test and move constant around
2021-02-15 08:35:47 -08:00
Kamil Gabryjelski
d0b00bc08f
fix: Fix switching viz type to and from Filter box (#13094)
* Fix switching viz_type to and from filter_box

* Remove RESET_FIELDS action

* Restore removed log

* Refactor reducer logic
2021-02-15 08:05:40 -08:00
Victor Malai
24ebf10976
feat: add sort_by_metric for charts with single metric (#13058) 2021-02-15 02:59:50 -08:00
Amit Miran
d55a040acd
feat(native-filters): hide filterBar and toggle icon when in editMode (#13108) 2021-02-14 22:37:48 +02:00
simcha90
2010e64c94
refactor(native-filters): decouple params from filter config modal (first phase) (#13021)
* refactor: decouple params from filter config modal (first phase)

* refactor: remove unnecessary fields

* refactor: fix CR notes

* fix: fix controlValues

* refactor: fix Cr notes

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-02-14 10:38:15 +02:00
Ville Brofeldt
bc4c837da3
fix(native-filters): set currentValue null when empty (#13000) 2021-02-13 21:01:12 +02:00
simcha90
dae1258903
feat(native-filters): add storybook entry for select filter (#13005)
* refactor: update native filters ignores

* refactor: use behaviour variable

* refactor: move story for Filter select

* chore: update dependencies

* lint: fix lint

* remove unnecessary changes

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-02-13 13:11:18 +02:00
simcha90
d6fc720f4c
feat(native-filters): Time native filter (#12992)
* Add Time Filter component

* Improve Time Filter component

* Fix import errors

* Display Time Filter

* Remove console logs

* Change Control Panel

* Remove unnecessary files

* Use time range override

* test: fix tests

* feat: re run pipeline

* fix: fix some case for Time filter

* fix: merge with master

* use original time range

* fix height

* add cross filter behavior

* apply filters on initialization

* add applied filter to overrides

* add unit tests for merge_extra_form_data

Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-02-13 12:09:54 +02:00
simcha90
956f276e70
feat(cross-filters): add cross filters (#12662)
* feat: add cross filters

* refactor: fix CR notes

* lint: fix lint

* lint: fix lint

* chore: pre-commit

* refactor: under chage

* refactor: move to behaviors

* lint: fix lint

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-02-12 09:58:19 +02:00
Kamil Gabryjelski
85d02620b7
fix(explore): Enable selecting an option not included in suggestions (#13029) 2021-02-11 23:15:46 -08:00
Michael S. Molina
86807e40b7
Improves RTL configuration (#13079)
- Adds plugin:jest-dom/recommended to ESLint plugins list to enforce tests best practices

- Moves import @testing-library/jest-dom/extend-expect; from setup.ts to testing-library.tsx to avoid matchers collision

- Adds @testing-library/user-event to help simulate users events
2021-02-11 15:32:22 -08:00
Jesse Yang
6bc28a087c
chore: lock down npm to v6 (#13069) 2021-02-11 10:49:34 -08:00
Moriah Kreeger
7f7e113de2
add required * indicator to message content/notif method (#12931) 2021-02-11 10:17:53 -08:00
simcha90
c5781cde60
feat(style): hide dashboard header by url parameter (#12918)
* feat(native-filters): hide dashboard header bu url parameter

* lint: fix lint

* test: add tests

* test: fix test

* refactor: upgrade standalone param

* fix: pre-commit and extract to method is_standalone_mode

* test: fix tests

* test: fix tests

* fix: fix standalone statement

* refactor: fix CR notes

* chore: pre-commit

* fix: fix sticky tabs + update CR notes

* lint: fix lint

* lint: fix lint

* fix: fix CR notes

* fix: fix CR notes

* lint: fix lint

* refactor: fix cr notes

Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-02-11 15:05:35 +02:00
Ville Brofeldt
42c4facb7e
fix(explore): pie chart label bugs (#13052) 2021-02-11 11:23:40 +02:00
AAfghahi
6c9f315b77
fix: Disabled state button transition time (#13008)
* button fix

* tooltips disabled when it is disabled, border width changed

* added isDisabled to tooltip

* worked on transition times

* cleaned up transition to be local instead of global

* made it local

* linted

* trying to resolve a conflict
2021-02-10 20:36:33 -08:00
Beto Dealmeida
249b51bfba
fix: vertical scroll in query history (#13042) 2021-02-10 07:31:46 -08:00
Daniel Vaz Gaspar
3e0681b438
fix: UI toast typo (#13026)
* fix: UI toast typo

* translate

* fix error msg
2021-02-10 08:17:54 +00:00
Thinking Chen
4ba98bf8c8
fix: untranslated text content of Dashboard page (#13024)
* fix: fix the untranslated text content of Dashboard page

* fix: add the untranslated text content of Dashboard page in messages.pot

* fix linting error

Co-authored-by: chenx <yuxiang1989>
2021-02-09 10:34:22 -08:00
Michael S. Molina
d5e6190998
Refresh dashboard list after bulk delete (#12945) 2021-02-08 16:49:23 -08:00
Michael S. Molina
dd0af74019
Updates storybook to version 6.1.17 (#13014) 2021-02-08 16:47:09 -08:00
Kamil Gabryjelski
2ce79823df
feat: Save datapanel state in local storage (#12996)
* Save datapanel state in local storage

* Export string to a constant

* Move local storage helpers to separate file

* Use helper functions in ExploreViewContainer
2021-02-08 16:42:59 -08:00
AAfghahi
69b0ed663d
fix: added text and changed margins (#12923) 2021-02-08 17:26:55 -05:00
simcha90
c440d98fad
refactor(native-filters): refactor code of native filters (#12889)
* refactor(native-filters): refactor code of native filters

* refactor: update refactor dependencies

* refactor: update refactor dependencies

* lint: fix lint

* fix: merge with master

* chore: fix selector
2021-02-08 13:26:58 +02:00
Lyndsi Kay Williams
022d18d359
refactor: TemplateParamsEditor.jsx converted from class to functional component (#12873)
* TemplateParamsEditor.jsx converted from class to functional component

* Fixed import in SqlEditor.jsx

* Corrected renderDoc

* Corrected renderModalBody

* Corrected functional name and import

* Corrected props

* Corrected modalBody and incorporated renderDoc

* Removed t strings

* Removed unnecessary single quotes

* Editor text updating correctly

* Split useState into three different hooks

* Removed onChangefunc, adjusted component to use onChange and code from props through useEffect

* Added parsedJSON reset to catch in useEffect

* Put a throttle on the onChange

* Switched from throttle to debounce
2021-02-07 21:44:39 -08:00
Beto Dealmeida
76bcc446f0
fix: SQL Lab editor height in Safari (#12973) 2021-02-05 13:10:07 -08:00
adam-stasiak-polidea
3235d918aa
test: Added some Cypress tests for Native Filters (#12180) 2021-02-04 22:54:00 -08:00
Phillip Kelley-Dotson
3bb14ab950
feat: reset metrics on dataset change (#12782)
* reset metrics on dataset change take one

* remove code

* part 2 or reseting adhoc controls

* update input controls and customize defaults

* remove conosles

* remove extra method

* simplify logic for controls reset and have them use their defaults

* remove consoles

* add annotation control to defaultvalues

* remove line
2021-02-05 14:08:27 +08:00
AAfghahi
ac3e16d0ac
fix: SqlLab Run button fix (#12956)
* button fix

* tooltips disabled when it is disabled, border width changed

* added isDisabled to tooltip
2021-02-04 20:21:43 -08:00
Kasia Kucharczyk
973306461c
[11907] Added detecting top scroll on Dashboard header (#12953) 2021-02-04 13:22:16 -08:00
Ville Brofeldt
ac73991913
fix(viz): improve dtype inference logic (#12933) 2021-02-04 10:47:27 -08:00
Jesse Yang
9982fdebd8
test: fix table chart sort order E2E tests (#12936)
* test: fix table chart sort order E2E tests

* Upgrade npm packages
2021-02-04 13:27:45 +02:00
Victor Malai
77093a874e
Add inclusive and exclusive for date start and end (#12859) 2021-02-04 14:55:02 +08:00
Victor Malai
137cf5d4d9
Add row limit control for timeseries table (#12887) 2021-02-04 14:29:14 +08:00