Michael S. Molina
d6f9fb5af1
chore: Removes unused vars ( #20194 )
...
* chore: Removes unused vars
* Fixes lint
* Disables no-unused-vars for the operators
2022-06-15 11:01:45 -03:00
Cody Leff
d0165b617b
chore(dashboard): update Edit Dashboard side panel tabs ( #20337 )
...
* Reorder Dashboard Edit tabs and rename 'Components' tab to 'Layout Elements'.
* Add tests for BuilderComponentPane.
* Fix Cypress tests, capitalization, test nesting.
2022-06-10 12:57:32 -03:00
Geido
3a4176a8d5
chore: Implement global header in Dashboard ( #20146 )
...
* Add gloal header
* Reimplement report dropdown
* Update unit tests
* Clean up
* Clean up
* Remove unused import
* Update Cypress
* Update Cypress save dashboard test
* Fix spacing
2022-05-25 12:56:19 +02:00
Jesse Yang
6139057dcf
test: make tabbed dashboard a little more complex ( #19966 )
2022-05-13 17:31:23 -07:00
AAfghahi
fd611d7653
refactor: Refactor reports for Charts and Dashboards ( #19130 )
...
* bumping shillelagh
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* Preset io ch28954 refactor reports (#19129 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* refactoring reports
* ready for review
* added testing
* removed user reducer
* elizabeth suggestions
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
* deleted additional folder
* fixing tests
* all but styling
* bumping shillelagh
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* Preset io ch28954 refactor reports (#19129 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* refactoring reports
* ready for review
* added testing
* removed user reducer
* elizabeth suggestions
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
* deleted additional folder
* fixing tests
* all but styling
* fixed tests
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-05-11 14:19:51 -04:00
Geido
d0b8b1e97d
feat: Applitools Cypress workflow ( #19956 )
...
* WIP
* Attempt Github Actions integration
* Add completion notification to workflow
* Update env
* Add new line
* Add license
* Fix whitespaces
* Fix Yaml indentation
* Fix afterEach
* Add initial tests
* Update config
* Use test secret
* Clean up
* Add batchName
* Disable logs - add secret
* Create separate workflow
* Clean up
* Update workflow
* Exclude applitools tests
* Update jobs name
* Run applitools tests separetely
* Fix path pattern
* Run once
* Add more initial tests
* Enhance tests
* Add dashboard edit mode test
* Move env
* Exclude applitools from sqllab test run
* Attempt pull_request_target
* Catch Applitools failures
* Clean up tests
* Add test step
* Add test step
* Remove step
* Fix SqlLab test
* Update CURL request
* Fix Yaml
* Add empty data to batch completion
2022-05-09 15:42:20 +02:00
Jinghuayao
ad1338fb47
test(native filter): refactor and add new test ( #19821 )
...
* refactor and add new test
* fix lint
* fix fail test
* fix front end error
* fix frontend error
* fix fail test for front end check
* add native filter helper
* more changes
* seperated test for different state
* seperated tests by initail state
* fix failure
* one more fix
* enable test
2022-04-28 09:41:22 -07:00
Josh Soref
bebb10e495
chore(frontend-tests): Spelling ( #19853 )
...
* spelling: against
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: been
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: charts
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: clicking
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: columns
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: duplicate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: especially
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: extensions
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fields
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: filter
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: for
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: label
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: labeled
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: nativefilter
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: registry
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: render
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: resizable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: response
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: successful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: transform
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unfortunately
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: until
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: virtual
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: wrapper
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2022-04-26 10:35:01 -07:00
Jinghuayao
2a75e4c3c3
test(native filter): add new test for dependent filter ( #19392 )
...
* add new test for dependent filter
2022-04-01 01:06:48 -07:00
Jesse Yang
8d53db1db6
test: fix TimezoneSelector tests on daylight saving time ( #19156 )
2022-03-16 14:47:41 -07:00
Jinghuayao
981f09b5db
test(native filter): add new native filter test ( #19115 )
...
* add new native filter test
2022-03-15 08:16:06 -07:00
Michael S. Molina
06e1e4285e
feat: Adds support to multiple dependencies to the native filters ( #18793 )
...
* chore(native-filters): Remove cascading popovers from filter bar
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-03-04 13:06:10 -03:00
John Bodley
26486d01c1
chore: Remove legacy SIP-15 interim logic/flags ( #18936 )
...
* chore: Remove legacy SIP-15 logic
* Update ab9a9d86e695_deprecate_time_range_endpoints.py
* Update UPDATING.md
* Update UPDATING.md
* Update UPDATING.md
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-03-04 09:15:36 +13:00
Jesse Yang
5a8eb09afb
feat: remove loading indicator when typing in select ( #18799 )
2022-03-03 09:40:49 -08:00
Jinghuayao
2bd8d3b349
test(Native Filter): User can create parent filters using "Filter is hierarchical ( #18915 )
...
* add new native test for parent filter
2022-02-25 00:27:26 -08:00
Jinghuayao
0af671fa25
test(native filter): add new native filter test for time column filter ( #18850 )
...
* add new native filter test for time column filter
2022-02-24 10:24:14 -08:00
Michael S. Molina
48a80950de
feat: Improve state key generation for dashboards and charts ( #18576 )
...
* feat: Improve state key generation for dashboards and charts
2022-02-14 17:09:06 -03:00
Jinghuayao
e44163ef55
test(Native filter): add cypress test user can add time grain filter ( #18669 )
...
* add new test time grain filter
2022-02-11 08:12:24 -08:00
Jinghuayao
7670f3a208
test(native filter): add test for time range filter ( #18647 )
...
* add native filter test for time range filter
2022-02-10 08:08:24 -08:00
Michael S. Molina
fdf57cc22a
chore: Rename and reposition native filter modal fields ( #18558 )
...
* chore: Rename and reposition native filter modal fields
* Fixes collapse initial state
* Changes the button to sentence case
2022-02-08 16:36:40 -03:00
Phillip Kelley-Dotson
cfd851aa13
fix: replace datamask with key from new key value api ( #17680 )
...
* afirst stage to ccheck to get initial datamask
* clean up code and update typescript
* remove consoles
* fix ts and update copy dashboard url
* use key when one doesn't exists
* lint clean up
* fix errors
* add suggested changes
* remove line
* add tests and add changes for copydashboard
* fix lint
* fix lint
* fix lint
* Update superset-frontend/src/dashboard/components/Header/index.jsx
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* add timeout
* fix test
* fix test, add qs to cypress and add suggestions
* add suggestions
* fix lint
* more suggested changes for backwards comapat
* fix lint
* cleanup naming and add qs parse to tests
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* more changes and fix lint
* remove nativefiler param
* fix path
* remove con
* simplify logic
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-12-21 09:08:48 -08:00
Geido
dad8c20af7
fix(Dashboard): Copy dashboard with duplicating charts 500 error ( #17707 )
...
* Fix copy dashboard with charts
* Fix Cypress test
2021-12-09 16:25:01 -07:00
Geido
12bd1fcde5
fix: Save properties after applying changes in Dashboard ( #17570 )
...
* Refactor PropertiesModal
* Update json_metadata fully
* Clean up
* Verify values
* Catch changed to metadata
* Always updated dashboard info on update
* Avoid unnecessary fetches
* Formt
* Fix copy dashboards
* Fixes onUpdate onCopy handlers
* Pylint
* Update tests
* Clean up
* Handle data on show
* Change Save to Apply
* Update Cypress save test
* Update Cypress edit prop test
* Update PropertiesModal test
* Fix duplicate request with cross filters
* Improve code style
* Fix typo
* Lint
2021-12-09 10:03:07 -07:00
Geido
8963cca265
Revert "fix(Dashboard): Only apply changes when editing properties ( #17392 )" ( #17618 )
...
This reverts commit 0712be4c12
.
2021-12-01 11:35:55 -07:00
jinghua-qa
1e2c83419c
test: add native filter default value e2e ( #17398 )
...
* add native filter default value e2e test
* fix lint
* remove unnecessary check
2021-11-16 18:54:08 +02:00
Geido
0712be4c12
fix(Dashboard): Only apply changes when editing properties ( #17392 )
...
* Apply only
* Test apply button
* Update Cypress
* Rename test
2021-11-12 19:34:21 +02:00
jinghua-qa
ab1fcf3068
test: add native filter e2e test part3 ( #17343 )
...
* add 2 stable test
* fix lint
2021-11-05 22:32:27 +08:00
Geido
59a6502efe
fix: Color consistency ( #17089 )
...
* Update label colors on the fly
* Clean up
* Improve getFormDataWithExtraFilters
* Improve code structure
* Remove labelColors from formData
* Exclude label_colors from URL
* Refactor color scheme implementation
* Clean up
* Refactor and simplify
* Fix lint
* Remove unnecessary ColorMapControl
* Lint
* Give json color scheme precedence
* Add label_colors prop in metadata
* Separate owners and dashboard meta requests
* Remove label_colors control
* bump superset-ui 0.18.19
* Fix end of file
* Update tests
* Fix lint
* Update Cypress
* Update setColorScheme method
* Use Antd modal body
2021-11-03 19:22:38 +02:00
jinghua-qa
abf24bbb5d
test: add native filter part2 ( #17283 )
...
* add native filter part2
* fix lint
* remove unused code
* fix lint after modified
2021-11-01 11:36:47 -03:00
jinghua-qa
9ef9adfd78
test: added some sanity test for native filter ( #17231 )
...
* add sanity native filter cypress e2e test
* add liscense
* fix front-end lint
* fix fail
* remove unuse import
2021-10-29 11:08:18 +08:00
Lyndsi Kay Williams
732e5891e5
test: Cypress 7.0.0 migration ( #16911 )
...
* Copied changes from original PR, minus package-lock.json files
* Reverted command name change
* Fixed package.json in superset-frontend
* Test adjustments
2021-10-14 17:01:11 -07:00
Geido
271ec6ec75
chore: Select component refactoring - SaveModal - Iteration 5 ( #16446 )
...
* Refactor Select
* Fix Cypress
* Reconcile with master
* Use onChange over onSelect
* Reconcile with latest changes
* Update Cypress
* Update Cypress test
* Fix lint
2021-09-27 18:14:58 +03:00
Kamil Gabryjelski
486e0d412c
chore: Upgrade Webpack to v5 ( #16701 )
...
* Upgrade Webpack to v5
* Remove mapbox hack
* Replace url-loaders and file-loaders with asset modules
* Remove 1 rule
* Change --colors to --color
* Remove invalid option (--no-progress)
* Remove url-loader, bump plugin
* Fix AnnotationLayer formula check
* Remove redundant tests
* Bump cypress packages
* Remove old comment
* Fix tests
* Remove checks for number of scripts in markdown test
* Cosmetic changes
* Add tests
* Fix test
* Fix test
* Fixes test warnings
* disable flaky test
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-22 14:24:54 +03:00
Kamil Gabryjelski
9ff2531cd0
fix(dashboard): Add resize handles to right and bottom of component ( #15778 )
...
* fix(dashboard): Add resize handles to right and bottom of component
* Fix test
2021-07-20 11:23:37 +02:00
Phillip Kelley-Dotson
070f0b6cb2
refactor: icon to icons for IconButton and Header component ( #15647 )
...
* initial commit
* fix test
* last one
* fix cypress
* remove gridunit for fonsize
* fix cypress
* more data-test removal
* last one
* more data-test
2021-07-14 11:04:21 -07:00
Phillip Kelley-Dotson
abd999bd6b
refactor: icon to icons for filterbadge components ( #15557 )
...
* initial commit
* fix test
2021-07-08 11:53:35 +08:00
Phillip Kelley-Dotson
29dd0844bf
refactor: icon to icons for headeractionsdropdown ( #15560 )
...
* initial commit
* fix test
* fix cypress
* fix markdown cypress test
2021-07-07 10:20:15 -07:00
Phillip Kelley-Dotson
ea2a98fcc2
refactor: icon to icons for popovercomponent ( #15451 )
...
* initial commit
* fix test
* lint
* align icon
* remove consoles
2021-07-02 08:07:06 -07:00
Phillip Kelley-Dotson
95b9e2e185
refactor: icon to icons for favestar component ( #15371 )
...
* initial commit
* initial commit
* fix cypress test
* fix favstar cypress test
* fix card view
* fix other card view
2021-06-25 09:48:22 -07:00
Yongjie Zhao
9f54231af1
fix: filterbox apply single value ( #14841 )
...
* fix: filterbox apply single value
* fix ci
* fix e2e
2021-05-27 14:00:48 +08:00
Ville Brofeldt
97c9e37c24
perf: memoize db_engine_spec in database ( #14638 )
...
* perf: memoize db_engine_spec in sqla table classes
* remove extended cypress timeouts
2021-05-14 12:49:35 +03:00
Ville Brofeldt
3f6bd1e4a4
feat: add generic type to column payload ( #14547 )
...
* feat: add generic type to column payload
* feat: add generic type to column payload
* xit flaky test
2021-05-13 09:36:09 +03:00
Grace Guo
ada380982b
fix: bring back dashboard perf logger ( #14584 )
...
* fix: bring back dashboard perf logger
* add test
2021-05-12 08:25:46 -07:00
Michael S. Molina
331310db9b
refactor: Bootstrap to AntD - Form - iteration 2 ( #14379 )
2021-05-05 22:00:37 -07:00
Ville Brofeldt
40fb94dcca
feat(native-filters): add optional sort metric to select filter ( #14346 )
...
* feat(native-filters): add optional sort metric to select filter
* use verbose name when defined
* fixes
* lint
* disable flaky test
* disable flaky test
* disable flaky test
2021-04-27 20:28:38 +03:00
simcha90
7e5440a359
test(native-filters): Filter config modal test ( #14245 )
...
* test: add tests for filter bar
* test: merge filter bar tests with master
* test: add test for filter set
* test: filter set tests
* test: merge with master
* test: fix tests for filter bar
* test: filter config modal
* test: add select filter
* feat: filter config modal
* lint: fix lint
* lint: fix TS
* test: test testWithId
2021-04-20 14:07:08 +03:00
simcha90
d386e66f59
test(native-filters): add integration tests for filter bar ( #14098 )
...
* test: add tests for filter bar
* test: merge filter bar tests with master
* test: add test for filter set
* test: filter set tests
* test: merge with master
* test: fix tests for filter bar
* fix: fix CR notes
* fix: fix CR notes
2021-04-20 12:24:12 +03:00
Phillip Kelley-Dotson
4bb29b6f04
chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata ( #13306 )
...
* add hook for future async api calls
* test to see conflict
* add async middleware and update reducers
* working async dashboard load
* implement getcharts api
* add user permissions to explore and dashboard bootstrap data
* integrate api calls with getinitial state
* update namings
* accept an id or a slug in the dashboard charts api
* add permissions function
* fix merge
* update state
* get dashboard charts by id or slug
* fix undefined states
* variable names
* stop using some more bootstrap data
* fix metadata reference
* remove unused bootstrap from the template
* add errorboundry to dashboard
* refactoring, fixing
* update permissions
* add just roles
* id is supposed to be a string
* unused vars
* get datasources from api
* make onError optional
* use resource hooks, better error boundary
* add loading state for dashboardroute
* remove console
* add conditional
* more conditionals
* testing out a possible fix for cypress
* convert edit/standalone test to cypress
* remove bootstrappy assertions
* lint
* fix dashboard edit history issue
* rename stuff
* address recent native filters schema change
* remove unused getInitialState
* remove .only from test
* hooksy redux usage
* Revert "more conditionals"
This reverts commit 25c8ed61b4
.
* cleanup
* undo unnecessary change
* actually need conditions here
* certainty
* Revert "certainty"
This reverts commit 77dea1915b
.
* more permutations (untested yolo)
* Update superset-frontend/src/chart/chartReducer.ts
Co-authored-by: Evan Rusackas <evan@preset.io>
* import style
* comment
* cleaner dashboardInfo
* remove debug code
* use memo for getPermissions
* fix lint
* adjust name/location of DashboardPage
* move logic for REMOVE_SLICE_LEVEL_LABEL_COLORS to DAO
* stop using full_data()
* remove unused (and now useless) json=true query param
Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2021-04-12 16:10:29 -07:00
David Aaron Suddjian
db1d598f50
fix(cypress): avoid referencing detached dom nodes ( #13825 )
2021-03-26 14:46:31 -07:00
David Aaron Suddjian
a45a5e1060
chore(cypress): Make the e2e tests more behavior-driven ( #13784 )
...
* chore(cypress): make the load dashboard test behavior driven
* remove bootstrap usage from controls test, + new utils
* fix save test to not use bootstrap dat
* remove bootstrap usage from the filter test
* fix race condition
* remove bootstrap from url params test
* fix lint
* remove unused const
* add chart specs for the tab test
* attempt removing bootstrap data from tabs tests
* fix cypress async/sync confusion
* remove redundant assertions
* attempt fixing tab test
* attempt fixing tabs test
* cleanup commented code
* better aliases so you can tell what they are in the logs
* remove unused imports
* get the line chart alias before clicking the tab
* simplify getChartGridComponent
* wait for all the charts before force refresh
* fix tabs test
* one more time with the tabs test
* another edit to tabs test
* fix flaky test
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
2021-03-26 09:20:13 -07:00