Commit Graph

1019 Commits

Author SHA1 Message Date
Jesse Yang
ef839f674d
fix: remove whitespace at the bottom of select dropdown (#12699) 2021-01-24 09:10:32 +08:00
Kasia Kucharczyk
dc740ecc1e
[12486] Top tab dropdown indicator moved closer to the bottom of edge (#12658) 2021-01-23 15:48:38 +08:00
Ville Brofeldt
ede879022c
fix(multiline): return all chart data on initial request (#12660)
* fix(multiline): return chart data on data request

* bump package

* optimize chart retrieval and fix chart form_data
2021-01-23 15:01:50 +08:00
Agata Stawarz
0c38134e5c
fix(native-filters): Reset column field for removed dataset (#12519)
* Reset column field for removed dataset

* Fix issue with cleaning exisiting field

* Fix lint error and remove unnecessary import

* Change message text for wrong filter

* Add Basic Error Alert component

* Fix hiding error after filter correction
2021-01-23 13:24:31 +08:00
Agata Stawarz
b37598cc97
fix(native-filters): Improve UI for long native filters names (#12524)
* Fix UI for long native filters names

* Add Filter width const

* Refactor Filter Bar and Config Modal

* Break word for long Filter Control titles
2021-01-23 13:24:15 +08:00
Agata Stawarz
9c53ad48aa
fix(native-filters): Show incompatible native filters indicator (#12687)
* Show incompatible native filters indicator

* Add Native Filters mocks and tests to Filter Badge

* Compare filter names in deduplication logic

* Add indicator key

* Remove unnecessary import
2021-01-23 13:23:21 +08:00
Jesse Yang
7e77975d22
feat(explore): better search for dataset pane (#12675)
1. Upgrade match-sorter from 4.1.0 to 6.1.0
2. Add a debounce delay of 200 milliseconds to reduce excessive rendering (and searching)
3. Set keepDiacritics to true to improve performance
4. Display count of filtered results in "Showing x of xx", instead of the total results
5. Rank certified metrics to the top
2021-01-22 14:26:55 -08:00
Jesse Yang
55232e235a
fix: faster search for Change Dataset modal (#12669) 2021-01-22 14:26:02 -08:00
Geido
b32b6cd5de
fix(explore): Certified metric icons are various sizes (#12690) 2021-01-22 13:14:40 -08:00
Michael S. Molina
e80cd61e06
Apply capitalization guidelines - iteration 5 (#12343) (#12451) 2021-01-22 10:11:48 -08:00
Michael S. Molina
fc20e8b594
Apply capitalization guidelines - iteration 4 (#12343) (#12450) 2021-01-22 10:11:38 -08:00
Michael S. Molina
5d3265b6db
Apply capitalization guidelines - iteration 3 (#12343) (#12449) 2021-01-22 10:11:28 -08:00
Jesse Yang
57fa6d2cf9
fix: explore page style fix, remove unnecessary scroll bars (#12649)
* fix: various style touch on Explore page

* More style fixes

* Force 100% height for sidebars

* Fix linting
2021-01-22 09:18:13 -08:00
Michael S. Molina
7838f035ae
Apply capitalization guidelines - iteration 9 (#12343) (#12455) 2021-01-21 21:46:29 -08:00
Michael S. Molina
217034e990
Apply capitalization guidelines - iteration 8 (#12343) (#12454) 2021-01-21 21:46:18 -08:00
Michael S. Molina
d9388d4535
Apply capitalization guidelines - iteration 7 (#12343) (#12453) 2021-01-21 21:46:06 -08:00
Michael S. Molina
2a587f6cb1
Apply capitalization guidelines - iteration 6 (#12343) (#12452) 2021-01-21 21:45:44 -08:00
Michael S. Molina
8532e6d9e1
Apply capitalization guidelines - iteration 2 (#12343) (#12448) 2021-01-21 21:45:12 -08:00
Kamil Gabryjelski
6280b34483
fix(explore): don't allow selecting duplicated saved metric (#12657) 2021-01-21 15:51:59 -08:00
Kamil Gabryjelski
a90ebd94d4
fix(explore): Error message not displayed correctly in Timeseries table chart (#12659)
* Fix error message not displayed correctly in Timeseries table chart

* Fix lint error
2021-01-22 12:42:44 +13:00
Geido
3444d654ed
fix(explore): Scroll only table in Change Dataset and Edit Dataset Modals (#12598) 2021-01-21 10:34:41 -08:00
Ville Brofeldt
734fb75219
chore(viz): bump superset-ui packages to 0.16.9 (#12632) 2021-01-21 13:50:47 +02:00
Kasia Kucharczyk
effd717094
[12601] Hovered menu items on dashboard - brought back padding and added margin on top of chart (#12603) 2021-01-21 11:32:34 +02:00
Agata Stawarz
c72c39bffd
feat(native-filters): Show alert for unsaved filters after cancelling Filter Config Modal (#12554)
* Add Alert when native filter is canceled and not saved

* Improve styles and setting styles visible

* Improve displaying filter names

* Add tests for canceling native filter modal

* Fix linter errors

* Refactor Cancel Confirmation Alert
2021-01-20 20:57:28 -08:00
Srini Kadamati
7577f47706
docs: update README.MD and FAQ Page for Superset 1.0 launch (#12499)
* fixed whitespace

* commit exclusion of package-lock from large file size precommit hook

* Converted all PNG files to JPG files to save space, stay under <500kb file size

* added link to release notes for 1.0
2021-01-20 16:27:19 -08:00
Kasia Kucharczyk
b592165f68
fix: dropdown indicator in tabs has proper width and position (#12584)
Closes #12481 , partially fix #12486
2021-01-20 14:18:42 -08:00
Michael S. Molina
c85b4c75b1
Fix translation files and update documentation (#12595) 2021-01-20 10:50:24 -08:00
simchaNielsen
2463215d73
refactor: Sync Scoping tree with Forms data (#12171)
* refactor: sync Scoping tree with Forms data

* refactor: update scoping tree

* refactor: update scope tree logic to be more UX friendly

* test: fix tests

* lint: fix lin CR notes

* fix: fix jsx

* refactor: revert type changes

* refactor: revert type changes

* lint: fix lint

* lint: fix lint

* test: fix test

* fix: process initial dashboard case

* lint: fix lint / tests
2021-01-20 11:40:53 +02:00
Nikola Gigić
a422c765c7
chore(chart): Save modal select placeholder value (#12413)
* Fix SaveModal select value

* var name change and null

* Address Comments
2021-01-19 22:17:56 -08:00
Kamil Gabryjelski
853d34beba
fix(explore): Disable saved metric name edit in Metric popover (#12582) 2021-01-19 12:28:55 -08:00
Duy Nguyen Hoang
862ddd9cb4
fix: chart disappears in standalone slice (#12606) 2021-01-19 11:56:24 -08:00
Hugh A. Miles II
68fe2208ba
fix: save tabs when saving the query bug (#12607)
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-01-19 14:27:48 -05:00
Geido
c347ddbfb6
Switch button position (#12604) 2021-01-19 10:26:46 -08:00
Evan Rusackas
dd4256a841 chore: bumping superset UI packages (0.16.7 + 0.16.8) (#12564)
* chore: package bump manifest (package.json)

* fresh package lock
2021-01-19 09:38:04 -08:00
Yongjie Zhao
9771b82c94
refactor(explore): move MetricControl and FilterControl to sub-component (#12446)
* wip

* wip

* wip

* wip

* move spec

* wip

* wip

* remove unused file

* wip

* wip

* Update superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopoverSqlTabContent_spec.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/explore/components/AdhocFilterOption_spec.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopoverTitle_spec.jsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-01-19 22:46:28 +08:00
Nikola Gigić
a0f3bb8dbe
feat(chart): Add expression, description and verbose name to search filter (#12549) 2021-01-18 09:38:19 -08:00
Kasia Kucharczyk
4ddb55b930
fix: row component handler is visible (#12498) 2021-01-17 16:38:17 -09:00
Hugh A. Miles II
db4664ec11
fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555) 2021-01-15 18:00:33 -05:00
Beto Dealmeida
39c6ef2c75
fix: incorrect cursor position Firefox (#12423)
* fix: incorrect cursor position Firefox

* Use different font

* Fix lint

* Use Lucida Console
2021-01-15 14:00:23 -08:00
Beto Dealmeida
cce05e888b
fix: height on grid results (#12558) 2021-01-15 13:54:55 -08:00
Kamil Gabryjelski
e1eeeebe53
fix: Select options overflowing Save chart modal on Explore view (#12522)
* Fix select options overflowing modal

* fix unit test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-01-15 12:43:33 +02:00
Jesse Yang
1dd3344206
fix(explore): Add Time section back to FilterBox (#12537) 2021-01-14 22:09:33 -08:00
Jesse Yang
41b7eb3d04
fix(explore): time table control panel (#12532) 2021-01-14 19:17:35 -08:00
Agata Stawarz
57e37ed4d5
fix: Displaying filter indicators (#12252)
* Fix chart filter indicator to match native filter indicator

* Refactor indicators deduplication
2021-01-14 10:57:41 -08:00
Geido
c1b8a46d01
fix: Popover closes on change of dropdowns values (#12410) 2021-01-14 10:33:20 -08:00
Jesse Yang
eec78560f2
build: fix emotion theme errors when npm link @superset-ui/core (#12510) 2021-01-14 10:20:13 -08:00
Ville Brofeldt
78baf46eb2
ci(cypress): disable failing test (#12523) 2021-01-14 19:40:28 +02:00
Karol Kostrzewa
241f380e2e
test: World bank examples (#12161)
* add world bank data fixture

* fix fixture cleanup, add fixture to dashboard_tests

* apply world bank fixtures, fix tests

* fix fixture typo, dashboard ids

* fix export dashboard metadata

* fix test_export_dashboard_command_key_order

* fix export dash tests, not add row when no orphans

* debug timeout

* fixes after merge

* fix lint

* run pre-commit

* comment test for debug

* fix save.test.js

Co-authored-by: Karol Kostrzewa <karol.kostrzewa@polidea.com>
2021-01-13 14:20:05 -08:00
Michael S. Molina
87ac22ba52
Fix list filters vertical alignment (#12497) 2021-01-13 13:58:05 -08:00
Moriah Kreeger
628a9b2b7b
keep modal open on error, utilize useEffect (#12360) 2021-01-13 10:53:31 -08:00
Lily Kuang
908c0f2b52
remove crontab guru link (#12467) 2021-01-13 10:49:54 -08:00
Hugh A. Miles II
7ac6e61b96
fix: styling for change dataset confirmation (#12471) 2021-01-13 12:48:15 -05:00
Beto Dealmeida
086b3a66a0
fix (SQL Lab): disappearing results on tab switch (#12472)
* fix (SQL Lab): disappearing results on tab switch

* Remove state

* Fix test
2021-01-13 19:10:04 +02:00
Jesse Yang
f8270b0b80
fix(dashboard): use datasource id from slice metadata (#12483) 2021-01-13 18:49:51 +02:00
Ville Brofeldt
40a334aacf
feat(db-engine-specs): add support for Postgres root cert (#11720)
* feat(db-engine-specs): add support for Postgres root cert

* remove logging of json decode exception message

* fix error message

* fix error message
2021-01-13 13:39:28 +02:00
Evan Rusackas
7aba4c246a
chore: bump superset-ui deckgl plugin (#12466) 2021-01-13 00:10:47 -08:00
Michael S. Molina
551a3e4373
Fix uneven list header padding (#12029) (#12412) 2021-01-12 23:29:43 -08:00
Grace Guo
e9d66e904f
fix: do not show vertical scrollbar for charts in dashboard (#12478)
* fix: do not show vertical scrollbar for charts in dashboard

* Proper fix for #11419

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-01-12 17:16:25 -08:00
Beto Dealmeida
8f83afcf49
feat: new Slack dashboard (#12415)
* feat: new Slack dashboard

* Add ASL license

* Fix test
2021-01-12 15:24:44 -08:00
Kasia Kucharczyk
5f93a14f5d
fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418)
* [12181] Fix artifacts while drag and dropping deck.gl charts.

* Run prettier
2021-01-12 12:06:48 -08:00
Michael S. Molina
6731cd0be6
chore: apply capitalization guidelines - iteration 1 (#12447)
Apply capitalization guidelines defined in #12343 

Use sentence casing for most places.
2021-01-12 10:47:55 -08:00
Kamil Gabryjelski
ed53b0090e
feat: Resizable dataset and controls panels on Explore view (#12411)
* Implement resizable panels on explore view

* Optimize chart rendering while resizing

* Make dataset column narrower

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-01-12 10:39:56 -08:00
Phillip Kelley-Dotson
d8f4443c10
bump superset-ui packages for rolling window change (#12426) 2021-01-12 09:50:01 -08:00
Junlin Chen
fe01e2d88d
fix(explore): fixed table header in chrome (#12432) 2021-01-12 09:17:00 -08:00
Hugh A. Miles II
1e527d54e7
fix: update savedatasetmodal message (#12433) 2021-01-12 11:58:29 -05:00
Ville Brofeldt
078a8a17a1
fix(native-filters): incorrect queriesData state (#12409) 2021-01-12 09:01:16 +02:00
Michael S. Molina
75f927b9eb
Fixes control panel fields styling (#12236) (#12326) 2021-01-11 16:47:10 -08:00
Geido
376723a1f5
chore: Show datasets when search input is empty (#12391) 2021-01-11 14:06:57 -08:00
Agata Stawarz
ddbcf5b0e9
fix: Refresh Interval Modal dropdown (#12406) 2021-01-11 11:58:28 -08:00
Grace Guo
9618f0786c
[explore] Prevent duplicated query by data table (#12404) 2021-01-11 11:37:54 -08:00
dependabot[bot]
ee53d82184
build(deps): bump urijs from 1.19.1 to 1.19.4 in /superset-frontend (#12232)
Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.1 to 1.19.4.
- [Release notes](https://github.com/medialize/URI.js/releases)
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md)
- [Commits](https://github.com/medialize/URI.js/compare/v1.19.1...v1.19.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-11 05:58:33 -08:00
Jesse Yang
ff7b789931
docs: reword and cleanup docs for local dev server (#11869) 2021-01-10 23:36:01 -08:00
Yongjie Zhao
23263da9f3
feat(explore): add tooltip to timepicker label (#12401) 2021-01-10 21:52:02 -08:00
Yongjie Zhao
c327cb911e
fix(explore): long metric name display (#12387)
* fix(explore): long metric name display

* add tooltip to control
2021-01-11 09:42:38 +08:00
Jesse Yang
9acf48fd1e
chore: upgrade eslint, babel, and prettier (#12393) 2021-01-10 17:26:35 -08:00
Junlin Chen
6bee3a0581
chore: change Datasource to Dataset in Explore ui (#12402)
* chore(explore):change dataset to datasource in ui

* modal

* Add space

* Changing it back🤦🏾‍♀️

* Chargeback
2021-01-10 12:53:51 -08:00
Junlin Chen
f13f2e2ed3
chore: Fix typo “Rest” to “Reset” (#12392) 2021-01-09 19:40:28 -08:00
Duy Nguyen Hoang
99de8a49b6
fix: explore replace wrong standalone slice url (#12359) 2021-01-09 13:32:06 -08:00
Geido
3eb0470a2f
Closes #12389 (#12390) 2021-01-09 22:18:59 +02:00
Kamil Gabryjelski
5d04f7dbce
fix: Data tables styling issues on Explore view (#12383)
* Fix sort icons wrapping

* Fix large table stretching chart section container

* Implement sticky paginattion

* Display "loading" when data is loading

* Lint fix
2021-01-09 18:04:53 +02:00
Kamil Gabryjelski
14ccbe43b3
Fix new metric popover showing previous popover's title (#12385) 2021-01-09 16:05:25 +02:00
Yongjie Zhao
64b49778c5
fix(explore): adhoc metric label and control value not consistent (#12381)
* fix(explore): adhoc metric label and control value not consistent

* minor fix

* fix lint
2021-01-09 17:59:09 +08:00
Ville Brofeldt
662b64960f
fix(explore): clear custom label if removed (#12382) 2021-01-09 01:41:41 -08:00
Kamil Gabryjelski
6a3103ff49
Fix filter popover under data table (#12377) 2021-01-09 00:54:39 -08:00
Kamil Gabryjelski
41751529a6
Update samples table when datasource changes (#12378) 2021-01-09 10:11:42 +02:00
Hugh A. Miles II
12504264e7
fix: datasets populating after user creation (#12368) 2021-01-08 21:04:00 -05:00
Phillip Kelley-Dotson
9c5be8e4d8
chore: make datasource search input sticky (#12365) 2021-01-08 17:08:07 -08:00
Kamil Gabryjelski
77b80c9431
fix: Fix chart resizing when using split view (#12362)
* Fix chart resizing when using split view

* Fix z-index issues
2021-01-08 15:20:51 -08:00
Jesse Yang
2210015aab
test: rename column names for birth_names dataset (#12082) 2021-01-08 14:13:20 -08:00
Kamil Gabryjelski
1d2789944c
Fix running query on every change in chart controls (#12361) 2021-01-08 12:56:45 -08:00
Hugh A. Miles II
7c8ead85c1
fix: Fix dataset condition to allow query for datasets in sqllab (#12357) 2021-01-08 15:36:19 -05:00
Kamil Gabryjelski
fd15dff60e
perf: Optimize performance of Results and Samples tables on Explore (#12257) 2021-01-08 12:07:51 -08:00
Michael S. Molina
76b06b215f
Fix CSS injection order (#12265) (#12353) 2021-01-08 11:08:34 -08:00
Nikola Gigić
737e6b4aee
chore(dashboard): Add ErrorBoudary for AdhocFilter components (#12352)
* Add ErrorBoudary for AdhocFilter components

* Add tests

* typo fix
2021-01-08 20:58:26 +02:00
Ville Brofeldt
78d3557757
fix(explore): improve filter translation (#12350)
* fix(explore): improve filter translation

* address review comments
2021-01-08 20:57:21 +02:00
Victor Malai
4d279935df
fix: Set width to pseudoelement to wrap filter box (#12306)
* fix: set width pseudoelement to wrap

* Fix

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
2021-01-08 10:09:37 -08:00
Elizabeth Thompson
466a7c8693
fix: south pane scrolling issues (#12318)
* remove extra scrollbars

* fix sql lab south pane bottom margin

* Update superset-frontend/src/SqlLab/components/SouthPane.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/SqlLab/components/SouthPane.jsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* move styles to component

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-01-08 09:52:33 -08:00
Evan Rusackas
d1767b9065
chore: bumping nvd3 plugin (and thus, nvd3-fork) (#12349) 2021-01-08 16:08:31 +02:00
simchaNielsen
fecfc34cd3
feat: move filters from superset-ui to incubator (#12154)
* feat: move filters from superset-ui to incubator

* refactor: add safety check

* refactor: move extraForm data utils

* refactor: move extraForm data utils

* lint: fix lint

* chore: add license

* chore: undo changes to file

* refactor: fix CR notes / add tests

* test: update tests

* fix: fix range logic

Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
2021-01-08 14:44:25 +02:00
Evan Rusackas
d760e885d7
window.location > history.push (#12347) 2021-01-07 22:26:31 -08:00