Commit Graph

647 Commits

Author SHA1 Message Date
Kamil Gabryjelski
70081a698f
fix(dashboard): Empty states overflowing small chart containers (#19095)
* fix(dashboard): Empty states overflowing small chart containers

* Fix test
2022-03-10 15:54:07 +01:00
smileydev
220c46131e
fix(altered-modal): make specified text fields wrap in table (#18822)
* fix(altered-modal): make all text fields wrap

* fix(altered-modal): limit the wrap text in particular column

* fix(altered-modal): make to update the unit test

* fix(altered-modal): make to fix the type of columnsForWrapText

* fix(alerted-modal): make to fix the type of columnsForWrapTest with string type
2022-03-09 12:43:16 -07:00
Michael S. Molina
79a7a5d1b1
fix: Select clear and loading icons overlap (#19070) 2022-03-09 10:03:30 -03:00
Jesse Yang
c75f233109
feat(select): sort exact and startsWith match to first (#18856) 2022-03-08 07:08:40 -08:00
Michael S. Molina
04a36d5c92
chore: Moves Chart to the components folder (#19029) 2022-03-08 08:57:29 -03:00
Michael S. Molina
71b8d31e77
chore: Moves CRUD components to the Datasource component (#19032)
* chore: Moves CRUD components to the Datasource component

* Fixes imports

* Fixes less import
2022-03-07 09:02:18 -03:00
Michael S. Molina
329855170e
refactor: Deletes the common/components folder (#18999) 2022-03-04 14:19:14 -03:00
Michael S. Molina
06e1e4285e
feat: Adds support to multiple dependencies to the native filters (#18793)
* chore(native-filters): Remove cascading popovers from filter bar

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-03-04 13:06:10 -03:00
Jesse Yang
5a8eb09afb
feat: remove loading indicator when typing in select (#18799) 2022-03-03 09:40:49 -08:00
smileydev
ca93d63bbb
fix(tooltip-not-dissapeared): make the tooltip disappear when mouse away (#18892)
* fix(tooltip-not-dissapeared): make the tooltip disappear when mouse away

* fix(tooltip-not-dissapeared): change css props instead of sytles props
2022-03-01 08:05:11 -07:00
Michael S. Molina
fd4bd1edbc
chore: Moves components out of the commons folder (#18931)
* refactor: Moves components out of the commons folder

* Fixes tests
2022-02-25 10:17:32 -03:00
Kamil Gabryjelski
9d5c0505cf
feat(native-filters): Re-arrange controls in FilterBar (#18784)
* feat(native-filters): Re-arrange controls in FilterBar

* Typo fix

* Add tests

* Fix tests

* Address PR reviews

* Add 1px bottom padding to icon

* Fix test

* Tiny refactor

* Change buttons background

* Add hover state to Clear all button

* Fix Clear All button logic so it clears all selections

* Remove redundant useEffect

* Set zindex higher than loading icon

* Fix scrolling issue
2022-02-22 17:45:53 +01:00
smileydev
3c17c609c9
fix(altered-modal): displayed the metric value in altered modal correctly (#18813)
Co-authored-by: Evan Rusackas <evan@preset.io>
2022-02-20 16:27:46 -08:00
smileydev
91236a5225
fix(sqllab): Removed the tooltip from CopyToClipboard button in sqllab (#18749)
* fix(15849): Removed the tooltip from CopyToClipboard button in sqllab

* chore(sqllab): added props for tooltip in CopyToClipboard component

* fix(sqllab): Added arg to storybook and refactor the component

* fix(sqllab): added a test case for hideTooltip
2022-02-18 16:22:21 -07:00
smileydev
2d67d2f14e
fix(delete-modal): Changed the color of the help text with grayScale.dark1 in DeleteModal (#18786)
* fix(delete-modal): Changed the color of the help text with grayScale.dark1 in DeleteModal

* Update superset-frontend/src/components/DeleteModal/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-02-17 11:45:04 -07:00
Corbin Robb
c8df84985c
fix(CRUD/listviews): Errors with rison and search strings using special characters (#18056)
* fix errors with rison and useQueryParams

* add test for encode/decode

* add rison link and make test case more readable

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2022-02-15 16:08:36 -06:00
Adam Dobrawy
8b3e27d68b
refactor: migrate QueryAndSaveBtns to TypeScript and add stories (#18121)
* refactor: Migrate QueryAndSaveBtns to TS and stories

* fix: change typing notation in QueryAndSaveBtns
2022-02-15 17:04:48 +02:00
Corbin Robb
5bb406b296
fix(sqllab): fix query results sorting (#18666)
* add sorting for query results grid and add natural order sort

* modify tests for natural/original order state

* clean up setState

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2022-02-14 13:42:04 -08:00
Kamil Gabryjelski
f8b3ece27b
feat(dashboard): Implement empty states for dashboard (#18712)
* feat(dashboard): Implement empty states for dashboard

* Add empty state to native filters

* Add missing license

* Remove redundant string types from EmptyState
2022-02-14 15:24:02 +01:00
Kamil Gabryjelski
a7d505db41
feat: Implement EmptyState components (#18676)
* feat: Implement EmptyState components

* Fix title in storybook

* Add licenses

* Add max widths
2022-02-11 17:43:09 +01:00
Meitong Qu
9f678e55b9
chore: migrate QueryTable component from jsx to tsx (#17944)
* chore: fix misspelling of button

* changed QuerySearch/index.jsx to index.tsx

* updated Query type at src/SqlLab/types.ts/Query and extended it into QueryTable

* updated defaultQueryLimit to be optional at ResultSetProps of superset-frontend/src/SqlLab/components/ResultSet/index.tsx

* moved statusAttributes into useMemo hook so that it will not make the dependencies of useMemo Hook change on every render and statusAttributes is only used within useMomo hook

* reset package-lock.json and package.json at frontend

* Acquired redux rootestate type for SqlLab, to be used at useSelector(state)

* updated query to be Query type and added a comment for q.status on line 178

* updated queryTable for typescript conversion

* updated actions type on QueryHistory and QuerySearch

* updated type for actions in SouthPane

* created type for SqlLab redux

Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-02-11 06:54:42 -06:00
Adam Dobrawy
7c69a1bc60
chore: improve React import reference consistency (#18608) 2022-02-10 21:03:16 -08:00
Emmanuel Bavoux
00eb6b1f57
feat: editable title xl certified badge (#18626)
* Add size to EditableTitle certified badge

* Lint EditableTitle file

Co-authored-by: Emmanuel Bavoux <emmanuel.bavoux@free2move.com>
2022-02-09 17:09:20 -08:00
Ville Brofeldt
8b0634c9ed
fix(listview): add nowrap to view mode container (#18246) 2022-02-04 07:42:10 +02:00
Lyndsi Kay Williams
c40b337978
feat: Added success toasts for database, dataset, chart, dashboard, and query imports (#18190)
* Added imports toasts

* Removed generic import toast

* Remove addSuccessToast from props

* Added addSuccessToast back to prop type

* Made success toast strings translatable
2022-01-28 15:29:44 -06:00
Hugh A. Miles II
e6bb0fc7ad
feat: Add toast for successful table or schema refreshes in Sqllab (#18169)
* save

* add use redux to test

* update test for db selector

* add condition for refresh only
2022-01-26 20:26:50 -05:00
David Aaron Suddjian
4ad5ad045a
feat: embedded dashboard core (#17530)
* feat(dashboard): embedded dashboard UI configuration (#17175) (#17450)

* setup embedded provider

* update ui configuration

* fix test

* feat: Guest token (for embedded dashboard auth) (#17517)

* generate an embed token

* improve existing tests

* add some auth setup, and rename token

* fix the stuff for compatibility with external request loaders

* docs, standard jwt claims, tweaks

* black

* lint

* tests, and safer token decoding

* linting

* type annotation

* prettier

* add feature flag

* quiet pylint

* apparently typing is a problem again

* Make guest role name configurable

* fake being a non-anonymous user

* just one log entry

* customizable algo

* lint

* lint again

* 403 works now!

* get guest token from header instead of cookie

* Revert "403 works now!"

This reverts commit df2f49a6d4.

* fix tests

* Revert "Revert "403 works now!""

This reverts commit 883dff38f1.

* rename method

* correct import

* feat: entry for embedded dashboard (#17529)

* create entry for embedded dashboard in webpack

* add cookies

* lint

* token message handshake

* guestTokenHeaderName

* use setupClient instead of calling configure

* rename the webpack chunk

* simplified handshake

* embedded entrypoint: render a proper app

* make the embedded page accept anonymous connections

* format

* lint

* fix test
# Conflicts:
#	superset-frontend/src/embedded/index.tsx
#	superset/views/core.py

* lint

* Update superset-frontend/src/embedded/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* comment out origins checks

* move embedded for core to dashboard

* pylint

* isort

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* feat: Authorizing guest access to embedded dashboards (#17757)

* helper methods and dashboard access

* guest token dashboard authz

* adjust csrf exempt list

* eums don't work that way

* Remove unnecessary import

* move row level security tests to their own file

* a bit of refactoring

* add guest token security tests

* refactor tests

* clean imports

* variable names can be too long apparently

* missing argument to get_user_roles

* don't redefine builtins

* remove unused imports

* fix test import

* default to global user when getting roles

* missing import

* mock it

* test get_user_roles

* infer g.user for ease of tests

* remove redundant check

* tests for guest user security manager fns

* use algo to get rid of warning messages

* tweaking access checks

* fix guest token security tests

* missing imports

* more tests

* more testing and also some small refactoring

* move validation out of parsing

* fix dashboard access check again

* add more test

Co-authored-by: Lily Kuang <lily@preset.io>

* feat: Row Level Security rules for guest tokens (#17836)

* helper methods and dashboard access

* guest token dashboard authz

* adjust csrf exempt list

* eums don't work that way

* Remove unnecessary import

* move row level security tests to their own file

* a bit of refactoring

* add guest token security tests

* refactor tests

* clean imports

* variable names can be too long apparently

* missing argument to get_user_roles

* don't redefine builtins

* remove unused imports

* fix test import

* default to global user when getting roles

* missing import

* mock it

* test get_user_roles

* infer g.user for ease of tests

* remove redundant check

* tests for guest user security manager fns

* use algo to get rid of warning messages

* tweaking access checks

* fix guest token security tests

* missing imports

* more tests

* more testing and also some small refactoring

* move validation out of parsing

* fix dashboard access check again

* rls rules for guest tokens

* test guest token rls rules

* more flexible rls rules

* lint

* fix tests

* fix test

* defaults

* fix some tests

* fix some tests

* lint

Co-authored-by: Lily Kuang <lily@preset.io>

* SupersetClient guest token test

* Apply suggestions from code review

Co-authored-by: Lily Kuang <lily@preset.io>

Co-authored-by: Lily Kuang <lily@preset.io>
2022-01-25 16:41:32 -08:00
Lyndsi Kay Williams
2491b89f29
Columns tab name field no longer editable, calculated columns rows now vertically aligned (#18164) 2022-01-25 14:34:56 -06:00
Adam Dobrawy
c3a17a7228
Migrate Checkbox story to tsx - see #18100 (#18101)
Looks good!
2022-01-20 15:33:45 +01:00
Erik Ritter
27000da2f8
fix: SQL Lab sorting of non-numbers (#18006) 2022-01-12 11:09:59 -08:00
AAfghahi
536ca1f62c
chore(DatasourceEditor): Create Datasource Legacy Editor Feature Flag (#18003)
* a lot of console logs

* adding new feature flag for datasource editor
2022-01-12 14:02:53 -05:00
Yongjie Zhao
46715b295c
refactor: remove unused ts-jest (#17996) 2022-01-11 23:43:45 +08:00
Lyndsi Kay Williams
f7add546ad
Fixed error handling in Report modal (#17988) 2022-01-10 17:01:08 -06:00
Lyndsi Kay Williams
df69920a2e
Moved dataset editor lock to top of component (#17930) 2022-01-10 16:55:00 -06:00
Evan Rusackas
c0a769581f
chore: bump typescript to 4.5.4, and adjust storybook story. (#17971)
* chore: bump typescript to 4.5.4, and adjust storybook story to pass linting

* ugh... missed a space. Thanks, linter :)

* nixing erroneous package lock file
2022-01-09 21:01:59 -07:00
Stephen Liu
2ae29c9281
fix(Select): options will be overwritten due to seState (#17951) 2022-01-07 08:09:25 -07:00
Michael S. Molina
aa91662ec8
chore: Moves the Menu to views/components folder (#17897)
* chore: Moves the Menu to views/components folder

* Fixes imports
2022-01-07 09:25:31 -03:00
Michael S. Molina
53d8d383cc
chore: Moves the hooks folder to the src folder (#17896) 2022-01-07 09:25:06 -03:00
Yongjie Zhao
ceecc7047b
chore: remove unused eslintrc (#17860)
* chore: remove unused eslintrc

* remove unused lint

* add comments

* change comments
2022-01-05 19:31:12 +08:00
Beto Dealmeida
2cd8054358
feat: add force option to report screenshots (#17853)
* Update existing tests

* Add backend test

* feat: add force option to report screenshots

* Add tests

* Rebase fixes

* Do not force screenshot on dashboard alerts
2021-12-22 12:16:04 -08:00
Lyndsi Kay Williams
d2ed1b72dc
chore: Help user to find the input fields in the dataset editor (#17824)
* Updated fields in Metrics and Calculated Columns tabs inside dataset editor, deleted label in expanded Metrics tab

* Fix tests

* Vertically aligned rows in columns tab
2021-12-22 12:21:37 -06:00
Stephen Liu
142b5bc506
fix: local warning in the frontend development (#17727) 2021-12-15 09:52:42 +02:00
Beto Dealmeida
63d9693f21
feat: add main datetime column to dataset editor (#17739)
* feat: add main dttm col to dataset editor

* Add tests
2021-12-14 14:47:08 -08:00
Geido
4b969710e4
Rename CertifiedIcon to CertifiedBadge (#17715) 2021-12-10 11:45:53 -07:00
Geido
8de93871d7
Fix flacky header (#17690) 2021-12-10 18:25:40 +02:00
Corbin Robb
f476ba23a2
fix(select): select component sort functionality on certain options (#17638)
* fix: Select component sort function sorting by label instead of value on numbers

* fix: change select component default sorting to sort by the initial index rather than a property like value or label

* fix: select sorting add sortOptions to select components using sortByProperty

* fix: change select component back, add order to options coming in from SelectControl

* fix: select component options intitial sort bug

* fix: add test cases for select fix

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-12-09 11:40:25 -05:00
Ville Brofeldt
c4b04952d0
feat: customize recent activity access (#17589)
* feat: customize recent activity access

* address comments

* fix and add tests

* add alert assertion and UPDATING.md entry

* replace .get_id() with .id

* fix updating comment

* update config name
2021-12-08 11:30:23 +02:00
Lyndsi Kay Williams
05752e3fe8
fix(sqllab): Floating numbers not sorting correctly in result column (#17573)
* Floating nums now sorting correctly with parseFloatingNums function

* Floating numbers AND strings now sorting correctly, +locale comparison

* Added NULL handling back to sort function

* Moved parseFloatingNums outside of sortResults

* Removed localeCompare and added testing

* Add equality check back to sort function

* Added floatValue nit
2021-12-03 16:31:46 -08:00
Hugh A. Miles II
d9e9c3a3de
refactor: Add AutoSizer to react-virtualized Grid (#17606)
* remove styles from renderCell

* remove styling on grid
2021-12-02 12:47:47 -05:00
Phillip Kelley-Dotson
4e76637252
initial fix (#17547) 2021-11-30 08:24:18 -08:00