Commit Graph

5007 Commits

Author SHA1 Message Date
EugeneTorap
6f3a555e58
fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane (#20969) 2022-08-16 19:29:28 +02:00
Kamil Gabryjelski
d3684c0937
fix(dashboard): Dashboard header overflowing in edit mode (#21100) 2022-08-16 19:08:29 +02:00
Diego Medina
0c84203053
fix: Unable to sync columns when dataset name has '+' (#21019) 2022-08-16 07:55:27 -06:00
Stephen Liu
b303d1e156
fix(plugin-chart-echarts): gauge chart enhancements and fixes (#21007)
* fix(plugin-chart-echarts): gauge chart enhancements and fixes

* fix lint
2022-08-16 07:54:17 -06:00
Stephen Liu
5c2a1f85ff
fix(database-modal): 'CTAS & CVAS SCHEMA' getting cut off (#21004) 2022-08-15 22:24:38 -06:00
Moriah Kreeger
83dd85166f
feat: add extension point for workspace home page (#21033)
* updates to allow insertion of workspace home sidescroll/table UI

* fix types

* fix User type import

* add welcome message to ui registry

* add extra fields to individual chart/query GET results (for workspace home required info)

* update list view card to support a subtitle

* add id to individual chart fetch

* update chart api test

* another test fix

* fix saved query test

* update extension types + insert point

* fix typing

* fix type name
2022-08-15 12:16:40 -07:00
Jack Fragassi
394d62ee51
Add embedded docs config details to extensions registry (#21052) 2022-08-12 16:33:21 -07:00
JUST.in DO IT
2d1ba46844
fix(plugin-chart-echarts): missing value format in mixed timeseries (#21044) 2022-08-11 12:33:59 -07:00
JUST.in DO IT
a8ba544e60
fix(plugin-chart-echarts): invalid total label location for negative values in stacked bar chart (#21032) 2022-08-11 11:28:18 -07:00
dependabot[bot]
42a5375e83
chore(deps): bump ejs from 2.7.4 to 3.1.8 in /superset-frontend (#21046)
Bumps [ejs](https://github.com/mde/ejs) from 2.7.4 to 3.1.8.
- [Release notes](https://github.com/mde/ejs/releases)
- [Changelog](https://github.com/mde/ejs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/mde/ejs/compare/v2.7.4...v3.1.8)

---
updated-dependencies:
- dependency-name: ejs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-11 09:49:36 -06:00
dependabot[bot]
778b6a3ba2
chore(deps): bump minimist from 1.2.5 to 1.2.6 in /superset-frontend (#21047)
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-11 09:48:31 -06:00
Eric Briscoe
ab6ec89f68
fix: [sc-54864] Adds safety check to provide near term fix to save query (#21034)
* [sc-54864] Adds safety check to provide near term fix for Queries not saving

There is an error when casting the columns array to String() for saving queries where the objects in the array are missing the toString method.   This is a near term rapid patch to fix workflow in production which will have a follow up to identify root cause.

* fix typo

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Adjusted chekc to be explicit for undefined instead of truthy

This fixes issue caught by unit test where the if statement was using a truthy check where it should be explicitly checking for value of undefined

* Adds new unit test to get 100% coverage for callApi

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-08-10 10:33:47 -07:00
Yongjie Zhao
dfe5a04938
fix: unable to show view as table modal (#21025) 2022-08-10 11:35:06 +08:00
Michael S. Molina
3df8335f87
feat: Adds drill to detail context menu for ECharts visualizations (#20891)
* feat: Adds drill to detail context menu for ECharts visualizations

* Rebases and adds time grain

* Fixes selected gauge values

* Fixes Treemap edge click

* Adds right click to big number trendline

* Address some comments
2022-08-09 17:02:31 -03:00
Evan Rusackas
0042ade66f
fix: making crossFilter.chartsInScope optional (#21030) 2022-08-09 12:21:40 -06:00
Michael S. Molina
6650076228
fix: forwardRef warnings in selects (#20970) 2022-08-09 09:00:12 -03:00
JUST.in DO IT
9114175db2
fix(plugin-echart-timeseries: legend trancated on show extra controls (#21017) 2022-08-09 16:12:00 +08:00
Geido
03764e6ae8
chore: Audit E2E tests for color schemes in Dashboard and Explore (#20807)
* Update properties tests

* Update selectors

* Verify charts changing colors

* Test shared and label colors

* Update dashboard edit test

* Enhance viz tests

* Remove chart ids

* Update color
2022-08-09 07:49:46 +03:00
Jesse Yang
58245dd7f7
fix(sqllab): result set min-height (#21016) 2022-08-08 20:52:52 -07:00
AAfghahi
846529a500
easy fix (#20999) 2022-08-08 12:31:08 -04:00
Phillip Kelley-Dotson
e214e1ace6
chore: update text for dbconn modal (#20773)
* chore: update text for dbconn modal

* fix text and close opts for adddataset modal

* update loading state, add state change for cta btns, and styling

* remove space
2022-08-05 15:01:04 -07:00
Elizabeth Thompson
463406ff09
fix: save dataset and repopulate state (#20965)
* save dataset and repopulate state

* disable dashboard button if dataset is missing

* fix error message

* fix tests
2022-08-05 14:32:49 -07:00
AAfghahi
f89ba0c7c1
beginning the reducer (#20945) 2022-08-05 11:53:55 -04:00
Kamil Gabryjelski
9350bbafee
fix(explore): Replace url search params only if current page is Explore (#20972)
* fix(explore): Replace url search params only if current page is Explore

* Add unit test
2022-08-05 16:59:52 +02:00
Sam Faber-Manning
226712d831
feat: add 'dashboard.nav.right' extension to registry (#20835)
* add 'dashboard.nav.right' extension to registry

* add test
2022-08-04 15:24:34 -07:00
Lyndsi Kay Williams
d42cf4e4c9
fix: Columns not passing properly from SQL Lab to Explore (#20975)
* debugging columns

* Clean up code

* Fix test
2022-08-04 14:59:50 -04:00
Phillip Kelley-Dotson
fa416fa130
fix: remove extra line for link (#20959)
* fix: remove extra line for link

* add space
2022-08-04 13:29:07 -04:00
AAfghahi
eb5369f2a6
fix: No back button in save dataset modal (#20964)
* back button fix

* fixed test
2022-08-03 21:29:11 -04:00
Kamil Gabryjelski
e4fc5564ce
fix: Explore scrolled down when navigating from dashboard (#20962) 2022-08-03 21:55:52 +02:00
Antonio Rivero Martinez
aa53c10312
Big Number Viz: (#20946)
- When the value is zero we still render the percent change and suffix if present
2022-08-03 23:12:56 +08:00
EugeneTorap
96a63bcbfe
fix: Use SPA Dataset link in Chart and Dashboard (#20941)
* Use SPA Dataset link in Chart and Dashboard

* Validate datasourceUrl

* Show datasourceName when datasourceUrl is undefined
2022-08-03 09:09:33 +02:00
Jesse Yang
ac585821d8
fix(sqllab): tracking url and error alert padding (#20937) 2022-08-02 14:55:41 -07:00
Stephen Liu
7beda3bbdb
chore: change Sort-by and Sort-Descending controls for Bar Chart v2 (#20868) 2022-08-02 14:36:21 -06:00
Antonio Rivero Martinez
9362e27ce2
fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627)
* Time Series Chart:

-Apache echarts has this option as false by default for time axis, so we need to override it for our charts so it's uto determined and not fixed to hidden.
- Add AxisType enum so we stop comparing agains raw strings when checking xAxis type

* Time Series Chart:

- set the showMaxLabel option directly without using merge

* Time Series Chart:

 - Rename the property to showMaxLabel as it was originally
2022-08-02 14:35:41 -06:00
Antonio Rivero Martinez
e2206a7151
Annotations: (#20720)
- Fix scrollbar when removing annotations
2022-08-02 14:31:48 -06:00
Diego Medina
fe581a3640
fix: adjust timeseries grid right offset to match the rest (#20933) 2022-08-02 14:19:49 -06:00
Diego Medina
dd353ca86a
feat: Add resize drag handle to Dataset SQL fields (#20670)
* feat: Add resize drag handle to Dataset SQL fields

* PR comments
2022-08-02 14:13:14 -06:00
AAfghahi
460b213057
feat: Creating dataset/add route (#20869)
* beginning of routing

* elizabeth review

* changed folder layout

* Update superset-frontend/src/views/CRUD/data/dataset/DatasetPage/index.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Update superset-frontend/src/views/CRUD/data/dataset/DatasetPage/RightPanel/index.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-08-01 16:59:40 -04:00
Lyndsi Kay Williams
8a04536f9d
feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)
* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
2022-08-01 14:36:34 -05:00
Kamil Gabryjelski
6ec164e6a9
feat: Use SPA navigation from datasets list to Explore (#20890)
* feat: Use SPA navigation from datasets list to Explore

* fix lint

* Fix lint

* Fix type

* Make external links work without protocols

* add comment
2022-08-01 16:45:07 +02:00
Kamil Gabryjelski
90e2d82a38
fix(dashboard): Incorrect scopes of cross filters (#20927) 2022-08-01 13:39:42 +02:00
Hugh A. Miles II
67e3dc7c7b
hide modal after overwrite (#20924) 2022-07-29 19:18:11 -04:00
Eric Briscoe
1a8c28db3d
Fixes issue where type query datasource had incorrect time controls when datasource type was 'query' (#20923) 2022-07-29 18:14:03 -04:00
Hugh A. Miles II
0d8889dc9c
fix: Save dataset + chart when Chart source is Query (#20880)
* feat: save dataset savemodal

* fix lint

* add comments

* enable chart power query

* clean up

* added test

* fix overwrite

* add proper error messaging for save datasetModal

* lint

* fix ts lint

* fix

* Disables Save button while network call is in progress, removing second Chart saved toast message

* change naming

* err

* Update superset-frontend/src/explore/components/SaveModal.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Update SaveModal.tsx

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-07-29 17:30:28 -04:00
dependabot[bot]
adf1f5cccf
chore(deps): bump terser from 4.6.3 to 4.8.1 in /superset-frontend (#20787)
Bumps [terser](https://github.com/terser/terser) from 4.6.3 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-29 10:48:15 -06:00
Jesse Yang
5ae0e83b8a
fix(sqllab): hide tracking url when fetching (#20905) 2022-07-29 08:47:53 -07:00
Cody Leff
e7acb1a79d
chore(explore): update Explore icons and icon colors (#20612)
* Update Explore icons and icon colors.

* Change shade of blue and make blue only appear when fields have never been filled in.

* Fix Cypress test.

* Update non-error validation color from blue to yellow.

* Unpack ternary.

* Replace direct AntD imports with our Icons component.
2022-07-29 09:05:15 -06:00
Cody Leff
90460f1333
Unskip Cypress test. (#20915) 2022-07-29 11:38:04 -03:00
Just[in]Do it!
3f124d9d67
fix(plugin-chart-pivot-table): Invalid Formats Date Fields (#20909)
When a custom date field value converted in a string format, some aggregators truncated to the first four digits.
 This is caused by the parseFloat function which converts to first matched number rather than NaN(Not-A-Number) value.
 This commit replaces the parseFloat by Number wrapper to handle this case correctly.
2022-07-28 22:56:08 -07:00
Cody Leff
d50784dd80
feat(dashboard): Add thumbnails to dashboard edit draggable chart list (#20528)
* Add chart thumbnails to dashboard edit draggable charts.

* Reorganize hierarchy and add tests.

* Incorporate review suggestions.

* Update design and add tooltips.

* Fix missing thumbnails.

* Fix tests.

* Fix moving viz type label.

* Convert AddSliceCard to TS, update hierarchy.
2022-07-28 10:46:13 -06:00