Yongjie Zhao
387ac2b6d3
fix: replace absolute difference with difference in compareOperator ( #16930 )
...
* fix: replace absolute difference with difference in compareOperator
* fix ut
2021-10-04 13:31:19 +08:00
ofekisr
0d0c759cfe
refactor: sql lab command: separate concerns into different modules ( #16917 )
...
* chore move sql_execution_context to sqllab package
* add new helper methods into base Dao
* refactor separate get existing query concern from command
* refactor separate query access validation concern
* refactor separate get query's database concern from command
* refactor separate get query rendering concern from command
* refactor sqllab_execution_context
* refactor separate creating payload for view
* chore decouple command from superset app
* fix pylint issues
* fix failed tests
* fix pylint issues
* fix failed test
* fix failed black
* fix failed black
* fix failed test
2021-10-03 11:15:46 +03:00
apurva-sigmoid
420eff42b8
feat: add Firebolt DB engine spec ( #16903 )
...
* New branch from superset for integration with firebolt sqlalchemy adapter
* Added db_engine_spec file for Firebolt
* Removed firebolt code from superset repo
* Deleted virtual env commit
* Adding time grain changes to firebolt.py
* Updated README.md
Added steps to install and run Superset with Firebolt SQLAlchemy Adapter
* Update README.md
Reduced installation steps. Using PyPi installation for adapter now
* Revert "Update README.md"
This reverts commit 5ed17c7a45
.
* Revert "Updated README.md"
This reverts commit 45c5072649
.
* added epoch methods, added test cases for firebolt db engine spec and edited setup.py
* Added license to files
* Added documentation for Firebolt-SQLAlchemy
* Removed trailing whitespace
Co-authored-by: raghavsharma <raghavs@sigmoidanalytics.com>
Co-authored-by: raghavSharmaSigmoid <88667094+raghavSharmaSigmoid@users.noreply.github.com>
2021-10-01 19:43:15 +03:00
Yongjie Zhao
94282b7ecd
fix: time comparison can't guarantee the accuracy ( #16895 )
...
* fix: time comparison can't guarantee the accuracy
* fix multiple series
* fix lint
* fix ut
* fix lint
* more ut
* fix typo
2021-09-30 19:59:57 +08:00
AAfghahi
aa747219ad
feat: Add Private Google Sheets to dynamic form ( #16628 )
...
* first pass private gsheets
* made encrypted extra into string, refactored onParametersChanged
* private sheets working, credential_info errors
* all but test connection working
* first pass private gsheets
* made encrypted extra into string, refactored onParametersChanged
* private sheets working, credential_info errors
* all but test connection working
* Regenerate package-lock.json
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-28 17:08:50 -07:00
Ville Brofeldt
0f16177bde
fix(native-filters): ignore unset filter box time range ( #16854 )
2021-09-27 17:17:52 +03:00
ofekisr
c520eb79b0
refactor: sqllab: move sqllab ralated enumns and utils to more logical place ( #16843 )
...
* refactor move QueryStatus to common
* refactor move apply_display_max_row_limit to sqllab package
* refactor move limiting_factor to sqllab package
* fix pylint issues
2021-09-26 21:15:57 +03:00
ofekisr
84f7614e97
feat(filter-set): Add filterset resource ( #14015 )
...
* Add filterset resource
* fix: fix pre-commit
* add tests
* add tests and fixes based of failures
* Fix pre-commit errors
* chore init filterset resource under ff constraint
* Fix migration conflicts
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* add tests and fixes based of failures
* Fix missing license
* fix down revision
* update down_revision
* fix: update down_revision
* chore: add description to migration
* fix: type
* refactor: is_user_admin
* fix: use get_public_role
* fix: move import to the relevant location
* chore: add openSpec api schema
* chore: cover all openspec API
* fix: pre-commit and lint
* fix: put and post schemas
* fix: undo superset_test_config.py
* fix: limit filterSetsApi to include_route_methods = {"get_list", "put", "post", "delete"}
* renaming some params
* chore: add debug in test config
* fix: rename database to different name
* fix: try to make conftest.py harmless
* fix: pre-commit
* fix: new down_revision ref
* fix: bad ref
* fix: bad ref 2
* fix: bad ref 3
* fix: add api in initiatior
* fix: open spec
* fix: convert name to str to include int usecases
* fix: pylint
* fix: pylint
* Update superset/common/request_contexed_based.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* chore: resolve PR comments
* chore: resolve PR comments
* chore: resolve PR comments
* fix failed tests
* fix pylint
* Update conftest.py
* chore remove BaseCommand to remove abstraction
* chore remove BaseCommand to remove abstraction
* chore remove BaseCommand to remove abstraction
* chore remove BaseCommand to remove abstraction
* chore fix migration
Co-authored-by: Ofeknielsen <ofek.israel@nieslen.com>
Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-09-23 11:27:59 +03:00
Phillip Kelley-Dotson
a198dbb19b
feat: add certifiedby & certification details fields to the edit dataset columns fields ( #16454 )
...
* add migration
* add backend and frontend for certified
* update migration with batch
* fix integration test and update Updating.md
* Update superset-frontend/src/datasource/DatasourceEditor.jsx
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
* Update superset-frontend/src/datasource/DatasourceEditor.jsx
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
* Update superset-frontend/src/datasource/DatasourceEditor.jsx
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
* change method name
* add tooltip info
* add mixin
* merge heads
* address comments
* fix select label styles
* add extra field
* fix test?
* add extra field to put schema
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2021-09-22 15:09:30 -07:00
Michael S. Molina
596e1cdf9b
refactor: Changes the DatabaseSelector and TableSelector to use the new Select component ( #16483 )
2021-09-22 07:43:46 -03:00
Beto Dealmeida
48a61bacc5
fix: handle CTEs with comments on is_select ( #16769 )
2021-09-21 16:23:54 -07:00
Elizabeth Thompson
2a25e2d7ca
update execution logs and states for alerts ( #16736 )
2021-09-20 14:26:30 -07:00
Yongjie Zhao
cc1c6c1bb6
feat: add resample operator in post processing ( #16607 )
...
* feat: add resample operator in post processing
* wip
* fill zero values
* updates
* fix ut
2021-09-17 16:40:59 +08:00
Ville Brofeldt
4e3d4f6daf
feat: add global max row limit ( #16683 )
...
* feat: add global max limit
* fix lint and tests
* leave SAMPLES_ROW_LIMIT unchanged
* fix sample rowcount test
* replace max global limit with existing sql max row limit
* fix test
* make max_limit optional in util
* improve comments
2021-09-16 19:33:41 +03:00
Ville Brofeldt
a839649e5c
fix(pandas-postprocessing): percentage compare to use correct column ( #16716 )
2021-09-16 13:29:58 +03:00
Ville Brofeldt
836b5e2c86
feat: add support for generic series limit ( #16660 )
...
* feat: add support for generic series limit
* refine series_columns logic
* update docs
* bump superset-ui
* add note to UPDATING.md
* remove default value for timeseries_limit
2021-09-16 12:09:08 +03:00
Yongjie Zhao
21f98ddc21
fix: catch exception when create connection ( #16692 )
...
* fix: catch exception when create connection
* fix lint
* added UT
2021-09-16 15:55:57 +08:00
Beto Dealmeida
092ef5bdfc
fix: set importer as owner ( #16656 )
...
* fix: set importer as owner
* Fix tests
2021-09-15 12:27:02 -07:00
Ville Brofeldt
88c09c2138
feat(jinja): improve url parameter formatting ( #16711 )
...
* feat(jinja): improve url parameter formatting
* add UPDATING.md
* fix test
2021-09-15 20:00:26 +03:00
John Bodley
fb4650a6eb
chore(pylint): Remove top-level disable ( #16589 )
...
* chore(pylint): Remove top-level disable
* Update examples.py
* Update command.py
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-09-15 09:30:23 -07:00
aniaan
9e00e4e8cc
fix(dataset): create ES-View dataset raise exception #16623 ( #16624 )
...
* fix(dataset): create es-view dataset raise exception #16623
* fix(database): fix has_view logic
* refactor(database): fix logic
* style(lint): remove unused typing
* fix(test): add test case
* fix(test): fix test case
2021-09-14 22:29:29 +08:00
Daniel Vaz Gaspar
f2bc139e35
feat: feature flag configurable custom backend ( #16618 )
...
* feat: feature flag configurable custom backend
* fix lint
* simpler approach
* fix tests
* revert dependency updates
* Update superset/utils/feature_flag_manager.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Update superset/config.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-09-13 14:09:53 +01:00
Jack Fragassi
4dc859f89e
fix: Ensure alerts & reports aren't schduled when flag is off ( #16639 )
...
* Don't schedule alerts & reports when flag is off
* Fix test function name
* Fix test
* Oops
* Another tweak
* Try to lint by hand
* Fix mock
2021-09-10 13:37:21 +01:00
天河
bb014b5131
fix: fix assignment in FilterBoxViz ( #16662 )
...
* Fixing assignment.
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
* Adding unit test for FilterBoxViz.
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
* Reformatting with black.
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
* Revert format change in other test.
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
* Reformatting with the same black version with pre-commit config.
Signed-off-by: tianhe1986 <w1s2j3229@163.com>
2021-09-10 15:10:55 +03:00
AAfghahi
c66f278b42
feat: Backend Validation for Creation Method ( #16375 )
...
* backend creation method validation
* added tests
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update tests/integration_tests/reports/api_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update tests/integration_tests/reports/api_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/commands/create.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/commands/exceptions.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* revisions
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-08 16:35:18 -07:00
Ville Brofeldt
9de2196b7f
fix: TemporalWrapperType string representation ( #16614 )
...
* fix: TemporalWrapperType string representation
* fix tests
2021-09-07 13:50:24 +03:00
ofekisr
e60b489867
refactor sql_json view endpoint: separate concern into ad hod method ( #16595 )
2021-09-05 23:18:17 +03:00
ofekisr
be77ad2288
refactor: sql_json view endpoint: encapsulate ctas parameters ( #16548 )
...
* refactor sql_json view endpoint: encapsulate ctas parameters
* fix failed tests
* fix failed tests and ci issues
2021-09-05 16:34:26 +03:00
Rob DiCiuccio
4e380db3fd
fix: Support Jinja template functions in global async queries ( #16412 )
...
* Support Jinja template functions in async queries
* Pylint
* Add tests for async tasks
* Remove redundant has_request_context check
2021-09-03 14:33:29 +03:00
Ville Brofeldt
070fdbeebc
fix(tests): make parquet select deterministic with order by ( #16570 )
2021-09-02 15:16:33 -03:00
Shiva Raisinghani
d25b0967a1
feat: Add parquet upload ( #14449 )
...
* allow csv upload to accept parquet file
* fix mypy
* fix if statement
* add test for specificying columns in CSV upload
* clean up test
* change order in test
* fix failures
* upload parquet to seperate table in test
* fix error message
* fix mypy again
* rename other extensions to columnar
* add new form for columnar upload
* add support for zip files
* undo csv form changes except usecols
* add more tests for zip
* isort & black
* pylint
* fix trailing space
* address more review comments
* pylint
* black
* resolve remaining issues
2021-08-31 10:20:25 +03:00
Erik Ritter
8adc31d14c
Revert "chore: Changes the DatabaseSelector to use the new Select component ( #16334 )" ( #16478 )
...
This reverts commit c768941f2f
.
2021-08-26 22:28:04 -03:00
Ville Brofeldt
35864748f2
fix(explore): retain chart ownership on query context update ( #16419 )
2021-08-24 18:37:34 +03:00
Ville Brofeldt
f6637cac7d
fix(api): return total count on related endpoint ( #16397 )
...
* fix(api): return total count on related endpoint
* update response code from 400 to 422
2021-08-24 15:07:58 +03:00
Michael S. Molina
c768941f2f
chore: Changes the DatabaseSelector to use the new Select component ( #16334 )
2021-08-23 15:41:03 -03:00
Beto Dealmeida
adebc0997b
fix: update table ID in query context on chart import ( #16374 )
...
* fix: update table ID in query context on chart import
* Fix test
2021-08-20 10:03:31 -07:00
Hugh A. Miles II
50d896f1b7
fix: Fix parsing onSaving reports toast when user hasn't saved chart ( #16330 )
...
* don't maniuplate error message
* remove extra idx reference
* u
* change print
* update with test
* add case for dashboards
* fix test
2021-08-19 14:04:23 -04:00
Beto Dealmeida
afb8bd5fe6
feat: improve embedded data table in text reports ( #16335 )
...
* feat: improve HTML table in text reports
* Remove unused import
* Update tests
* Fix test
2021-08-18 17:00:29 -07:00
Beto Dealmeida
ac8e54d909
fix: improve pivot post-processing ( #16289 )
...
* fix: improve pivot post-processing
* Add tests
* Trim space from column name
2021-08-17 14:41:22 -07:00
Ville Brofeldt
36abc51f90
fix(dashboard): unset empty time filter indicator ( #16272 )
2021-08-16 19:32:05 +03:00
Ville Brofeldt
d46dc9aa45
chore: upgrade mypy and add type guards ( #16227 )
2021-08-14 06:31:45 +03:00
John Bodley
24b43beff9
chore(pylint): Bump Pylint to 2.9.6 ( #16146 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-08-14 10:32:28 +12:00
Michael S. Molina
720e5b111a
chore: Shows the dataset description in the gallery dropdown ( #16200 )
...
* chore: Shows the dataset description in the gallery dropdown
* chore: Adjusts the tooltip positioning, fixes the search and removes unnecessary bootstrap data
2021-08-13 15:08:12 -03:00
Yongjie Zhao
6cd15d54a0
refactor: external metadata fetch API ( #16193 )
...
* refactor: external metadata api
* fix comments
* fix ut
* fix fe lint
* fix UT
* fix UT
2021-08-13 20:56:42 +08:00
Ville Brofeldt
d6f9c48aa1
feat(dao): admin can remove self from object owners ( #15149 )
2021-08-13 12:42:48 +03:00
Ville Brofeldt
b61c34f7c9
fix(viz): deduce metric name if empty ( #16194 )
...
* fix(viz): deduce metric name if empty
* fix unit test
2021-08-12 11:16:05 +03:00
Beto Dealmeida
7b3fce7e81
fix: revert data endpoint name ( #16162 )
2021-08-10 11:59:27 -07:00
Hugh A. Miles II
fd80ae34a3
fix: Make sheet_name into a ValidationInputError
( #16056 )
...
* setup validates for name
* add error type
* fix linting
* fix test
* remove errors
* fix number
* fix test
2021-08-10 13:07:31 -04:00
Phillip Kelley-Dotson
f0e3b68cc2
fix: ensure that users viewing chart does not automatically save edit data ( #16077 )
...
* add last_change_at migration
* add last_saved_by db migration
* finish rest of api migration
* run precommit
* fix name
* run precommitt
* remove unused mods
* merge migrations
* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/migrations/versions/f6196627326f_update_chart_permissions.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* fix test
* precommit
* remove print
* fix test
* change test
* test commit
* test 2
* test 3
* third time the charm
* fix put req
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 10:29:49 -06:00
Ville Brofeldt
63ace7b288
feat(cross-filters): add support for temporal filters ( #16139 )
...
* feat(cross-filters): add support for temporal filters
* fix test
* make filter optional
* remove mocks
* fix more tests
* remove unnecessary optionality
* fix even more tests
* bump superset-ui
* add isExtra to schema
* address comments
* fix presto test
2021-08-10 17:18:46 +01:00