Commit Graph

7324 Commits

Author SHA1 Message Date
Jesse Yang 4789074309
fix(sqla-query): order by aggregations in Presto and Hive (#13739) 2021-04-01 18:10:17 -07:00
Lily Kuang 762101018b
feat(alert/report): add ALERTS_ATTACH_REPORTS feature flags + feature (#13894)
* Add a feature flag ALERTS_ATTACH_REPORTS

* update test

* update feature flag

* add comment for feature flag

* add unit tests for alerts with attachments disabled

* fix lint

Co-authored-by: samtfm <sam@preset.io>
2021-04-01 13:06:45 -07:00
Michael S. Molina a1442497d4
test: Fixes PropertiesModal_spec (#13548) 2021-04-01 11:42:14 -07:00
Étienne Boisseau-Sierra 73a2cc322a
fix: Pin Prophet dependency after breaking changes (#13852)
Prophet is heavily dependent on Pystan:
https://facebook.github.io/prophet/docs/installation.html

Pystan has recently (2021-03-25) release its v3.0.0.

This release is not backward compatible and breaks fbprophet:
https://github.com/facebook/prophet/issues/1856

(Indeed, fbprophet 0.6 specifies `pystan>=2.14` — but doesn't restrict
upgrading to next major release:
https://github.com/facebook/prophet/blob/0.6/python/requirements.txt#L3)

So we need to pin pystan to the lastest non 3.x release, while fbprophet
fixes the dependency on their side.

We have taken this opportunity to bump fbprophet too to its next minor
version.

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>
2021-04-02 00:42:29 +08:00
Michael S. Molina 42c7e2cae6
test: Adds tests to dnd controls (#13650) 2021-04-01 09:11:33 -07:00
Michael S. Molina bb677b8ef1
test: Adds tests to the AnnotationLayer component (#13748) 2021-04-01 09:10:42 -07:00
Geido 9156f089ff
test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799)
* Refactor and enhance tests

* Fix linting issues
2021-03-31 23:14:51 -07:00
Geido a5c4db3aee
Add tests (#13778) 2021-03-31 23:08:56 -07:00
Bruno Motta 1dbc1496b2
test: DisplayQueryButton (#13750)
* Tests for DisplayQueryButton component

* add factories to props and fetch-mock

* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 23:08:20 -07:00
Evan Rusackas a7f48c6599
Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905) 2021-03-31 21:32:46 -07:00
Erik Ritter 5315d2cc2d
Revert "fix: select table overlay (#13694)" (#13901)
This reverts commit b247279ffe.
2021-03-31 18:47:38 -07:00
Michael S. Molina 6fd62e3f7e
test: Adds tests to the OptionControls component (#13729) 2021-03-31 18:07:22 -07:00
Bruno Motta ec5d2f5f32
test: DatasourceControl (#13605)
* Tests for DatasourceControl

* fix: lint error

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove error comment

* replace component data-test

* factory to props

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 17:52:45 -07:00
Bruno Motta 9fd297f636
tests for function handleScroll (#13896) 2021-03-31 17:49:43 -07:00
Michael S. Molina 28fe6e0ef1
test: Adds tests to the CustomFrame component (#13675)
* test: Adds tests to the CustomFrame component

* Replaces full path with relative path
2021-03-31 15:53:07 -07:00
Michael S. Molina 7ae80e9d66
test: Adds tests to the AdvancedFrame component (#13664)
* test: Adds tests to AdvancedFrame component

* Replaces full path with relative path
2021-03-31 15:52:03 -07:00
Bruno Motta 1252fd700e
test: DataTableControl (#13668)
* Tests for DataTableControl

* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 15:45:30 -07:00
Michael S. Molina 8ddcba82e0
chore: Removes Select duplication (#13477) 2021-03-31 15:42:14 -07:00
Beto Dealmeida 11dd2493b3
feat: create table with long name (#13871) 2021-03-31 11:28:34 -07:00
Ben Reinhart ca506e9396
fix(#13378): Ensure g.user is set for impersonation (#13878) 2021-03-31 11:22:56 -07:00
cccs-jc 507041e93b
docs: Documenting how to debug Flask app (#13813)
Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>
2021-03-31 12:12:11 -06:00
Erik Ritter ceb88926ff
fix: Check for permissions in FilterBox (#13859) 2021-03-31 10:34:48 -07:00
Hugh A. Miles II d54cc6d82a
fix: change status code for generic errors to 400 (#13868)
* change status code for generic errors to 422

* Update exceptions.py
2021-03-31 16:19:15 +08:00
Michael S. Molina 9d6832dc27
test: Adds tests and storybook to CertifiedIcon component (#13457) 2021-03-30 14:31:35 -07:00
Michael S. Molina 3c4591ef15
chore: Moves CheckboxIcons to Checkbox folder (#13459) 2021-03-30 13:55:10 -07:00
Michael S. Molina 6fe4cc0c51
chore: Removes Popover duplication (#13462) 2021-03-30 13:54:53 -07:00
dependabot[bot] 9031e69dc2
build(deps): bump elliptic from 6.5.3 to 6.5.4 in /docs (#13527)
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-03-30 14:18:22 -06:00
Beto Dealmeida ce2760edf7
fix: allow spaces in DB names (#13800) 2021-03-30 10:12:10 -07:00
Rob DiCiuccio f81b746556
chore: Update PR template for SIP-59 DB migrations process (#13855) 2021-03-30 08:54:26 -07:00
Rob DiCiuccio 2a4e4b320c
Add CODEOWNERS (#13759) 2021-03-30 08:54:08 -07:00
Jack Fragassi 304e3b36eb
feat(alerts & reports): Easier to read execution logs (#13752)
* Prep for migration

* Migration for execution id column

* Generate execution ids for alerts and reports

* Change execution id range

* Add execution id to API endpoint

* Add execution id to execution log view

* Change execution id range

* Change execution id to a uuid

* Fix execution id type

* Switch state and exec. id columns

* Change db column to UUIDType

* Python lint

* Fix failing frontend tests

* execution_id -> uuid

* Fix migration head

* lint

* Use celery task id as the execution id

* lint

* lint for real

* Fix tests
2021-03-30 08:46:16 -07:00
Michael S. Molina 4ae9b819d3
fix: Disallows negative options remaining (#13749) 2021-03-30 08:34:12 -07:00
Eric Anderson 9d0bb3a3ba
Fix broken link (#13861)
Currently link goes to: https://superset.apache.org/docs/docs/installation/installing-superset-using-docker-compose
It should go to: https://superset.apache.org/docs/installation/installing-superset-using-docker-compose
2021-03-29 23:11:04 -07:00
Ville Brofeldt 3394421fa8
fix(native-filters): add global async query support to native filters (#13837)
* fix(native-filters): improve loading styles for filter component

* round up fractional grid unit

* fix(native-filters): add support for global async queries

* move form item out of default value component

* move default value hook declaration to form

* delete LoadingBox
2021-03-30 07:50:52 +03:00
Michael S. Molina ac43f4c491
Displays row limit warning with Alert component (#13854) 2021-03-29 17:04:33 -07:00
Will Barrett 84560e8527
fix(errors): Downgrade error on stop query to a warning (#13826) 2021-03-29 13:51:57 -07:00
Jack Fragassi 33f7845010
fix(alerts and reports): Unify timestamp format on execution log view (#13718)
* Unify timestamp format on execution log view

* Fix lint
2021-03-29 13:30:19 -07:00
zuzana-vej 467848d8f7
fix(sqllab): warning message when rows limited (#13841) 2021-03-29 10:47:51 -07:00
Hugh A. Miles II 9f53c6c5bc
chore: add success log whenever a connection is working (#13811) 2021-03-29 13:22:09 -04:00
Ville Brofeldt 9fa52b50ed
fix(native-filters): improve loading styles for filter component (#13794)
* fix(native-filters): improve loading styles for filter component

* round up fractional grid unit

* remove LoadingBox
2021-03-29 10:23:01 +03:00
Lily Kuang 18ff484186
chore: update change log with cherry-picks for release 1.1 (#13824)
* add 1.1 cherries to change log

* one more cherry
2021-03-26 15:58:27 -07:00
cccs-jc 24f805ebc4
feat: added support to configure the default explorer viz (#13610)
* added support to configure the default explorer viz

* code review fix

* lint

Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-03-26 15:27:36 -07:00
Ben Reinhart 55ba47ec2e
fix(#13734): Properly escape special characters in CSV output (#13735)
* fix: Escape csv content during downloads

* Reuse CsvResponse object

* Use correct mimetype for csv responses

* Ensure that headers are also escaped

* Update escaping logic
2021-03-26 15:22:00 -07:00
Cemre Mengu 5842cb1b12
chore(git): ignore superset/app/ folder (#13767)
upload generate this folder in the form of /app/static/uploads
2021-03-26 15:14:14 -07:00
David Aaron Suddjian db1d598f50
fix(cypress): avoid referencing detached dom nodes (#13825) 2021-03-26 14:46:31 -07:00
David Aaron Suddjian a45a5e1060
chore(cypress): Make the e2e tests more behavior-driven (#13784)
* chore(cypress): make the load dashboard test behavior driven

* remove bootstrap usage from controls test, + new utils

* fix save test to not use bootstrap dat

* remove bootstrap usage from the filter test

* fix race condition

* remove bootstrap from url params test

* fix lint

* remove unused const

* add chart specs for the tab test

* attempt removing bootstrap data from tabs tests

* fix cypress async/sync confusion

* remove redundant assertions

* attempt fixing tab test

* attempt fixing tabs test

* cleanup commented code

* better aliases so you can tell what they are in the logs

* remove unused imports

* get the line chart alias before clicking the tab

* simplify getChartGridComponent

* wait for all the charts before force refresh

* fix tabs test

* one more time with the tabs test

* another edit to tabs test

* fix flaky test

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
2021-03-26 09:20:13 -07:00
Ville Brofeldt 5ae91e2dd8
feat(rls): enable row level security by default (#13772) 2021-03-26 17:40:41 +02:00
Andreas Eberle 3cfeb43878
Add extraSecrets config to allow specifying extra secret files (#13728) 2021-03-26 08:04:21 -07:00
AAfghahi b247279ffe
fix: select table overlay (#13694) 2021-03-26 10:39:39 -04:00
AAfghahi 64f967cb2d
refactor: New schedule query button (#13797) 2021-03-26 09:56:59 -04:00