Commit Graph

1369 Commits

Author SHA1 Message Date
Amit Miran
8c5b6b1263
feat(dashboard_rbac): provide data access based on dashboard access (#13992)
* feat: provide data access based onb dashboard access

* chore: adjust code after CR comments

* fix: add brackets

* fix: type

* chore: add tests

* fix: pre-commit

* fix: pre-commit and lint

* fix: fix test

* fix: pre-commit

* fix: fix local pylint warnings

* revert: birth_names pylint  change bc it  affects tests

* Update superset/security/manager.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset/security/manager.py

* Update tests/utils_tests.py

* fix: after CR

* fix: after CR from ville

* chore: update roles description

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-04-13 16:23:31 +03:00
Amit Miran
9c5264af0d
feat(can_share): can share chart and dashboard (#14076)
* feat: share chart  - can_share_chart
share dashboard can_share_dashboard

* fix: pre-commit

* fix: userCanShare tests

* fix: after hugh CR

* fix: adjust after spa refactor
2021-04-13 13:54:14 +03:00
Michael S. Molina
b394733ff3
test: Adds tests to the UndoRedoKeyListeners component (#13919) 2021-04-12 23:51:57 -07:00
Michael S. Molina
55257ab48c
chore: Adds dataMask reducer to reducerIndex (#13951) 2021-04-12 23:50:20 -07:00
Geido
11869dc076
test: Tests audit for the Dashboard FilterBar (#13916)
* Add FilterBar tests

* Finalize FilterBar tests

* Add tests for FilterBar Header

* Add tests for FilterBar FilterConfigurationLink

* Add tests for FilterBar FilterSets EditSection

* Add tests for FilterBar FilterSets

* Clean up

* Add tests for FilterBar FilterSetUnit

* Add tests for FilterBar FilterSets FiltersHeader

* Add tests for FilterBar FilterSets Footer

* Fix linting

* Fix import

* Fix minor changes

* Fix import

* Add factory and clean up
2021-04-12 23:28:19 -07:00
Michael S. Molina
92a66921e0
refactor: Bootstrap to AntD - Slider (#13989) 2021-04-12 16:28:06 -07:00
Phillip Kelley-Dotson
4bb29b6f04
chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306)
* add hook for future async api calls

* test to see conflict

* add async middleware and update reducers

* working async dashboard load

* implement getcharts api

* add user permissions to explore and dashboard bootstrap data

* integrate api calls with getinitial state

* update namings

* accept an id or a slug in the dashboard charts api

* add permissions function

* fix merge

* update state

* get dashboard charts by id or slug

* fix undefined states

* variable names

* stop using some more bootstrap data

* fix metadata reference

* remove unused bootstrap from the template

* add errorboundry to dashboard

* refactoring, fixing

* update permissions

* add just roles

* id is supposed to be a string

* unused vars

* get datasources from api

* make onError optional

* use resource hooks, better error boundary

* add loading state for dashboardroute

* remove console

* add conditional

* more conditionals

* testing out a possible fix for cypress

* convert edit/standalone test to cypress

* remove bootstrappy assertions

* lint

* fix dashboard edit history issue

* rename stuff

* address recent native filters schema change

* remove unused getInitialState

* remove .only from test

* hooksy redux usage

* Revert "more conditionals"

This reverts commit 25c8ed61b4.

* cleanup

* undo unnecessary change

* actually need conditions here

* certainty

* Revert "certainty"

This reverts commit 77dea1915b.

* more permutations (untested yolo)

* Update superset-frontend/src/chart/chartReducer.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* import style

* comment

* cleaner dashboardInfo

* remove debug code

* use memo for getPermissions

* fix lint

* adjust name/location of DashboardPage

* move logic for REMOVE_SLICE_LEVEL_LABEL_COLORS to DAO

* stop using full_data()

* remove unused (and now useless) json=true query param

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2021-04-12 16:10:29 -07:00
Beto Dealmeida
786dadc836
feat: invalid password error message (Postgres) (#14038) 2021-04-12 14:03:21 -07:00
Kamil Gabryjelski
bf22487e23
Make chart exclude itself from cross filtering (#14046) 2021-04-12 14:08:07 +03:00
simcha90
d6bd160250
fix: fix bug when remove chart not removing it's related cross filter data (#14081) 2021-04-12 10:54:31 +03:00
simcha90
468638c5b8
feat(native-filters): Add default first value to select filter (#13726)
* feat: native filters first default value

* fix: fix CR notes

* feat: add support for `Place` type

* refactor: sync with master

* feat: add first value to Select filters

* refactor: fix CR notes

* refactor: updates usage of `ownFilters` to `ownState`

* Revert "refactor: updates usage of `ownFilters` to `ownState`"

This reverts commit 58b91998

* fix: revert mocks

* fix: fix CR notes

* chore: update package json

* chore: update package json

* chore: update package json

* test: fix tests

* fix: fix BE empty metrics

* lint: fix lint

* fix: fix BE empty metrics

* refactor: fix Cr notes
2021-04-12 09:22:33 +03:00
Bruno Motta
66201e7c55
test: FilterSets-utils (#14028)
* Tests for "nativeFilters/FilterBar/FilterSets/utils"

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/generateFiltersSetId.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Fix: Lint error

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:07:37 -07:00
Bruno Motta
95ed8735f1
chore: well component to card component(Updating PR #12200) (#14033)
* replace Well componenet with Card component

* Fix lint errors

* Fix lint

* Addressing comments

* Addressing comments

* Fix lint errors

* Exporting Card from index.tsx and adding storybook variants

* Fix some refactoring

* Fix errors

* solving conflicts and lint errors

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:06:44 -07:00
Ville Brofeldt
bfa6140b15
fix(viz): bump superset-ui 0.17.30 (#14045)
* fix(viz): bump superset-ui 0.17.30

* fix test

* bump react-table to match the version in superset-ui
2021-04-09 20:49:38 +03:00
Bruno Motta
ff08d423a9
Tests for ControlItems (#13975) 2021-04-09 09:54:35 -07:00
Bruno Motta
1920811cf2
test: Tabs (#13941)
* Test for Tabs component

* Fix: "creteProps" to "createProps"

* Update superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:54:16 -07:00
Bruno Motta
011af825a9
test: Tab (#13937)
* Tests for Tab component

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:53:54 -07:00
Bruno Motta
ec3f8d07f4
test: SliceHeader (#13888)
* tests for SliceHeader

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:14:16 -07:00
Bruno Motta
36f101e500
test: ShareMenuItems (#13860)
* Tests for ShareMenuItems

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:13:05 -07:00
Bruno Motta
c0017b3262
Tests for ColumnSelect (#13991) 2021-04-09 09:02:39 -07:00
Beto Dealmeida
c60a93db9c
feat: add extract_errors to Postgres (#13997)
* feat: add extract_errors to Postgres

* Add unit tests

* Fix lint

* Fix unit tests
2021-04-08 13:24:54 -07:00
Michael S. Molina
784d29b57c
chore: Moves Fade component into TableElement (#13458) 2021-04-08 12:56:21 -07:00
Jack Fragassi
5dd971eaf5
fix: execution log crashes for logs with no uuid (#13998)
* Fix execution log when no execution id

* Use single quotes

* Pretty
2021-04-08 06:50:23 -07:00
Lyndsi Kay Williams
7697bc297c
feat: FE: Export for Queries II (#13981)
* package.lock upgrade

* Copied changes from old PR

* Cleaned up ternaries

* Added export check for VERSIONED_EXPORT feature flag
2021-04-08 09:22:15 -04:00
Michael S. Molina
b5c95c537c
test: Adds tests to the CssEditor component (#13933) 2021-04-07 14:40:24 -07:00
Geido
6c06866583
test: Tests and Storybook entry for the IndeterminateCheckbox Component (#13502)
* Add tests for IndeterminateCheckbox

* Add storybook entry

* Fix linting issue

* Remove mocked icon

* Add jest.fn to mockedProps
2021-04-07 13:34:19 -07:00
Bruno Motta
dcb9f7cff1
test: DataTablesPane (#13736)
* Tests for DataTablesPane

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Using factory for props

* replacing "data-test"

* removing "act" from tests and fix error

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-07 11:35:27 -07:00
Bruno Motta
284402c583
test: AdhocMetricEditPopover (#13787)
* tests for AdhocMetricEditPopover

* replace "factoryProps" for "createProps"

* removing unnecessary if

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-04-07 10:34:29 -07:00
Geido
cc075f23ef
test: Tests and Storybook entry for the TableView Component (#13501)
* Refactor TableView tests

* Add more tests

* Add storybook entry

* Remove unnecessary control
2021-04-07 10:33:55 -07:00
Yongjie Zhao
f06d53455c
fix: annotation modal dateRangePicker saved invalid value (#13969) 2021-04-07 22:02:29 +08:00
Yongjie Zhao
e3efaba775
test: prevent flaky frontend unit test case (#13984)
* test: prevent flaky unit test case

* Update superset-frontend/spec/javascripts/datasource/ChangeDatasourceModal_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-07 20:08:04 +08:00
Yongjie Zhao
56dc74e09f
fix: Pie chart not displayed in viz (#13987) 2021-04-07 17:08:24 +08:00
Beto Dealmeida
a82d72fef6
feat: initial work to make v1 API compatible with SIP-40 and SIP-41 (#13960)
* WIP

* Use errorhandler

* Add response schema

* Fix status on HTTPException

* s/found/encountered/g

* Fix test

* Fix lint

* Fix lint and test
2021-04-06 22:06:32 -07:00
Bruno Motta
1638e6e932
test: exploreUtils (#13719)
* Tests for exploreUtils

* removing eslint-disable

* applying factory

* Removing skip tests and code comments.

* Improving test name

* remove comments

* Improving "shouldUseLegacyApi" tests

* fixing typo
2021-04-06 21:35:34 -07:00
Michael S. Molina
4602ead10c
test: Adds tests to the filter scope components (#13887) 2021-04-06 21:31:35 -07:00
Bruno Motta
ab0f5e3087
test: PropertiesModal (Dashboard) (#13931)
* Tests for PropertiesModal (Dashboard)

* fix: fetchMock
2021-04-06 14:00:35 -07:00
Geido
c0888dc16d
Add tests for FilterBar CascadeFilterControl (#13950) 2021-04-06 11:15:17 -07:00
AAfghahi
7fb138381f
fix: Data table z index in sql Editor (#13972) 2021-04-06 12:42:48 -04:00
Grace Guo
4b29789b64
fix: null exception from adhoc metric popover (#13955) 2021-04-06 13:36:59 +08:00
Jesse Yang
b9e601487a
chore: bump @superset-ui/plugin-chart-table to 0.17.28 (#13953)
* chore: bump @superset-ui/plugin-chart-table to 0.17.28

* Bump chrono-node
2021-04-06 09:55:35 +08:00
AAfghahi
f19f2c3ac8
fix: Floating Menu in SQL Left Bar (#13858)
* floating table git issue

* made changes

* floating table git issue

* made changes

* long table names

* floating table git issue

* made changes

* floating table git issue

* made changes

* long table names

* floating table git issue

* made changes

* floating table git issue

* made changes

* long table names

* table values

* aligned

* active key

* changed to customStyle

* update dropdown styles

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-04-05 15:54:28 -07:00
Hugh A. Miles II
d006178c03
refactor: move CTAS/CVAS field II (#13877)
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
2021-04-05 16:57:40 -04:00
Bruno Motta
d489d0018c
test: SliceHeaderControls (#13895)
* tests for SliceHeaderControls

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* fix lint error

* Improving accessibility

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-05 13:34:06 -07:00
Geido
fa1e028974
Add dedicated dir and storybook (#13553) 2021-04-05 13:11:50 -07:00
Bruno Motta
592c566bb4
test: PropertiesModal (#13818)
* Tests for test-PropertiesModal

* finish fetchMock to solve conflicts

* clean fetchMock
2021-04-05 11:24:10 -07:00
Bruno Motta
203512e189
test: CrossFilterScopingForm (#13875)
* tests for CrossFilterScopingForm

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-05 11:16:04 -07:00
Bruno Motta
12982ef387
tests for FilterIndicator (#13873) 2021-04-05 11:14:30 -07:00
Bruno Motta
f2d65989ab
Tests for DetailsPanel (#13872) 2021-04-05 11:13:15 -07:00
Geido
9a4de232a7
test: Enhance tests and directory structure for FilterControl components (#13745)
* Enhance directory structure

* Enhance paths

* Move AdhocFilter

* Add AdhocFilterPopoverTrigger tests

* Move import

* Enhance AdhocFilterOption tests

* Linting

* Fix linting

* Update superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterOption/AdhocFilterOption.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterOption/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Enhance

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-05 11:05:35 -07:00
Michael S. Molina
61129f749f
test: Adds tests to the TimeSeriesColumnControl component (#13712) 2021-04-05 11:04:58 -07:00
Bruno Motta
7e394e556a
test: FilterBoxItemControl (#13753)
* Tests for FilterBoxItemControl

* factory for props

* fix lint
2021-04-05 11:00:20 -07:00
Bruno Motta
555d7bbb35
test: CollectionControl (#13656)
* Tests for CollectionControl

* add role to icon

* applying factory to props
2021-04-05 10:52:24 -07:00
Michael S. Molina
35f33e8276
test: Adds storybook to Dropdown and DropdownButton components (#13482) 2021-04-05 10:48:59 -07:00
simcha90
e06290663a
fix(colors): fix color schemes (#13945)
* fix: fix color schemes

* fix: tests case
2021-04-04 15:53:21 +03:00
Elizabeth Thompson
abd4051f7a
catch collapse onchange (#13927) 2021-04-03 00:00:34 -07:00
Bruno Motta
e829aa52eb
Tests for "CrossFilterScopingModal/utils" (#13876) 2021-04-02 17:06:42 -07:00
David Aaron Suddjian
e640b7f0e0
chore(dashboard): Datasource -> Dataset (#13939)
* chore(dashboard): Datasource -> Dataset

* lint

* more renaming datasource -> dataset
2021-04-02 16:47:16 -07:00
Michael S. Molina
a0a00e6470
test: Adds tests to the PublishedStatus component (#13892) 2021-04-02 14:26:06 -07:00
AAfghahi
4187d9e4c4
fix: adjusted tab height (#13822) 2021-04-02 12:44:45 -04:00
Amit Miran
f6f412b4ae
chore: bump to new superset-ui version (#13932) 2021-04-02 18:27:10 +03:00
Jesse Yang
65940770ac
feat(explore): adhoc column formatting for Table chart (#13758) 2021-04-01 23:28:42 -07:00
Michael S. Molina
a1442497d4
test: Fixes PropertiesModal_spec (#13548) 2021-04-01 11:42:14 -07:00
Michael S. Molina
42c7e2cae6
test: Adds tests to dnd controls (#13650) 2021-04-01 09:11:33 -07:00
Michael S. Molina
bb677b8ef1
test: Adds tests to the AnnotationLayer component (#13748) 2021-04-01 09:10:42 -07:00
Geido
9156f089ff
test: Refactor and enhance tests for the Explore DatasourcePanel Component (#13799)
* Refactor and enhance tests

* Fix linting issues
2021-03-31 23:14:51 -07:00
Geido
a5c4db3aee
Add tests (#13778) 2021-03-31 23:08:56 -07:00
Bruno Motta
1dbc1496b2
test: DisplayQueryButton (#13750)
* Tests for DisplayQueryButton component

* add factories to props and fetch-mock

* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 23:08:20 -07:00
Evan Rusackas
a7f48c6599
Fixing condition around left margin for dashboard layout. Fixes #13863 (#13905) 2021-03-31 21:32:46 -07:00
Erik Ritter
5315d2cc2d
Revert "fix: select table overlay (#13694)" (#13901)
This reverts commit b247279ffe.
2021-03-31 18:47:38 -07:00
Michael S. Molina
6fd62e3f7e
test: Adds tests to the OptionControls component (#13729) 2021-03-31 18:07:22 -07:00
Bruno Motta
ec5d2f5f32
test: DatasourceControl (#13605)
* Tests for DatasourceControl

* fix: lint error

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove error comment

* replace component data-test

* factory to props

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 17:52:45 -07:00
Bruno Motta
9fd297f636
tests for function handleScroll (#13896) 2021-03-31 17:49:43 -07:00
Michael S. Molina
28fe6e0ef1
test: Adds tests to the CustomFrame component (#13675)
* test: Adds tests to the CustomFrame component

* Replaces full path with relative path
2021-03-31 15:53:07 -07:00
Michael S. Molina
7ae80e9d66
test: Adds tests to the AdvancedFrame component (#13664)
* test: Adds tests to AdvancedFrame component

* Replaces full path with relative path
2021-03-31 15:52:03 -07:00
Bruno Motta
1252fd700e
test: DataTableControl (#13668)
* Tests for DataTableControl

* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-31 15:45:30 -07:00
Michael S. Molina
8ddcba82e0
chore: Removes Select duplication (#13477) 2021-03-31 15:42:14 -07:00
Michael S. Molina
9d6832dc27
test: Adds tests and storybook to CertifiedIcon component (#13457) 2021-03-30 14:31:35 -07:00
Michael S. Molina
3c4591ef15
chore: Moves CheckboxIcons to Checkbox folder (#13459) 2021-03-30 13:55:10 -07:00
Michael S. Molina
6fe4cc0c51
chore: Removes Popover duplication (#13462) 2021-03-30 13:54:53 -07:00
Beto Dealmeida
ce2760edf7
fix: allow spaces in DB names (#13800) 2021-03-30 10:12:10 -07:00
Jack Fragassi
304e3b36eb
feat(alerts & reports): Easier to read execution logs (#13752)
* Prep for migration

* Migration for execution id column

* Generate execution ids for alerts and reports

* Change execution id range

* Add execution id to API endpoint

* Add execution id to execution log view

* Change execution id range

* Change execution id to a uuid

* Fix execution id type

* Switch state and exec. id columns

* Change db column to UUIDType

* Python lint

* Fix failing frontend tests

* execution_id -> uuid

* Fix migration head

* lint

* Use celery task id as the execution id

* lint

* lint for real

* Fix tests
2021-03-30 08:46:16 -07:00
Michael S. Molina
4ae9b819d3
fix: Disallows negative options remaining (#13749) 2021-03-30 08:34:12 -07:00
Ville Brofeldt
3394421fa8
fix(native-filters): add global async query support to native filters (#13837)
* fix(native-filters): improve loading styles for filter component

* round up fractional grid unit

* fix(native-filters): add support for global async queries

* move form item out of default value component

* move default value hook declaration to form

* delete LoadingBox
2021-03-30 07:50:52 +03:00
Michael S. Molina
ac43f4c491
Displays row limit warning with Alert component (#13854) 2021-03-29 17:04:33 -07:00
Jack Fragassi
33f7845010
fix(alerts and reports): Unify timestamp format on execution log view (#13718)
* Unify timestamp format on execution log view

* Fix lint
2021-03-29 13:30:19 -07:00
zuzana-vej
467848d8f7
fix(sqllab): warning message when rows limited (#13841) 2021-03-29 10:47:51 -07:00
Ville Brofeldt
9fa52b50ed
fix(native-filters): improve loading styles for filter component (#13794)
* fix(native-filters): improve loading styles for filter component

* round up fractional grid unit

* remove LoadingBox
2021-03-29 10:23:01 +03:00
cccs-jc
24f805ebc4
feat: added support to configure the default explorer viz (#13610)
* added support to configure the default explorer viz

* code review fix

* lint

Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-03-26 15:27:36 -07:00
David Aaron Suddjian
db1d598f50
fix(cypress): avoid referencing detached dom nodes (#13825) 2021-03-26 14:46:31 -07:00
David Aaron Suddjian
a45a5e1060
chore(cypress): Make the e2e tests more behavior-driven (#13784)
* chore(cypress): make the load dashboard test behavior driven

* remove bootstrap usage from controls test, + new utils

* fix save test to not use bootstrap dat

* remove bootstrap usage from the filter test

* fix race condition

* remove bootstrap from url params test

* fix lint

* remove unused const

* add chart specs for the tab test

* attempt removing bootstrap data from tabs tests

* fix cypress async/sync confusion

* remove redundant assertions

* attempt fixing tab test

* attempt fixing tabs test

* cleanup commented code

* better aliases so you can tell what they are in the logs

* remove unused imports

* get the line chart alias before clicking the tab

* simplify getChartGridComponent

* wait for all the charts before force refresh

* fix tabs test

* one more time with the tabs test

* another edit to tabs test

* fix flaky test

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
2021-03-26 09:20:13 -07:00
AAfghahi
b247279ffe
fix: select table overlay (#13694) 2021-03-26 10:39:39 -04:00
AAfghahi
64f967cb2d
refactor: New schedule query button (#13797) 2021-03-26 09:56:59 -04:00
Michael S. Molina
be8f8d9c1f
test: Adds storybook and tests to PopoverDropdown component (#13547)
* test: Adds storybook and tests to PopoverDropdown component

* Changes to use gridUnit and theme hook
2021-03-26 05:29:03 -07:00
Bruno Motta
416f188328
test: SelectAsyncControl (#13638)
* SelectAsyncControl tests

* fix: lint error

* applying factory to  props
2021-03-25 22:07:05 -07:00
Bruno Motta
2aedaaa03e
test: DatabaseSelector (#13581)
* Moving DatabaseSelector to a folder

* Tests for DatabaseSelector

* Using factory for props

* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* apply waitFor and remove act

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-25 22:01:13 -07:00
Geido
930cbea2e1
test: Tests, dedicated directory and Storybook for the ProgressBar component (#13534)
* Move to own dir and add storybook

* Add tests
2021-03-25 15:44:00 -07:00
Phillip Kelley-Dotson
3e4c3bddb9
feat(homescreen and cards): Toggle thumbnails off or on and feature flag (#13683) 2021-03-25 13:21:04 -04:00
AAfghahi
1d5c58d005
refactor: SouthPane into functional component (#13676) 2021-03-24 23:00:12 -04:00
Hugh A. Miles II
71ca5aca5b
refactor: Revert "refactor: ScheduleQueryButton into functional component (#134… (#13785)
This reverts commit 2c3d9e9b1e.
2021-03-24 22:50:59 -04:00
AAfghahi
2c3d9e9b1e
refactor: ScheduleQueryButton into functional component (#13443) 2021-03-24 17:46:24 -04:00