Commit Graph

95 Commits

Author SHA1 Message Date
Grace Guo
43eec67291
[table editor] hide Edit Datasource option when no onDatasourceSave (#9706)
* [table editor] hide Edit Datasource option when no onDatasourceSave

* add !! operator to get truthiness
2020-04-30 17:32:01 -07:00
Erik Ritter
5fb883e279
chore(ts): type getClientErrorObject (#9693) 2020-04-30 17:03:31 -07:00
ʈᵃᵢ
f7f60cc75d
[Chart & Dashboard] improve listview filter ui and add expandable list support (#9651)
* better styling for select filters and search input

* add emotion babel plugin

* add spec for search input

* fix async select, add beeter error messages

* add error boundary around views

* cleanup and lint

* add expandable list to dashboards

* fix emotion babel config

* fix specs

* remove commented out code

* add selected style

* DRY up styles

* add icons

* fix type

* add apache license

* fix svgs

* fix ExpandableList type

* reduce custom css

* lint
2020-04-29 21:54:07 -07:00
Erik Ritter
5d7b13507e
feat(errors): add client scaffolding for custom error messages (#9677) 2020-04-29 17:20:31 -07:00
Grace Guo
52a0afe241
[fix] reduce table metadata fetch for latest_partition check (#9685)
* [fix] reduce table metadata fetch for latest_partition check

* fix review comment
2020-04-29 11:40:29 -07:00
Grace Guo
735dcd2002
[explore view] add partition as adhoc filter option (#9637)
* [explore view] add partition as adhoc option

* use adhocFilter Simple Tab

* simplify conditional check for custom adhoc filter operator

* add simple unit tests
2020-04-28 23:09:44 -07:00
Natalie Ruhe
9d755bc1ad
[fix] Support APP_ICON_WIDTH configuration parameter in SPA menu (#9666)
* Expose additional APP_ICON_WIDTH python config variable to ui via app bootstrap for use in Menu

* Update base.py to inclue APP_ICON_WIDTH via bracket notation instead of .get and adjust Menu proptypes to be required.

Co-authored-by: Natalie Ruhe <nruhe@nruhe.attlocal.net>
Co-authored-by: Natalie Ruhe <natalie@preset.io>
2020-04-28 12:59:03 -07:00
Lily Kuang
c474ea848a
[fix] Push browser history on pagination in react listviews (#9624)
* improve history for query params

* fix: push browser history on pagination in react listviews

* fix spec

Co-authored-by: Tai Dupree <tdupreetan@gmail.com>
2020-04-27 21:37:22 -07:00
Erik Ritter
e8c3803336
chore(ts): refactor and migrate StackTraceMessage to TypeScript (#9663) 2020-04-27 13:24:21 -07:00
Evan Rusackas
5e4c291913
Controls cleanup pass (#9578)
* migrating date_filter

* normalized control

* filter_configs control

* column_collection control

* time_range_endpoints control

* time_range_fixed control

* url_params control

* cache_timeout control

* annotation_layers control

* color control unused?

* linters rule 🤘

* this should have been deleted earlier

* global_opacity, mapbox_label, mapbox_style, viewport_zoom

* linting

* comparison_type

* contribution control

* log_scale

* show_values

* table_filter

* pandas_aggfunc

* code control

* formatSelectOptions import

* lint

* markup_type control

* lintage

* date_time_format control, linting

* url control, test mods

* min_periods control

* rolling_periods

* rolling_type

* missing lib

* order_desc

* number_format

* link_length

* all_columns_y

* all_columns_x

* normalize_across, select_country, all_columns

* fixing test

* linter-caught dependencies

* waiting

* wait longer!

* utilizing tabOverride for Analytics

* tabOverride for Annotations and Layers
2020-04-24 16:12:26 -07:00
Grace Guo
29dd989483
[dashboard] increase tab count limit (#9640) 2020-04-24 13:41:33 -07:00
David Aaron Suddjian
f8adfc8fbf
use new @superset-ui/style package for theming (#9605)
* use new @superset-ui/style package for theming

* fix tests to reference theme

* try adding a wait
2020-04-22 13:13:40 -07:00
Jesse Yang
7b33d5457b
fix: change number format to original value to "~g" (#9608)
Originally it uses " ", which do give the original value, but will
not work when the `getNumberFormatter` in `superset-ui/number-format`
is called for the second time. Because the format will successfully
register as "" [1], but cannot be obtained again via `registry.get()`[2].

[1]: 44ad062dd0/packages/superset-ui-number-format/src/NumberFormatterRegistry.ts (L30)
[2]: dc804b7a70/packages/superset-ui-core/src/models/RegistryWithDefaultKey.ts (L36)
2020-04-22 10:07:37 -07:00
Erik Ritter
dcbffed9bb
[SQL Lab] Lock result set controls to be always visible (#9587) 2020-04-21 12:09:33 -07:00
ʈᵃᵢ
0b999e3b91
[charts] adds new filters ui (#9530)
* [charts] adds new filters ui

* move null check to be more visible

* better filter lists and async filter functionality
2020-04-21 12:04:11 -07:00
Jesse Yang
2b957a2c1e
Add raw number/integer option to d3 number formats (#9562) 2020-04-20 21:31:47 -07:00
Evan Rusackas
ea27e68ee1
Migrating shared NVD3 controls to new module (#9525)
* proto module

* caught a missed 'freq' unique control

* line_interpolation

* linting

* showLegend

* show_controls

* xAxisLabel

* bottomMargin

* x_ticks_layout

* missed one

* x_axis_format

* yLogScale

* y_axis_bounds

* linting

* nixing yarn lock

* x_axis_showminmax

* xAxisShowminmax control

* richTooltip

* linting, syntax fix

* show_bar_value, bar_stacked

* reduceXticks, yaxislabel

* left_margin, max_bubble_size, y_axis_showminmax

* show_labels

* send_time_range, y_axis_2_format, show_markers, order_bars

* nixing commented imports

* fake controls

* looking up actual controls for comparison.

* adding key to test setup

* controls inventory

* apache junk

* lint 

* ignore null controls

* fixing goofed up spread operation for xAxisFormat config

* lint 

* fixes for errors caused by <hr> element in filterbox controls

* fixing filter controls for 'druid_time_origin', 'granularity', 'granularity_sqla', 'time_grain_sqla'

* getControlsInventory -> getControlsForVizType

* further renaming of chartControlsInventory - > getControlsForVizType

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
2020-04-17 11:40:50 -07:00
Ville Brofeldt
427d2a05e5
chore: Migrate unique FilterBox controls from controls.jsx (#9566)
* Migrate FilterBox controls from controls.jsx

* Linting
2020-04-17 12:20:32 +03:00
Grace Guo
4a55e1ea3a
[fix] dashboard filter scope bug (#9550) 2020-04-16 15:44:03 -07:00
ʈᵃᵢ
1ccda920fe
[list views] add work-break css for table layouts (#9537) 2020-04-14 22:04:24 -07:00
Evan Rusackas
6270f7dc24
Importing validators module from superset-ui (#9465)
* importing... this is going to break CI, but there it is.

* adding validator package.

* pluralization - maybe it should be plural, but whatevs

* updating validators to match new exports

* removing old validators

* lintage 

* validateNumeric -> validateNumber

* using legacyValidateInteger, legacyValidateNumber

* linting 

* removing extraneous package lock file
2020-04-14 12:00:25 -07:00
Evan Rusackas
f29d0fd9f2
control to turn off table bar-chart backgrounds (#9500)
* control to turn off table bar-chart backgrounds

* flipping enable to disable, to support existing charts

* lint 

* Turn ON to enable (reversing logic)

* bumping big number chart

* ling 
2020-04-13 16:53:50 -07:00
ʈᵃᵢ
f90824fa17
[Dashboard] new listview filters & emotion infra (#9462)
* [Dashboard] listview filters to match new design

* use title_or_slug filter

* use ?. operator

* move components to components folder
2020-04-13 13:39:55 -07:00
Bogdan
02b3fb1d63
Add visualization flow to the CTA queries (#9370)
* Visualize after running Ctas query (#4)

* Visualize after running Ctas query.

Stub for table viz

Work on the viz

Add JS functionality for Ctas viz

Add test for the table viz flow

Fix test

Add js test for the ctas viz

* Fix tests

* Resolve comments

* Leverate tmpSchema in the query object

* Fix i18n string

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-04-11 00:46:46 +03:00
Ville Brofeldt
5ec0192bcc
fix: add lineWidth to Shared_DeckGL.jsx (#9496)
* fix: add lineWidth to Shared_DeckGL.jsx

* linting
2020-04-09 12:47:50 -07:00
Jianchao Yang
5565895819
fix: add explore control tabOverride at the section level (#9495) 2020-04-08 18:26:53 -07:00
Jianchao Yang
36cd5411d0
feat: change default time range in sql lab explore (#9486)
Change from "100 years go" to "no filter".

100 years ago is basically equivalent to no filter, but has
implications on how x-axis is plotted on certain charts (e.g. Big
Number).
2020-04-08 17:39:14 -07:00
David Aaron Suddjian
5e535062da
Filter owners select by text input (#9337)
* filter owners select by text input

* use rison

* fix backend owners filter logic

* use fullname, not username on owners inputs

* fix some tests

* fixing tests

* deterministic tests

* appease linter

* add back search by username

* more comprehensive filter test

* add clarifying text

* formatting...
2020-04-07 09:09:02 -07:00
Evan Rusackas
b6bca9f137
Migrating shared DeckGL controls (#9455)
* Missed a couple unique controls!

* new shared module, with filter_nulls export.

* autozoom

* dimension

* nixing unneeded import

* stroke_width

* js_columns

* remaining js_* controls

* cleaning up unused stuff

* legend_format

* exports for prior commit

* legend_position

* line_column

* fill_color_picker

* filled, stroked, stroke_color_picker

* grid_size, extruded

* ... more gridsize

* viewport

* point_radius_fixed, spatial

* multiplier, line_type, line_width

* reverse_long_lat

* lint 
2020-04-06 18:37:25 -07:00
Evan Rusackas
1cdfb829d7
Eslint prefer-object-spread (#9466)
* The rule.

* The result
2020-04-03 17:05:16 -07:00
Evan Rusackas
265a2feb29
Migrating NVD3 Area's stacked_style config (#9454)
* Migrating NVD3 Area's stacked_style config

* test mods

* lint

* nonsense change

* undoing nonsense. Come on GitHub, WORK.
2020-04-03 12:50:28 -07:00
Evan Rusackas
cd572334c9
Migrating unique NVD3 viz controls (#9445)
* donut control

* labels outside

* linting

* x_log_scale, pie_label_type

* linting

* line_charts, line_charts_2

* marker_labels

* marker_line_labels, marker_lines, markers

* prefix_metric_with_slice_name, range_labels, ranges

* stacked_style

* Revert "stacked_style"

This reverts commit aae2d418b8f1950fbe32248b62e50a12fbf186bd.

* stacked_style take 2...

* Revert "stacked_style take 2..."

This reverts commit 38b7155f50143684c92a67b2a9fa16f65c269d35.
2020-04-03 12:50:07 -07:00
Evan Rusackas
9e79cf37f8
Migrating unique bigNumber(total) controls (#9440)
* migrating options controls

* lint 

* baby steps...

* shared BigNumber controls file

* capitalization matters
2020-04-02 10:52:32 -07:00
Evan Rusackas
c003189d0d
migrating unique controls (#9446) 2020-04-02 09:26:52 -07:00
Jianchao Yang
f0f4f7e91d
feat(visualization): add timeRangeFixed to Big Number w/ Trendlines (#9341)
* feat: add timeRangeFixed and increase font size for Big Number chart

* Update package-lock.json
2020-04-01 12:38:56 -07:00
ʈᵃᵢ
893c95521b
fix pagination for list views (#9425) 2020-04-01 09:20:17 -07:00
Grace Guo
a9ff51bd61
[fix] dashboard filter indicator no showing single number value (#9401) 2020-03-30 15:05:04 -07:00
Grace Guo
ce3031b925
[fix] allow force refresh for No Results chart (#9408) 2020-03-30 15:00:58 -07:00
Jianchao Yang
3d8a2b859e
Build: fix hot reload for charts (#9400)
* Fix hot reload for charts

* Override tsc options for plugins

Plugins will sometimes have their own `tsconfig.json`, which will
interfere with the dev server config if configured inappropriately.

This change makes sure `tsc` (and `ts-loader`) always compiles to
`esnext` modules, so we don't get "Uncaught ReferenceError: exports
is not defined" error.
2020-03-30 09:31:46 -07:00
Evan Rusackas
fd227888b6
Mirgrating unique Partition chart controls (#9385)
* mirgrating controls

* specific import
2020-03-27 09:16:36 -07:00
Evan Rusackas
98a26c4f2c
migrating controls (#9373) 2020-03-26 21:32:23 -07:00
Jianchao Yang
77fcc4b6aa
build: use manifest hooks for dev server proxy and fix hot reload for charts (#9333)
* Use manifest hooks for dev server proxy

* Rewrite dashboard/App.jsx to supress Redux error in hot reload

* Update ChartRenderer to allow hot realod in Explore

* Fix hot reload in dashboars as well

* Revert changes to ChartRenderer.jsx

Will submit in another PR.

* Clean up
2020-03-26 16:55:22 -07:00
Evan Rusackas
9fcdc93c06
Migrating horizon controls (#9368)
* migrating unique controls

* linting 
2020-03-26 15:16:07 -07:00
Evan Rusackas
b12188ec80
migrating unique controls (#9374) 2020-03-26 15:15:47 -07:00
David Aaron Suddjian
cfa786850f
upgrade to react-bootstrap v0.33.1 (#9372)
* upgrade to react-bootstrap v0.33.1

* fix test

* simplify proptypes

Co-Authored-By: Evan Rusackas <evan@preset.io>

* simplify more proptypes

Co-Authored-By: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-03-26 11:16:49 -07:00
Evan Rusackas
ccff6be969
Migrating unique BoxPlot controls (#9392) 2020-03-26 09:29:17 -07:00
Evan Rusackas
7e86e38dab
Migrating unique Table controls (#9388) 2020-03-26 09:28:51 -07:00
Evan Rusackas
bf0fa84bbc
migrating controls 🎛 (#9386) 2020-03-26 09:28:09 -07:00
Grace Guo
5b07c8d229
[dashboard] handle markdown error (#9350)
* [dashboard] handle markdown error

* localize error message, fix review comments.
2020-03-26 09:06:23 -07:00
ʈᵃᵢ
f5cc0ef906
fix: [dashboard] add row padding (#9381) 2020-03-26 08:18:53 -07:00