Beto Dealmeida
c7f9060a2f
feat: import external management columns ( #19315 )
...
* feat: import flags
* Add tests
2022-03-24 10:41:22 -07:00
Yongjie Zhao
375c03e084
feat(advanced analysis): support MultiIndex column in post processing stage ( #19116 )
2022-03-23 13:46:28 +08:00
Beto Dealmeida
b05e7dbf2a
feat: API for asset sync ( #19220 )
...
* feat: API for asset sync
* Add unit tests.
* Improve tests
* Move files
* Add more tests
2022-03-22 08:29:24 -07:00
John Bodley
82a6811e7e
fix(presto/trino): Add TIME/TIMESTAMP WITH TIME ZONE ( #19263 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-03-22 06:33:38 +13:00
Elizabeth Thompson
88029e21b6
fix dataset update table ( #19269 )
2022-03-21 09:43:51 -07:00
Ville Brofeldt
f341025d80
feat: add support for comments in adhoc clauses ( #19248 )
...
* feat: add support for comments in adhoc clauses
* sanitize remaining freeform clauses
* sanitize adhoc having in frontend
* address review comment
2022-03-18 15:08:06 -07:00
Lily Kuang
50902d51f5
fix: allow subquery in ad-hoc SQL (WIP) ( #19242 )
...
* allow adhoc subquery
* add config for allow ad hoc subquery
* default to true allow adhoc subquery
* fix test
* Update superset/errors.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/connectors/sqla/utils.py
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
* rename and add doc string
* fix for big query test
* Update superset/connectors/sqla/utils.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Apply suggestions from code review
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* add test
* update validate adhoc subquery
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-03-18 10:04:55 -07:00
Beto Dealmeida
51061f0d67
feat: import/export assets commands ( #19217 )
...
* feat: import/export assets commands
* Add overwrite test
* Fix tests
2022-03-17 10:51:17 -07:00
Craig Rueda
4b34817b19
feat(ui): Adding manifest prefix config ( #19141 )
...
* Adding manifest prefix config
* Fixing broken tests
* Fixing import
* Adding prefix for remaining assets
* Changing static prefix strategy
* Fixing DST test
* Fixing up formatting
* Fixing up async_query_manager.py types
2022-03-17 08:58:48 -07:00
Ville Brofeldt
b7a0559aaf
feat: add permalink to dashboard and explore ( #19078 )
...
* rename key_value to temporary_cache
* add migration
* create new key_value package
* add commands
* lots of new stuff
* fix schema reference
* remove redundant filter state from bootstrap data
* add missing license headers
* fix pylint
* fix dashboard permalink access
* use valid json mocks for filter state tests
* fix temporary cache tests
* add anchors to dashboard state
* lint
* fix util test
* fix url shortlink button tests
* remove legacy shortner
* remove unused imports
* fix js tests
* fix test
* add native filter state to anchor link
* add UPDATING.md section
* address comments
* address comments
* lint
* fix test
* add utils tests + other test stubs
* add key_value integration tests
* add filter box state to permalink state
* fully support persisting url parameters
* lint, add redirects and a few integration tests
* fix test + clean up trailing comma
* fix anchor bug
* change value to LargeBinary to support persisting binary values
* fix urlParams type and simplify urlencode
* lint
* add optional entry expiration
* fix incorrect chart id + add test
2022-03-17 01:15:52 +02:00
Beto Dealmeida
8234395466
feat: helper functions for RLS ( #19055 )
...
* feat: helper functions for RLS
* Add function to inject RLS
* Add UNION tests
* Add tests for schema
* Add more tests; cleanup
* has_table_query via tree traversal
* Wrap existing predicate in parenthesis
* Clean up logic
* Improve table matching
2022-03-11 14:47:11 -08:00
Ville Brofeldt
999c2c6826
fix(dashboard): import handle missing excluded charts ( #19088 )
2022-03-10 12:59:29 +02:00
John Bodley
26486d01c1
chore: Remove legacy SIP-15 interim logic/flags ( #18936 )
...
* chore: Remove legacy SIP-15 logic
* Update ab9a9d86e695_deprecate_time_range_endpoints.py
* Update UPDATING.md
* Update UPDATING.md
* Update UPDATING.md
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-03-04 09:15:36 +13:00
Beto Dealmeida
00c99c91ec
feat: new dataset/table/column models ( #17543 )
...
* feat: new models for SIP-68
* feat: new dataset models DB migration
* Add shadow write (WIP)
* Physical dataset shadow write (WIP)
* Virtual dataset shadow write (WIP)
* Update migration to populate models
* Cascade delete columns
* after_delete
* Update hook
* Add metric test
* Do not rename tables
* Small fixes
* Fix migration
* Fix tests
* Fix more tests
* Even more tests
* Addressing comments (WIP)
* Fix migration
* Rebase and update head
* Fix unit tests
* Add external management cols
* Small fixes
2022-02-24 11:02:01 -08:00
Corbin Robb
0ae1ca7e02
chore(tests-backend): migrate snowflake and sqlite to unit tests ( #18854 )
...
* migrate snowflake and sqlite
* change structure to better match the other unit tests
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2022-02-23 11:11:10 -06:00
Sujith Kumar S
7e51b200b4
fix(mssql): support top syntax for limiting queries ( #18746 )
...
* SQL-TOP Fix For Database Engines
MSSQL is not supporting LIMIT syntax in SQLs. For limiting the rows, MSSQL having a different keyword TOP. Added fixes for handling the TOP and LIMIT clauses based on the database engines.
* Teradata code for top clause handling removed from teradata.py
Teradata code for top clause handling removed from teradata.py file, since we added generic section in base engine for the same.
* Changes to handle CTE along with TOP in complex SQLs
Added changes to handle TOP command in CTEs, for DB Engines which are not supporting inline CTEs.
* Test cases for TOP unit testing in MSSQL
Added multiple unit test cases for MSSQL top command handling and also along with CTEs
* Corrected the select_keywords name key in basengine
Corrected the select_keywords name key in basengine
* Changes based on as per review.
made the required corrections based on code review to keep good code readability and code cleanliness.
* Review changes to correct lint and typo issues
Made the changes according to the review comments.
* fix linting errors
* fix teradata tests
* add coverage
* lint
* Code cleanliness
Moved the top/limit flag check from sql_lab to core.
* Changed for code cleanliness
Changes for keeping code cleanliness
* Corrected lint issue
Corrected lint issue.
* Code cleanliness
Code cleanliness
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-21 09:58:39 +02:00
Yongjie Zhao
987740aa8d
fix: contribution operator meets nan value ( #18782 )
2022-02-18 23:28:28 +08:00
Yongjie Zhao
38cd696981
refactor: move date_parser to unittest ( #18810 )
2022-02-18 20:15:31 +08:00
Yongjie Zhao
30a9d14639
refactor: postprocessing move to unit test ( #18779 )
2022-02-17 20:05:41 +08:00
Sujith Kumar S
b8aef10098
fix(mssql): support cte in virtual tables ( #18567 )
...
* Fix for handling regular CTE queries with MSSQL,#8074
* Moved the get_cte_query function from mssql.py to base.py for using irrespetcive of dbengine
* Fix for handling regular CTE queries with MSSQL,#8074
* Moved the get_cte_query function from mssql.py to base.py for using irrespetcive of dbengine
* Unit test added for the db engine CTE SQL parsing.
Unit test added for the db engine CTE SQL parsing. Removed additional spaces from the CTE parsing SQL generation.
* implement in sqla model
* lint + cleanup
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-10 10:28:05 +02:00
Ville Brofeldt
fdbcbb5c84
fix(csv-export): pivot v2 with verbose names ( #18633 )
...
* fix(csv-export): pivot v2 with verbose names
* refine logic + add test
* add missing verbose_map
2022-02-09 14:01:57 +02:00
Hugh A. Miles II
7194a01040
fix: user UUIDs on export for Native Filter Configuration ( #18562 )
...
* saving work for import
* update
* move logic to update ref
* remove export updates
* remove unneeded code
* cleanup
* Update superset/dashboards/commands/importers/v1/utils.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update tests/unit_tests/dashboards/commands/importers/v1/utils_test.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2022-02-08 13:10:40 -08:00
Ville Brofeldt
7ad38d5ba1
chore(tests): migrate mssql tests to pytest ( #18251 )
...
* move test
* migrate to pytest
2022-02-02 13:19:58 +02:00
Dave McNulla
8c376548e3
fix(teradata): LIMIT syntax ( #18240 )
...
Co-authored-by: Mccush, Jack <jack.mccush@teradata.com>
Co-authored-by: Jack McCush <33156805+mccushjack@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: David McNulla <david.mcnulla@teradata.com>
2022-01-31 19:15:42 -08:00
AAfghahi
fa11a97585
fix: remove standalone ( #18157 )
...
* removed standalone
* Update tests/integration_tests/reports/commands_tests.py
* changed standalone
* added tests
* made function more generic
* Update superset/reports/notifications/email.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2022-01-26 13:04:26 -05:00
Michael S. Molina
f018c826b8
refactor: Moves the Explore form_data endpoint ( #18151 )
...
* refactor: Moves the Explore form_data endpoint
* Removes unused imports
* Fixes openapi schema error
* Fixes typo
* Renames and UPDATING.md
2022-01-25 11:14:50 -03:00
Michael S. Molina
959b15eeca
feat: Adds a key-value endpoint to store charts form data ( #17882 )
...
* feat: Adds a key-value endpoint to store charts form data
* Fixes linting problems
* Removes the query_params from the endpoints
* Refactors the commands
* Removes unused imports
* Changes the parameters to use dataclass
* Adds more access tests
* Gets the first dataset while testing
* Adds unit tests for the check_access function
* Changes the can_access check
* Always check for dataset access
2022-01-20 16:27:57 -03:00
Erik Ritter
14b9298ef7
fix: revert #17654 to fix subselect table name parsing ( #18017 )
2022-01-12 21:28:23 -08:00
John Bodley
63ca09e345
fix: Workaround for sqlparse issue #652 ( #17995 )
...
* fix: Workaround for sqlparse issue #652
* Update superset/sql_parse.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Update sql_parse.py
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-01-12 14:03:56 +13:00
Mikhail Kumachev
d2d4f8eb44
feat: Add support for Azure Data Explorer (Kusto) db engine spec ( #17898 )
...
* Add two Kusto engine specs: KQL and SQL. Some minor changes in core code to support Kusto engine specs.
* Remove redundant imports and logging.
* docs: Kusto sqlalchemy docs
* fix: Fix mypy and linting errors
* fix: Handle Black vs Pylint checks
* fix: isort problem
* refactor: Merge kustosql and kustokql in the single kusto module
* test: Add tests for Kusto db spec
* feat: Schema override does not require in KQL anymore
* Removed redundant imports.
* Added ".show" queries to readonly query determination.
* Fixed some bugs.
Added tests for convert_dttm.
* Fixed major sqlalchemy-kusto version.
* Fixed by isort.
Co-authored-by: Eugene Bikkinin <xnegxneg@gmail.com>
Co-authored-by: k.tomak <k.tomak@dodopizza.com>
Co-authored-by: Eugene Bikkinin <e.bikkinin@dodopizza.com>
2022-01-10 14:42:20 +02:00
Beto Dealmeida
30c0459808
fix: extra column in metrics ( #17784 )
2021-12-22 10:39:29 -08:00
Beto Dealmeida
c49545aec1
fix: dataset extra import/export ( #17740 )
...
* fix: dataset extra import/export
* Update superset/datasets/commands/importers/v1/utils.py
2021-12-22 09:41:31 -08:00
Beto Dealmeida
37cc2c4d15
fix: column extra in import/export ( #17738 )
2021-12-14 18:33:52 -08:00
Beto Dealmeida
2633bcccc3
fix: import dashboard stale filter_scopes ( #17741 )
2021-12-14 07:23:55 -08:00
Beto Dealmeida
fceabf6bc5
fix: import dash with missing immune ID ( #17732 )
2021-12-13 16:20:55 -08:00
Beto Dealmeida
3873cdff4d
feat: convert dataframe tests ( #17655 )
2021-12-09 09:47:53 -08:00
Ville Brofeldt
3a42071e0f
chore(sql): clean up invalid filter clause exception types ( #17702 )
...
* chore(sql): clean up invalid filter clause exception types
* fix lint
* rename exception
2021-12-09 17:49:32 +02:00
Beto Dealmeida
b7ae7f976a
chore: convert feature flag tests to unit tests ( #17689 )
...
* chore: convert feature flag tests to unit tests
* Fix test
2021-12-08 14:51:47 -08:00
Beto Dealmeida
8c25f2f356
fix: extract tables doesn't work with reserved keywords ( #17654 )
2021-12-08 05:50:42 -08:00
Ville Brofeldt
b2ffa268cd
fix(sqla): make text clause escaping optional ( #17641 )
2021-12-03 12:35:26 +02:00
Elizabeth Thompson
13e19291f2
fix: allow for multiple columns in pivot table report ( #17636 )
...
* allow for multiple columns in pivot table report
* fix null data issue
* Update tests/unit_tests/charts/test_post_processing.py
2021-12-02 16:42:37 -08:00
ofekisr
683d1dab13
refactor(QueryObject): decouple from superset ( #17479 )
...
* refactor: queryObject - decouple from superset
* refactor: queryObject - decouple from superset
2021-11-18 19:53:56 +02:00
Elizabeth Thompson
f10bc6d8fe
fix: add fallback and validation for report and cron timezones ( #17338 )
...
* add fallback and validation for report and cron timezones
* add logging to exception catch
* Run black
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-11-12 12:28:17 -08:00
Christian Pfarr
333b1371f7
feat: Drill ODBC/JDBC Impersonation feature ( #17353 )
...
* Added Drill ODBC Impersonation feature and necessary translations/docs
* Code Cleanup
* add jdbc impersonation_target parameter
* add unittests for DrillEngineSpec.modify_url_for_impersonation method
* reformat test_drill.py with black formatter
* run pre-commit locally
Co-authored-by: Christian Pfarr <Christian.Pfarr@deutschebahn.com>
Co-authored-by: Christian Pfarr <z0ltrix+gitlab@pm.me>
2021-11-10 08:45:16 +02:00
Beto Dealmeida
03a2c6ee8a
feat: apply d3NumberFormat to table reports ( #17336 )
2021-11-04 08:18:01 -07:00
Geido
2199ef2dd7
chore: Test cases for annotations and annotation layers incorrect creation through API ( #17246 )
...
* Add/Refactor tests
* Add return type
* Update api tests
2021-11-03 09:11:41 +00:00
Beto Dealmeida
93bafa0e6a
feat: improve logic in is_select ( #17329 )
...
* feat: improve logic in is_select
* Add more edge cases
2021-11-02 17:30:12 -07:00
Beto Dealmeida
83a2f8346e
chore: enable BQ tests ( #17017 )
2021-10-14 08:07:47 -07:00
Beto Dealmeida
c993c5845f
fix(BigQuery): explicitly quote columns in select_star ( #16822 )
...
* fix (BigQuery): explicitly quote columns in select_star
* Fix test
* Fix SELECT * in BQ
* Add unit tests
* Remove type changes
2021-10-06 07:43:32 -07:00
AAfghahi
aa747219ad
feat: Add Private Google Sheets to dynamic form ( #16628 )
...
* first pass private gsheets
* made encrypted extra into string, refactored onParametersChanged
* private sheets working, credential_info errors
* all but test connection working
* first pass private gsheets
* made encrypted extra into string, refactored onParametersChanged
* private sheets working, credential_info errors
* all but test connection working
* Regenerate package-lock.json
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-28 17:08:50 -07:00
Ville Brofeldt
0f16177bde
fix(native-filters): ignore unset filter box time range ( #16854 )
2021-09-27 17:17:52 +03:00
Beto Dealmeida
48a61bacc5
fix: handle CTEs with comments on is_select ( #16769 )
2021-09-21 16:23:54 -07:00
John Bodley
fb4650a6eb
chore(pylint): Remove top-level disable ( #16589 )
...
* chore(pylint): Remove top-level disable
* Update examples.py
* Update command.py
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-09-15 09:30:23 -07:00
Beto Dealmeida
afb8bd5fe6
feat: improve embedded data table in text reports ( #16335 )
...
* feat: improve HTML table in text reports
* Remove unused import
* Update tests
* Fix test
2021-08-18 17:00:29 -07:00
Beto Dealmeida
ac8e54d909
fix: improve pivot post-processing ( #16289 )
...
* fix: improve pivot post-processing
* Add tests
* Trim space from column name
2021-08-17 14:41:22 -07:00
Ville Brofeldt
36abc51f90
fix(dashboard): unset empty time filter indicator ( #16272 )
2021-08-16 19:32:05 +03:00
Ville Brofeldt
d46dc9aa45
chore: upgrade mypy and add type guards ( #16227 )
2021-08-14 06:31:45 +03:00
Ville Brofeldt
b61c34f7c9
fix(viz): deduce metric name if empty ( #16194 )
...
* fix(viz): deduce metric name if empty
* fix unit test
2021-08-12 11:16:05 +03:00
Hugh A. Miles II
fd80ae34a3
fix: Make sheet_name into a ValidationInputError
( #16056 )
...
* setup validates for name
* add error type
* fix linting
* fix test
* remove errors
* fix number
* fix test
2021-08-10 13:07:31 -04:00
Beto Dealmeida
2d61f15153
feat: send post-processed data in reports ( #15953 )
...
* feat: send post-processed data in reports
* Fix tests and lint
* Use enums
* Limit Slack message to 4k chars
2021-07-30 09:37:16 -07:00
Beto Dealmeida
f4739f427e
feat: post-processing for pivot table v2 ( #15879 )
...
* feat: add pivot v2 post-processing
* Fix lint
2021-07-29 11:05:56 -07:00
Hugh A. Miles II
bfe7eb9a7b
feat(dbc ui): Adding Google Sheets Dynamic Form ( #15801 )
...
* feat: Make Google Sheets Dyanmic (#15576 )
* first draft
* second draft
* added tests
* first draft
* added table_catalog
* remove console.log
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* revisions
* save this for now
* working form
* save disable on public sheets
* refactor somethings
* saving this for now
* working edit
* add back query to schema
* working add
* fix styling
* fixing x
* fix linting
* prettier
* fix some type issues
* more lint fixes
* remove unused dependency
* fix linint
* fix validation
* pylint bypass
* pylint bypass
* fix this
* fix mypy
* yerp
* fix test
* fix test
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* wrap add sheets
* fix linting issues
* fix unit test
* ignore typing
* fix editting and paste issues
* remove query
* fix this
* fix test
* add test back
* fix error messaging
* update url messaging on error
* change error type
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* add errors for sheets with no name
* fix
* fix messaging for gsheets
* stop pylint
* update line
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Arash <arash.afghahi@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-28 15:00:27 -04:00
Elizabeth Thompson
ea49aa3d2d
feat: add timezones to report cron ( #15849 )
...
* add timezones to report cron
* fix test
2021-07-27 18:28:24 -07:00
John Bodley
ab4e3b9bf9
chore: Enforce Mypy for non-tests ( #15757 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-22 06:46:43 +12:00
Amit Miran
62a8f2e193
chore(python-testing): move memoized tests to unit tests ( #15507 )
...
* chore: move memoized test into a separated file
create integration test workflow
* chore: create unit test workflow to run purely pytest
* fix: bad reference
* fix: remove pip requirements bc there aren't any yet
* temp: install unit dependencies directly
* fix: --rootdir=
* fix: try to run only unit test
* chore: decouple memoized as separated module
* fix: bring back dependencies bc superset top-level module is coupled to flask and others so no reason no to do it
* fix: reference
* fix: pre-commit
* fix: pylint
2021-07-12 10:00:18 +03:00
Beto Dealmeida
4f5f9287fc
feat: validate_parameters for GSheets ( #15578 )
...
* feat: validate_parameters for GSheets
* Move import inside fixture
* Update deps
* Rename parameter
2021-07-08 08:26:39 -07:00
ofekisr
b5119b8dff
refactor(tests): decouple unittests from integration tests ( #15473 )
...
* refactor move all tests to be under integration_tests package
* refactor decouple unittests from integration tests - commands
* add unit_tests package
* fix celery_tests.py
* fix wrong FIXTURES_DIR value
2021-07-01 18:03:07 +03:00