b8aef10098
fix(mssql): support cte in virtual tables ( #18567 )
...
* Fix for handling regular CTE queries with MSSQL,#8074
* Moved the get_cte_query function from mssql.py to base.py for using irrespetcive of dbengine
* Fix for handling regular CTE queries with MSSQL,#8074
* Moved the get_cte_query function from mssql.py to base.py for using irrespetcive of dbengine
* Unit test added for the db engine CTE SQL parsing.
Unit test added for the db engine CTE SQL parsing. Removed additional spaces from the CTE parsing SQL generation.
* implement in sqla model
* lint + cleanup
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-10 10:28:05 +02:00
fdbcbb5c84
fix(csv-export): pivot v2 with verbose names ( #18633 )
...
* fix(csv-export): pivot v2 with verbose names
* refine logic + add test
* add missing verbose_map
2022-02-09 14:01:57 +02:00
7194a01040
fix: user UUIDs on export for Native Filter Configuration ( #18562 )
...
* saving work for import
* update
* move logic to update ref
* remove export updates
* remove unneeded code
* cleanup
* Update superset/dashboards/commands/importers/v1/utils.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update tests/unit_tests/dashboards/commands/importers/v1/utils_test.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2022-02-08 13:10:40 -08:00
7ad38d5ba1
chore(tests): migrate mssql tests to pytest ( #18251 )
...
* move test
* migrate to pytest
2022-02-02 13:19:58 +02:00
8c376548e3
fix(teradata): LIMIT syntax ( #18240 )
...
Co-authored-by: Mccush, Jack <jack.mccush@teradata.com>
Co-authored-by: Jack McCush <33156805+mccushjack@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: David McNulla <david.mcnulla@teradata.com>
2022-01-31 19:15:42 -08:00
fa11a97585
fix: remove standalone ( #18157 )
...
* removed standalone
* Update tests/integration_tests/reports/commands_tests.py
* changed standalone
* added tests
* made function more generic
* Update superset/reports/notifications/email.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2022-01-26 13:04:26 -05:00
f018c826b8
refactor: Moves the Explore form_data endpoint ( #18151 )
...
* refactor: Moves the Explore form_data endpoint
* Removes unused imports
* Fixes openapi schema error
* Fixes typo
* Renames and UPDATING.md
2022-01-25 11:14:50 -03:00
959b15eeca
feat: Adds a key-value endpoint to store charts form data ( #17882 )
...
* feat: Adds a key-value endpoint to store charts form data
* Fixes linting problems
* Removes the query_params from the endpoints
* Refactors the commands
* Removes unused imports
* Changes the parameters to use dataclass
* Adds more access tests
* Gets the first dataset while testing
* Adds unit tests for the check_access function
* Changes the can_access check
* Always check for dataset access
2022-01-20 16:27:57 -03:00
14b9298ef7
fix: revert #17654 to fix subselect table name parsing ( #18017 )
2022-01-12 21:28:23 -08:00
63ca09e345
fix: Workaround for sqlparse issue #652 ( #17995 )
...
* fix: Workaround for sqlparse issue #652
* Update superset/sql_parse.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Update sql_parse.py
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-01-12 14:03:56 +13:00
d2d4f8eb44
feat: Add support for Azure Data Explorer (Kusto) db engine spec ( #17898 )
...
* Add two Kusto engine specs: KQL and SQL. Some minor changes in core code to support Kusto engine specs.
* Remove redundant imports and logging.
* docs: Kusto sqlalchemy docs
* fix: Fix mypy and linting errors
* fix: Handle Black vs Pylint checks
* fix: isort problem
* refactor: Merge kustosql and kustokql in the single kusto module
* test: Add tests for Kusto db spec
* feat: Schema override does not require in KQL anymore
* Removed redundant imports.
* Added ".show" queries to readonly query determination.
* Fixed some bugs.
Added tests for convert_dttm.
* Fixed major sqlalchemy-kusto version.
* Fixed by isort.
Co-authored-by: Eugene Bikkinin <xnegxneg@gmail.com>
Co-authored-by: k.tomak <k.tomak@dodopizza.com>
Co-authored-by: Eugene Bikkinin <e.bikkinin@dodopizza.com>
2022-01-10 14:42:20 +02:00
30c0459808
fix: extra column in metrics ( #17784 )
2021-12-22 10:39:29 -08:00
c49545aec1
fix: dataset extra import/export ( #17740 )
...
* fix: dataset extra import/export
* Update superset/datasets/commands/importers/v1/utils.py
2021-12-22 09:41:31 -08:00
37cc2c4d15
fix: column extra in import/export ( #17738 )
2021-12-14 18:33:52 -08:00
2633bcccc3
fix: import dashboard stale filter_scopes ( #17741 )
2021-12-14 07:23:55 -08:00
fceabf6bc5
fix: import dash with missing immune ID ( #17732 )
2021-12-13 16:20:55 -08:00
3873cdff4d
feat: convert dataframe tests ( #17655 )
2021-12-09 09:47:53 -08:00
3a42071e0f
chore(sql): clean up invalid filter clause exception types ( #17702 )
...
* chore(sql): clean up invalid filter clause exception types
* fix lint
* rename exception
2021-12-09 17:49:32 +02:00
b7ae7f976a
chore: convert feature flag tests to unit tests ( #17689 )
...
* chore: convert feature flag tests to unit tests
* Fix test
2021-12-08 14:51:47 -08:00
8c25f2f356
fix: extract tables doesn't work with reserved keywords ( #17654 )
2021-12-08 05:50:42 -08:00
b2ffa268cd
fix(sqla): make text clause escaping optional ( #17641 )
2021-12-03 12:35:26 +02:00
13e19291f2
fix: allow for multiple columns in pivot table report ( #17636 )
...
* allow for multiple columns in pivot table report
* fix null data issue
* Update tests/unit_tests/charts/test_post_processing.py
2021-12-02 16:42:37 -08:00
683d1dab13
refactor(QueryObject): decouple from superset ( #17479 )
...
* refactor: queryObject - decouple from superset
* refactor: queryObject - decouple from superset
2021-11-18 19:53:56 +02:00
f10bc6d8fe
fix: add fallback and validation for report and cron timezones ( #17338 )
...
* add fallback and validation for report and cron timezones
* add logging to exception catch
* Run black
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-11-12 12:28:17 -08:00
333b1371f7
feat: Drill ODBC/JDBC Impersonation feature ( #17353 )
...
* Added Drill ODBC Impersonation feature and necessary translations/docs
* Code Cleanup
* add jdbc impersonation_target parameter
* add unittests for DrillEngineSpec.modify_url_for_impersonation method
* reformat test_drill.py with black formatter
* run pre-commit locally
Co-authored-by: Christian Pfarr <Christian.Pfarr@deutschebahn.com>
Co-authored-by: Christian Pfarr <z0ltrix+gitlab@pm.me>
2021-11-10 08:45:16 +02:00
03a2c6ee8a
feat: apply d3NumberFormat to table reports ( #17336 )
2021-11-04 08:18:01 -07:00
2199ef2dd7
chore: Test cases for annotations and annotation layers incorrect creation through API ( #17246 )
...
* Add/Refactor tests
* Add return type
* Update api tests
2021-11-03 09:11:41 +00:00
93bafa0e6a
feat: improve logic in is_select ( #17329 )
...
* feat: improve logic in is_select
* Add more edge cases
2021-11-02 17:30:12 -07:00
83a2f8346e
chore: enable BQ tests ( #17017 )
2021-10-14 08:07:47 -07:00
c993c5845f
fix(BigQuery): explicitly quote columns in select_star ( #16822 )
...
* fix (BigQuery): explicitly quote columns in select_star
* Fix test
* Fix SELECT * in BQ
* Add unit tests
* Remove type changes
2021-10-06 07:43:32 -07:00
aa747219ad
feat: Add Private Google Sheets to dynamic form ( #16628 )
...
* first pass private gsheets
* made encrypted extra into string, refactored onParametersChanged
* private sheets working, credential_info errors
* all but test connection working
* first pass private gsheets
* made encrypted extra into string, refactored onParametersChanged
* private sheets working, credential_info errors
* all but test connection working
* Regenerate package-lock.json
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-28 17:08:50 -07:00
0f16177bde
fix(native-filters): ignore unset filter box time range ( #16854 )
2021-09-27 17:17:52 +03:00
48a61bacc5
fix: handle CTEs with comments on is_select ( #16769 )
2021-09-21 16:23:54 -07:00
fb4650a6eb
chore(pylint): Remove top-level disable ( #16589 )
...
* chore(pylint): Remove top-level disable
* Update examples.py
* Update command.py
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-09-15 09:30:23 -07:00
afb8bd5fe6
feat: improve embedded data table in text reports ( #16335 )
...
* feat: improve HTML table in text reports
* Remove unused import
* Update tests
* Fix test
2021-08-18 17:00:29 -07:00
ac8e54d909
fix: improve pivot post-processing ( #16289 )
...
* fix: improve pivot post-processing
* Add tests
* Trim space from column name
2021-08-17 14:41:22 -07:00
36abc51f90
fix(dashboard): unset empty time filter indicator ( #16272 )
2021-08-16 19:32:05 +03:00
d46dc9aa45
chore: upgrade mypy and add type guards ( #16227 )
2021-08-14 06:31:45 +03:00
b61c34f7c9
fix(viz): deduce metric name if empty ( #16194 )
...
* fix(viz): deduce metric name if empty
* fix unit test
2021-08-12 11:16:05 +03:00
fd80ae34a3
fix: Make sheet_name into a `ValidationInputError` ( #16056 )
...
* setup validates for name
* add error type
* fix linting
* fix test
* remove errors
* fix number
* fix test
2021-08-10 13:07:31 -04:00
2d61f15153
feat: send post-processed data in reports ( #15953 )
...
* feat: send post-processed data in reports
* Fix tests and lint
* Use enums
* Limit Slack message to 4k chars
2021-07-30 09:37:16 -07:00
f4739f427e
feat: post-processing for pivot table v2 ( #15879 )
...
* feat: add pivot v2 post-processing
* Fix lint
2021-07-29 11:05:56 -07:00
bfe7eb9a7b
feat(dbc ui): Adding Google Sheets Dynamic Form ( #15801 )
...
* feat: Make Google Sheets Dyanmic (#15576 )
* first draft
* second draft
* added tests
* first draft
* added table_catalog
* remove console.log
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* revisions
* save this for now
* working form
* save disable on public sheets
* refactor somethings
* saving this for now
* working edit
* add back query to schema
* working add
* fix styling
* fixing x
* fix linting
* prettier
* fix some type issues
* more lint fixes
* remove unused dependency
* fix linint
* fix validation
* pylint bypass
* pylint bypass
* fix this
* fix mypy
* yerp
* fix test
* fix test
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* wrap add sheets
* fix linting issues
* fix unit test
* ignore typing
* fix editting and paste issues
* remove query
* fix this
* fix test
* add test back
* fix error messaging
* update url messaging on error
* change error type
* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* add errors for sheets with no name
* fix
* fix messaging for gsheets
* stop pylint
* update line
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: Arash <arash.afghahi@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-28 15:00:27 -04:00
ea49aa3d2d
feat: add timezones to report cron ( #15849 )
...
* add timezones to report cron
* fix test
2021-07-27 18:28:24 -07:00
ab4e3b9bf9
chore: Enforce Mypy for non-tests ( #15757 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-22 06:46:43 +12:00
62a8f2e193
chore(python-testing): move memoized tests to unit tests ( #15507 )
...
* chore: move memoized test into a separated file
create integration test workflow
* chore: create unit test workflow to run purely pytest
* fix: bad reference
* fix: remove pip requirements bc there aren't any yet
* temp: install unit dependencies directly
* fix: --rootdir=
* fix: try to run only unit test
* chore: decouple memoized as separated module
* fix: bring back dependencies bc superset top-level module is coupled to flask and others so no reason no to do it
* fix: reference
* fix: pre-commit
* fix: pylint
2021-07-12 10:00:18 +03:00
4f5f9287fc
feat: validate_parameters for GSheets ( #15578 )
...
* feat: validate_parameters for GSheets
* Move import inside fixture
* Update deps
* Rename parameter
2021-07-08 08:26:39 -07:00
b5119b8dff
refactor(tests): decouple unittests from integration tests ( #15473 )
...
* refactor move all tests to be under integration_tests package
* refactor decouple unittests from integration tests - commands
* add unit_tests package
* fix celery_tests.py
* fix wrong FIXTURES_DIR value
2021-07-01 18:03:07 +03:00
Sujith Kumar S
Ville Brofeldt
Hugh A. Miles II
Dave McNulla
AAfghahi
Michael S. Molina
Erik Ritter
John Bodley
Mikhail Kumachev
Beto Dealmeida
Elizabeth Thompson
ofekisr
Christian Pfarr
Geido
Amit Miran