Commit Graph

5885 Commits

Author SHA1 Message Date
Evan Rusackas
9fe30ab71e
style: Pass at propagating (and enhancing) Button component throughout Superset (#10649)
* getting rid of weird focus/active outline ring

* Buttons... buttons _everywhere_

* linting

* Nixing views/CRUD/dataset/Button component

* fixing 2 typing errors

* fixing more TS errors

* prefer src path for include

* one more real button, one less CSS class

* one more "button" to "Button"

* Published Status is now a proper clickable Label

* nixing the CRUD button again

* touching up stories, with SupersetButton story

* SIP-34 button colors

* adding polished package to mix colors

* updating button colors to match Superset theme

* abstracting away from bootstrap-specific props (might pivot libraries soon!)

* more abstraction from bsStyle/bsSize props

* exchanging styles for a prop

* linting

* restoring feature flag to stock

* using src alias

* last <button> replacement

* this classname would never be applied

* more linting action

* fixing unsupported bsSize 'medium', and cta typing error

* more cta action

* unnecessary styles

* errant bsSize prop

* cleanup

* tweaks to make new New button work

* Linting

* fixing a couple tests

* fixing theme based test failure

* margin tweak for NEW button

* another fixed test

* another fixed test

* fixing two more tests

* fixing last broken tests.

* always be linting

* Adding tertiary/dashed buttons

* cleaning up QueryAndSave buttons

* fixing "link" button styles

* fixing/updating link button styles

* cta buttons on Modal component

* linting.

* exporting button story knobs, making ALL knobs safe for export.

* capitalizing a file... no big whoop

* Basic button tests

* renaming button - temporarily

* renaming file to fix capitalization issue

* passing theme through to a difficult popover.

* fixin' a newly busted unit test

* lint fixin'

* oops, shouldn't have changed this prop!

* adding a dive() to themedShallow, and fixing a cypress/jest test

* addressing lint stuff

* touching up stories, with SupersetButton story

* SIP-34 button colors

* updating button colors to match Superset theme

* abstracting away from bootstrap-specific props (might pivot libraries soon!)

* linting

* restoring feature flag to stock

* cleanup

* Linting

* renaming button - temporarily

* renaming file to fix capitalization issue

* oops, shouldn't have changed this prop!

* adding a dive() to themedShallow, and fixing a cypress/jest test

* addressing lint stuff

* nixing new modal button

* Fixing another popover/button issue that should break cypress

* lint 

* passing classNames through to new button (should fix some tests)

* cleaning unused classes, making cypress tests use data attrs

* fixin' the test

* fixing another class-based test with data-test attr

* no longer passing theme as prop to buttons in popovers... themeprovider is better

* outline/border tweaks!
2020-08-28 17:34:28 -07:00
Bogdan
33fa9ebff1
Covert celery tests to the pytest (#10704)
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-08-28 17:04:30 -07:00
Erik Ritter
4e01f39733
chore: update samesite config documentation (#10720) 2020-08-28 16:14:37 -07:00
ʈᵃᵢ
d3bdea3805
fix: move menu reorg logic from crud app into Menu component (#10717) 2020-08-28 13:56:01 -07:00
Ville Brofeldt
58b075bc17
fix(jinja): extract form_data from json body (#10684)
* fix(jinja): extract form_data from json body

* add test

* disable test for presto
2020-08-28 21:26:07 +03:00
Ville Brofeldt
dd0bc472e3
refactor(database): use SupersetResultSet on SqlaTable.get_df() (#10707)
* refactor(database): use SupersetResultSet on SqlaTable.get_df()

* lint

* change cypress test
2020-08-28 21:12:03 +03:00
Daniel Vaz Gaspar
3e374dab07
fix: change public role like gamma procedure (#10674)
* fix: change public role like gamma procedure

* lint and updating UPDATING with breaking change

* fix updating text

* add test and support PUBLIC_ROLE_LIKE_GAMMA

* fix, cleanup tests

* fix, new test

* fix, public default

* Update superset/config.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* add simple public welcome page

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-08-28 10:49:10 +01:00
Moriah Kreeger
c715cad48e
feat: base tabbed modal for new database CRUD UI (#10668) 2020-08-27 14:28:06 -07:00
ʈᵃᵢ
937b868321
style: add border between menu and submenu (#10698) 2020-08-27 14:15:22 -07:00
Bogdan
6ed36552e6
Use test name for the custom macros testing: (#10695)
:

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-08-27 13:12:24 -07:00
Lily Kuang
7abdf53944
fix: card view failed cypress tests (#10699) 2020-08-27 11:33:12 -07:00
Moriah Kreeger
8d94534881
style: Move security/manage navigation tabs into a settings dropdown (#10439) 2020-08-27 10:21:51 -07:00
Grace Guo
7fc227c92d
fix: shorten url with extra request parameters (#10693) 2020-08-27 09:53:20 -07:00
Bogdan
19a9bcc9c5
chore: ci Initial hive support (#10593)
* Initial hive support

* Clone hive setup

* Make hive tests work locally

* Debugging presto failure

* sleep in dataset test

* Address comments

* Address comments

* Pin ipython, exclude new pylint rules

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-08-27 09:49:18 -07:00
ʈᵃᵢ
81525c3e9d
feat(listview): set default view mode based on THUMBNAIL feature flag (#10691)
* feat(listview): set default view mode based on THUMBNAIL feature flag

* add spec

* better generic typing for ListView

* lint

* fix specs
2020-08-27 09:40:32 -07:00
Lily Kuang
bb92c1f84d
feat: chart and dashboard card list view e2e cypress test (#10669)
* card view cypress tests

* update test config

* chart filter cypress test

* move setting to superset test config

* update test description card view
2020-08-27 09:38:12 -07:00
Ville Brofeldt
aaf04cc344
fix(filter-box): don't add empty filter to filtersChoices (#10687)
* fix(filter-box): don't add empty filter to filtersChoices

* add test
2020-08-27 12:36:02 +03:00
John Bodley
8581bda2f1
chore: Fix indentation issue (#10690) 2020-08-26 20:09:09 -07:00
ʈᵃᵢ
6ff96cfc72
refactor: useListViewResource hook for charts, dashboards, datasets (#10680) 2020-08-26 15:39:18 -07:00
ʈᵃᵢ
bc0fc4ea25
fix: SubMenu css (#10682) 2020-08-26 14:00:20 -07:00
Evan Rusackas
a95e5c9327
fix: layout flexiness (#10681) 2020-08-26 09:49:58 -07:00
Ville Brofeldt
4251b4e294
feat(row-level-security): add hook for customizing form dropdowns (#10683) 2020-08-26 11:55:35 +03:00
henryyeh
a6101f72c9
fix: only call signal if executing on the main thread (#10677) 2020-08-25 16:57:58 -07:00
John Bodley
502f4db6f9
feature: Adding extra_filters to warm_up_cache (#10675)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-08-25 15:19:34 -07:00
ʈᵃᵢ
fe574fdaa7
fix(sqllab): log exceptions caused by the user as debug and not error (#10676) 2020-08-25 14:35:50 -07:00
Evan Rusackas
4b40d44b5c
style: Fancier menus, more SIP-34-ish (#10423)
* style: shinier menus

* fixing mouseover glitch

* unused import

* rm emotion-reset

* restoring default config values

* lint fixes 

* a bit more pizzaz to the underlines (max's idea), fading active background

* simplifying navtitle -> label

* RBNavDropdown  -> ReactBootstrapNavDropdown

* nixing whitespace

* replacing !importants with better selector specificity

* moving Menu LESS into Emotion

* no more border!

* fixing border issue

* language picker, account dropdown now use new dropdown component

* nixing whitespace in comment

* nixing duplicate styling

* removing borders on FAB navbar

* explicit font coloring

* linting
2020-08-24 23:16:44 -07:00
Evan Rusackas
fdfb7cdfd2
Eslint error cleanup (#10657)
* moving two console errors to logger errors

* nixing unused map index

* nixing unused param

* linting

* changing an alert to a toast

* fixing tests

* lint fix

* one letter change, just to see if iti gets CI to pass this test.
2020-08-24 14:04:27 -07:00
Ville Brofeldt
9461f9c1e0
fix(db_engine_specs): improve Presto column type matching (#10658)
* fix: improve Presto column type matching

* add optional callback to type map and add tests

* lint

* change private to public
2020-08-24 22:42:07 +03:00
Ville Brofeldt
0177c2f591
fix(db_engine_specs): mysql longtext type should not be numeric (#10661) 2020-08-24 21:24:43 +03:00
Will Barrett
52d7671204
Remove incorrect comment (#10652) 2020-08-24 10:40:36 -07:00
auxten
0f44d3edf2
Fix add chart page frontend i18n issue (#9321) 2020-08-22 21:04:18 +03:00
ʈᵃᵢ
45fee60b62
fix: remove FAB rendered menu in favor of react based one (#10401) 2020-08-21 17:19:00 -07:00
Grace Guo
aa8ff8759c
feat: use shorten url in standalone iframe (#10651) 2020-08-21 15:27:15 -07:00
ʈᵃᵢ
b86c0e5727
feat(listview): skeleton loading states for table and card collections (#10606) 2020-08-21 10:32:37 -07:00
Evan Rusackas
878f06d133
feat: Getting fancier with Storybook (#10647)
* Niftier paddings

* upgrading storybook, fixing glob pattern

* moving a couple storybook dependencies to dev dependencies

* fixing annoying lint issue about dev dependencies needing to be dependencies

* adds essential addons, fixes backgrounds

* newline tweaks

* comment about no-extraneous-dependencies, higher specificity on that rule, other linting stuff

* a *python* linter doesn't like this whitespace?!

* putting the linespace back

* ugh, found the space causing CI issues... I think
2020-08-20 22:41:25 -07:00
Maxime Beauchemin
82dda473b1
fix: dedup groupby in viz.py while preserving order (#10633) 2020-08-21 08:02:02 +03:00
Erik Ritter
cb1989a4fd
feat: bump superset-ui for certified tag (#10650) 2020-08-20 16:56:18 -07:00
ʈᵃᵢ
7301a363c1
feat: setup react page with submenu for datasources listview (#10642) 2020-08-20 11:42:17 -07:00
Erik Ritter
38da552a57
feat: add certification to metrics (#10630) 2020-08-19 20:45:33 -07:00
Ville Brofeldt
5136c5c16e
feat(viz-plugins): add date formatting to pivot-table (#10637)
* feat: make pivot table dates formattable

* Bump npm packages
2020-08-19 23:55:59 +03:00
Evan Rusackas
84d08cb8da
fix: controls scroll issue (#10644) 2020-08-19 13:19:40 -07:00
Evan Rusackas
b0380befa1
feat: Allow tests files in /src (plus Label component tests) (#10634)
* allow tests in jest confg

* sample stories for Label component

* passing tests

* stories to tsx!

* excluding knobs exports from published stories

* ts fix

* ts fix

* Label test to TS

* explicitly ignoring test files in webpack bundling

* linting stuff

* adding comment about test file exclusions
2020-08-19 12:54:26 -07:00
Lily Kuang
3f5d5cc0aa
fix: remove duplicated params and cache_timeout from list_columns; add viz_type to list_columns (#10643) 2020-08-19 11:59:16 -07:00
Evan Rusackas
d0953874f2
chore: splitting button stories into separate stories (#10631)
* splitting button stories into separate stories

* lint
2020-08-18 22:47:27 -07:00
Grace Guo
3bc79191c4
refactor: remove slice level label_colors from dashboard init load (#10603) 2020-08-18 18:10:06 -07:00
Lily Kuang
a3ac5061fe
feat: card view bulk select (#10607) 2020-08-18 18:04:36 -07:00
Evan Rusackas
ec7874ff98
style: Label styling/storybook touchups (#10627)
* colors corrected, hover/cursory only change if there's an onClick

* adding info label, breaking gallery out to its own story

* linting

* fixing bad class name

* now with fading!

* now supporting additional (non-bootstrap) label styles

* adding new secondary/primary labels to gallery

* fixing map key react warning

* using the new secondary label in the ChartList view

* linting

* fixing TS issue
2020-08-18 15:42:00 -07:00
Evan Rusackas
844b471509
fix: removing unsupported modal sizes (#10625)
* fix: removing unsupported modal sizes

* linting!

* NOT specifying bsSize seems to have the same effect as (unsupported) "medium"

* supporting 'large' and 'small' over 'lg' and 'sm'
2020-08-18 14:33:39 -07:00
Ville Brofeldt
ca5dc4256f
feat(datasource): remove deleted columns and update column type on metadata refresh (#10619)
* fix: remove missing columns on metadata refresh

* add tests

* lint and simplify

* lint

* reduce locals

* fix label style
2020-08-18 21:47:13 +03:00
Cory Zue
4ee524736d
improve documentation for country maps (#10621) 2020-08-18 09:36:35 -07:00