Commit Graph

5885 Commits

Author SHA1 Message Date
Kasia Kucharczyk a6f258747b
fix: enable pylint rules in db_engine_specs module (#10998)
* Athena.py: cretaed variable for too long line, removed disabled pylint rule.

* Enabled `line-too-long` in `drill.py`. Added variable for too long string.

* Reformatted hana.py:
- changed return statement into two lines to keep line lenght limit

* Enabling pylint rule in hive.py:
- `no-name-in-module` for pyhive in several places
- `line-too-long` and adding new lines
- `unused-import` is not invalid anymore

* Enabled `line-too-long` in `kylin.py`. Added variable for too long string.

* Enabled `unused_import` in `base.py` from db_engine_specs module.

* Enabled `unused_import` in `bigquery.py` from db_engine_specs module.

* Enabled `unused_import` in `druid.py` from db_engine_specs module.

* fix: athena datetime string converting
2020-09-22 13:44:45 -07:00
Kamil Gabryjelski e93d92e8ac
Replace reactable with DataTable from superset-ui in QueryTable (#10981)
* Replace reactable with DataTable from superset-ui in QueryTable

* Fix tests

* Fix pagination

* Fix tests
2020-09-22 13:24:30 -07:00
Kamil Gabryjelski 9f01a7fdf8
ESLint: Re-enable rule default-props-match-prop-types (#10868)
* Re-enable rule default-props-match-prop-types

* Restore default props and remove isRequired

* Remove unused props
2020-09-22 13:17:41 -07:00
Ville Brofeldt a9eab33d64
feat: add ECharts Pie chart (#10966)
* feat: introduce echarts pie chart

* lint

* remove viz.py shim

* remove tests

* fix cypress test

* fix test
2020-09-22 19:27:40 +03:00
Beto Dealmeida 0554c8918e
Enable subqueries in gsheetsdb (#10991) 2020-09-22 08:51:29 -07:00
Karthikeyan Singaravelan 95ba8e1fb7
fix: deprecation warnings due to invalid escape sequences. (#10710)
* fix: Fix deprecation warnings due to invalid escape sequences.

* fix: Fix black related errors.
2020-09-22 16:03:58 +01:00
Ville Brofeldt bd140e018a
fix(presto): default unknown types to string type (#10753)
* fix(presto): default unknown types to string type

* lint
2020-09-22 13:16:54 +03:00
Ville Brofeldt 448a41a4e7
feat(row-level-security): add base filter type and filter grouping (#10946)
* feat(row-level-security): add filter type and group key

* simplify tests and add custom list widget

* address comments

* use enum value to ensure case sensitive value is used
2020-09-22 08:54:10 +03:00
Maxime Beauchemin 3be8bdad9a
docs: add gallery screenshot & link in README (#10988)
* docs: add gallery screenshot & link in README

* deallowing large files
2020-09-21 22:48:55 -07:00
Maxime Beauchemin 8e4a1c8356
docs: add a "Gallery" page (#10968)
* docs: add a gallery page

* Adding image gallery

* linted

* add more screenshots

* a few more screenshots
2020-09-21 22:27:03 -07:00
ʈᵃᵢ 96a61e327e
build: add PR lint action (#10990) 2020-09-21 21:21:04 -07:00
Evan Rusackas 193796ca16
adding filters back that caused issues (#10989) 2020-09-21 19:12:34 -07:00
adam-stasiak-polidea dc893fe1b3
chore: selectors refactor in SQLLab test suite (Cypress) (#10944)
* changed selectors for not skipped tests in sqllab suite

* linter fixes

* linter fixes
2020-09-21 15:49:44 -07:00
Kamil Gabryjelski a8f5029cb1
ESLint: Remove ts-ignore comments (#10933)
* Upgrade json-bigint, add @types/json-bigint to deps

* Upgrade react-bootstrap-dialog

* Fix ts-ignore

* Fix ts-ignore

* Fix ts-ignore

* Upgrade react-syntax-highlighter, fix ts-ignore

* Fix ts-ignore

* Fix ts-ignore in styles.tsx

* Wrap Input in div to pass onPaste

* Change esm to cjs imports for highlighter to fix tests

* Add null checks
2020-09-21 15:47:33 -07:00
Maxime Beauchemin e4e78b66fa
style: fix checkbox color (#10970)
* style: fix checkbox color

* lint

* wrap test into theme
2020-09-21 13:12:12 -07:00
Kasia Kucharczyk 41dfcd4834
fix: changed disabled rules in datasets module (#10979)
* Updated `put` method in `datasets/api.py`:
- changed return statements in put method
- removed disabled pylint rule too-many-return-statements
- removed disabled pylint rule arguments-differ since arguments match

* Removed disabled pylint rule arguments-differ in `delete()` method since arguments match
2020-09-21 12:26:17 -07:00
Moriah Kreeger 4aa53244c7
fix: update the time filter for 'Last Year' option in explore (#10829)
* Update explore time filter ranges

* rm console statements

* only update moment calculation for years

* tests

* add open/close test
2020-09-21 11:39:11 -07:00
Bogdan 56d001835e
fix: use nullpool even for user lookup in the celery (#10938)
* Use nullpool even for user lookup in the celery

* Address feedback

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-09-21 10:34:03 -07:00
Bogdan 801fb4063c
Allow empty observations in alerting (#10939)
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-09-21 08:48:02 -07:00
Kasia Kucharczyk 74a2270d0a
fix: re-enabling several globally disabled lint rules (#10957)
* Removed global pylintrc rule: bad-continuation. Black repaired it.

* Enable global pylintrc rule: duplicate-code. It might help with providing clean code and future refactors.

* Removed global rule `dict-iter-method` since Python3 doesn't support methods: dict.iterkeys(), itervalues() or iteritems()

* Removing global disabler rule `invalid-unary-operand-type`, because all unary operators are used on objects which supports those operations
2020-09-21 08:47:04 -07:00
Kasia Kucharczyk f01c488664
fix: setting specific exceptions common/query_context.py (#10942)
* Specified an exceptions in reading cache in `get_df_payload()` method

* Reverted change after review:
- added broad exception in `get_df_payload` method
2020-09-21 08:46:08 -07:00
Kasia Kucharczyk 88a671153b
Pylint disabled rule `pointless-string-statement` is not raising warining anymore - removing (#10975) 2020-09-21 08:45:21 -07:00
Kasia Kucharczyk 9d7b3536e1
fix: pylint disabled rules in dashboard/api.py (#10976)
* Refactored `put` method in dashboards/api.py:
- changed retun statements
- removed lint disabled rule

* `arguments-differ` disabled rule is not anymore valid - put argiments don't differ

* `delete()` method in dashboards/api has now same list of argiments:
- removing unecessary pylint check disabled

* `bulk_delete()` method in dashboards/api has now same list of argiments:
    - removing unecessary pylint check disabled
2020-09-21 16:02:41 +01:00
Kasia Kucharczyk fd0f6e1541
fix: removed disabled lint rule `too-many-locals` in connectors/base/models.py (#10958) 2020-09-21 09:13:38 +01:00
Kamil Gabryjelski 4835d3b0a2
ESLint: Re-enable rule no-access-state-in-setstate (#10870)
* Re-enable rule no-access-state-in-setstate

* Move accessing event values out of async functions
2020-09-20 23:48:23 -07:00
Ville Brofeldt 3d8f757ac8
fix: simply is_adhoc_metric (#10964)
* fix: simply is_adhoc_metric

* address comment
2020-09-20 13:22:55 +03:00
Kamil Gabryjelski 557a303cc5
ESLint: Enable rule no-named-as-default (#10879)
* Enable rule no-named-as-default

* Fix wrong import
2020-09-18 13:41:01 -07:00
Kamil Gabryjelski 91fd06e093
ESLint: Remove ts-ignore (#10961)
* Fix prop types of styled

* Fix props in windowed
2020-09-18 13:33:32 -07:00
Srini Kadamati 4a4fdb1e02
docs: set up client-side redirects from previous era docs urls (#10921)
* one simple redirect, as a test

* adding license to header

* painstakingly added SEO redirects!

* addressed feedback and ran lint-fix!

* lets try newline again!

* Revert "lets try newline again!"

This reverts commit 20f89bd23c.

* Revert "Revert "lets try newline again!""

This reverts commit e441edc54a.

* wait... there were TWO newlines?

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-09-18 13:31:22 -07:00
Evan Rusackas d4f33cc9de
Ignore '/docs' on some GH actions, give docs its own action (#10949)
* ignore docs on several actions, give docs its own action

* Random doc change to see if the new action runs.

* umm... not paths-ignore, paths!

* eof fix

* enabling typescript checking on docs
2020-09-18 12:23:48 -07:00
Jesse Yang 4f607371e5
fix: typo in prefer typescript (#10959)
Prefer TypeScript has stopped working since #10170 because of a [typo](https://github.com/apache/incubator-superset/pull/10170/files#diff-0f1a9bbd1316e385c51f8aba1583bd99R24) in `jq` script.

Also fix the `trilom/file-changes-action` GH Action version so the process can be more predictable.
2020-09-18 12:02:09 -07:00
Kamil Gabryjelski ccfd293227
ESLint: no-restricted-syntax (#10889)
* Enable no-restricted syntax rule

* Fix webpack.config.js

* Remove unused function from utils/common.js

* Refactor triple nested for loop

* Fix loops in src/explore components

* Fix loops in SqlLab components

* Fix loops in AlteredSliceTag

* Fix loops in FilterableTable

* Add fixtures and uinit tests for findControlItem

* Add license
2020-09-18 09:05:57 -07:00
Kasia Kucharczyk 2003442b32
fix: several disabled pylint rules in models/helpers.py (#10909)
* Removed conflicting lint and isort check in model helpers seems it's not appearing anymore

* Removed disabled linting for accessing private method. `parent_foreign_key_mappings` becomes public because it is accessed by other instance than `self`.

* Updated model's helper - removed unecessary exception and replaced with check while accessing global context to reset ownerships.

* Updated model's helper - renamed unused attribute to private in user link method.

* Updated model's helper - added specific exception for adding extra json column. Removed disabled pylint rule.

* Applied changes after review to `models/helpers.py`:
- removed unecesary function's param rename
- added extra JSON content in exception

* Removed self.extra_json content from exception message.
2020-09-18 16:32:02 +01:00
Daniel Vaz Gaspar e375ed4678
fix(jinja): make context attrs private on SQL templates (#10934)
* fix(jinja): make SQLAlchemy models private on SQL templates

* add missing privates

* fix test
2020-09-18 12:56:07 +01:00
Kasia Kucharczyk e21a354b3b
fix: update pylint disabled checks in common/query_context.py (#10941)
* Updated common/query_context.py
- removed disabled pylint rule no-self-use from `df_metrics_to_num` since it has `@staticmethod`
- applied black on the file

* Removed disabled lint check `too-many-locals` in get_df_payload method. Applied black.

* Method `get_data()` has self param:
- removing # pylint: disable=no-self-use
- autoformatting
2020-09-17 21:30:02 -07:00
Kasia Kucharczyk 141ef4a188
Updated `type: ignore` in model's helper: (#10906)
- added sql alchemy mapper as a type
2020-09-17 13:49:14 -07:00
Elizabeth Thompson ed9b50be2c
chore: upgrade cypress to use retries (#10923) 2020-09-17 12:54:50 -07:00
ʈᵃᵢ 213b772368
chore: remove SIP_34_DATABASE_UI (#10926) 2020-09-17 12:53:00 -07:00
Kasia Kucharczyk d6be977d1b
fix: address all disabled pylint checks in charts/api.py (#10932)
* Refactored put in charts/api.py to have less return statement. Removed pylint rule too-many-return-statements

* Refactored data() in charts/api.py to have less return statement. Removed pylint rule too-many-return-statements

* Pylint disabled arguments-differ check is not necessary anymore in put method

* Pylint disabled arguments-differ check is not necessary anymore in delete method

* Pylint disabled arguments-differ check is not necessary anymore in bulk_delete method. Applied black
2020-09-17 17:31:44 +01:00
Kasia Kucharczyk 8735a14ea7
Removed global pylintrc rule: old-ne-operator. Which is not applicable in code anymore. (#10915) 2020-09-17 06:47:52 -07:00
Ville Brofeldt 69081009d3
fix(legacy-druid): undefined filter key (#10931) 2020-09-17 15:10:06 +03:00
Moriah Kreeger 5623cd64ca
feat: update saved query backend routing + add savedquery list (#10922)
* Update saved query backend routing + add savedquery list

* add spec fileg

* add FE flag for SIP_34_SAVED_QUERIES_UI
2020-09-16 21:08:40 -07:00
Kasia Kucharczyk cd77797802
Removed disabled linting redefined-outer-name. Url parameters are renamed where url was already defined in class attributes (#10911) 2020-09-16 20:22:46 -07:00
Yongjie Zhao af75bee582
feat: adding dashboard toggle fullscreen button (#10840) 2020-09-16 14:20:52 -07:00
Elizabeth Thompson a3519b42cb
fix lint errors (#10918)
Co-authored-by: Elizabeth Thompson <elizabeth@preset.io>
2020-09-16 13:42:27 -07:00
Yongjie Zhao 5099dbef6b
fix: babel script broken by format string (#10902) 2020-09-16 13:35:35 -07:00
Rob DiCiuccio d74044c2e6
Update FOSSA configuration for new requirements layout (#10848)
* Update FOSSA configuration

* test FOSSA failure

* Update FOSSA files changed regex

* Revert "test FOSSA failure"

This reverts commit a97213db78.

* pre-commit linting

* remove docker.txt check
2020-09-16 13:28:04 -07:00
Kamil Gabryjelski 281305e0cf
Enable anchor-has-content rule (#10908) 2020-09-16 13:27:52 -07:00
Evan Rusackas 2a5946d117
docs: Client side redirects (one POC) (#10898)
* one simple redirect, as a test

* adding license to header
2020-09-16 13:24:26 -07:00
Elizabeth Thompson 0d90bc9920
chore: update port that cypress runs on for local vs test (#10847) 2020-09-16 12:31:03 -07:00