Commit Graph

942 Commits

Author SHA1 Message Date
Kamil Gabryjelski
39c96d0568
chore: Migrate .less styles to Emotion (#22474) 2023-01-19 09:17:10 +01:00
Lyndsi Kay Williams
c87f654901
feat: Enable new dataset creation flow (#22610) 2023-01-17 20:05:40 -06:00
Cody Leff
f5c404fc51
fix(explore): Restore missing dataset states (#22693) 2023-01-13 09:42:38 -07:00
Artem Shumeiko
f3696ceef3
chore: Localization of several charts and elements (#22150)
Co-authored-by: ashumeiko <ashumeiko@ashumeiko.com>
2023-01-11 09:42:54 -07:00
Ville Brofeldt
08f45ef207
fix(viz-gallery): respect denylist in viz gallery (#22658) 2023-01-10 19:08:30 +02:00
Ville Brofeldt
5b2ca97341
fix(sqllab): remove link to sqllab if missing perms (#22566) 2023-01-09 14:02:36 +02:00
EugeneTorap
30dab3a00a
chore: Bump flask libs (#22355) 2023-01-09 10:10:31 +00:00
Musa Hamada
c2ace8dacb
fix(explore): datasource_type typo (#22543)
Co-authored-by: musa.hammadi <musa.hammadi@infostrategic.com>
2022-12-31 10:00:58 +00:00
John Bodley
9e81c3a119
feat: update time comparison choices (again) (#22458) 2022-12-24 10:13:35 +13:00
Hugh A. Miles II
9b26794419
chore: Update dataset_id & dataset_type datasource_id & datasource_type for SPA explore (#22461) 2022-12-22 19:46:00 -05:00
Lyndsi Kay Williams
fa919f3d8c
test: Fix act errors in VizTypeControl test (#22424) 2022-12-15 10:27:07 -06:00
Ville Brofeldt
012d1300c1
chore(viz): rename v1 and v2 charts (#22369) 2022-12-09 22:51:37 +02:00
Geido
f64423a740
fix: Time filter position and click in Horizontal FilterBar (#22338) 2022-12-08 10:58:16 +01:00
Anthony Gainor
0dbaaad83d
feat(explore-popover): Show disabled 'Save' button in explore popover (#21318)
Co-authored-by: Herbert Gainor <herbert.gainor@preset.io>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2022-12-07 12:25:54 -05:00
Lyndsi Kay Williams
4cf40fb286
test: Fix act errors in FixedOrMetricControl test (#22334) 2022-12-06 07:27:02 -06:00
Kamil Gabryjelski
2d30e9cbe9
feat: New time range label (#22317) 2022-12-05 19:46:15 +01:00
Yongjie Zhao
0fdc520797
fix: the TimePicker overlay the AdhocFilter (#22234) 2022-11-28 17:12:40 +08:00
Yongjie Zhao
22fab5e58c
feat: Axis sort in the Bar Chart V2 (#21993) 2022-11-26 22:06:26 +08:00
Kamil Gabryjelski
d1e576cbd1
fix(explore): Prevent infinite rerenders when editing dataset (#22219) 2022-11-25 16:00:21 +01:00
Kamil Gabryjelski
1809d2b957
fix(explore): Value undefined and Unhashable type errors (#22207) 2022-11-23 20:45:10 +01:00
Maxime Beauchemin
888f43c6ad
chore: rename 'Change dataset' action to 'Swap dataset' (#22197) 2022-11-23 10:19:59 -08:00
Daniel Vaz Gaspar
a77b2d6ebf
chore: remove annotation layer FAB CRUD model view (#22178) 2022-11-22 16:19:57 +00:00
Corbin Robb
cdec09243b
test: Fix act errors in DndColumnSelectControl tests (#22068) 2022-11-08 16:24:43 -05:00
Lyndsi Kay Williams
7a52b22237
test: Fix act errors in DndMetricSelect test (#22048) 2022-11-07 12:33:57 -06:00
Michael S. Molina
7d1df3b78d
feat: Improves SafeMarkdown HTML sanitization (#21895) 2022-11-04 10:34:02 -04:00
Yongjie Zhao
429f246f7a
refactor: clean up codes (#22002) 2022-11-03 00:16:10 +08:00
Yongjie Zhao
a9b229dd1d
feat: support mulitple temporal filters in AdhocFilter and move the Time Section away (#21767) 2022-11-02 08:21:17 +08:00
Ville Brofeldt
dc7399540b
chore: bubble up more db error messages (#21982) 2022-11-01 07:54:27 +02:00
Anthony Gainor
7f563cf92d
chore: Remove several React app console warnings and errors v2 (#21725)
Co-authored-by: Herbert Gainor <herbert.gainor@preset.io>
2022-10-28 19:08:10 +08:00
Kamil Gabryjelski
3c7a081281
fix(explore): Small changes in metadata bar copy and tooltip placement (#21952) 2022-10-28 11:40:18 +02:00
Kamil Gabryjelski
9d25453425
fix(explore): Chart save modal displays error instead of failing silently (#21920) 2022-10-27 23:30:59 +02:00
Geido
fa67315f5b
fix: Default temporal column in Datasource (#21857) 2022-10-25 14:42:11 +03:00
Geido
c2834cc14c
chore: Remove CROSS_REFERENCES feature flag (#21815) 2022-10-21 15:11:49 +03:00
Usiel Riedl
9a063abb3b
feat(explore): add config for default time filter (#21879)
Co-authored-by: Usiel Riedl <usiel.riedl@automattic.com>
2022-10-20 20:09:51 +08:00
Kamil Gabryjelski
cddc361adc
feat(explore): Don't discard controls with custom sql when changing datasource (#20934) 2022-10-19 15:29:38 +02:00
Andrew
df7840c041
chore: Added translate functions (#21816) 2022-10-19 09:54:16 +08:00
Stephen Liu
7a7181a244
feat(color): color consistency enhancements (#21507) 2022-10-17 17:01:20 +08:00
Eric Briscoe
2258fbf878
fix(CustomFrame): Resolves issue #21731 where date range in explore throws runtime error (#21776) 2022-10-13 09:52:35 -07:00
Michael S. Molina
11d7d6e078
fix: Preserve unknown URL params (#21785) 2022-10-12 15:52:36 -07:00
Yongjie Zhao
8f74e46d45
fix: regression in #21766 (#21782) 2022-10-12 19:28:55 +08:00
Yongjie Zhao
8f61e3c5d9
refactor: preparation for time section migration (#21766) 2022-10-12 08:38:30 +08:00
Antonio Rivero Martinez
605b6920a6
fix(datasets): Stop showing alert when saving from query (#21442) 2022-10-11 10:24:11 -07:00
Cody Leff
070b865e32
chore(explore): Add tests for getControlValuesCompatibleWithDatasource (#21744) 2022-10-11 08:31:46 -03:00
JUST.in DO IT
35d9cb38a8
fix(explore): chart link is broken without localStorage (#21707) 2022-10-07 15:11:04 -03:00
Michael S. Molina
200bed6f7e
feat: Shows related dashboards in Explore (#21685) 2022-10-07 12:59:49 -03:00
Victor Arbues
ebd75366c0
feat(chart): add feature flag that displays the data pane closes by default (#21649) 2022-10-05 15:34:03 +08:00
Evan Rusackas
4245bc3f38
chore(style): Enforce optional chaining (#21614) 2022-10-03 09:17:20 -06:00
Anthony Gainor
3edc656f20
fix(explore): Dashboard list is unsorted in save modal (#21317)
Co-authored-by: Herbert Gainor <herbert.gainor@preset.io>
2022-10-03 17:16:35 +03:00
Michael S. Molina
0dda5fe1cf
feat: Adds the MetadataBar to the Explore header (#21560) 2022-09-29 14:34:57 -03:00
Michael S. Molina
bb1cf7f145
refactor: Organizes the Select files (#21589) 2022-09-27 08:38:06 -03:00
Cody Leff
954fc89871
fix(explore): Fix datasource switch for table chart (#21544) 2022-09-26 10:39:28 -07:00
Michael S. Molina
bbac67a2dc
refactor: Rewrites ColorSchemeControl with Typescript (#21496) 2022-09-22 08:29:02 -03:00
Cody Leff
6644a84f79
fix(explore): fix chart save when dashboard deleted (#21497) 2022-09-20 13:49:31 -06:00
cccs-RyanK
4fcc1d952f
chore: Extract common select component code (#21094) 2022-09-15 09:57:37 -03:00
Cody Leff
2285ebe72e
fix(explore): Prevent shared controls from checking feature flags outside React render (#21315) 2022-09-14 20:41:47 +02:00
Lyndsi Kay Williams
4ad1de3be5
test: Fix act errors in ExploreChartPanel test (#21456) 2022-09-13 13:29:31 -05:00
Yongjie Zhao
eb4ba5b089
fix: should be able to remove selection from X-AXIS control (#21371) 2022-09-13 21:05:07 +08:00
Ville Brofeldt
e1e9fda72b
fix: remove extras from all adhoc_filters controls (#21450)
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
2022-09-13 15:52:21 +03:00
Jesse Yang
1084bde2cc
fix(dashboard): JS error when editing charts (#21422) 2022-09-12 07:43:48 -07:00
Stephen Liu
d28909d56c
fix(explore): disable resize bar when the results area is collapsed (#21366) 2022-09-12 08:37:50 -06:00
Lyndsi Kay Williams
cf7c420e01
test: Fix act errors in CustomFrame test (#21427) 2022-09-12 09:39:08 -03:00
Lyndsi Kay Williams
210a2b9053
test: Fix act errors in DndFilterSelect test (#21429) 2022-09-09 20:28:46 -05:00
Lyndsi Kay Williams
2c7da649e4
test: Fix act errors in DndColumnSelect test (#21428) 2022-09-09 20:28:21 -05:00
Lyndsi Kay Williams
3819d5154a
test: Fix act errors in DatasourceControl test (#21426) 2022-09-09 20:27:50 -05:00
Lyndsi Kay Williams
69d3a336b4
test: Fix act errors in AnnotationLayer test (#21423) 2022-09-09 20:27:21 -05:00
Lyndsi Kay Williams
c7c6149f4a
test: Fix act errors in CollectionControl test (#21421) 2022-09-09 20:26:31 -05:00
Lyndsi Kay Williams
d3f9fbb5f9
test: Fix act errors in DatasourcePanelDragOption test (#21410) 2022-09-09 13:10:59 -03:00
Lyndsi Kay Williams
2f8cc44c5d
test: Fix act error in FilterInput test (#21407) 2022-09-09 13:10:41 -03:00
Lyndsi Kay Williams
3197cc6eaa
test: Fix act errors in DatasourcePanel test (#21409) 2022-09-09 08:34:50 -03:00
Lyndsi Kay Williams
bd1abd3b6e
test: Fix act errors in SamplesPane test (#21406) 2022-09-09 08:33:14 -03:00
Lyndsi Kay Williams
295de2d098
test: Fix act errors in ResultsPaneOnDashboard test (#21404) 2022-09-09 08:32:46 -03:00
Lyndsi Kay Williams
fdae29b0f0
test: Fix act error in DataTablesPane test (#21403) 2022-09-09 08:32:10 -03:00
Lyndsi Kay Williams
d635566c16
test: Fix act errors in ExploreChartHeader test (#21402) 2022-09-09 08:31:33 -03:00
Lyndsi Kay Williams
6fad3f9a35
test: Fix act error in ExportToCVSDropdown test (#21401) 2022-09-09 08:30:46 -03:00
Lyndsi Kay Williams
9318e269b1
test: Fix act error in PropertyModal test (#21400) 2022-09-09 08:30:01 -03:00
Lyndsi Kay Williams
714196e745
test: Fix act errors in ControlPanelsContainer test (#21398) 2022-09-09 08:29:23 -03:00
Lyndsi Kay Williams
ac114cae48
test: Fix act errors in ExploreChartPanel test (#21397) 2022-09-09 08:28:47 -03:00
Cody Leff
875e9f8a04
fix(dashboard): Fix scrolling on "View as table" modal (#21282) 2022-09-07 10:16:16 +08:00
aehanno
c382d53478
fix: Add locale for DatePicker component (#20063)
Co-authored-by: Kevin Dethelot <kevin.dethelot@kosmos.fr>
Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
2022-09-07 10:10:05 +08:00
Zef Lin
9be4870c7f
feat: only show active user for chart/dashboard/datasource owner drop… (#20837) 2022-09-06 19:17:50 +01:00
Shubham Sinha
b354f2265a
fix(dev-server run): Check for environment tag not being undefined (#21232)
* fixed local dev-server run

* removed console log

* removed console log
2022-08-30 14:51:32 +08:00
Geido
f017f98b88
chore: E2E tests for the Drill to detail modal (#21187)
* Add example ECharts Dashboard

* [WIP] E2E test

* Add echarts interactions

* Lint

* DRY
2022-08-29 11:25:27 +03:00
Hugh A. Miles II
c61a507e14
fix: add back custom sql filtering with Query as source (#21190) 2022-08-26 19:12:21 -07:00
Lyndsi Kay Williams
6094274f0b
feat: Create dataset blank state (#21058)
* beginning of routing

* elizabeth review

* changed folder layout

* Dataset layout setup

* Fix DatasetLayout test

* Fixed height issue

* Fix link to sqllab

* Fix DatasetPanel test

* Remove arbitrary right panel

* Add empty state SVGs

* Restructure/rename some Dataset files

* Fixed styling issue

* Fix background color

* Fix header border

* Fix empty DatasetPanel styles

* Adjust description rendering in DatasetPanel to fix tests

* Add spaces back to blank dataset description to fix tests

* Fix blank dataset description styles

Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
2022-08-22 18:45:03 -05:00
Geido
756ed0e36a
feat: Add label and tooltip for the color schemes control (#21040)
* Add tooltip

* Remove title

* Add license

* Enhance E2E tests

* Update tests

* Lint and test fixes

* Enhance layout
2022-08-22 10:44:15 +03:00
Kamil Gabryjelski
55304b02cd
fix(explore): Filters with custom SQL disappearing (#21114)
* fix(explore): Filters with custom SQL disappearing

* Fix adhoc filter for query b disappearing

* Improve test coverage
2022-08-17 22:15:41 +02:00
Yongjie Zhao
dfe5a04938
fix: unable to show view as table modal (#21025) 2022-08-10 11:35:06 +08:00
Elizabeth Thompson
463406ff09
fix: save dataset and repopulate state (#20965)
* save dataset and repopulate state

* disable dashboard button if dataset is missing

* fix error message

* fix tests
2022-08-05 14:32:49 -07:00
Kamil Gabryjelski
9350bbafee
fix(explore): Replace url search params only if current page is Explore (#20972)
* fix(explore): Replace url search params only if current page is Explore

* Add unit test
2022-08-05 16:59:52 +02:00
Phillip Kelley-Dotson
fa416fa130
fix: remove extra line for link (#20959)
* fix: remove extra line for link

* add space
2022-08-04 13:29:07 -04:00
Antonio Rivero Martinez
e2206a7151
Annotations: (#20720)
- Fix scrollbar when removing annotations
2022-08-02 14:31:48 -06:00
Diego Medina
dd353ca86a
feat: Add resize drag handle to Dataset SQL fields (#20670)
* feat: Add resize drag handle to Dataset SQL fields

* PR comments
2022-08-02 14:13:14 -06:00
Eric Briscoe
1a8c28db3d
Fixes issue where type query datasource had incorrect time controls when datasource type was 'query' (#20923) 2022-07-29 18:14:03 -04:00
Hugh A. Miles II
0d8889dc9c
fix: Save dataset + chart when Chart source is Query (#20880)
* feat: save dataset savemodal

* fix lint

* add comments

* enable chart power query

* clean up

* added test

* fix overwrite

* add proper error messaging for save datasetModal

* lint

* fix ts lint

* fix

* Disables Save button while network call is in progress, removing second Chart saved toast message

* change naming

* err

* Update superset-frontend/src/explore/components/SaveModal.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Update SaveModal.tsx

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-07-29 17:30:28 -04:00
Cody Leff
e7acb1a79d
chore(explore): update Explore icons and icon colors (#20612)
* Update Explore icons and icon colors.

* Change shade of blue and make blue only appear when fields have never been filled in.

* Fix Cypress test.

* Update non-error validation color from blue to yellow.

* Unpack ternary.

* Replace direct AntD imports with our Icons component.
2022-07-29 09:05:15 -06:00
Phillip Kelley-Dotson
2f3e11db66
feat: blankstate metrics columns (#20755)
* add POC ExploreMixin

* Working POC
> columns are loading into page

* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Visual updates to explore datasource panel

* Temporarily make Query icon visible

* Remove Query icon visibility

* Removed isValidDatasourceType check

* Added Query preview Modal from DatasourceControl if the data source type is Query [41493]

Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component

* > fix integration point with frontend
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working

* Adjusts conditional logic approach to be extensible for additional types from DatasourceTypes options

* refactor

* set field for sql

* Fixes issue where Missing query parameters error was showing in datasourcePanel

* add query_language

* fix ds main_dttm

* Fixes issue where menu.tsx was blocking access to redux debugging for SqlLab and Explore

* Fixes issue where database id was not available to save query as dataset, adds default metric when chart source is query

* oops

* fix pre-commit to 50 errors now

* fix circuliar dep

* Disables showing Metrics section in DatasourcePanel when Query is the datasource

A follow on separate effort will enable having a default Count metric when Query is the datasource type

* adds condition to use query.columns if query.results is not present enable saving query as a dataset

* down to 26 now

* patch for pre-commit

* one more pre-commit

* added explore_json error

* added error messages

* add for metrics

* add text for columns

* add model open/close method

* add propogation and methods

* change link to span

* lint fix

* Fixes frontend lint and TypeScript errors unit test fixes will be next commit

* Aditional TypeScript error fix

* Fixes unit test failure

* fix some types

* added frontend piece

* fix type

* Fixes bad import caused by merge from master and removes duplicate showSaveDatasetModal check

* Fixes for DartasourceControl Test Suite

* Fix lint error

* Fixes unit test issues due to array instead of a component being passed to modal footer

* Fixes unit test failure for DatasourceControl and simplifies getDatasourceTitle based on PR comment

* fix ts

* pylint

* core_test fix

* Fixes line error post merge from master

* fixed from master

* fixed from master

* Fixes issue where Overwrite dataset does not work due to userid error

SPA refractor changed Redux structure that is used when in explore (which is now within SPA).  user object is at the root of the store now for anything under SPA.

* Resolves TypeScript errors with changes made for SPA merging in and changes needed for overwriting dataset from SaveDatasetModal

* fix: top right panel view query functionality

* remove unneeded code from core.py

* working samples endpoint for query

* add owner check

* update FE for it

* handle columns are dict vs object

* fix exceptions

* fix fe lint

* fix test

* add tab_name to payload

* Enables use of tab name from Query

* fix cypress test

* save columns on execution

* fix frontend build test

* remove parathesis around columns

* changing column types

* fixing samples that has literal_columns

* address comments

* add changes

* fix path

* fix merge

* fix types

* remove console

* add type

* fix linting

* update to enum

* fix test

* remove explore from buttons

* fix logic

* fix logic

* oops

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-07-26 14:32:30 -04:00
Geido
a69f016bca
chore: Feature flag for embedding charts (#20804)
* Add EMBEDDABLE_CHARTS feature flag

* Pretty

* Update test
2022-07-26 17:55:44 +03:00
Yongjie Zhao
cb9ae38361
fix: switch form_data between different datasource (#20867) 2022-07-26 22:13:17 +08:00
Kamil Gabryjelski
5c2c2e8040
feat(explore): UX changes in fast viz switcher (#20848)
* feat(explore): UX changes in fast viz switcher

* Fix test
2022-07-26 08:44:17 +02:00
Diego Medina
5d107b86ab
fix: explore warnings cleanup (#20864) 2022-07-26 13:28:50 +08:00