Cody Leff
76e57ec651
feat(dashboard): menu improvements, fallback support for Drill to Detail ( #21351 )
2022-10-19 18:34:46 -03:00
John Bodley
eac6fdcd29
chore(sqllab): Cleanup /tables/... endpoint ( #21284 )
2022-09-13 08:22:12 -07:00
Geido
1d3a805a61
chore: Drill to detail Modal tests ( #21148 )
...
* Add DrillDetailModal test
* Add DrillDetailPane tests
* Add TableControls test
* Lint
* Enhance SliceHeaderControls tests
* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-08-29 14:22:15 +03:00
Kamil Gabryjelski
0945d4a2f4
feat: Pass dashboard context to explore through local storage ( #20743 )
...
* feat: Pass dashboard context to explore through local storage
* Remove console log
* Remove unused local storage keys
* Fix lint
* Fix link
* Fix UT
* fix lint
* fix prettier
* Fix bug
* Fix bug with some sample dashboards
* Roll back unnecessary change
* style fix
* Add comments
* Fix lint
* Address code review comments
* Fix
2022-07-25 16:44:43 +02:00
Cody Leff
84d4302628
fix(explore): Fix chart standalone URL for report/thumbnail generation ( #20673 )
...
* Update explore URLs.
* More URL fixes.
* Make frontend accept true/false query params case-insensitively.
* Fix URL mistake.
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-07-19 13:53:55 -03:00
Cody Leff
edb1383bf8
chore(dashboard): Resolve form_data vs. formData in dashboard redux state
2022-06-30 18:49:18 +08:00
Evan Rusackas
76b4a14d30
chore(config): Migrating ENABLE_JAVASCRIPT_CONTROLS
from app config to a feature flag ( #19113 )
...
* first pass migrating config to ff
* nixing a console log from testing
* adding an entry to `UPDATING.md`
* linting ✨
* Adding ENABLE_JAVASCRIPT_CONTROLS to FEATURE_FLAGS.md
* no longer in need of state!
* Turning the flag back off
* linting... le sigh
* and more linting...
2022-03-14 08:54:02 -06:00
Kamil Gabryjelski
3c1fb944c1
perf(dashboard): Improve performance of complex dashboards ( #19064 )
...
* perf(dashboard): Improve performance of filter indicators
* Improve perf of cross filters
* Rename old function
* Fix undefined
* fix type
* fix tests
* fix undefined
* Address code review comments
* Address code review comments
2022-03-09 22:39:58 +01:00
Michael S. Molina
06e1e4285e
feat: Adds support to multiple dependencies to the native filters ( #18793 )
...
* chore(native-filters): Remove cascading popovers from filter bar
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-03-04 13:06:10 -03:00
simcha90
bcad1acec2
feat: Dynamic dashboard component ( #17208 )
...
* fix:fix get permission function
* feat: dynamic loading of dashboard components
* fix: revert image
* fix: fix py
* fix: fix py
* fix: pass state to dynamic component
* lint: add typing
* lint: fix lint
* lint: fix lint
* refactor: re-run pipeline
* fix: fix CR notes
* fix: fix CR notes
* move types and interfaces to core
* reorder exports
* rename Scope and Target
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-02-09 17:44:40 +02:00
Michael S. Molina
bb7e979142
chore: Moves spec files to the src folder - iteration 9 ( #17901 )
2022-01-07 15:23:57 -03:00
Beto Dealmeida
63d9693f21
feat: add main datetime column to dataset editor ( #17739 )
...
* feat: add main dttm col to dataset editor
* Add tests
2021-12-14 14:47:08 -08:00
Yongjie Zhao
9070b6b19c
refactor(monorepo): stage 1 ( #17427 )
...
* skip geojson in pre-commit
update prettier
* update package.json
update package.json
u package
pkg
pkg2
* lint main repo 2
lint main repo
lint
* lintrc
lintrc 2
lintrc2
lintrc 3
lintrc
* fix import
* refresh lock file
* fix break line make @ts-ignore invalid
* update rat-excludes
rat-excludes
update rat-excludes
* update eslintrc.js
* lint lint lint
2021-11-17 15:31:36 +08:00
Ajay M
65f1644208
feat(dashboard): Add description to the native filter ( #17025 )
...
* Adding description works
* Add some tests
* Fix tests
* Styled look good
* Tests successful
* Address PR comments
* fix a test
2021-10-27 11:45:31 -07:00
Ajay M
9e6d5fc775
feat(dashboard): Let users re-arrange native filters ( #16154 )
...
* feat. flag: ON
* refactor filter tabs
* WIP
* Drag and Rearrange, styling
* refactoring dnd code
* Add apache license header
* Fix bug reported during PR review
* Minor fix on remove
* turn off filters
* Fix status
* Fix a test
* Address PR comments
* iSort fixes
* Add type key to the new filters
* Fix wrong attribute
* indent
* PR comments
* PR comments
* Fix failing tests
* Styling
* Fix remove filter
* Fix the drag issue
* Save works
* fix
* Write tests
* Style changes
* New Icon
* Grab & Grabbing Cursor
* Commented out code
* Fix tests, fix CI
* Fix failing tests
* Fix test
* Style fixes
* portal nodes dependency
* More style fixes
* PR comments
* add unique ids to collapse panels
* Filter removal bug fixed
* PR comments
* Fix test warnings
* delete filter tabs
* Fix the breaking test
* Fix warnings
* Fix the weird bug on cancel
* refactor
* Fix broken scope
2021-10-15 16:56:33 -07:00
Hugh A. Miles II
959fd763a8
fix: Owners selection in dataset edit UX ( #17063 )
...
* boilerplate
* update owner select component
* this is working
* update onchange
* refactorig
* you need to useMemo or things break
* update test
* prettier
* move logic into bootstrap data endpoint
* address concerns
* oops
* oops
* fix test
2021-10-12 20:27:56 -04:00
Michael S. Molina
1ab36c94f3
chore: Moves spec files to the src folder - iteration 7 ( #16943 )
2021-10-04 10:56:49 -03:00
Michael S. Molina
9b17e86b44
chore: Moves messageToasts to the components folder ( #14431 )
...
* chore: Moves messageToasts to the components folder
* Rebases
2021-09-22 07:44:54 -03:00
Ajay M
4b70d46355
feat(dashboard): Native filters - add type to native filter configuration ( #16549 )
...
* iSort fixes
* Add type key to the new filters
* Fix wrong attribute
* PR comments
* PR comments
* Fix failing tests
2021-09-09 09:46:44 -07:00
Lyndsi Kay Williams
518c3c9ae0
test: Functional RTL for email report modal II ( #16148 )
...
* Email Report Modal validation testing
* Starting RTL testing for email report
* Calendar icon now rendering!
* Create report testing in dashboard
* make linter happy
* Fixing weird error
* Removed ExploreChartHeader_spec
* Fixed dashboard header test
* revert changes from merge
* Fix tests
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-20 10:08:36 -07:00
Elizabeth Thompson
5031a67597
feat: Self subscribe reports ( #16027 )
...
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-08-02 09:12:09 -07:00
Ville Brofeldt
f286647140
chore(native-filters): remove instant filtering option ( #15365 )
...
* chore(native-filters): remove instant filtering option
* fix test
2021-07-01 13:38:56 +03:00
Ville Brofeldt
b3cdff4995
fix(native-filters): show default text on filter scoping tree ( #15351 )
2021-06-24 11:01:24 +03:00
Kamil Gabryjelski
c7c63751e9
feat(native-filters): Hide time filters if loaded datasets don't have temporal columns ( #15225 )
...
* feat(native-filters): Hide time filters if loaded datasets don't have temporal columns
* Remove "px" suffixes to fix warnings
* Disable an option instead of hiding filter types
* Fix tests
* Add 2 more tests
2021-06-17 16:51:11 +02:00
Elizabeth Thompson
21aa3daae3
display all metric results in editor ( #15031 )
2021-06-07 19:12:56 -07:00
David Aaron Suddjian
21cf12a480
chore(dashboard): Integrate dashboard app into the SPA bundle ( #14356 )
...
* chore(dashboard): Integrate dashboard app into the SPA bundle
* fix url params
* change variable name
* change title correctly
* custom css
* lint
* remove unused file
* remove content assertions from dashboard tests
* fix case with missing bootstrap data
* fix: respect crud views flag
* crud views -> spa
* remove unused dashboard templates
* fix: remove unused variable
* fix: missed a spot with the crudViews -> spa
* router link to dashboard from dashboard list page
* link using the router when in card mode
* lint
* fix tests, add memory router
* remove dashboard app files
* split up the bundle a little more
* use webpack preload
2021-05-04 08:51:17 -07:00
simcha90
bbb1f2d757
perf(native-filters): avoid unnecessary reloading of charts ( #14408 )
...
* fix:fix get permission function
* refactor: filter default value
* refactor: update default value loading
* refactor: apply defaultValues
* lint: fix lint
* lint: fix lint
* test: fix test
* refactor: use extraFormData for reload charts
* test: fix tests
* test: fix tests
* test: fix tests
2021-05-03 14:56:41 +03:00
simcha90
1f8de1d06c
test(maximize-chart): Add tests to maximize chart action ( #14371 )
...
* fixed FullSize charts broken #13600
* Update ChartHolder.jsx
* fix:fix get permission function
* test: adding tests to full screen
* lint: fix lint
* fix: fix CR notes
* fix: fix CR notes
* fix: fix CR notes
Co-authored-by: toop <mytoop@163.com>
2021-05-02 09:27:38 +03:00
simcha90
3e8bf96642
fix(native-filters): Fix first loading of charts ( #14332 )
...
* fix:fix get permission function
* fix: fix unnecessary loading for native filters
* test: fix mocks
2021-04-25 13:58:53 +03:00
simcha90
7e5440a359
test(native-filters): Filter config modal test ( #14245 )
...
* test: add tests for filter bar
* test: merge filter bar tests with master
* test: add test for filter set
* test: filter set tests
* test: merge with master
* test: fix tests for filter bar
* test: filter config modal
* test: add select filter
* feat: filter config modal
* lint: fix lint
* lint: fix TS
* test: test testWithId
2021-04-20 14:07:08 +03:00
simcha90
d386e66f59
test(native-filters): add integration tests for filter bar ( #14098 )
...
* test: add tests for filter bar
* test: merge filter bar tests with master
* test: add test for filter set
* test: filter set tests
* test: merge with master
* test: fix tests for filter bar
* fix: fix CR notes
* fix: fix CR notes
2021-04-20 12:24:12 +03:00
simcha90
8ef572a412
refactor(native-filters): update dataMask and ExtraFormData schema ( #13983 )
...
* refactor: updates usage of `ownFilters` to `ownState`
* refactor: update dataMask (final)
* lint: fix lint
* refactor: revert feat
* fix: fix missed chart configuration
* add filter set migration
* apply new changes
* fix migration revision
* update migration
* fix jest mock
* js lint
* fix test types
* update tests and types
* remove append_form_data from tests
* fix findExistingFilterSet tests
* add migration test
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-04-15 17:43:29 +03:00
simcha90
45972e9945
refactor(native-filters): Move filtersState
to dataMask
redux root ( #13437 )
2021-03-07 09:34:12 +02:00
simcha90
f19a830d9b
refactor(self-trigger): Split native filters state ( #13137 )
...
* feat: add cross filters
* refactor: fix CR notes
* lint: fix lint
* lint: fix lint
* feat: POC adding filters set feature
* chore: pre-commit
* refactor: under chage
* lint: fix TS
* fix: fix FF name
* refactor: move to behaviors
* lint: fix lint
* refactor: update state of native filters
* refactor: finish refactor nativeFilter state
* feat: split native filters state
* refactor: refactor Time filter to use new API
* refactor: refactor Time filter to use new API
* refactor: fix CR notes
* fix: fix update values in filter bar
* refactor: save filter sets in meta
* feat(filter-sets): save filters sets in metadata
* refactor: partially fix ts
* refactor: merge conflicts
* refactor: add behaviors property
* refactor: add behaviors property
* fix: undo py changes
* fix: under some changes
* refactor: synx with master
* fix: undo FF
* fix: undo FF
* lint: ts-ignore
* chore: update lock file
* refactor: update enum
* refactor: naming of enum
* test: fix test
* test: update mocks
Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-03-02 09:03:26 +02:00
Michael S. Molina
cd3f5214fa
test: Adds tests to TableLoader component ( #13299 )
2021-02-25 17:23:47 -08:00
Geido
409fc83ca9
chore: Tab title to be empty when creating a new tab ( #12773 )
...
* Remove unwanted package lock
* Edit on new and autofocus
* Update test
* Remove autofocus
2021-02-18 10:14:59 -08:00
simcha90
2ff8741248
feat(filter-sets): Saving filter sets in metadata ( #13205 )
...
* feat: POC adding filters set feature
* lint: fix TS
* fix: fix FF name
* refactor: fix CR notes
* fix: fix update values in filter bar
* refactor: save filter sets in meta
* feat(filter-sets): save filters sets in metadata
2021-02-18 15:43:10 +02:00
simcha90
5cbe2ac760
feat(filters-set): basic implementation for managing user filter sets ( #13031 )
...
* feat: POC adding filters set feature
* lint: fix TS
* fix: fix FF name
* refactor: fix CR notes
* fix: fix update values in filter bar
2021-02-17 21:06:12 +02:00
David Aaron Suddjian
189aced320
refactor: remove deprecated chart.edit_url field from frontend usage ( #13142 )
2021-02-16 19:54:43 -08:00
simcha90
5aa38ef929
feat(native-filters): enable filter indicator and make datasource optional ( #13148 )
...
* refactor: continue decouple native filters
* refactor(native-filters): decouple native filter parms from config modal
* lint: fix TS errors
* lint: fix TS errors
* refactor: update filter badge
* refactor: rename ant filters
* test: fix tests
* test: fix tests
* refactor: remove 18 from dataset
2021-02-16 16:12:35 +02:00
simcha90
2010e64c94
refactor(native-filters): decouple params from filter config modal (first phase) ( #13021 )
...
* refactor: decouple params from filter config modal (first phase)
* refactor: remove unnecessary fields
* refactor: fix CR notes
* fix: fix controlValues
* refactor: fix Cr notes
Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
2021-02-14 10:38:15 +02:00
simcha90
dae1258903
feat(native-filters): add storybook entry for select filter ( #13005 )
...
* refactor: update native filters ignores
* refactor: use behaviour variable
* refactor: move story for Filter select
* chore: update dependencies
* lint: fix lint
* remove unnecessary changes
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-02-13 13:11:18 +02:00
simcha90
c440d98fad
refactor(native-filters): refactor code of native filters ( #12889 )
...
* refactor(native-filters): refactor code of native filters
* refactor: update refactor dependencies
* refactor: update refactor dependencies
* lint: fix lint
* fix: merge with master
* chore: fix selector
2021-02-08 13:26:58 +02:00
simcha90
465d986617
feat(native-filters): Add defaultValue for Native filters modal ( #12199 )
...
* refactor: sync Scoping tree with Forms data
* refactor: update scoping tree
* refactor: update scope tree logic to be more UX friendly
* test: fix tests
* lint: fix lin CR notes
* chore: temp
* fix: fix jsx
* feat: Init value
* refactor: move effect to utils
* chore: add comments
* feat: updates for default value in native filters
* refactor: move multi values management to Modal
* feat: added currentState to filterState
fix: Reset all fixed
* style: update filter styles
* fix: process selection of same filter
* fix: fix double choose select
* fix: fix order of cascading filters
* fix: fix CR comments
* fix: fix CR comments
2021-02-02 11:28:12 +02:00
simchaNielsen
da63b4b0ea
test(native-filters): scoping tree in native filters modal ( #12655 )
...
* test: add test to scoping tree in native filters
* test: rename mocks
2021-01-26 14:23:07 +02:00
simchaNielsen
4d04565c9a
feat(native-filters): apply scoping of native filters to dashboard ( #12716 )
...
* feat: scoping native filters in dashboard
* test: add tests / fix reducer
* test: fix tests
* chore: merge with master
* fix: fix undefined cases
* fix: fix code according cypress
* refactor: fix mocks according CRs
* chore: re run pipeline
2021-01-26 09:29:49 +02:00
Michael S. Molina
0c08bb87c3
Fix tests errors and warnings - iteration 4 ( #12212 ) ( #12223 )
2021-01-25 23:24:41 -08:00
Michael S. Molina
3fb183349f
Fix tests errors and warnings - iteration 2 ( #12212 ) ( #12214 )
2021-01-25 12:03:16 -08:00
Agata Stawarz
9c53ad48aa
fix(native-filters): Show incompatible native filters indicator ( #12687 )
...
* Show incompatible native filters indicator
* Add Native Filters mocks and tests to Filter Badge
* Compare filter names in deduplication logic
* Add indicator key
* Remove unnecessary import
2021-01-23 13:23:21 +08:00
Jesse Yang
2210015aab
test: rename column names for birth_names dataset ( #12082 )
2021-01-08 14:13:20 -08:00