Maxime Beauchemin
796a2a6924
fix: error around latest partition in BigQuery ( #11274 )
...
* fix: error around latest partition in BigQuery
* lint
* Going with a backend-first approach
* fix test
* add an extra test
2020-10-20 21:34:46 -07:00
Maxime Beauchemin
c360413fc2
style(menu): clean up right menu - leaving only "Settings" ( #11227 )
...
* style(menu): clean up right menu - leaving only settings
* bring pre-commit back
* fix frontend tests
* pre-commit
* re-introduce subtle '+'
2020-10-20 21:33:28 -07:00
Kamil Gabryjelski
3a0fcdacd3
Fix tabs switching in SouthPane ( #11343 )
2020-10-20 14:24:27 -07:00
Lily Kuang
6f3d4c131f
feat: css template add/edit modal ( #11296 )
2020-10-20 12:15:39 -07:00
Lily Kuang
9f8d0e7a06
fix: update table_name and schema on dataset editor ( #11218 )
...
* fix dataset editor for updating table_name and schema
* update test
* remove table_name from restrict list
* fix pylint
* fix cypress test
* fix test
2020-10-20 09:38:57 -07:00
adam-stasiak-polidea
55ae259b13
chore: Dashboard cypress refactor ( #11280 )
...
* moved dashboard tests to use data-test attributes
* linter
* fix for unstable save test
2020-10-19 21:36:20 -07:00
Kamil Gabryjelski
9266f0a4a8
refactor: Replace usages of reactable in ChangeDatasourceModal ( #11241 )
...
* Refactor ChangeDatasourceModal to use react-table
* Fix import
* Moved columns declaration out of component scope
2020-10-19 20:44:21 -07:00
Kamil Gabryjelski
901a42b1df
refactor: Replace usages of Popover from react-bootstrap with Antd ( #11163 )
...
* New popover component
* LimitControl
* Moar components migrated
* TimeSeriesColumnControl
* Hotkeys
* ColorPicker
* FilterBoxItemCOntrol
* AdhocFilterEditPopover
* AdhocMetric
* AnnotationLayerControl
* DateFilterControl
* Tests fix
* Fix linting issue
* Fix tests
* Bug fix
* Test fix
* Remove Antd global stylesheet
* Fix linting
* Fix test
* Fix test
* Fix test
* Fix test
* Fix test
2020-10-19 20:42:33 -07:00
ʈᵃᵢ
4208ca76e0
refactor: replace AvatarIcon instances with FacePile ( #11279 )
2020-10-19 20:23:16 -07:00
Kamil Gabryjelski
735123d1f5
refactor: Refactor QueryTable to use react-table ( #11216 )
...
* Refactor QueryTable to use react-table
* Fix lodash import
* Fix tests
* Fix imports and QuerySearch styles
* Update superset-frontend/src/SqlLab/components/QuerySearch.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/SqlLab/components/QuerySearch.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Lint fix
* Refactored QueryTable into functional component
* Remove calculating content height
* Lint fix
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-10-18 22:32:13 -07:00
Kamil Gabryjelski
31e4a90440
Fix overflowing tab's styling in TabbedSqlEditors ( #11303 )
2020-10-16 14:23:21 -07:00
Grace Guo
8863c939ad
fix: should update last_modified_time in client-side after save dash ( #11305 )
2020-10-16 10:54:35 -07:00
Yongjie Zhao
afee008a10
fix CTAS and CVAS buttons invisible ( #11300 )
2020-10-16 08:02:39 -07:00
Erik Ritter
9856f99620
feat: update time_compare description and choices ( #11294 )
...
* feat: update time_compare description and choices
* Update sections.jsx
2020-10-15 21:28:09 -07:00
rubenSastre
4f0a06dda5
fix: button translations missing ( #11187 )
...
* button translations missing
* blank space before text
2020-10-15 21:27:26 -07:00
Jesse Yang
a720bba40e
chore: upgrade vis plugins npm packages ( #11272 )
...
https://github.com/apache-superset/superset-ui/compare/v0.15.4...v0.15.8
2020-10-15 10:41:10 -07:00
Kamil Gabryjelski
9aef9c5764
fix: Fix styling in SqlLab when tabs overflow ( #11287 )
...
* Fix styling in SqlLab when tabs overflow
* Use theme variables
2020-10-15 08:38:13 -07:00
adam-stasiak-polidea
fc03549299
chore: Added data-test attributes for testing ( #11254 )
...
* Added data-test attributes for testing
* fixed incorrect naming change
* review changes
2020-10-14 16:12:01 -07:00
ʈᵃᵢ
a6224a2ed2
fix(query search): use new api to fetch users ( #11260 )
2020-10-14 13:52:48 -07:00
Erik Ritter
fc74b5d4a2
Revert "fix: keep placeholder in multivalue select when a value exists ( #11181 )" ( #11270 )
...
This reverts commit 31cc4155b7
.
2020-10-14 12:58:58 -07:00
Kamil Gabryjelski
820fa473a7
refactor: Implement TableView component ( #11217 )
2020-10-14 11:15:34 -07:00
Ville Brofeldt
2a4ca9fa98
fix(crud): set default extra value ( #11262 )
2020-10-14 19:05:20 +03:00
Lily Kuang
cd7392e618
update dashboard edit modal ( #11258 )
2020-10-13 20:50:02 -07:00
Jesse Yang
eb389ba8d4
build: update webpack for npm linking plugins ( #11253 )
2020-10-13 16:54:06 -07:00
Elizabeth Thompson
31cc4155b7
fix: keep placeholder in multivalue select when a value exists ( #11181 )
2020-10-13 13:45:31 -07:00
Grace Guo
88af85ac53
fix: show TIME COLUMN options in dashboard ( #11210 )
...
* fix: show TIME COLUMN options in dashboard
* add unit test
2020-10-12 21:43:30 -07:00
Grace Guo
4f4367edf3
feat: prevent co-edit dashboard collision ( #11220 )
...
* feat: prevent co-edit dashboard collision
* fix comments
2020-10-12 17:58:32 -07:00
Maxime Beauchemin
ae87b0c767
fix: questioning a few lines that force an ORDER clause ( #11153 )
...
* draft: questioning a few lines that force an ORDER clause
* sorting by main metric DESC by default
2020-10-12 14:53:37 -07:00
Lily Kuang
8e58730092
fix(dataset): update user list endpoint ( #11221 )
2020-10-12 17:11:00 +01:00
Yongjie Zhao
16d36a776c
fix(cypress): table viz failed to run in postgres12 ( #11230 )
2020-10-11 11:28:13 -07:00
Kamil Gabryjelski
b071344531
refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab ( #11212 )
...
* Create styled Antd Tabs and Dropdown
* Replace Tabs in SqlLab
2020-10-09 23:11:25 -07:00
Moriah Kreeger
a6fc3d2384
feat: CSS Templates List ( #11189 )
2020-10-09 16:32:31 -07:00
ʈᵃᵢ
7b0dabd7aa
style(listview): various changes to get closer to SIP-34 designs ( #11101 )
2020-10-09 13:06:26 -07:00
John Bodley
2a447ff466
Revert "refactor: Replace react-bootstrap tabs with Antd tabs ( #11090 )" ( #11194 )
...
This reverts commit 4fd993c4e0
.
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-10-07 16:21:24 -07:00
Lily Kuang
a0713938b3
fixed undefined names error ( #11180 )
2020-10-06 22:11:16 -07:00
Moriah Kreeger
21c8d672a8
fix: save query modal/button styling + convert to ant-d modal ( #11164 )
2020-10-06 16:55:17 -07:00
Lily Kuang
2eb400a2fc
chore: remove SIP_34_SAVED_QUERIES_UI feature flag ( #11175 )
2020-10-06 15:13:41 -07:00
Maxime Beauchemin
c8a5dec84d
style(dashboard): minor improvements to chart context menu ( #11170 )
...
Bumping "Explore/edit chart" as the first option. Getting rid of the
old "edit chart properties" deprecated CRUD link
2020-10-06 12:55:13 -07:00
Maxime Beauchemin
f109f11ceb
style: fix too light form labels in DatabaseModal + DRY css ( #11056 )
...
eventually should be moved away from bootstrap and onto a DRY
ControlLabel component in our design system.
2020-10-06 12:51:00 -07:00
Maxime Beauchemin
b2af0c0e22
style(sqllab): make database errors more clear and render as monospace ( #11075 )
...
* style(sqllab): make database errors more clear and render as monospace
In SQL Lab, when a database error message is returned, generally because
of a user error in the SQL, it's identified as an "Unexpected Error" and
some of the text formatting of the error message (\n, spaces, tabs, ...)
are lost as they are rendered in html.
This PR identifies the error as a "Database Error", and renders like
more like a <pre>, using a monospace font.
* fix the build
* addressing comments
* addressed comments
* lint + removing cruft
* addressing comments
2020-10-06 12:50:38 -07:00
Grace Guo
13963acefb
fix: Fix Time Column dropdown for date filter ( #11149 )
2020-10-06 11:51:10 -07:00
Maxime Beauchemin
3d7b805755
chore: more 'datasource' -> 'dataset' renaming ( #11055 )
...
* chore: more 'datasource' -> 'dataset' renaming
* fix build
* explicitely setting disabled to false to avoid cypress confusion
* fix tests
* RAT
2020-10-05 20:04:17 -07:00
Lily Kuang
152315d0f4
feat: saved query preview modal ( #11135 )
2020-10-05 16:21:59 -07:00
Erik Ritter
3d76f81bf7
Revert "refactor: Remove usages of reactable from TimeTable ( #11046 )" ( #11150 )
...
This reverts commit f01b8a30f7
.
2020-10-02 22:21:10 -07:00
Kamil Gabryjelski
07f87149e6
fix: Enable ESLint rule default-props-match-prop-types ( #11058 )
...
* Re-enable ESLint rule default-props-match-props-types
* Add cypress test for switching tabs
* fix
* Typo fix
* Test fix
2020-10-02 15:54:56 -07:00
Elizabeth Thompson
d95b7c2a73
fix: clean up prop type errors in jest tests ( #11120 )
2020-10-02 14:59:04 -07:00
Ville Brofeldt
662fb43350
fix(examples): missing expressions in birth_names ( #11141 )
...
* fix(examples): missing expressions in birth_names
* disable flaky tests
2020-10-02 23:47:38 +03:00
Kamil Gabryjelski
4fd993c4e0
refactor: Replace react-bootstrap tabs with Antd tabs ( #11090 )
...
* Replace tabs in profile
* Replace tabs in SouthPane
* Replace tabs in TabbedSqlEditors
* Add typing for dropdown
* Add license
* Remove isSelected
* Fixes
* Add data-test
* Fix test
* Remove unnecessary style
* Remove unnecessary style
* Tests fix
* Tests fix
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Tabs.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Remove inModal prop
* Remove inModal from storybook
* Move inline style to styled component
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-10-02 13:07:52 -07:00
Jesse Yang
53cd05d74a
perf(explore): render datasource details only when needed ( #10924 )
2020-10-02 12:15:06 -07:00
ʈᵃᵢ
269644d18e
style: override ace edit error icon ( #11139 )
2020-10-02 09:45:36 -07:00
Elizabeth Thompson
a4e1dc9c27
add info about case sensitive search ( #11124 )
2020-10-01 21:30:39 -07:00
ʈᵃᵢ
017e5acd14
style(listview): dynamic card size and grid spacing ( #11111 )
2020-10-01 15:44:42 -07:00
Maxime Beauchemin
5f55d94b9b
style: rename label 'table name'->'dataset name' ( #11126 )
2020-10-01 15:13:01 -07:00
Phillip Kelley-Dotson
07716ffd76
chore: refactor submenu's right nav to accept list of buttons ( #11102 )
...
* submenu right-nav button refactor
* undo changes
* fix lint
* fix test
* update pr with suggested changes and test
* fix lint
* use enum to define btn style props
* add suggestions
* update savedquery buttons
2020-10-01 15:05:49 -07:00
ʈᵃᵢ
7a72082d31
fix: Revert "Replace reactable with DataTable from superset-ui in QueryTable ( #10981 )" ( #11125 )
...
This reverts commit e93d92e8ac
.
2020-10-01 10:06:22 -07:00
Maxime Beauchemin
c4d96f64ff
fix: SpatialControl popover won't open ( #11127 )
...
Recently a change related to emotion styling not properly working through
react-bootstrap's popover broke the SpatialControl.
This PR makes SpatialControl use antd's equivalent, and addresses the
issue as a result: emotion's styling context is preserved through
this superior popover.
2020-09-30 23:12:51 -07:00
Moriah Kreeger
e7a4265c30
feat: saved query list actions ( #11109 )
2020-09-30 18:18:34 -07:00
Lily Kuang
5b284e67eb
feat: add created by chart CRUD view ( #11067 )
2020-09-30 13:53:04 -07:00
Erik Ritter
fa5dab85c4
feat: more specific presto error messages ( #11099 )
2020-09-29 21:50:58 -07:00
Evan Rusackas
0409b12a55
style: fix secondary label border ( #11100 )
2020-09-29 14:15:18 -07:00
Moriah Kreeger
b8d616a9d2
feat: saved query list view + sort/filters ( #11005 )
2020-09-29 13:39:10 -07:00
Ville Brofeldt
80e395559d
fix: echarts timeseries groupby ( #11103 )
...
* fix: echarts timeseries groupby
* address review comment
2020-09-29 14:25:38 +03:00
Lily Kuang
8b458ac172
fix: double scroll bars on dataset editor ( #11095 )
...
* fix double scroll bar on dataset editor
* add table name to virtual tab
2020-09-28 19:28:27 -07:00
Lily Kuang
e337355162
refactor: table selector on dataset editor ( #10914 )
...
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
2020-09-28 11:16:03 -07:00
ʈᵃᵢ
1dc05d4c12
feat(charts): modify custom api filter to include more fields ( #11054 )
2020-09-28 10:18:34 -07:00
Kamil Gabryjelski
2fd8fca207
chore: Clean up some console warnings ( #11061 )
...
* Upgrade a few packages
* Update some prop types
* Update HTML
* Moar warning fixes
* Remove wrapper div
2020-09-28 09:43:21 -07:00
Kamil Gabryjelski
f01b8a30f7
refactor: Remove usages of reactable from TimeTable ( #11046 )
...
* Use ListView instead of reactable
* Refactor TimeTable
* Spark column width fix
2020-09-28 09:42:06 -07:00
Kamil Gabryjelski
a879622e07
refactor: Remove usages of reactable from AlteredSliceTag ( #11012 )
...
* Remove usages of reactable in AlteredSliceTag
* Fix tests
* Move mocked data to fixtures file
* Use optional chaining
* Remove default value, change a unit test logic
* Code review fixes
2020-09-28 09:41:08 -07:00
Maxime Beauchemin
046bd02d65
style: improve "Datasource & Chart Type" <Label>s ( #10971 )
...
* style: improve default <Label>
* fix name-shifting icon
* adding some styles to remove the inner drop shadow from the 'more' button
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-09-28 08:32:25 -07:00
Evan Rusackas
497d3f3910
fix: Adding timeout to flaky cypress test, to wait for animation to complete ( #11074 )
...
* adding timeout for animation
* 1s timeout
2020-09-27 20:08:21 -07:00
Evan Rusackas
cff034e2cf
chore: cleaning out unused code from utils ( #11076 )
...
* removing unused stuff (and some jquery) from utils.js
* linting
2020-09-27 20:08:05 -07:00
Maxime Beauchemin
7f1e4e441d
fix: surface connection error messages on the client ( #11077 )
...
* fix: surface connection error messages on the client
* typo
* lint
2020-09-26 16:09:40 -07:00
Yongjie Zhao
1493450a6f
fix(jest): using UTC mock date ( #11079 )
2020-09-26 14:53:41 -07:00
Evan Rusackas
23d62f37a6
removing unused component ( #11072 )
2020-09-25 23:02:01 -07:00
Evan Rusackas
8cba1c823d
changing to the correct hex color ( #11073 )
2020-09-25 21:09:59 -07:00
Maxime Beauchemin
8e6f7d6598
style: remove unecessary padding ( #11071 )
2020-09-25 17:22:46 -07:00
Moriah Kreeger
374b06b4dd
fix: database list checkboxes ( #11068 )
2020-09-25 16:28:22 -07:00
Evan Rusackas
eeeb21077d
feat: adding all icons from the design system to the codebase ( #11033 )
...
* error -> error-solid
* warning -> warning-solid
* all the new icons mixed in!
* card-view -> card_view
* circle-check-solid -> circle_check_solid
* corrected circle-check to new name and correct (stroke) icon
* sort-asc/desc -> sort_asc/desc
* databases -> database
* compass -> nav_explore
* pencil -> edit-alt
* more pencil migrations
* easy list view rename
* star -> favorite (changed in Figma)
* removing deprecated icon
* renaming icon to mach figma
* More -> More Horiz
* forgot to change this when ranming the file
* updating some icon names in use
* adding hella icons
* fixing errant viewboxes
* removing dropdown-arrow in favor of triangle-down
* adding key to storybook map.
* fixing icon component reference
* tweaks to fave star styling to support revised icon
* fixing a bad icon inclusion
* missed a license
* touchup to virtual dataset... will tweak later.
* e2e fix
* linting
2020-09-25 14:49:30 -07:00
Erik Ritter
052d7a0a3e
fix: sql lab autocomplete width ( #11063 )
2020-09-25 10:13:21 -07:00
Evan Rusackas
d056e3dfd3
clickable labels have outlines, storybook shows them ( #11034 )
2020-09-24 20:50:44 -07:00
Srini Kadamati
66e49807ef
fixed routes for customer in docs ( #11052 )
2020-09-24 20:43:03 -07:00
Grace Guo
3467d2d8d6
Revert "style: fix checkbox color ( #10970 )" ( #11051 )
...
This reverts commit e4e78b66fa
.
2020-09-24 16:53:02 -07:00
Lily Kuang
ea105bc23b
feat: add "created by" to dashboard CRUD view ( #11030 )
2020-09-24 14:33:55 -07:00
Grace Guo
f99753a800
Revert "ESLint: Re-enable rule default-props-match-prop-types ( #10868 )" ( #11050 )
...
This reverts commit 9f01a7fdf8
.
2020-09-24 12:33:38 -07:00
ʈᵃᵢ
eded51b2f8
feat(saved_queries): add custom api filter for all string & text fields ( #11031 )
2020-09-24 11:05:25 -07:00
Grace Guo
8e9b0b3f11
fix: dashboard edit button (again) ( #11029 )
2020-09-23 15:42:06 -07:00
Maxime Beauchemin
dc76a2688e
style(explore): use tertiary button against gray background ( #11011 )
...
"primary" style buttons seem to expect a white background and really
look muted against the gray background. Using "tertiary" style button makes
things much better.
Eventually we may reconsider the layout and gray background and go back
to secondary, but for now this makes these important pop much more
2020-09-23 11:44:39 -07:00
Grace Guo
0409393a4e
fix: [dashboard] should not show edit button when user has no edit permit ( #11024 )
2020-09-23 10:55:32 -07:00
Jesse Yang
7549dad12d
fix: timer component, fixes #10849 , closes #11002 ( #11004 )
2020-09-23 10:53:24 -07:00
ʈᵃᵢ
345fe07d64
fix: menu shows a 0 when there are not settings ( #11009 )
2020-09-23 09:22:45 -07:00
Lily Kuang
02ab5cc644
fix: Add Item Overflow on Dataset Editor ( #10983 )
...
* move add item button to the top
* fix cypress
* fix cypress
2020-09-22 22:19:41 -07:00
Beto Dealmeida
d992c306c2
Bring back import menu ( #11007 )
2020-09-22 19:32:44 -07:00
ʈᵃᵢ
0d1f6119a6
feat(listview): feature flag config to set default viewing mode ( #10986 )
2020-09-22 18:01:19 -07:00
Jesse Yang
220c410df4
build: add react-hooks linting ( #11006 )
...
Fixed a couple of criticle errors and left the warnings as is (mostly
from react-hooks/exhaustive-deps).
Let's fix the warnings in future PRs as sometimes unexhaustive deps
are intentional.
2020-09-22 15:09:22 -07:00
Kamil Gabryjelski
e93d92e8ac
Replace reactable with DataTable from superset-ui in QueryTable ( #10981 )
...
* Replace reactable with DataTable from superset-ui in QueryTable
* Fix tests
* Fix pagination
* Fix tests
2020-09-22 13:24:30 -07:00
Kamil Gabryjelski
9f01a7fdf8
ESLint: Re-enable rule default-props-match-prop-types ( #10868 )
...
* Re-enable rule default-props-match-prop-types
* Restore default props and remove isRequired
* Remove unused props
2020-09-22 13:17:41 -07:00
Ville Brofeldt
a9eab33d64
feat: add ECharts Pie chart ( #10966 )
...
* feat: introduce echarts pie chart
* lint
* remove viz.py shim
* remove tests
* fix cypress test
* fix test
2020-09-22 19:27:40 +03:00
Maxime Beauchemin
3be8bdad9a
docs: add gallery screenshot & link in README ( #10988 )
...
* docs: add gallery screenshot & link in README
* deallowing large files
2020-09-21 22:48:55 -07:00
Evan Rusackas
193796ca16
adding filters back that caused issues ( #10989 )
2020-09-21 19:12:34 -07:00
adam-stasiak-polidea
dc893fe1b3
chore: selectors refactor in SQLLab test suite (Cypress) ( #10944 )
...
* changed selectors for not skipped tests in sqllab suite
* linter fixes
* linter fixes
2020-09-21 15:49:44 -07:00
Kamil Gabryjelski
a8f5029cb1
ESLint: Remove ts-ignore comments ( #10933 )
...
* Upgrade json-bigint, add @types/json-bigint to deps
* Upgrade react-bootstrap-dialog
* Fix ts-ignore
* Fix ts-ignore
* Fix ts-ignore
* Upgrade react-syntax-highlighter, fix ts-ignore
* Fix ts-ignore
* Fix ts-ignore in styles.tsx
* Wrap Input in div to pass onPaste
* Change esm to cjs imports for highlighter to fix tests
* Add null checks
2020-09-21 15:47:33 -07:00
Maxime Beauchemin
e4e78b66fa
style: fix checkbox color ( #10970 )
...
* style: fix checkbox color
* lint
* wrap test into theme
2020-09-21 13:12:12 -07:00
Moriah Kreeger
4aa53244c7
fix: update the time filter for 'Last Year' option in explore ( #10829 )
...
* Update explore time filter ranges
* rm console statements
* only update moment calculation for years
* tests
* add open/close test
2020-09-21 11:39:11 -07:00
Kamil Gabryjelski
4835d3b0a2
ESLint: Re-enable rule no-access-state-in-setstate ( #10870 )
...
* Re-enable rule no-access-state-in-setstate
* Move accessing event values out of async functions
2020-09-20 23:48:23 -07:00
Kamil Gabryjelski
557a303cc5
ESLint: Enable rule no-named-as-default ( #10879 )
...
* Enable rule no-named-as-default
* Fix wrong import
2020-09-18 13:41:01 -07:00
Kamil Gabryjelski
91fd06e093
ESLint: Remove ts-ignore ( #10961 )
...
* Fix prop types of styled
* Fix props in windowed
2020-09-18 13:33:32 -07:00
Kamil Gabryjelski
ccfd293227
ESLint: no-restricted-syntax ( #10889 )
...
* Enable no-restricted syntax rule
* Fix webpack.config.js
* Remove unused function from utils/common.js
* Refactor triple nested for loop
* Fix loops in src/explore components
* Fix loops in SqlLab components
* Fix loops in AlteredSliceTag
* Fix loops in FilterableTable
* Add fixtures and uinit tests for findControlItem
* Add license
2020-09-18 09:05:57 -07:00
Elizabeth Thompson
ed9b50be2c
chore: upgrade cypress to use retries ( #10923 )
2020-09-17 12:54:50 -07:00
Moriah Kreeger
5623cd64ca
feat: update saved query backend routing + add savedquery list ( #10922 )
...
* Update saved query backend routing + add savedquery list
* add spec fileg
* add FE flag for SIP_34_SAVED_QUERIES_UI
2020-09-16 21:08:40 -07:00
Yongjie Zhao
af75bee582
feat: adding dashboard toggle fullscreen button ( #10840 )
2020-09-16 14:20:52 -07:00
Elizabeth Thompson
a3519b42cb
fix lint errors ( #10918 )
...
Co-authored-by: Elizabeth Thompson <elizabeth@preset.io>
2020-09-16 13:42:27 -07:00
Kamil Gabryjelski
281305e0cf
Enable anchor-has-content rule ( #10908 )
2020-09-16 13:27:52 -07:00
Elizabeth Thompson
0d90bc9920
chore: update port that cypress runs on for local vs test ( #10847 )
2020-09-16 12:31:03 -07:00
Elizabeth Thompson
d3e9c565b7
feat: use svg for checkbox component ( #10799 )
...
* use svg for checkbox component
* add vertical align to svg
* use emotion styling
* update import to superset core
Co-authored-by: Elizabeth Thompson <elizabeth@preset.io>
2020-09-16 12:03:14 -07:00
Elizabeth Thompson
13cc1a3d2d
fix: front end CI tests and test runner ( #10897 )
2020-09-16 11:35:18 -07:00
Maxime Beauchemin
0870d3ae2b
docs: add back issue code links ( #10903 )
...
* docs: add back issue code links
closes: https://github.com/apache/incubator-superset/issues/10852
* Addressing comments
2020-09-16 09:28:53 -07:00
Jesse Yang
d4291edffa
build: optimize eslint import resolver configs ( #10901 )
...
Use `node` resolver and `node` env for `webpack.config.js`, use
`webpack` resolver only for `src`.
2020-09-16 09:26:14 -07:00
Maxime Beauchemin
3b035d2af3
docs: redirect http -> https ( #10900 )
...
* docs: redirect http -> https
* fix issues
2020-09-16 08:24:08 -07:00
Jesse Yang
4eeee4c2eb
chore: enable eslint-import-resolver-typescript ( #10895 )
...
Let eslint understand tsconfig.json when importing modules, so we
can use `compilerOption.paths` to override where to find ts modules.
2020-09-15 15:33:49 -07:00
Moriah Kreeger
c43992bec8
feat: data menu routing ( #10880 )
2020-09-15 14:53:31 -07:00
Jesse Yang
0129c4253d
feat: move ace-editor and mathjs to async modules ( #10837 )
...
Follow up on #10831 , move brace and mathjs to async modules so that the initial page load for dashboards most pages can be faster.
2020-09-15 14:12:06 -07:00
ʈᵃᵢ
045335a687
fix(cypress): wait for filterValues request ( #10884 )
2020-09-15 09:52:44 -07:00
Jesse Yang
4502690ef9
chore: clean up aphrodite ( #10883 )
2020-09-14 17:47:39 -07:00
Kamil Gabryjelski
01f90107e1
ESLint: Re-enable rule no-unused-vars ( #10865 )
...
* Re-enable rule no-unused-vars
* fixup! Re-enable rule no-unused-vars
2020-09-14 15:42:06 -07:00
Kamil Gabryjelski
e28f3d6220
Re-enable rule line-between-class-members ( #10862 )
2020-09-14 15:41:32 -07:00
Kamil Gabryjelski
91b8c8afc9
Re-enable rule state-in-constructor ( #10873 )
2020-09-14 13:31:11 -07:00
Kamil Gabryjelski
767044bfe5
ESLint: Re-enable rule control-has-associated-label ( #10866 )
...
* Re-enable rule control-has-associated-label
* Change aria-label message in DatasourceControl
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-09-14 13:00:39 -07:00
Kamil Gabryjelski
2d8f4e3aaf
Re-enable rule no-else-return ( #10861 )
2020-09-14 13:00:07 -07:00
Kamil Gabryjelski
76275ec410
Enable rule no-plusplus ( #10876 )
2020-09-14 11:59:32 -07:00
Kamil Gabryjelski
d93b2b99b2
Re-enable rule sort-comp ( #10872 )
2020-09-14 10:45:05 -07:00
Kamil Gabryjelski
a75c36281d
Re-enable rule jsx-curly-brace-presence ( #10869 )
2020-09-14 10:44:03 -07:00
Kamil Gabryjelski
c5193ca018
Re-enable rule no-non-null-assertion ( #10864 )
2020-09-14 10:40:20 -07:00
Kamil Gabryjelski
1908a94c7e
ESLint: Re-enable rule no-restricted-globals ( #10863 )
...
* Re-enable rule no-restricted-globals
* Fix missing semicolons
2020-09-14 10:39:46 -07:00
Kamil Gabryjelski
7f1012360a
Re-enable no-useless-path-segments rule ( #10860 )
2020-09-14 10:38:18 -07:00
Kamil Gabryjelski
906a629b33
Re-enable rule no-unused-state ( #10871 )
2020-09-14 10:31:16 -07:00
Kamil Gabryjelski
352e8a1afd
Re-enable rule prefer-destructuring (only for objects) ( #10867 )
2020-09-14 10:11:20 -07:00
Kamil Gabryjelski
c51168a30a
Re-enable no-confusing-arrow rule ( #10874 )
2020-09-14 10:03:37 -07:00
Kamil Gabryjelski
8a774d59ed
Eslint dependencies versions updates ( #10839 )
...
* Update eslint version to 7.8.1
* Give names to unnamed functions to fix lint errors
* Update eslint-import-resolver-webpack
* Update eslint-plugin-cypress
* Add eslint-plugin-react-hooks
* Update necessary peer dependencies for eslint-config-airbnb
* Update eslint airbnb config and ts plugins
* Remove "this" from functional component
* Disable all rules that cause new errors
* Fix linting errors in tests
* Add licenses to .eslintrc files
* Add path and zlib to package.json
* Disable incompatible rule in eslint-plugin-cypress
* Remove redundant config for typescript linting
* Mark disabled rules with comments
* Remove path and zlib from deps, disable import rule for webpack files
2020-09-13 23:59:02 -07:00
Moriah Kreeger
686c19abcf
Fix test_connection POST body ( #10846 )
2020-09-11 23:33:43 -07:00
Maxime Beauchemin
6cb67017a5
style: white toolbar for SQL Lab ( #10851 )
2020-09-11 23:27:25 -07:00
Moriah Kreeger
7cd96edcdf
feat: add/edit database modal form sections UI ( #10745 )
2020-09-11 09:53:18 -07:00
John Bodley
a3e2e65121
fix: Making the database read-only ( #10823 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-09-10 16:23:24 -07:00
Jesse Yang
d80f406239
build: optimize webpack code split ( #10831 )
2020-09-10 15:11:21 -07:00
Ville Brofeldt
8a9ae811d0
fix(sql-lab): relax column name restrictions ( #10816 )
2020-09-10 07:54:37 +03:00
Jesse Yang
9a59bdda48
refactor: merge/upgrade superset-ui packages ( #10790 )
...
* refactor: merge/upgrade superset-ui packages
* Fix flaky big number test
* Fix Flaky AdhocFilters test
2020-09-09 13:18:55 -07:00
ʈᵃᵢ
50672bb11b
feat: database delete warning ( #10800 )
2020-09-08 18:54:02 -07:00
Jesse Yang
cda232bf15
fix: ColorSchemeControl should not use CreatableSelect ( #10814 )
...
* fix: ColorSchemeControl should not be CreatableSelect
Currently if you type to search in ColorSchemeControl it crashes the
whole page.
* Make it possible to filter by label
* Fix ColorSchemeControl unit test
2020-09-08 18:38:50 -07:00
ʈᵃᵢ
92f2353f80
feat: filters for database list view ( #10772 )
2020-09-04 16:23:38 -07:00
Grace Guo
596200528d
fix: disable domain sharding on explore view ( #10787 )
2020-09-03 15:42:39 -07:00
Shaoqing Hu
9bcb15091c
fix: can not type 0.05
in TextControl
( #10778 )
2020-09-03 12:11:34 -07:00
Evan Rusackas
824cea24ba
More Label touchups (margins) ( #10722 )
...
* labels with onClick don't need .pointer. No labels need `m-r-5`
* making Timer a proper Label
* a little linting
* addresing (helpful, thanks) comment
2020-09-02 23:13:58 -07:00
ʈᵃᵢ
7bccb38a60
feat: SIP-34 table list view for databases ( #10705 )
2020-09-02 11:48:21 -07:00
ʈᵃᵢ
5a4370012b
refactor: convert DatasetList schema filter to use new distinct api ( #10746 )
2020-09-02 11:07:37 -07:00
Evan Rusackas
e0deaad5e3
chore: removing fsevents dependency ( #10751 )
2020-09-02 10:37:23 -07:00
Ville Brofeldt
8c564fba38
feat(viz): add ECharts Timeseries chart ( #10752 )
...
* initial commit
* Change reference to new echarts plugin
* initial commit
* Change reference to new echarts plugin
* moving dependencies to plugin
* adding pie chart
* rename piechart key
* lint
* Bump packages and implement echarts colors
* remove pie for now
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-09-02 09:18:59 +03:00
Evan Rusackas
5a106eb8f5
moving all @types to dev dependencies ( #10750 )
2020-09-01 15:32:39 -07:00
Evan Rusackas
807bd656c6
Fix: Rejiggering some dependencies, trying to get CI to pass ( #10747 )
...
* removing two duplicate devdependencies - leaving dependencies
* bumping shuffled dependencies, making fsevents non-optional
* bumping @babel/cli
* Another bump
2020-08-31 20:50:46 -07:00
Evan Rusackas
cd144b68ac
style: Tabs now support AntD compound components (+ basic stories) ( #10728 )
...
* Supporting compound coponents, adding stories
* Adding a coupe o' knobs just for fun.
2020-08-31 13:56:59 -07:00
Maxime Beauchemin
3d8857ecc8
style: rename 'Source' top nav item to 'Data' ( #10715 )
...
* style: rename 'Source' top nav item to 'Data'
* Fix tests
* tables -> datasets
* rename datasource -> dataset
* lint
* more renaming
* use npm ci
2020-08-29 18:09:47 -07:00
Evan Rusackas
9fe30ab71e
style: Pass at propagating (and enhancing) Button component throughout Superset ( #10649 )
...
* getting rid of weird focus/active outline ring
* Buttons... buttons _everywhere_
* linting
* Nixing views/CRUD/dataset/Button component
* fixing 2 typing errors
* fixing more TS errors
* prefer src path for include
* one more real button, one less CSS class
* one more "button" to "Button"
* Published Status is now a proper clickable Label
* nixing the CRUD button again
* touching up stories, with SupersetButton story
* SIP-34 button colors
* adding polished package to mix colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* more abstraction from bsStyle/bsSize props
* exchanging styles for a prop
* linting
* restoring feature flag to stock
* using src alias
* last <button> replacement
* this classname would never be applied
* more linting action
* fixing unsupported bsSize 'medium', and cta typing error
* more cta action
* unnecessary styles
* errant bsSize prop
* cleanup
* tweaks to make new New button work
* Linting
* fixing a couple tests
* fixing theme based test failure
* margin tweak for NEW button
* another fixed test
* another fixed test
* fixing two more tests
* fixing last broken tests.
* always be linting
* Adding tertiary/dashed buttons
* cleaning up QueryAndSave buttons
* fixing "link" button styles
* fixing/updating link button styles
* cta buttons on Modal component
* linting.
* exporting button story knobs, making ALL knobs safe for export.
* capitalizing a file... no big whoop
* Basic button tests
* renaming button - temporarily
* renaming file to fix capitalization issue
* passing theme through to a difficult popover.
* fixin' a newly busted unit test
* lint fixin'
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* touching up stories, with SupersetButton story
* SIP-34 button colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* linting
* restoring feature flag to stock
* cleanup
* Linting
* renaming button - temporarily
* renaming file to fix capitalization issue
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* nixing new modal button
* Fixing another popover/button issue that should break cypress
* lint ✨
* passing classNames through to new button (should fix some tests)
* cleaning unused classes, making cypress tests use data attrs
* fixin' the test
* fixing another class-based test with data-test attr
* no longer passing theme as prop to buttons in popovers... themeprovider is better
* outline/border tweaks!
2020-08-28 17:34:28 -07:00
ʈᵃᵢ
d3bdea3805
fix: move menu reorg logic from crud app into Menu component ( #10717 )
2020-08-28 13:56:01 -07:00
Ville Brofeldt
dd0bc472e3
refactor(database): use SupersetResultSet on SqlaTable.get_df() ( #10707 )
...
* refactor(database): use SupersetResultSet on SqlaTable.get_df()
* lint
* change cypress test
2020-08-28 21:12:03 +03:00
Moriah Kreeger
c715cad48e
feat: base tabbed modal for new database CRUD UI ( #10668 )
2020-08-27 14:28:06 -07:00
ʈᵃᵢ
937b868321
style: add border between menu and submenu ( #10698 )
2020-08-27 14:15:22 -07:00
Lily Kuang
7abdf53944
fix: card view failed cypress tests ( #10699 )
2020-08-27 11:33:12 -07:00
Moriah Kreeger
8d94534881
style: Move security/manage navigation tabs into a settings dropdown ( #10439 )
2020-08-27 10:21:51 -07:00
Grace Guo
7fc227c92d
fix: shorten url with extra request parameters ( #10693 )
2020-08-27 09:53:20 -07:00
ʈᵃᵢ
81525c3e9d
feat(listview): set default view mode based on THUMBNAIL feature flag ( #10691 )
...
* feat(listview): set default view mode based on THUMBNAIL feature flag
* add spec
* better generic typing for ListView
* lint
* fix specs
2020-08-27 09:40:32 -07:00
Lily Kuang
bb92c1f84d
feat: chart and dashboard card list view e2e cypress test ( #10669 )
...
* card view cypress tests
* update test config
* chart filter cypress test
* move setting to superset test config
* update test description card view
2020-08-27 09:38:12 -07:00
Ville Brofeldt
aaf04cc344
fix(filter-box): don't add empty filter to filtersChoices ( #10687 )
...
* fix(filter-box): don't add empty filter to filtersChoices
* add test
2020-08-27 12:36:02 +03:00
ʈᵃᵢ
6ff96cfc72
refactor: useListViewResource hook for charts, dashboards, datasets ( #10680 )
2020-08-26 15:39:18 -07:00
ʈᵃᵢ
bc0fc4ea25
fix: SubMenu css ( #10682 )
2020-08-26 14:00:20 -07:00
Evan Rusackas
a95e5c9327
fix: layout flexiness ( #10681 )
2020-08-26 09:49:58 -07:00
Evan Rusackas
4b40d44b5c
style: Fancier menus, more SIP-34-ish ( #10423 )
...
* style: shinier menus
* fixing mouseover glitch
* unused import
* rm emotion-reset
* restoring default config values
* lint fixes ✨
* a bit more pizzaz to the underlines (max's idea), fading active background
* simplifying navtitle -> label
* RBNavDropdown -> ReactBootstrapNavDropdown
* nixing whitespace
* replacing !importants with better selector specificity
* moving Menu LESS into Emotion
* no more border!
* fixing border issue
* language picker, account dropdown now use new dropdown component
* nixing whitespace in comment
* nixing duplicate styling
* removing borders on FAB navbar
* explicit font coloring
* linting
2020-08-24 23:16:44 -07:00
Evan Rusackas
fdfb7cdfd2
Eslint error cleanup ( #10657 )
...
* moving two console errors to logger errors
* nixing unused map index
* nixing unused param
* linting
* changing an alert to a toast
* fixing tests
* lint fix
* one letter change, just to see if iti gets CI to pass this test.
2020-08-24 14:04:27 -07:00
auxten
0f44d3edf2
Fix add chart page frontend i18n issue ( #9321 )
2020-08-22 21:04:18 +03:00
ʈᵃᵢ
45fee60b62
fix: remove FAB rendered menu in favor of react based one ( #10401 )
2020-08-21 17:19:00 -07:00
Grace Guo
aa8ff8759c
feat: use shorten url in standalone iframe ( #10651 )
2020-08-21 15:27:15 -07:00
ʈᵃᵢ
b86c0e5727
feat(listview): skeleton loading states for table and card collections ( #10606 )
2020-08-21 10:32:37 -07:00
Evan Rusackas
878f06d133
feat: Getting fancier with Storybook ( #10647 )
...
* Niftier paddings
* upgrading storybook, fixing glob pattern
* moving a couple storybook dependencies to dev dependencies
* fixing annoying lint issue about dev dependencies needing to be dependencies
* adds essential addons, fixes backgrounds
* newline tweaks
* comment about no-extraneous-dependencies, higher specificity on that rule, other linting stuff
* a *python* linter doesn't like this whitespace?!
* putting the linespace back
* ugh, found the space causing CI issues... I think
2020-08-20 22:41:25 -07:00
Erik Ritter
cb1989a4fd
feat: bump superset-ui for certified tag ( #10650 )
2020-08-20 16:56:18 -07:00
ʈᵃᵢ
7301a363c1
feat: setup react page with submenu for datasources listview ( #10642 )
2020-08-20 11:42:17 -07:00
Erik Ritter
38da552a57
feat: add certification to metrics ( #10630 )
2020-08-19 20:45:33 -07:00
Ville Brofeldt
5136c5c16e
feat(viz-plugins): add date formatting to pivot-table ( #10637 )
...
* feat: make pivot table dates formattable
* Bump npm packages
2020-08-19 23:55:59 +03:00
Evan Rusackas
84d08cb8da
fix: controls scroll issue ( #10644 )
2020-08-19 13:19:40 -07:00
Evan Rusackas
b0380befa1
feat: Allow tests files in /src (plus Label component tests) ( #10634 )
...
* allow tests in jest confg
* sample stories for Label component
* passing tests
* stories to tsx!
* excluding knobs exports from published stories
* ts fix
* ts fix
* Label test to TS
* explicitly ignoring test files in webpack bundling
* linting stuff
* adding comment about test file exclusions
2020-08-19 12:54:26 -07:00
Evan Rusackas
d0953874f2
chore: splitting button stories into separate stories ( #10631 )
...
* splitting button stories into separate stories
* lint
2020-08-18 22:47:27 -07:00
Lily Kuang
a3ac5061fe
feat: card view bulk select ( #10607 )
2020-08-18 18:04:36 -07:00
Evan Rusackas
ec7874ff98
style: Label styling/storybook touchups ( #10627 )
...
* colors corrected, hover/cursory only change if there's an onClick
* adding info label, breaking gallery out to its own story
* linting
* fixing bad class name
* now with fading!
* now supporting additional (non-bootstrap) label styles
* adding new secondary/primary labels to gallery
* fixing map key react warning
* using the new secondary label in the ChartList view
* linting
* fixing TS issue
2020-08-18 15:42:00 -07:00
Evan Rusackas
844b471509
fix: removing unsupported modal sizes ( #10625 )
...
* fix: removing unsupported modal sizes
* linting!
* NOT specifying bsSize seems to have the same effect as (unsupported) "medium"
* supporting 'large' and 'small' over 'lg' and 'sm'
2020-08-18 14:33:39 -07:00
Ville Brofeldt
ca5dc4256f
feat(datasource): remove deleted columns and update column type on metadata refresh ( #10619 )
...
* fix: remove missing columns on metadata refresh
* add tests
* lint and simplify
* lint
* reduce locals
* fix label style
2020-08-18 21:47:13 +03:00
Maxime Beauchemin
0d3caf08e5
chore: npm audit fix as of 2020-08-15 ( #10613 )
...
* chore: npm audit fix as of 2020-08-15
* --force
* fixing copy-webpack-plugin
* lint
* resolve conflicts
2020-08-17 15:27:01 -07:00
Evan Rusackas
f868580f64
chore: bump react-redux to 5.1.2, whittling console noise ( #10602 )
...
* chore: bump react-redux to 5.1.2
* fixing spy, and thus the breaking test.
* relabeling tests to UNSAFE_componentWillReceiveProps because why not.
2020-08-16 21:29:08 -07:00
Evan Rusackas
ed9b6dbf2b
fixing console error about bad html attribute ( #10604 )
2020-08-16 20:21:21 -07:00
Evan Rusackas
08211953b2
chore: migrate console logs to logging service ( #10608 )
2020-08-16 20:20:47 -07:00
Grace Guo
ca9ca99510
refactor: [migration] convert iframe chart into dashboard markdown component ( #10590 )
...
* refactor: [migration] convert iframe chart into dashboard markdown component
* remove 3 viz_types
* fix comments
2020-08-16 14:43:30 -07:00
Lily Kuang
03a62f15d8
feat: sort card view by Alphabetical, Recently Modified, and Least Recently Modified ( #10601 )
2020-08-14 15:07:37 -07:00
ʈᵃᵢ
db88cec431
feat: SIP-34 card/grid views for dashboards and charts ( #10526 )
2020-08-13 14:46:56 -07:00
Evan Rusackas
a3fd2b420e
fix: More tweaks needed after adding Doctype tag ( #10504 )
...
* fixing last-of-type specificity
* Simplifying/consolidating styles
* fixing filterbox in explore
* linting
* adding some px to font sizes
* fixing in-dash overflow
* removing px for one special fontsize case
* simplifying, addressing comments
2020-08-13 11:50:14 -07:00
Erik Ritter
a8197976fe
fix: error message modal overflow ( #10580 )
2020-08-11 17:20:39 -07:00