Commit Graph

3494 Commits

Author SHA1 Message Date
Junda Yang a0e7c176e9 fix sqlab progress bar and status inconsistency (#5848) 2018-09-20 11:20:36 -07:00
Krist Wongsuphasawat 8c83b72ce2 remove .only (#5943) 2018-09-20 10:42:22 -07:00
timifasubaa 00c4c7ec4b
fix csv upload bugs (#5940) 2018-09-20 10:34:15 -05:00
Krist Wongsuphasawat 1e5a02a42d use es6 import (#5938) 2018-09-20 08:12:29 -07:00
Maxime Beauchemin 5b97fe5c0c
Some linting (#5790) 2018-09-20 08:11:43 -07:00
Beto Dealmeida 71f014e9b6
Allow removing legend (#5932) 2018-09-19 13:32:07 -07:00
Maxime Beauchemin b9e3159f7c
Fix regression around low row limit for CSV exports (#5866)
* Fix regression around low row limit for CSV exports

* fix tests

* Still trying to fix tests
2018-09-19 13:30:25 -07:00
Alek Storm 549328f8f0 Clean up CONTRIBUTING.md: (#5911)
- Reorganize sections for better navigability
- Add table of contents
- Rework frontend assets section for clarity and DRY
- Rework translating section for clarity, add "Add Translations" contribution type
- Move release docs only useful for maintainers to RELEASING.md
- Other miscellaneous improvements
2018-09-19 10:01:51 -07:00
Krist Wongsuphasawat 8fff0d9e8f [SIP-6] Add reactify function and convert world map to new directory structure. (#5893)
* reactify world map

* add createAdaptor

* fix typo

* add schema

* move directory

* remove unnecessary lines

* make setRef a function

* convert keys to camelcase

* add unit test

* update formatting

* add check for displayName

* pass width and height as separate inputs
2018-09-18 23:35:36 -07:00
Maxime Beauchemin 75bc501146
[explore flow] handling duplicated column aliases (#5778)
* [explore flow] handling duplicated column aliases

closes #5739

* lint
2018-09-18 23:17:38 -07:00
Maxime Beauchemin 7448d07e54
[bugfix] ignore history.pushState errors (#5905)
Ignoring history.pushState handling errors as they are impredictable and
crash the application hard.

I'm thinking this may be because the payload object is too big and the
browser is unhappy about it. I'm not sure if the payload/state is ever
used (when hitting back?). The error seem to stop when replacing payload
by an empty object.
2018-09-18 21:52:30 -07:00
Krist Wongsuphasawat 325e7c03b8 [bugfix] De-dup <script> tags. #5883 (#5890)
* Fix adding duplicate script tags.

* add more empty lines

* rename function
2018-09-18 17:50:30 -07:00
michellethomas 8cb734d7e0 Table and dist bar tests (#5901)
* Creating commands to verify codes and slices

* Creating tests for table and dist bar
2018-09-18 16:27:45 -07:00
Chris Williams 42ab1754db
[contributing.md] swap cypress command order (#5921) 2018-09-18 14:37:44 -07:00
Christine Chambers 24be6922fd [refactor] Remove dependency on personal fork of supercluster from mapbox visualizations (#5902)
* [refactor] Remove dependency to personal fork of supercluster from mapbox visualizations

- Update dependency to reference the vanilla supercluster
- Clean up backend api call for mapbox vizzes to ensure a boolean is sent to indicate whether the viz includes custom metric for clustering
- Refactor of mapbox and its cluster overlay components to use vanilla supercluster and its recommeded way for handling clustering based on custom aggregations.
- Allow reclustering within the initial bounds on render in mapbox visualizations (stay true to old behaviors).
- Remove the median aggregation from available cluster label aggregators as there is no memory efficient way to implement this and it is unknown how often this feature is used
- Updating doc to mention the backward incompatible change re median

* Perform the check for has_custom_metric through `not None` to produce a boolean and rename the field reflect it is a boolean.
2018-09-18 12:38:17 -07:00
Krist Wongsuphasawat 19a3319acf [bugfix] Fix percent metric display and check for string columns in table (#5917)
* fix percent metric display

* add empty line

* address string or number check
2018-09-18 10:30:47 -07:00
Krist Wongsuphasawat f2d64492ef Remove unused functions and jquery dependency (#5868)
* remove unused functions and jquery dependency

* rebase and remove more obsolete functions
2018-09-18 09:52:49 -07:00
Krist Wongsuphasawat 14de28a4f2 [bugfix] Fix color scheme picker (#5891)
* Fix color scheme picker

* fix .value
2018-09-18 09:50:14 -07:00
Christine Chambers 74940e6a16 Fixing linting error in macro_tests (#5918) 2018-09-17 20:29:14 -07:00
Krist Wongsuphasawat 39ef77abc5 Remove jquery usage to highlight sql lab menu (#5907)
* Remove jquery hack

* change filter to find
2018-09-17 11:05:22 -07:00
Manuel Silva 041fe52028 Adds a new macro to allow getting filter values easily (#5547)
* Adds new macro to get filter values from "filters" and "extra_filters"

Adds test for filter_values macro

Adds doco for filter_values

Changes filter_values return type to be a list rather than string

* Makes return value type consistent
- filter_values always return a list
2018-09-17 09:36:47 -07:00
Krist Wongsuphasawat 0e93a94ae4 [SIP-5] Refactor nvd3 (#5838)
* move into folder and scaffold adaptor

* extract width and height

* remove jquery

* extract showBrush

* extract lineInterpolation

* extract xAxisFormat and yAxisFormat

* extract annotationData

* extract xTicksLayout and colorScheme

* extract showXXX

* extract x and y axis labels

* extract showminmax

* extract pie chart props

* extract area chart props

* extract logscale and yAxisBounds

* extract margin

* extract bubble props x,y,size

* extract contribution, comparisonType and color_picker

* remove the last fd.xxx

* remove unnecessary variables

* remove slice.container

* fix unit test reference

* Rewrite logic to compute max label lengths to use only d3, not jquery.

* extract annotationLayers and no more slice.xxx in nvd3vis

* rename x, y, size to xField, yField, sizeField

* use arrow function

* move tooltip function

* extract helper functions into utils

* remove unused argument

* fix height calculation and show bar labels

* rename function

* update unit test

* organize tooltip generator

* update line_multi

* Add proptypes for data

* list proptypes for data

* extract tooltip function for bubble chart

* rename variables

* remove console.log

* enumerate vizTypes and pieLabelType

* parse maxBubble

* use new color scale

* fix import"

* remove line
2018-09-16 20:38:30 -07:00
Maxime Beauchemin 9c486a3b3d [react16] fix React type checking (#5903)
Somehow checking the type of a JSX-defined React component is not
straightforward and changes through versions of React.

Using the `name` attr addresses the issue for now.
2018-09-16 11:48:32 -07:00
Krist Wongsuphasawat b68766d373 Add cypress artifacts directory (videos/screenshots) to gitignore and sort items in gitignore (#5900)
* Add cypress artifacts to gitignore and sort items in gitignore

* update sort
2018-09-14 15:38:14 -07:00
Maxime Beauchemin acf1a1b2d3 [treemap] add row_limit control (#5811) 2018-09-14 11:40:22 -07:00
Junda Yang fdd44ace27 remove duplicated utils (#5851) 2018-09-13 15:24:08 -07:00
Chris Williams b453cd2bf2
[lint] turn no-undef back on, set browser, cypress, and mocha env's (#5879)
* [lint] turn no-undef back on, set browser, cypress, and mocha env's, and fix issues

* [lint] fix undefined var in TimeTable.jsx
2018-09-13 14:45:24 -07:00
Krist Wongsuphasawat 7098ada8c5 [SIP-5] Refactor Time Series Table (#5775)
* Break TimeTable into smaller pieces

* extract function to compute color

* Handle height and scrollbar

* sort out isGroupBy

* Set default values

* Specify proptypes for data

* rename fields and update proptypes

* Add default props

* remove commented line

* swap import
2018-09-13 10:40:46 -07:00
livinm 057c749471 Addded documentation for Teradata DB (#5885)
Documentation extension for PR5870
2018-09-13 08:01:37 -07:00
livinm 83fa7af42a Enable Teradata (#5870)
* Enable Teradata 

New DB engine spec for Teradata:
- LimitMethod should be WRAP_SQL since Teradata does not supporting "LIMIT" clause  (TOP)
- Timegrains for Teradata is added

* Update formatting to pass flake8 tests
2018-09-13 08:01:25 -07:00
Conglei 85692612d6 [bug fix] Fixed adhoc metric is not working for WordCloud (#5877)
* fixed adhoc metric

* change rotate default to flat
2018-09-12 23:12:04 -07:00
Conglei 10836ce53c fixed modal close issue (#5865)
* fixed modal close issue

* change Children array to Fragment
2018-09-12 21:28:45 -07:00
Conglei ee89a3eb5e [SIP-6] removed get_data for BigNumber (#5861)
* removed get_data for BigNumber

* removed duplicated condition

* fixed typo
2018-09-12 18:34:21 -07:00
Maxime Beauchemin 80faa8df80
Fix CSS theme flickering on FAB pages (#5880)
Since the recent PRs around webpack 4 and reloading, FAB pages have been
flickering on load, where a themeless Superset is shown for a fraction
of a second until the bootstrap theme gets loaded up.

This addresses it by moving the theme JS to the head section of the html
page.
2018-09-12 17:21:24 -07:00
Krist Wongsuphasawat 620beed867 remove getColorFromScheme in favor of CategoricalColorNamespace.getScale() for histogram (#5878) 2018-09-12 15:39:38 -07:00
Arpit 4121d57d32 fix: Pivot table not sorting formatted numeric column properly (#5709)
* fix: Pivot table not sorting formatted numeric column properly

* refactor(lint): fixed lint error
2018-09-12 15:07:44 -07:00
Krist Wongsuphasawat f482a6cf99 Improve categorical color management (#5815)
* Create new classes for handling categorical colors

* verify to pass existing unit tests

* separate logic for forcing color and getting color

* replace getColorFromScheme with CategoricalColorManager

* organize static functions

* migrate to new function

* Remove ALL_COLOR_SCHEMES

* move sequential colors to another file

* extract categorical colors to separate file

* move airbnb and lyft colors to separate files

* fix missing toFunction()

* Rewrite to support local and global force items, plus namespacing.

* fix references

* revert nvd3

* update namespace api

* Update the visualizations

* update usage with static functions

* update unit test

* add unit test

* rename default namespace

* add unit test for color namespace

* add unit test for namespace

* start unit test for colorschememanager

* add unit tests for color scheme manager

* check returns for chaining

* complete unit test for the new classes

* fix color tests

* update unit tests

* update unit tests

* move color scheme registration to common

* update unit test

* rename sharedForcedColors to parentForcedColors

* remove import
2018-09-12 14:10:26 -07:00
Chris Williams bec0b4cc37
[tests] fix sqllab/TableElement_spec (#5874) 2018-09-12 12:32:46 -07:00
Maxime Beauchemin 367dcdaa7d [time table] fix sorting on missing values (#5863) 2018-09-12 11:21:48 -07:00
Hugh A. Miles II 1e35030a90
[Docs] Running DB migration (#5748)
* Add doc to add new columns

* spelling

* spelling
2018-09-12 07:16:58 -10:00
Krist Wongsuphasawat 166058d95f correctly compute slice width in dashboard (#5867) 2018-09-12 10:05:39 -07:00
michellethomas 657993d609 Moving get_main_db out of tests and into superset utils (#5864) 2018-09-11 22:50:14 -07:00
timifasubaa c82cea3c8d
fix sqllab logging (#5862) 2018-09-11 17:23:44 -07:00
Krist Wongsuphasawat 962eb0860c fix Object.assign try to write to read-only option.style (#5860) 2018-09-11 16:57:11 -07:00
timifasubaa 01212c3755
make access request open new tab (#5859)
* make access request open new tab

* trigger build
2018-09-11 16:18:14 -07:00
Christine Chambers 6df720d873 [bugfix] mapbox pan on filter (#5858)
* Pan mapbox map on query

- Modify the backend to send back the bounds of the points to cluster
- Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom
- A minor clean up of unused props and also making the visual properties panel open by default

* Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend.

* a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups)
2018-09-11 13:33:54 -07:00
michellethomas 6ae285b6f7 Adding line and big number total integration tests (#5846)
* Adding line and big number total integration tests

* Breakout visualization tests into multiple files
2018-09-11 11:03:46 -07:00
Chris Williams 1f6e8b31d2
[dev] fix redux devtools (#5855) 2018-09-11 10:35:52 -07:00
Grace Guo 965c838fbb
update dashboard sidepane title (#5850) 2018-09-11 10:27:46 -07:00
timifasubaa 9a4bba485a
[sqllab]More granular sqllab logging (#5736)
* quote hive column names (#5368)

* create db migration

* use stats_logger timing

* trigger build
2018-09-11 08:52:37 -07:00