Commit Graph

6457 Commits

Author SHA1 Message Date
Rob DiCiuccio 8fe9ee04c8
build(cypress): Use pull_request_target event to run cypress (#11750)
* Use pull_request_target event to run cypress in order to access repo secrets

* Summary job for branch protection requirements

* Restore pull_request trigger

* Use merge base for e2e tests

* Restore push trigger for all branches
2020-12-16 10:45:21 -08:00
Nikola Gigić 48fb8c0b77
fix(dataset): Page blanks on large data load (#11979)
* Implement pagination in <TableView> for Samples preview

* Increase page size

* Fix lint

* Render cells based on width

* Fix lint errors

* Additional tests and changes

* Search bar fix

* Additional fixes

* Suggested changes
2020-12-16 16:35:12 +02:00
Daniel Vaz Gaspar 2302adb61a
feat(datasets): security perm simplification (#12000)
* feat(datasets): security perm simplification

* feat(datasets): security perm simplification

* fix tests

* fix tests

* fix tests

* fix tests

* fix tests

* include SqlMetricInlineView converge and fix JS tests

* update to current alembic revision
2020-12-16 11:49:03 +00:00
Kasia Kucharczyk 9c8b65d03f
feat(annotations): security permissions simplification (#12014)
* Changed security permissions for annotations and annotation layers

* Updated permissions in annotation layers list

* Created test for retrieving premissions info. Updated uris from f-strings to strings

* Updated annotations in security_tests and added annotations to NEW_SECURITY_CONVERGE_VIEWS

* Added migration for annotations security converge

* Updated current revision after rebase master

* Updated migration name to annotations security converge

* Updated annotations permissions names in AnnotationLayersList and updated test since 'can_write' has wider permissions

* Updated annotations migration to current
2020-12-16 09:08:06 +00:00
Geido 0ee03ae440
fix: Closes #11864 - Duplicate PropertiesModal (#12038)
* Closes #11864

* Fix typo
2020-12-16 10:01:34 +02:00
Kamil Gabryjelski 794d318989
refactor: Migrate react-select to Antd Select in Metrics and Filters popovers (#12042)
* Migrate react-select to Antd select in Metrics popover

* Fix tests

* Migrate react-select to Antd select in Filters popover

* Migrate SelectControl to Antd Select

* Add label with number of options left
2020-12-15 21:20:10 -08:00
Beto Dealmeida 8bda6b0bd9
feat: show missing parameters in query (#12049)
* feat: show missing parameters in query

* Fix lint

* Address comments

* Simplify error message

* Use f-string in helper function
2020-12-15 18:47:40 -08:00
Grace Guo 8da1900d8a
feat: add hook for dataset health check (#11970)
* feat: add hook for dataset health check

* add event log

* optimize datasource json data like certified data

* add unit test

* fix review comments

* extra code review comments
2020-12-15 18:12:06 -08:00
Jesse Yang 76f9f185fb
refactor: optimize backend log payload (#11927) 2020-12-15 17:22:23 -08:00
Beto Dealmeida 77cae64ccd
feat: Add new default dashboard (#12044)
* feat: Add new default dashboard

* Fix license

* Update data URL
2020-12-15 14:21:51 -08:00
Beto Dealmeida 5e811a14ef
feat: load examples from config instead of code (#12026)
* feat: load examples from config instead of code

* Remove database

* Update data URL
2020-12-15 13:44:23 -08:00
Beto Dealmeida e0079bb5ae
fix: small fixes to the new import/export (#12064) 2020-12-15 12:24:24 -08:00
Moriah Kreeger 52e970a520
fix(annotation layers): remove redirect on layer edit (#12063) 2020-12-15 12:21:10 -08:00
Beto Dealmeida 862c251924
feat: handle new export in CLI (#11803)
* feat: handle new export in CLI

* Fix imports

* Fix lint

* Set options based on feature flag

* Fix lint

* Fix lint

* Add better error messages
2020-12-15 11:21:13 -08:00
adam-stasiak-polidea 7dac150dc6
fixed CONTRIBUTING typos (#12057) 2020-12-15 09:07:34 -08:00
Victor Malai 12e086dc61
refactor: Transform URLShortLinkModal to Typescript (#11971)
* Transform jsx modal to tsx modal

* Change required type

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
2020-12-15 08:12:00 -08:00
Daniel Vaz Gaspar f79e52f48e
feat(charts): security perm simplification (#11981)
* feat(charts): security perm simplification

* fix superset explore

* fix JS test

* fix cypress test

* fix split heads

* fix favorite permission

* fix permission

* update with new async permission

* fix new permission coming from master

* fix core permission assert

* black

* update alembic down revision
2020-12-15 11:27:06 +00:00
Ville Brofeldt 821b01737d
fix(viz): remove orderby from sample request (#12055) 2020-12-15 12:54:32 +02:00
Evan Rusackas 2df519eab0
upgrade react-split (#12054) 2020-12-15 00:54:35 -08:00
Daniel Vaz Gaspar 0f979dea06
feat(reports): security perm simplification (#11853)
* feat: security converge report

* black

* fix: comment

* add frontend changes and rebase

* fix multiple heads
2020-12-15 08:48:00 +00:00
Daniel Vaz Gaspar 832267c776
fix(reports): log duration and sort column (#12039) 2020-12-15 08:44:30 +00:00
Daniel Vaz Gaspar 20b1aa7d6c
fix(reports): apply owners security validation (#12035)
* fix(reports): apply owners security validation

* fix pylint
2020-12-15 08:43:31 +00:00
Victor Malai 329dcc314e
fix: Fix style for error modal (#11996)
* Fix style for error alert

* Revert test code
2020-12-15 00:03:53 -08:00
Evan Rusackas 7a7da27253
chore: bumping plugin packages to latest (#11957)
* chore: bumping plugin packages to latest

* new package-lock.json
2020-12-14 23:19:35 -08:00
ʈᵃᵢ 6fcda5dac1
feat: add cron picker to AlertReportModal (#12032)
* humanize cron display in list view
2020-12-14 22:29:31 -08:00
ʈᵃᵢ fda3a2fe7c
fix: disable browser autocomplete for DeleteModal (#12043) 2020-12-14 14:10:55 -08:00
Hugh A. Miles II 3d56f58ef5
fix: Explore "Change Dataset" UX Enhancements (#12006) 2020-12-14 13:17:20 -05:00
Lily Kuang d5b16bcd85
fix schema datasource modal (#12018) 2020-12-14 08:44:47 -08:00
adam-stasiak-polidea 6311a9ec8c
feat: Added setup for running Cypress tests in docker locally (#11207)
* Working configuration

* Fixes

* Set database volume directory. Added info in CONTRIBUTING how to avoid malformed database in tests.
2020-12-14 08:06:19 -08:00
Geido 1afe91579e
refactor: Existing Antd Collapse to enhanced (#12013)
* Move ProgressBar to Antd

* Remove trailing space

* Fix linting issues

* Export enhanced Progress only

* Move existing antd Collapse to enhanced Collapse

* Move enhanced props up to Collapse only

* Add stories for enhanced Collapse

* Add 100% height for overflow

* Improve text light story
2020-12-13 22:57:08 -08:00
Evan Rusackas fee9bbe57b
style: Restoring menu highlights (#12024)
* restoring highlights

* fixing copypasta
2020-12-13 22:48:26 -08:00
Srini Kadamati 3e22668f8d
docs: restored page on roles in security, executed other touchups, and… (#11978)
* Restored docs page on roles in security, executed other touchups, and renamed docs readme.txt to readme.md

* missed a url anchor on the security page

* fixed licensing issue and limited char width to 80

* fixed licensing issue and limited char width to 80

* whitespace experiments

* removed 2 periods

* staging whitespace

* addressed Robs feedback

* implemented robs second round of feedback on public_role_like
2020-12-13 14:06:14 -08:00
Victor Malai 022d755640
refactor : Change menu name and reorder items (#11993)
* Change menu name and reorder items

* change type

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
2020-12-12 21:58:57 -08:00
Victor Malai 90ed3267e4
fix: Change url & add check for active item in menu (#11915)
* Change url & add check for active item in menu

* Refactor to pass lint validation

* Fix lint

* Revert back and remove underline
2020-12-11 20:25:29 -08:00
Beto Dealmeida 45703a1dea
feat: update IDs when importing dashboards (#11991)
* feat: update IDs when importing dashboards

* Fix typos
2020-12-11 18:19:36 -08:00
Beto Dealmeida 9277a54a12
feat: add confirmation dialog for imports (#11983)
* feat: add confirmation dialog for imports

* Small fixes

* Clean return
2020-12-11 17:23:43 -08:00
Moriah Kreeger 696308715d
feat: alerts/reports add/edit modal (#11770) 2020-12-11 15:50:08 -08:00
Beto Dealmeida 5d8ecc01b7
fix: add default position to dash export (#12007)
* fix: add default position to dash export

* Add constants
2020-12-11 11:55:33 -08:00
Beto Dealmeida 2769de3731
chore: remove generic type (#12003)
* chore: remove generic type

* Make resourceName type stricter

* Fix type

* Fix type

* Fix lint
2020-12-11 10:52:26 -08:00
Daniel Vaz Gaspar 916f7e923a
fix(dataset): fetch metadata on dataset creation may raise broad exceptions (#11973)
* fix(dataset): fetch metadata on dataset creation may raise broad driver exceptions
2020-12-11 11:07:43 +00:00
Victor Malai 12d9d1eccb
refactor : Transform SaveModal to typescript (#11951)
* Transform SaveModal to typescript

* Revert title

* Resolve code review

* Refactor

* Refactor

* Change

* Call method

* Fix test

* ShouldPersist default false

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
2020-12-10 23:02:03 -08:00
Rob DiCiuccio 4d329071a1
feat(SIP-39): Async query support for charts (#11499)
* Generate JWT in Flask app

* Refactor chart data API query logic, add JWT validation and async worker

* Add redis stream implementation, refactoring

* Add chart data cache endpoint, refactor QueryContext caching

* Typing, linting, refactoring

* pytest fixes and openapi schema update

* Enforce caching be configured for async query init

* Async query processing for explore_json endpoint

* Add /api/v1/async_event endpoint

* Async frontend for dashboards [WIP]

* Chart async error message support, refactoring

* Abstract asyncEvent middleware

* Async chart loading for Explore

* Pylint fixes

* asyncEvent middleware -> TypeScript, JS linting

* Chart data API: enforce forced_cache, add tests

* Add tests for explore_json endpoints

* Add test for chart data cache enpoint (no login)

* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag

* Add tests for tasks/async_queries and address PR comments

* Bypass non-JSON result formats for async queries

* Add tests for redux middleware

* Remove debug statement

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Skip force_cached if no queryObj

* SunburstViz: don't modify self.form_data

* Fix failing annotation test

* Resolve merge/lint issues

* Reduce polling delay

* Fix new getClientErrorObject reference

* Fix flakey unit tests

* /api/v1/async_event: increment redis stream ID, add tests

* PR feedback: refactoring, configuration

* Fixup: remove debugging

* Fix typescript errors due to redux upgrade

* Update UPDATING.md

* Fix failing py tests

* asyncEvent_spec.js -> asyncEvent_spec.ts

* Refactor flakey Python 3.7 mock assertions

* Fix another shared state issue in Py tests

* Use 'sub' claim in JWT for user_id

* Refactor async middleware config

* Fixup: restore FeatureFlag boolean type

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-12-10 20:21:56 -08:00
Grace Guo 0fdf026cbc
feat: add invisible layer on loading chart (#11994) 2020-12-10 16:15:10 -08:00
Lily Kuang df6efb6aa2
feat: alert/report execution log list view (#11937) 2020-12-10 15:15:13 -08:00
Beto Dealmeida 475f59cb1c
feat: confirm overwrite when importing (#11982)
* feat: confirm overwrite when importing

* Skip flaky test
2020-12-10 14:50:10 -08:00
Beto Dealmeida 9e07e10055
chore: move passwords needed message (#12002) 2020-12-10 11:47:54 -08:00
Michael S. Molina 3a6254184a
refactor: Removes hard coded colors (#11977)
* Removes hard coded colors

Removes hard coded colors defined in src/components/styles.ts. The colors defined in this file were used only in the Select component so they were migrated to src/components/Select/styles.tsx and ajusted to conform to the theme colors.

* Use theme context for Select styles

* Includes Theme Provider in tests with Select
2020-12-10 11:43:57 -08:00
Beto Dealmeida 9256b6fb3d
chore: consolidate common code in importers (#11936)
* chore: consolidate common code in importers

* Small fixes

* Small fixes
2020-12-10 10:11:58 -08:00
Victor Malai 38bb6f3f20
fix : Fix style for header (sqllab) (#11980)
* Fix style for header

* flex

* Refactor

* Remove styled from import

* Change width of container

* Add tooltip and set fixed width of sidebar

* Fix lint

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
2020-12-09 23:34:43 -08:00
Mayur Newase 8cc566792a
fix(explore): changing metric aggregate doesn't update label (#11946)
* fix: [chart]heatmap selecting metrics does not update the query results
fixes issue #11866
title's label is overriding metric label.

* Using custom label to decide label of metrics.

* lint

* Tests fixed

* early metric label check while saving from ui

* early custom label check

* removed extra space

* no state mutations

* simplify

* removed log

* nned to fix linting issue

* Lint fixed
2020-12-10 09:30:57 +02:00