* Enabled mssql
* Enabling pylint rules in `mysql.py` from `db_engine_specs`:
- added variable to shorten line and enable `line-too-long`
- `import-error` seems not prompting anymore
- specified exception instead broad-except
* Refactored too long line in `oracle.py` from `db_engine_specs`. Enabled too-long-line pylint rule.
* Changed fstring into string `pinot.py` to reenable `f-string-without-interpolation` rule.
* Enabled `unused-import` rule and changed line to adjust to correct number of characters in `db_engine_specs/postgres.py`.
* Enabled unused-import pylint check in `db_engine_specs/presto.py`
* Enabled unused-import pylint check in `db_engine_specs/snowflake.py`
* Enabled unused-import pylint check in `db_engine_specs/sqlite.py`
* Removed unused pylint rule `too-many-instance-attributes` from SqlaTable class.
* Removed unecessary rule: `bad-whitespace` from `get_sqla_query` method
* Disabling too-many-instance-attributes since it fails on CI
Fixed a couple of criticle errors and left the warnings as is (mostly
from react-hooks/exhaustive-deps).
Let's fix the warnings in future PRs as sometimes unexhaustive deps
are intentional.
* Athena.py: cretaed variable for too long line, removed disabled pylint rule.
* Enabled `line-too-long` in `drill.py`. Added variable for too long string.
* Reformatted hana.py:
- changed return statement into two lines to keep line lenght limit
* Enabling pylint rule in hive.py:
- `no-name-in-module` for pyhive in several places
- `line-too-long` and adding new lines
- `unused-import` is not invalid anymore
* Enabled `line-too-long` in `kylin.py`. Added variable for too long string.
* Enabled `unused_import` in `base.py` from db_engine_specs module.
* Enabled `unused_import` in `bigquery.py` from db_engine_specs module.
* Enabled `unused_import` in `druid.py` from db_engine_specs module.
* fix: athena datetime string converting
* feat(row-level-security): add filter type and group key
* simplify tests and add custom list widget
* address comments
* use enum value to ensure case sensitive value is used
* Updated `put` method in `datasets/api.py`:
- changed return statements in put method
- removed disabled pylint rule too-many-return-statements
- removed disabled pylint rule arguments-differ since arguments match
* Removed disabled pylint rule arguments-differ in `delete()` method since arguments match
* Removed global pylintrc rule: bad-continuation. Black repaired it.
* Enable global pylintrc rule: duplicate-code. It might help with providing clean code and future refactors.
* Removed global rule `dict-iter-method` since Python3 doesn't support methods: dict.iterkeys(), itervalues() or iteritems()
* Removing global disabler rule `invalid-unary-operand-type`, because all unary operators are used on objects which supports those operations
* Specified an exceptions in reading cache in `get_df_payload()` method
* Reverted change after review:
- added broad exception in `get_df_payload` method
* Refactored `put` method in dashboards/api.py:
- changed retun statements
- removed lint disabled rule
* `arguments-differ` disabled rule is not anymore valid - put argiments don't differ
* `delete()` method in dashboards/api has now same list of argiments:
- removing unecessary pylint check disabled
* `bulk_delete()` method in dashboards/api has now same list of argiments:
- removing unecessary pylint check disabled
* one simple redirect, as a test
* adding license to header
* painstakingly added SEO redirects!
* addressed feedback and ran lint-fix!
* lets try newline again!
* Revert "lets try newline again!"
This reverts commit 20f89bd23c.
* Revert "Revert "lets try newline again!""
This reverts commit e441edc54a.
* wait... there were TWO newlines?
Co-authored-by: Evan Rusackas <evan@preset.io>
* ignore docs on several actions, give docs its own action
* Random doc change to see if the new action runs.
* umm... not paths-ignore, paths!
* eof fix
* enabling typescript checking on docs
* Removed conflicting lint and isort check in model helpers seems it's not appearing anymore
* Removed disabled linting for accessing private method. `parent_foreign_key_mappings` becomes public because it is accessed by other instance than `self`.
* Updated model's helper - removed unecessary exception and replaced with check while accessing global context to reset ownerships.
* Updated model's helper - renamed unused attribute to private in user link method.
* Updated model's helper - added specific exception for adding extra json column. Removed disabled pylint rule.
* Applied changes after review to `models/helpers.py`:
- removed unecesary function's param rename
- added extra JSON content in exception
* Removed self.extra_json content from exception message.
* Updated common/query_context.py
- removed disabled pylint rule no-self-use from `df_metrics_to_num` since it has `@staticmethod`
- applied black on the file
* Removed disabled lint check `too-many-locals` in get_df_payload method. Applied black.
* Method `get_data()` has self param:
- removing # pylint: disable=no-self-use
- autoformatting
Kasia Kucharczyk
ʈᵃᵢ
Daniel Vaz Gaspar
Lily Kuang
Beto Dealmeida
Jesse Yang
Erik Ritter
Kamil Gabryjelski
Ville Brofeldt
Karthikeyan Singaravelan
Maxime Beauchemin
Evan Rusackas
adam-stasiak-polidea
Moriah Kreeger
Bogdan
Srini Kadamati
Elizabeth Thompson