Commit Graph

4483 Commits

Author SHA1 Message Date
Erik Ritter
0754f294e9 [Dashboard] Hide slice titles when they're empty (#8018) 2019-08-12 21:55:46 -07:00
Maxime Beauchemin
5375745193
Improve release instructions (#8016) 2019-08-12 14:01:15 -07:00
Erik Ritter
f039e17cd3 [SQL Lab] Improve perf for filterable table rendering (#8011) 2019-08-12 12:24:45 -07:00
Tom Hunter
2476814a6a [feat] Add d3 legend formatting for Arc, Polygon and Scatter deck.gl maps (#7951)
* Legend formatting for Arc, Polygon and Scatter

* fix typo

* refactor from d3-format to superset-ui
2019-08-10 18:55:56 -07:00
Arthur P
2ab8e15ddf Fix: There was an issue fetching the favorite status of this dashboard #6824 (#8013)
Issue: When Superset is running behind a reverse proxy and the dashboard page is requested with HTTPS protocol, the frontend can't retrieve the favorite status of the dashboard and, instead, displays the following toast message: 'There was an issue fetching the favorite status of this dashboard.'

Cause: While the API exposes the /favestar/Dashboard/{id}/count/ endpoint, the frontend executes an API call to /favestar/Dashboard/{id}/count, which leads to a redirect to an endpoint with HTTP protocol

Fix: Call the correct endpoint
2019-08-09 15:44:38 -07:00
schoel-bis
6df2a713e4 Fix tooltips not visible for NVD3 charts on Firefox (#7822) (#7929)
This bug was introduced by #7102

Using `position:absolute` on body gives `document.documentElement` a height of 0 which propagates to `clientHeight` on Firefox. This leads to a wrong calculation of the tooltip position in NVD3.

The solution proposed here is to use `min-height: 100vh` instead of the current technique for stretching the body element to the full window height, thus keeping body and html together.
2019-08-09 13:31:51 -07:00
semantiDan
aebffe0b44 Added better display of NULL values in FilterableTable (as in SQL Lab Results) (#8003)
* Added better display of NULL values in FilterableTable (Reults table as in SQL Lab results) and changed sorting order so that NULL values always come last

* fixed syntax according to elint recommendations

* changed code style and logic in getContentCell according to @etr2460 code review

* remvoved 'null-cell' class and replaced it with 'text-muted' as per @mistercrunch review
2019-08-09 19:07:59 +03:00
Dave Smith
9233a63a16 Event logger config takes instance instead of class (#7997)
* allow preconfigured event logger instance; deprecate specifying class

* add func docs and simplify conditions

* modify docs to reflect EVENT_LOGGER cfg change

* commit black formatting fixes and license header

* add type checking, fix other pre-commit failues

* remove superfluous/wordy condition

* fix flake8 failure

* fix new black failure

* dedent warning msg; use f-strings
2019-08-08 13:47:18 -07:00
Dave Smith
cd544fa6bc Local config no longer fails to import silently (#8006)
* Local config no longer fails to import silently

* fix types, use f-strings

* fix unhelpful pylint import error

* tweaked comment
2019-08-08 13:36:27 -07:00
Daniel Vaz Gaspar
73cdad2375 [SQLLab] Fix, database api unlimited page size v2 (#8002)
* [database] Fix, Removes the limit for the page size, Bump FAB to 2.1.8

Old FAB API had no limits by default, this will keep this behaviour
but only for this endpoint

* [sqllab] Add test for database API

* [sqllab] Add test for database API

* [sqllab] Include page zero on request

* [sqllab] Fix, Black and requirements

* [sqllab] Make database API return unlimited results

* [sqllab] just a test

* [sqllab] Bump FAB to 2.1.9

* [sqllab] Remove unused import
2019-08-08 11:37:00 -07:00
Maxime Beauchemin
2f2a3b79b4
Setup FOSSA as part of CI (#7999)
* Setup FOSSA as part of CI

* Add comments and links to FOSSA docs on script
2019-08-07 21:08:10 -07:00
Matthew Mutiso
cbfd1302c0 Update to fix the broken blueprints link (#7949)
* Updated to fix the broken blueprints link

The current link is http://flask.pocoo.org/docs/0.12/blueprints/ which redirects to a non-existent page. The new link is https://flask.palletsprojects.com/en/1.1.x/tutorial/views/.

* Link to the current Flask version(1.0.x)
2019-08-07 14:31:22 -07:00
Ville Brofeldt
8cd8ec16d5 Fix Pandas 0.24 DateOffset bug pt. 2 (#7981)
* Fix pandas 0.24 DateOffset bug

* Add try-catch for DateOffsets that don't support normalize
2019-08-07 14:17:23 -07:00
Erik Ritter
cd6de3a1d8 [Jinja] Make Presto template functions backwards compatible (#7993) 2019-08-07 09:35:16 -07:00
Grace Guo
b380879c41
[fix] reduce content in sql lab localStorage (#7998) 2019-08-06 21:23:40 -07:00
Maxime Beauchemin
af2b92d147
Fix #7984 (#7985)
See https://github.com/apache/incubator-superset/issues/7984 for more
details
2019-08-06 21:15:47 -07:00
Erik Ritter
e830474e5b Revert "Bump FAB to 2.1.8 (#7986)" (#7996)
This reverts commit 0c817e5fa9.
2019-08-06 16:56:02 -07:00
Erik Ritter
b62c122b4d Revert "[database] Fix, Removes the limit for the page size (#7987)" (#7995)
This reverts commit 8db419fe99.
2019-08-06 16:14:27 -07:00
Erik Ritter
4543898e29 Bump nvd3 charts for tooltip fix (#7994) 2019-08-06 15:23:54 -07:00
John Bodley
c6867d22b9
[init] Setting up cache before registering blueprints (#7992)
* [init] Setting up cache before registering blueprints

* Update __init__.py
2019-08-06 14:45:39 -07:00
Krist Wongsuphasawat
e455f1d86a
Bump @superset-ui versions (#7989)
* starting

* fix: upgrade chart error

* fix: address comments

* fix: package lock

* fix: bump typescript version
2019-08-06 10:41:37 -07:00
Daniel Vaz Gaspar
8db419fe99 [database] Fix, Removes the limit for the page size (#7987)
Old FAB API had no limits by default, this will keep this behaviour
but only for this endpoint
2019-08-05 22:52:43 -07:00
Daniel Vaz Gaspar
0c817e5fa9 Bump FAB to 2.1.8 (#7986) 2019-08-05 22:52:17 -07:00
John Bodley
fdb62e9865
[flake8] Ignoring I202 (#7988) 2019-08-05 15:01:33 -07:00
Erik Ritter
d58dbad076 [DB Engine] Support old and new Presto syntax (#7977) 2019-08-05 11:56:56 -07:00
John Bodley
f7af50c399
[security] Adding docstrings and type hints (#7952) 2019-08-05 11:24:13 -07:00
Ville Brofeldt
b856666ae2
Remove collation info from MSSQL column type (#7963) 2019-08-05 17:08:58 +03:00
Ville Brofeldt
a1261d7f9a
Bump sqlparse to 0.3.0 (#7973)
* Black

* Bump sqlparse to 0.3.0

* Convert str.format() to f-string
2019-08-05 17:08:05 +03:00
Beto Dealmeida
b8ca0783ff
Fix for new Pandas API (#7975) 2019-08-02 15:28:39 -07:00
Gianluca Ciccarelli
e23920b8ba 7620: Start removing dependencies on requests (#7643)
* 7620: Start removing dependencies on requests

* Patch urllib.request.urlopen instead of requests.get

* Try to fix flake8

* More work on flake8 import errors

* First attempt at using urllib with cookies

* Fix pylint/flake8

* Fix test_deliver_slice_csv_attachment

* Fix test_deliver_slice_csv_inline

* Import requests and pydruid conditionally, remove dependency on prison

* Fix flake errors

* Fix load_examples

* Please flake

* Skip tests depending on optional deps

* Try to please flake

* Address review comments

* Remove Druid-related UI

* Revert "Remove Druid-related UI"

This reverts commit d7e0f166cc3f3dd2496b4a666e177f0c191aeb0f.

* Skip a few tests more

* Put imports in right order

* Apply black patch

* Please flake

* Please black, silence flake

* Use flake8 silencing the right way

* Add deps for CI
2019-08-02 10:01:28 -07:00
Ville Brofeldt
cbac428b28 Bump python requirements file (#7965)
* Bump requirements.txt

* Cap gunicorn to <19.9.0 due to X-Forwarded-Proto regression

* Remove python-dotenv from requirements-dev.txt

* Cap sqlparse due to regression in 0.3.0
2019-08-01 13:41:07 -07:00
Ville Brofeldt
1f121183fb
Use python3 for black to support py>=3.6 (#7964) 2019-08-01 18:06:43 +03:00
Beto Dealmeida
a09f258379 Fix createDatasource (#7955) 2019-08-01 11:01:46 +03:00
Beto Dealmeida
10f00cdde3
[fix] Isolate and improve performance on tagging system (#7858)
* Fix tag perf

* Add ASF header

* Make script idempotent

* Add CLI to sync tags

* Add missing file

* Merge heads

* Fix lint

* Remove script
2019-07-31 09:19:39 -07:00
John Bodley
9b7261f101
Update .travis.yml (#7943) 2019-07-30 07:45:25 -07:00
Erik Ritter
dcef5a25b1 Bump nvd3 chart plugin (#7932) 2019-07-29 16:56:03 -07:00
Tom Hunter
b7b517a102 [fix] bug on FixedOrMetricControl component causing issues with deck.gl polygon height + deck.gl scatter radius controls (#7924)
* [WIP] bug fix for FixedOrMetricControl not rendering

* Updated value preview and type selection

* fix metric control not on setting polygon elevation data

* Updated layout of FoM comp

* linting fixes

* linting fix pt. 2

* linting fix pt. 3

* fix scatter tooltip to work with metric control

* Fixed tests
2019-07-29 16:53:52 -07:00
Grace Guo
06d547fbac
[feature flag] Enforce csrf protection on explore_json endpoint (#7935)
also added a section for featured flags in http://superset.incubator.apache.org/installation.html
2019-07-29 16:22:47 -07:00
Sayed Mohammad Hossein Torabi
d37b7cdce8 fixing error related to install codecove in travis (#7940) 2019-07-29 11:18:12 -07:00
John Bodley
af462fe79f
[revert] Partial revert of #7888 (#7933) 2019-07-29 09:19:21 -07:00
Daniel Vaz Gaspar
994ac04c1f [cli] New, command line option to create or set a db URI (#7918)
* [cli] New, command line option to create or set a db URI

* [tests] New, get or create db on utils

* [tests] flake8 and black

* [tests] Fix, remove dummy comments

* [cli] dummy commit to re-trigger build

* [cli] dummy commit to re-trigger build
2019-07-27 17:43:39 -07:00
Maxime Beauchemin
5f98d661f8
Fix #7130 - SQL Lab table name autocomplete (#7926) 2019-07-27 17:42:41 -07:00
Daniel Vaz Gaspar
54875756bb [log] Disable Log view when FAB security views are disabled (#7920)
* [log] Disable Log view when FAB security views are disabled

* [tests] New, config flag SUPERSET_LOG_VIEW to have more control

* [tests] Fix, flake8

* [log] Fix, pylint

* [log] Fix, pylint at log module

* [log] Fix, pylint at log module

* [log] Fix, black
2019-07-27 17:42:10 -07:00
Daniel Vaz Gaspar
eb891dc5b8 [sqllab] Fix, #7928 query async not working (#7930)
* [sqllab] Fix, #7928 query async not working

* [sqllab] Fix, allow_ctas and allow_multi_schema_metadata_fetch missing

* [sqllab] Fix, removed column selection on database selector

* [sqllab] Fix, removed config
2019-07-27 09:26:03 -07:00
Maxime Beauchemin
f1d566a90c
Fixing the build after travis upgraded Ubuntu (#7931)
* Fixing the build after travis upgraded Ubuntu

It seems Travis has been updated/ing its build environment to Ubuntu
16.04 from Ubuntu 14 in the past few days. This broke a bunch of things
on our side.

* postgres -> postgresql

* Fix java

* Try openjdk8

* Fix, license check oracle and python

* Fix, license check oracle and python v2

* Fix, license check oracle and python v3

* Fix, license check oracle and python v4

* dummy commit, just to trigger the build
2019-07-27 08:33:03 -07:00
Grace Guo
df9efa8ed9
[dashboard] fix chart showing loading icon when filter updated immuned fields (#7895) 2019-07-25 10:37:44 -07:00
Erik Ritter
51b34e4751 [Profile] Fix 5xx when user not found (#7864) 2019-07-24 09:16:05 -07:00
Ville Brofeldt
72d1011023
[sqllab] Fix limit parsing bug when using limit-offset comma notation (#7912)
* Fix limit parsing bug when using limit-offset comma notation

* Use native sqlparse semantics to find limit

* black
2019-07-24 08:18:39 +03:00
Ville Brofeldt
07a76f83b1
[Bugfix] Remove prequery properties from query_obj (#7896)
* Create query_obj for every filter

* Deprecate is_prequery and prequeries from query_obj

* Fix tests

* Fix typos and remove redundant ; from sql

* Add typing to namedtuples and move all query str logic to one place

* Fix unit test
2019-07-23 22:13:58 +03:00
Maxim Sukharev
2221445f44 Fix incorrect datasource_name in dashboard export (#7892)
The bug was introduced in #7773

It uses filter by `cls.table_name == datasource_name`:
https://github.com/apache/incubator-superset/pull/7773/files#diff-a8dd5ec8d8decda2e3c5571d1ec0cdb6R740

But export puts `slc.datasource.name` into exported json:
https://github.com/apache/incubator-superset/pull/7773/files#diff-ceeb7eee8d573333109e0037299c9711L673

`slc.datasource.name` in case of `SqlaTable` is `"{}.{}".format(self.schema, self.table_name)`
2019-07-22 22:31:47 -07:00