* Highlight affected slices for filter change in dashboard view
Done:
- When user adds/deletes a filter in dashboard, affected slices will
have their header highlighted for 2 seconds
* Modified highlight to a more subtle box shadow
* Added slice-cell class for highlight transition
* Changed class name to slice-cell-highlight
* Added dashboard standalone page
* Deleted additional template, parameterized dashboard.html for standalone
* Only wrap add-slice-container for standalone instead of including whole modal
* Use standalone_mode argument passed from both explore view and dashboard view
* Adjusted top margin of heatmap plot to get it working in V2
Problem:
The heatmap in V2 was shifted towards the top margin of slice
container, this was because in v2 slice name header was part of the
container body, while in v1 the header was separately defined in
explore.html template.
Solution:
To get heatmap properly shown in V2, we need to
take into account the height of the slice_name header. Adding to
margin_top will shift the plot in V1 too, but it won't make a big
difference to the look.
Ideally when we renovate slice container in future PR we would defined a
height for slice_name header and take it into account for all
visualization files.
* Added panel header height to margin_top for explore v2
* Use getBoundingClientRect to get header height
* Use slice-header for id of panel-title
* Added url shortner for sharing query link
* Move shortener outside CopyToClipboard and move ajax call to common.js
* transfer dbId to int to avoid failed prop
* Added d3format() function to mock slice in explorev2
Problem:
table viz was not working in explorev2 due to d3format() not defined in
mock slice.
* Change column_formats to camel case
* [sqllab] add support for results backends
Long running SQL queries (beyond the scope of a web request) can now use
a k/v store to hold their result sets.
* Addressing comments, fixed js tests
* Fixing mysql has gone away
* Adressing more comments
* Touchups
* Enable "Clone to New Tab" btn in QueryHistoryTable
Method #1; doesn't feel very clean.
Going to attempt to reimplement using an action and changing state directly
through the reducer rather than creating a new QueryEditor object directly from
the QueryTable
* Move Clone Logic to Action
* Implement PR feedback
* Clean up reducer action; fix bug
Bug => Attempting to clone anything other than the most recent Query for a given
TabbedQueryEditor would throw an exception, because we depended on lastQueryId
to find the title of the QueryEditor to clone. Since you can only activate a
clone from the currently active tab, we can instead fetch the ID of the Editor
to copy the Title of from the tip of tabHistory.
* Tests for Reducer Action
* Fix CodeClimate feedback
* make chart container work with nvd3_vis.js
* map vis to module, remove unneeded components
* fix linting
* use existing query and save btns, don't fork more things
* comment out chart and exploreviecontainer specs
* make a change because i think the js test is failing spuriously
* Changed eslint channel in codeclimate.yml for object spread
* Revert "Changed eslint channel in codeclimate.yml for object spread"
This reverts commit b9deb8ce84478f9c8f48ca7d41662e7222f40376.
* Took out the object spread operator
