Commit Graph

198 Commits

Author SHA1 Message Date
John Bodley 9ef2861fbd
Update CONTRIBUTING.md (#17016) 2021-10-07 10:38:40 -07:00
Geido 271ec6ec75
chore: Select component refactoring - SaveModal - Iteration 5 (#16446)
* Refactor Select

* Fix Cypress

* Reconcile with master

* Use onChange over onSelect

* Reconcile with latest changes

* Update Cypress

* Update Cypress test

* Fix lint
2021-09-27 18:14:58 +03:00
Ville Brofeldt a3413197de
chore: upgrade to Node 16 (#16809)
* chore: upgrade to Node 16

* add docs

* fix test
2021-09-25 07:26:35 +02:00
Michael S. Molina 99d15b25b0
chore: Moves the images folder to the assets folder (#14429)
* chore: Moves the images folder to the assets folder

* Rebases
2021-09-22 10:28:51 -03:00
John Bodley ad87ba3724
docs: Add section about updating Python requirements (#15574) 2021-07-14 07:26:29 +12:00
ofekisr b5119b8dff
refactor(tests): decouple unittests from integration tests (#15473)
* refactor move all tests to be under integration_tests package

* refactor decouple unittests from integration tests - commands

* add unit_tests package

* fix celery_tests.py

* fix wrong FIXTURES_DIR value
2021-07-01 18:03:07 +03:00
Étienne Boisseau-Sierra baf42bc2c5
docs: improve docs on running tests locally (#14102)
* Fix missing items in ToC

Thanks to whatever autoformatting tool was running (:

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* Fix minimal Python version required

Currently Python 3.7 is still supported by Superset — cf.
4b23d0ecca/setup.py (L160)

I assue it is thus safe to run the test with Py3.7.

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* List MySQL/MariaDB as OS dependecy for test

As raised in issue #14052, MySQL (or MariaDB) is required for being able
to install the Python requirements.
(I assume due to `mysqlclient` dependency — cf.
https://github.com/apache/superset/blob/master/requirements/development.txt#L23)

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* Fix which dependencies are installed for tests

To install `tox` (for running the test suite), we want to install the…
testing dependencies, rather than “simply” the local ones.

Note that the `requirements/testing` is a superset of the
`requirements/local`:
https://github.com/apache/superset/blob/master/requirements/testing.txt
vs https://github.com/apache/superset/blob/master/requirements/local.txt

Linked to issue #14052

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* Emphasize how to name demo admin user

Related to #14052

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>

* Fix max Python version required

Indeed, Python 3.9 isn't yet supported (cf. e.g., issue #14159).

Signed-off-by: Étienne Boisseau-Sierra <etienne.boisseau-sierra@unipart.io>
2021-07-01 14:11:03 +03:00
Ville Brofeldt ab7f31fd85
Revert "refactor(feature_flags configurations): remove redundant additional configuration for default vales (#15425)" (#15448) 2021-06-29 16:52:01 +03:00
Ibrahim Bolarinwa 18f3089fb5
Update CONTRIBUTING.md (#14880)
Description of the extra_filters chart parameter, usage ideas and links to source files.

Co-authored-by: Dirzel <78026187+Dirzel@users.noreply.github.com>
2021-06-28 20:07:11 +03:00
ofekisr 486b8d911f
refactor(feature_flags configurations): remove redundant additional configuration for default vales (#15425) 2021-06-28 16:30:13 +03:00
Erik Ritter 6ed0a3a9e0
chore: update documentation for frontend feature flags (#15093) 2021-06-14 10:46:50 -07:00
stellalc7 448c689988
Fix typo in contributing.md (#15152) 2021-06-14 13:23:51 -04:00
Ke Zhu 9967a5f640
refactor: adopt --app as celery global option (#15053) 2021-06-08 20:18:55 -07:00
Rob DiCiuccio 5776dcb61a
Update docs for GLOBAL_ASYNC_QUERIES_TRANSPORT (#14558) 2021-05-18 11:01:43 -04:00
Bonifacio de Oliveira cd899c5652
fix typo on CONTRIBUTING.md (#14536) 2021-05-11 11:15:32 -07:00
Bawantha Mihiran Rajapaksha 809983d32d
Uptate CONTRIBUTING.md (#13095)
add nvm latest tag --lts
2021-05-10 13:28:32 +03:00
Amit Miran 1faaf199ad
chore(docs): remove .py from db migrate -m (#14331)
no need to state the python extension 
before: add_metadata_column_to_annotation_model.py.py
after: add_metadata_column_to_annotation_model.py
2021-04-26 07:02:02 +03:00
Hugh A. Miles II 01de3096b3
chore: starter make file (#13970)
* starter make file

* yea

* update docs

* lit

* remove venv from comamnds

* venv
2021-04-22 17:54:12 -04:00
Ben Reinhart 1c6173c7ee
feat: Make async query JWT cookie domain configurable (#14007) 2021-04-11 20:33:33 -07:00
Hugh A. Miles II fd201fe834
Update CONTRIBUTING.md (#14025) 2021-04-09 11:57:53 -04:00
Rob DiCiuccio 6a81a7961c
feat: Support feature flag overrides in ephemeral test envs (#14008)
* Add support for feature flag overrides in ephemeral env cmd

* update docs to reference correct config

* Update ephemeral env docs
2021-04-08 11:05:59 -07:00
Alex Simoes 8b9c142e2b
updates load_examples to load-examples (#13897) 2021-04-06 15:30:50 +08:00
cccs-jc 507041e93b
docs: Documenting how to debug Flask app (#13813)
Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>
2021-03-31 12:12:11 -06:00
Beto Dealmeida fd63ac3687
chore: Update docs for 1.1 (#13732)
* Update docs for 1.1

* Update CONTRIBUTING.md

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update UPDATING.md

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update UPDATING.md

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update UPDATING.md

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-03-24 19:23:56 -07:00
Cemre Mengu c72c5c735b
docs(contributing): fix backend port (#13770)
8080 -> 8088
2021-03-24 09:18:05 -07:00
Kris Stern abf2c87115
Make preliminary suggested changes to CONTRIBUTING.md (#13643) 2021-03-17 14:57:13 -04:00
Elizabeth Thompson bf424e3351
docs: add file for users to see status of feature flags (#13402)
* add file for users to see status of feature flags

* move comment

* update flags per feedback

* move to subfolder and improve docs

* move CODE_OF_CONDUCT to root
2021-03-16 14:11:17 -07:00
Jesse Yang 5fca19da56
build: check potential db migration conflict for open PRs (#13498) 2021-03-10 16:02:52 -08:00
Rob DiCiuccio b21d2cfcac
build(test env): Shutdown test environments on PR close (#13452)
* Ephemeral env PR close cleanup action

* Add documentation for test envs
2021-03-09 10:19:43 -08:00
Elizabeth Thompson ec286f27c4
add more documentation around python testing and linting (#13365) 2021-03-08 16:45:37 -08:00
Jesse Yang c9f76d58f0
chore: upgrade to npm 7 and superset-ui 0.17.9 (#13100) 2021-02-15 09:45:29 -10:00
Robert H Stolz 870886ca2f
Added a note about the ! prefix for breaking changes to CONTRIBUTING.md (#13083) 2021-02-11 15:31:55 -05:00
AAfghahi 8c50cc9d1e
typo to apache/superset (#12966) 2021-02-05 14:32:03 -08:00
Jesse Yang e7ad106460
chore: update capitalization guideline (#12828)
- design guideline update
2021-01-29 14:47:57 -08:00
Amit Miran cae751ee54
update tox testing run to relevant python env (#12748) 2021-01-28 09:52:35 +02:00
mihir174 dec6661fa6
Adding design guidelines to CONTRIBUTING.md (#12749) 2021-01-27 17:25:13 -08:00
Lyndsi Kay Williams 51d1b66dca
docs: Fixed typo on line 348 (#12739)
* release: bump to 1.0.0 and CHANGELOG

* fix(explore): long metric name display (#12387)

* fix(explore): long metric name display

* add tooltip to control

* chore: Show datasets when search input is empty (#12391)

* chore: Fix typo “Rest” to “Reset” (#12392)

* chore: upgrade eslint, babel, and prettier (#12393)

* feat(explore): add tooltip to timepicker label (#12401)

* chore: change Datasource to Dataset in Explore ui (#12402)

* chore(explore):change dataset to datasource in ui

* modal

* Add space

* Changing it back🤦🏾‍♀️

* Chargeback

* fix: Refresh Interval Modal dropdown (#12406)

* fix(native-filters): incorrect queriesData state (#12409)

* refactor: from superset.utils.core break down date_parser (#12408)

* Fixes control panel fields styling (#12236) (#12326)

* feat: Resizable dataset and controls panels on Explore view (#12411)

* Implement resizable panels on explore view

* Optimize chart rendering while resizing

* Make dataset column narrower

Co-authored-by: Evan Rusackas <evan@preset.io>

* fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418)

* [12181] Fix artifacts while drag and dropping deck.gl charts.

* Run prettier

* bump superset-ui packages for rolling window change (#12426)

* chore: bump superset-ui deckgl plugin (#12466)

* fix: do not show vertical scrollbar for charts in dashboard (#12478)

* fix: do not show vertical scrollbar for charts in dashboard

* Proper fix for #11419

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* fix(dashboard): use datasource id from slice metadata (#12483)

* fix(timepicker): make pyparsing thread safe (#12489)

* fix: make pyparsing thread safe

* remove parenthesis for decorator

* fix (SQL Lab): disappearing results on tab switch (#12472)

* fix (SQL Lab): disappearing results on tab switch

* Remove state

* Fix test

* fix: import ZIP files that have been modified (#12425)

* fix: import ZIP files that have been modified

* Add unit test

* update changelog with rc2 entries

* fix: impose dataset ownership check on old API (#12491)

* fix: impose dataset ownership check on old API

* update UPDATING.md

* partially protect the old MVC also

* prevent metric and column add and update

* ci: remove refs/tags from docker tags on a release (#12518)

* ci: remove refs/tags from docker tags on a release

* wider head

* fix: lowercase all columns in examples (#12530)

* fix(explore): time table control panel (#12532)

* fix(explore): Add Time section back to FilterBox (#12537)

* Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536)

* fix: Select options overflowing Save chart modal on Explore view (#12522)

* Fix select options overflowing modal

* fix unit test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>

* Fix list filters vertical alignment (#12497)

* feat(db-engine): Add support for Apache Solr (#12403)

* [db engine] Add support for Apache Solr

* Fixing typo

* chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337)

* add rc3 changelog entries

* fix: Popover closes on change of dropdowns values (#12410)

* fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555)

* fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556)

* fix: height on grid results (#12558)

* fix: case expression should not have double quotes (#12562)

* Fix 500 error when loading dashboards with slice having deleted dataset (#12535)

* add rc4 changelog entries

* Fixed typo on line 348

* Added files

Co-authored-by: Daniel Gaspar <danielvazgaspar@gmail.com>
Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Junlin Chen <junlin@preset.io>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: Agata Stawarz <47450693+agatapst@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com>
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Grace Guo <grace.guo@airbnb.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Xiang Fu <fx19880617@gmail.com>
Co-authored-by: Ahmed Adel <github@aadel.io>
Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: Shuyao Bi <shuyaob@andrew.cmu.edu>
Co-authored-by: Lyndsi Kay Williams <lyndsikaywilliams@Lyndsis-MacBook-Pro.local>
2021-01-25 12:33:57 -08:00
Ayan Ginet 73586d8760
docs: link fix in CONTRIBUTING.md (#12718) 2021-01-24 16:40:04 -08:00
Amit Miran 0143a983b2
chore: add a note about using Draft PR's importance (#12678) 2021-01-23 09:52:57 +02:00
Michael S. Molina 0f8a62babf
chore: add capitalization guidelines to CONTRIBUTING.md (#12685) 2021-01-22 15:47:55 -08:00
Michael S. Molina c85b4c75b1
Fix translation files and update documentation (#12595) 2021-01-20 10:50:24 -08:00
Rob DiCiuccio 10c2b09942
Add docs for GLOBAL_ASYNC_QUERIES (SIP-39) (#12573) 2021-01-19 13:57:25 -08:00
Amit Miran 377f70b987
chore: update explanations about running common tasks like pylint and pre-commit (#12571) 2021-01-18 09:14:08 +02:00
Jesse Yang ff7b789931
docs: reword and cleanup docs for local dev server (#11869) 2021-01-10 23:36:01 -08:00
Amit Miran b221417e19
chore: remove harmless incubator refs (#12289)
* chore: migrate all harmless incubator refs like comments and documentation files

* chore: migrate all superset.incubator.apache.org to superset.apache.org to

* chore: migrate dist.apache.org refs

* chore: removing incubating and Disclaimer

* fix: linting issues
2021-01-06 13:45:19 +02:00
adam-stasiak-polidea 7dac150dc6
fixed CONTRIBUTING typos (#12057) 2020-12-15 09:07:34 -08:00
adam-stasiak-polidea 6311a9ec8c
feat: Added setup for running Cypress tests in docker locally (#11207)
* Working configuration

* Fixes

* Set database volume directory. Added info in CONTRIBUTING how to avoid malformed database in tests.
2020-12-14 08:06:19 -08:00
Rob DiCiuccio 4d329071a1
feat(SIP-39): Async query support for charts (#11499)
* Generate JWT in Flask app

* Refactor chart data API query logic, add JWT validation and async worker

* Add redis stream implementation, refactoring

* Add chart data cache endpoint, refactor QueryContext caching

* Typing, linting, refactoring

* pytest fixes and openapi schema update

* Enforce caching be configured for async query init

* Async query processing for explore_json endpoint

* Add /api/v1/async_event endpoint

* Async frontend for dashboards [WIP]

* Chart async error message support, refactoring

* Abstract asyncEvent middleware

* Async chart loading for Explore

* Pylint fixes

* asyncEvent middleware -> TypeScript, JS linting

* Chart data API: enforce forced_cache, add tests

* Add tests for explore_json endpoints

* Add test for chart data cache enpoint (no login)

* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag

* Add tests for tasks/async_queries and address PR comments

* Bypass non-JSON result formats for async queries

* Add tests for redux middleware

* Remove debug statement

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Skip force_cached if no queryObj

* SunburstViz: don't modify self.form_data

* Fix failing annotation test

* Resolve merge/lint issues

* Reduce polling delay

* Fix new getClientErrorObject reference

* Fix flakey unit tests

* /api/v1/async_event: increment redis stream ID, add tests

* PR feedback: refactoring, configuration

* Fixup: remove debugging

* Fix typescript errors due to redux upgrade

* Update UPDATING.md

* Fix failing py tests

* asyncEvent_spec.js -> asyncEvent_spec.ts

* Refactor flakey Python 3.7 mock assertions

* Fix another shared state issue in Py tests

* Use 'sub' claim in JWT for user_id

* Refactor async middleware config

* Fixup: restore FeatureFlag boolean type

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-12-10 20:21:56 -08:00
Rob DiCiuccio 01d15f5368
feat(templating): Safer Jinja template processing (#11704)
* Enable safer Jinja template processing

* Allow JINJA_CONTEXT_ADDONS with SAFE_JINJA_PROCESSING

* Make template processor initialization less magical, refactor classes

* Consolidat Jinja logic, remove config flag in favor of sane defaults

* Restore previous ENABLE_TEMPLATE_PROCESSING default

* Add recursive type checking, update tests

* remove erroneous config file

* Remove TableColumn models from template context

* pylint refactoring

* Add entry to UPDATING.md

* Resolve botched merge conflict

* Update docs on running single python test

* Refactor template context checking to support engine-specific methods
2020-11-17 11:55:47 -08:00
Jesse Yang 75245177e9
chore: pin node and npm versions (#11646) 2020-11-10 15:58:54 -08:00