Michael S. Molina
3a9bd12e3d
fix: Returns 404 instead of 500 for unknown dashboard filter state keys ( #17878 )
...
* fix: Returns 404 instead of 500 for unknown dashboard filter state keys
* Reduces hierarchies of if-expression
* Removes unnecessary check
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Removes unused variable
* Fixes type error
* Removes unused import
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-01-10 14:24:22 -03:00
Michael S. Molina
8ebec6016e
fix: Removes duplicated import in dashboard filter state tests ( #17887 )
2021-12-29 13:10:56 -03:00
Bogdan
afd2e9f2ca
chore: update fixtures scope that are loading data into the analytical db ( #17780 )
...
* Update db setup fixture scope
* Load data into db only once
* Update fixture scopes for data loading
* cleanup imports
* try import
* Update scope
* fix cleanup
* Import all fixtures
* Separate data log and metadata creation
* Retain table description
* fix dtype
Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2021-12-16 16:11:47 -08:00
Beto Dealmeida
c18d4862c4
chore: skip flaky test ( #17772 )
2021-12-15 17:06:40 -08:00
Evan Rusackas
3aa11614b5
fix: change 401 response to a 403 for Security Exceptions ( #17768 )
...
* fix: change 401 to 403 for Security Exceptions
* updating tests to reflect new (proper) status code
* another test update
2021-12-15 17:11:04 -07:00
Geido
12bd1fcde5
fix: Save properties after applying changes in Dashboard ( #17570 )
...
* Refactor PropertiesModal
* Update json_metadata fully
* Clean up
* Verify values
* Catch changed to metadata
* Always updated dashboard info on update
* Avoid unnecessary fetches
* Formt
* Fix copy dashboards
* Fixes onUpdate onCopy handlers
* Pylint
* Update tests
* Clean up
* Handle data on show
* Change Save to Apply
* Update Cypress save test
* Update Cypress edit prop test
* Update PropertiesModal test
* Fix duplicate request with cross filters
* Improve code style
* Fix typo
* Lint
2021-12-09 10:03:07 -07:00
Michael S. Molina
2ae83fac86
fix: Allows PUT and DELETE only for owners of dashboard filter state ( #17644 )
...
* fix: Allows PUT and DELETE only for owners of dashboard filter state
* Converts the values to TypedDict
* Fixes variable name
2021-12-05 22:13:09 -03:00
Michael S. Molina
78c5d9ac27
fix: Dashboard API flaky test ( #17611 )
2021-12-01 10:36:13 -03:00
Michael S. Molina
2f2e8fe412
feat: Adds a key-value endpoint to store the state of dashboard filters ( #17536 )
...
* feat: Adds a key-value endpoint to store the state of dashboard filters
* Fixes pylint issues
* Adds openapi schemas
* Adds more tests, move logic to commands and use singular form for the endpoint name
* Fixes model description
* Removes database model
* Adds open api specs
* Simplifies the commands
* Adds more tests
* Validates the value content and submits the correct http status code
* Fixes import order
* Skips flakky test
* Fixes tests
* Updates UPDATING.md
2021-12-01 09:06:49 -03:00
Hugh A. Miles II
2e29f36e78
fix: RBAC for export for dashboard viewers ( #17527 )
...
* set out export
* update test
* use default dataset
* update test
* these test work
* fix test
* update
* fix
* fix test
* make the test better
2021-11-25 20:10:41 -08:00
Geido
83e49fc9ee
feat: Certify Charts and Dashboards ( #17335 )
...
* Certify charts
* Format
* Certify dashboards
* Format
* Refactor card certification
* Clear details when certified by empty
* Show certification in detail page
* Add RTL tests
* Test charts api
* Enhance integration tests
* Lint
* Fix dashboards count
* Format
* Handle empty value
* Handle empty slice
* Downgrade migration
* Indent
* Use alter
* Fix revision
* Fix revision
2021-11-24 13:42:52 +02:00
Michael S. Molina
76024313c6
fix: Dashboard access when DASHBOARD_RBAC is disabled ( #17511 )
...
* fix: Dashboard access when RBAC is disabled
* Sends 403 when forbidden
* Fixes issort
* Changes assertion
* Allow access to unpublished dashboards that don't have roles
* Fixes the test_get_dashboard_changed_on test
2021-11-23 11:45:32 -03:00
Yongjie Zhao
4f1d202430
chore: use official isort in pre-commmit ( #17215 )
2021-10-25 17:57:38 +08:00
ofekisr
84f7614e97
feat(filter-set): Add filterset resource ( #14015 )
...
* Add filterset resource
* fix: fix pre-commit
* add tests
* add tests and fixes based of failures
* Fix pre-commit errors
* chore init filterset resource under ff constraint
* Fix migration conflicts
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* Fix pylint and migrations issues
* add tests and fixes based of failures
* Fix missing license
* fix down revision
* update down_revision
* fix: update down_revision
* chore: add description to migration
* fix: type
* refactor: is_user_admin
* fix: use get_public_role
* fix: move import to the relevant location
* chore: add openSpec api schema
* chore: cover all openspec API
* fix: pre-commit and lint
* fix: put and post schemas
* fix: undo superset_test_config.py
* fix: limit filterSetsApi to include_route_methods = {"get_list", "put", "post", "delete"}
* renaming some params
* chore: add debug in test config
* fix: rename database to different name
* fix: try to make conftest.py harmless
* fix: pre-commit
* fix: new down_revision ref
* fix: bad ref
* fix: bad ref 2
* fix: bad ref 3
* fix: add api in initiatior
* fix: open spec
* fix: convert name to str to include int usecases
* fix: pylint
* fix: pylint
* Update superset/common/request_contexed_based.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* chore: resolve PR comments
* chore: resolve PR comments
* chore: resolve PR comments
* fix failed tests
* fix pylint
* Update conftest.py
* chore remove BaseCommand to remove abstraction
* chore remove BaseCommand to remove abstraction
* chore remove BaseCommand to remove abstraction
* chore remove BaseCommand to remove abstraction
* chore fix migration
Co-authored-by: Ofeknielsen <ofek.israel@nieslen.com>
Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-09-23 11:27:59 +03:00
Beto Dealmeida
092ef5bdfc
fix: set importer as owner ( #16656 )
...
* fix: set importer as owner
* Fix tests
2021-09-15 12:27:02 -07:00
John Bodley
fb4650a6eb
chore(pylint): Remove top-level disable ( #16589 )
...
* chore(pylint): Remove top-level disable
* Update examples.py
* Update command.py
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-09-15 09:30:23 -07:00
Ville Brofeldt
d6f9c48aa1
feat(dao): admin can remove self from object owners ( #15149 )
2021-08-13 12:42:48 +03:00
Beto Dealmeida
7b3fce7e81
fix: revert data endpoint name ( #16162 )
2021-08-10 11:59:27 -07:00
Grace Guo
85329c374e
refactor: remove unnecessary dataset queries from dashboard requests ( #16110 )
...
* refactor: remove unnecessary dataset queries from dashboard requests
* fix comments
2021-08-06 19:01:05 -07:00
Beto Dealmeida
f104fba61d
feat: add GET /api/v1/chart/{chart_id}/data/?format{format} API ( #15827 )
...
* feat: add `GET /api/v1/chart/{chart_id}/data/?format{format}` API
* Fix test
2021-07-21 17:03:22 -07:00
Yongjie Zhao
ae160f7f21
chore: add changed_on_delta_humanized field on dashboard schema ( #15542 )
...
* chore: add changed_on_delta_humanized field on dashboard schema
* fix ut
2021-07-07 14:59:49 -07:00
ofekisr
b5119b8dff
refactor(tests): decouple unittests from integration tests ( #15473 )
...
* refactor move all tests to be under integration_tests package
* refactor decouple unittests from integration tests - commands
* add unit_tests package
* fix celery_tests.py
* fix wrong FIXTURES_DIR value
2021-07-01 18:03:07 +03:00
