Commit Graph

629 Commits

Author SHA1 Message Date
Stephen Liu
07998fea68
fix(explore): simple tab content input problem (#17872) 2022-01-03 12:41:19 +08:00
Beto Dealmeida
b7707e8ff7
feat: bypass cache on screenshots for alerts (#17695)
* feat: bypass cache on screenshots for alerts

* Update existing tests

* Add backend test

* Add frontend test
2021-12-22 08:26:38 -08:00
Stephen Liu
d5768ab649
fix(explore): make SORT-Descending visible if Sort-by has value (#17726) 2021-12-21 15:27:21 +08:00
Erik Ritter
6edc183c5f
chore: Refactor localstorage into typesafe version (#17832) 2021-12-20 13:58:59 -08:00
Geido
4b969710e4
Rename CertifiedIcon to CertifiedBadge (#17715) 2021-12-10 11:45:53 -07:00
Kamil Gabryjelski
b5b6ceb1b3
fix(explore): don't apply time range filter to Samples table (#17711) 2021-12-10 11:40:11 -07:00
Stephen Liu
bdc4e7a322
fix(explore): deck.gl Multiple chart broken (#17703) 2021-12-09 20:03:02 +02:00
Corbin Robb
f476ba23a2
fix(select): select component sort functionality on certain options (#17638)
* fix: Select component sort function sorting by label instead of value on numbers

* fix: change select component default sorting to sort by the initial index rather than a property like value or label

* fix: select sorting add sortOptions to select components using sortByProperty

* fix: change select component back, add order to options coming in from SelectControl

* fix: select component options intitial sort bug

* fix: add test cases for select fix

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-12-09 11:40:25 -05:00
Geido
46cdc77ae6
fix: Redirect on 401 (#17597)
* Redirect on 401

* Bump FAB

* Format

* Update Cypress save test

* Revert Cypress change

* Bump FAB 3.4.1rc2

* Update test

* Update return statement

* Update api test

* Update datasets api test

* Update datasets api 401s to 403s

* Add typeguard

* Use Promise.resolve

* Update callApiAndParseWithhTimeout test

* Disable parseResponse test

* Try catch

* Handle npm 8 issues
2021-12-08 13:14:30 -07:00
Kamil Gabryjelski
07e8837093
feat(explore): export csv data pivoted for Pivot Table [ID-9] (#17512)
* feat(explore): export csv data pivoted for Pivot Table

* Implement dropdown with download csv options

* Change label to "Original"

* Add tests

* Add form data to query context

* Add form data to query context generator

* Explicitly make form_data optional
2021-12-03 12:42:28 +01:00
Stephen Liu
a3cce5705d
feat(explore): support show annotation label [ID-8] (#17307)
* feat(explore): support always show annotation label

* fix: lint

* fix: lint

* Hopefully appeasing the linter

* fix: lint

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* change to allow none

* lint

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2021-12-02 00:26:32 -07:00
Michael S. Molina
a959e6df45
fix: Visualizations don't load when using keyboard shortcuts (#17542) 2021-11-29 09:14:21 -03:00
Holger Bruch
6604a6ab28
chore(translations): Add missing i18n (#17525)
* Add *.ts to babel.cfg

* Add missing i18n calls

* Update pot file

* Fix lint issues and review comment

* Incorparate review feedback

* Fix missing or non-extractable i18n calls

* Update pot file

* Fix syntax error in CommonParameters.tsx

* Fix introduced issues
2021-11-27 14:50:33 +02:00
Kamil Gabryjelski
7353a2bd75
fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) 2021-11-24 13:06:11 +01:00
Geido
83e49fc9ee
feat: Certify Charts and Dashboards (#17335)
* Certify charts

* Format

* Certify dashboards

* Format

* Refactor card certification

* Clear details when certified by empty

* Show certification in detail page

* Add RTL tests

* Test charts api

* Enhance integration tests

* Lint

* Fix dashboards count

* Format

* Handle empty value

* Handle empty slice

* Downgrade migration

* Indent

* Use alter

* Fix revision

* Fix revision
2021-11-24 13:42:52 +02:00
Evan Rusackas
6d66963489
fix: hiding HiddenControl inputs for real, to reduce bootstrap space consumption (#15182)
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-11-23 15:08:24 -08:00
Yongjie Zhao
9070b6b19c
refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
Geido
c2d8b0e72f
chore: Notify user of custom label colors and related Dashboard color scheme (#17422)
* Add alert for custom label colors

* Fix duplicate linear scheme

* Implement dashboard alert

* Remove trailing space

* Update Cypress

* Simplify check
2021-11-16 17:46:39 +02:00
Ville Brofeldt
e2a429b0c8
feat(explore): adhoc column expressions [ID-3] (#17379)
* add support for adhoc columns to api and sqla model

* fix some types

* fix duplicates in column names

* fix more lint

* fix schema and dedup

* clean up some logic

* first pass at fixing viz.py

* Add frontend support for adhoc columns

* Add title edit

* Fix showing custom title

* Use column name as default value in sql editor

* fix: Adds a loading message when needed in the Select component (#16531)

* fix(tests): make parquet select deterministic with order by (#16570)

* bump emotion to help with cache clobbering (#16559)

* fix: Support Jinja template functions in global async queries (#16412)

* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check

* fix: impersonate user label/tooltip (#16573)

* docs: update for small typos (#16568)

* feat: Add Aurora Data API engine spec (#16535)

* feat: Add Aurora Data API engine spec

* Fix lint

* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)

* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues

* refactor sql_json view endpoint: separate concern into ad hod method (#16595)

* feat: Experimental cross-filter plugins (#16594)

* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF

* chore(deps): bump superset-ui to 0.18.2 (#16601)

* update type guard references

* fix imports

* update series_columns schema

* Add changes that got lost in rebase

* Use current columns name or expression as sql editor init value

* add integration test and do minor fixes

* Bump superset-ui

* fix linting issue

* bump superset-ui to 0.18.22

* resolve merge conflict

* lint

* fix select filter infinite loop

* bump superset-ui to 0.18.23

* Fix auto setting column popover title

* Enable adhoc columns only if UX_BETA enabled

* put back removed test

* Move popover height and width to constants

* Refactor big ternary expression

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
2021-11-15 12:50:08 +02:00
Phillip Kelley-Dotson
e6ff25c980
fix(chart): ensure samples data is displayed (#16900)
* initial fix

* use data keys for cols

* add e2e test

* remove code

* trim logic
2021-11-12 14:23:46 -08:00
John Bodley
bcef8fa13b
feature: Add quarter unit to datetrunc (#17416)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-12 09:46:55 -08:00
Geido
7cdd58b2db
Fix missing dashboardId (#17380) 2021-11-11 19:07:00 +02:00
Mayur
8756c9089e
fix(dashboard): don't show report modal for anonymous user (#17106)
* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>
2021-11-11 07:50:12 -03:00
John Bodley
675ffaf8df
revert: Partial revert of 17236 (#17383)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-10 20:32:35 -08:00
Grace Guo
7d22c9ce17
feat(native_filter_migration): add transition mode (#16992)
* feat: [Migrate filter_box to filter component] add transition mode

* rebase and fix comments

* rebase and fix commnent -- patch 2
2021-11-09 09:55:25 -08:00
John Bodley
561d1ac9f2
feat(metrics): Provide override for disabling ad-hoc metrics (#17202)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-08 10:31:43 -08:00
Yongjie Zhao
b58f94ad2e
chore: bump @typescript-eslint/eslint-plugin to 5.3.0 (#17367) 2021-11-08 23:48:51 +08:00
Geido
d0085b1b29
Check validity of control item (#17349) 2021-11-05 12:56:03 +02:00
John Bodley
1c12167d8d
fix: Revert default series sort-by metric and enforce non-xor with series limit (#17236)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-03 13:59:38 -07:00
Geido
59a6502efe
fix: Color consistency (#17089)
* Update label colors on the fly

* Clean up

* Improve getFormDataWithExtraFilters

* Improve code structure

* Remove labelColors from formData

* Exclude label_colors from URL

* Refactor color scheme implementation

* Clean up

* Refactor and simplify

* Fix lint

* Remove unnecessary ColorMapControl

* Lint

* Give json color scheme precedence

* Add label_colors prop in metadata

* Separate owners and dashboard meta requests

* Remove label_colors control

* bump superset-ui 0.18.19

* Fix end of file

* Update tests

* Fix lint

* Update Cypress

* Update setColorScheme method

* Use Antd modal body
2021-11-03 19:22:38 +02:00
Daman Arora
28b494c597
chore: migrate HiddenControl component from jsx to tsx (#17315)
* migrate HiddenControl component from jsx to tsx

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* updating the type of value in the interface

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
2021-11-02 11:51:16 -07:00
Geido
5491a4d13c
fix(Explore): Remove changes to the properties on cancel (#17184)
* Remove on close

* Fix lint

* Add tests
2021-11-02 19:27:56 +02:00
Yongjie Zhao
1f2a7a40c4
fix: datatable crash when column is empty string (#17303)
* fix: datatable crash when column is empty string

* typo
2021-11-01 23:58:31 +08:00
AAfghahi
5948a9fd02
fix(AlertReportModal): Text Area Change (#17176)
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention
2021-10-29 15:30:20 -07:00
Kamil Gabryjelski
fa44325a36
fix(explore): Metrics disappearing after removing metric from dataset (#17201)
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls
2021-10-29 16:15:19 +02:00
Yongjie Zhao
faf7c74e44
chore: bump superset-ui v0.18.16 (#17251)
* chore: import ES module from chart-controls

* chore: bump superset-ui v0.18.16
2021-10-27 23:35:48 +08:00
Yongjie Zhao
dbf5225e1f
chore: bump to superset-ui 0.18.15 (#17232)
* bump 0.18.15

* prettier and update lock file
2021-10-26 19:25:34 +08:00
Ben Elgren
3641093a44
allow owners to edit chart title (#17047) 2021-10-26 12:58:07 +03:00
Elizabeth Thompson
08aab3b399
use full results as csv type (#17194) 2021-10-25 09:36:10 -07:00
Michael S. Molina
55be249870
fix: Order of Select items when unselecting (#17169)
* fix: Order of Select items when unselecting

* Adds a property comparator that supports strings and numbers

* Uses a named export for propertyComparator
2021-10-25 08:47:01 -03:00
David Aaron Suddjian
a63a01f158
small changes to dashboard->explore code (#17145) 2021-10-22 10:53:01 -07:00
Kamil Gabryjelski
860e481a97
fix(explore): timestamp format when copy datatable to clipboard (#17166)
* fix(explore): timestamp format when copy datatable to clipboard

* Fix test

* Fix test

* Use translation for aria label

* Memoize stringified cells

* Fix test
2021-10-21 16:05:14 +02:00
Michael S. Molina
e32acd22fd
chore: Moves the datasource components to the components folder (#17130) 2021-10-20 08:13:24 -03:00
David Aaron Suddjian
57f869cf22
fix(explore): remove unnecessary parameters from the explore url (#17123)
* remove unnecessary parameters from the explore url

* refactor, test
2021-10-18 15:30:15 +03:00
simcha90
eebc953dd5
feat: Custom filters control (#17006)
* fix:fix get permission function

* feat: customize filter control

* fix: fix types

* fix: fix merge

* refactor: update according CR

* refactor: fix CR notes
2021-10-15 14:14:04 +03:00
Hugh A. Miles II
959fd763a8
fix: Owners selection in dataset edit UX (#17063)
* boilerplate

* update owner select component

* this is working

* update onchange

* refactorig

* you need to useMemo or things break

* update test

* prettier

* move logic into bootstrap data endpoint

* address concerns

* oops

* oops

* fix test
2021-10-12 20:27:56 -04:00
Geido
14b7f6cdba
fix: Exclude SUPERSET_DEFAULT from the list of available color schemes (#17018)
* Handle SUPERSET_DEFAULT theme

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-11 16:16:06 +03:00
Phillip Kelley-Dotson
2c8e06e929
initial fix (#16998) 2021-10-08 10:56:14 -07:00
Geido
a57ae35011
fix: Verify when null value should be undefined in Select (#17013)
* Check for null value

* Safety chek SelectControl and SelectAsyncControl
2021-10-08 17:32:09 +03:00
Geido
66b0877445
Strict undefined check SelectControl (#17008) 2021-10-07 17:22:52 +03:00