Commit Graph

12259 Commits

Author SHA1 Message Date
Daniel Vaz Gaspar
bfd2a3d79f
fix: database permissions on update and delete (avoid orphaned perms) (#20081)
* fix: database permissions on update and delete (avoid orphaned perms)

* fix event transaction

* fix test

* fix lint

* update datasource access permissions

* add tests

* fix import

* fix tests

* update slice and dataset perms also

* fix lint

* fix tests

* fix lint

* fix lint

* add test for edge case, small refactor

* add test for edge case, small refactor

* improve code

* fix lint
2022-08-02 18:28:46 +01:00
Elizabeth Thompson
34ad80c642
add cypress codeowners to e2e tests (#20921) 2022-08-01 17:35:35 -07:00
AAfghahi
460b213057
feat: Creating dataset/add route (#20869)
* beginning of routing

* elizabeth review

* changed folder layout

* Update superset-frontend/src/views/CRUD/data/dataset/DatasetPage/index.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Update superset-frontend/src/views/CRUD/data/dataset/DatasetPage/RightPanel/index.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-08-01 16:59:40 -04:00
Lyndsi Kay Williams
8a04536f9d
feat(SqlLab): Change Save Dataset Button to Split Save Query Button IV (#20852)
* Moving entire split save btn PR

* Addressed review comments

* Remove arbitrary div from ErrorBoundary in Chart

* Added accidentally removed comment

* Fix act errors in SaveQuery tests

* Fix SaveDatasetActionButton test

* SaveDatasetModal test almost working

* SaveDatasetModal tests all passing

* Clean SaveDatasetModal test

* Fix create chart button and SaveDatasetModal text in SQL Lab

* Fix untitled dataset name on SaveDatasetModal in explore

* Fix styling on split save button
2022-08-01 14:36:34 -05:00
Hugh A. Miles II
3a11856ecb
Update Makefile (#20922) 2022-08-01 14:06:58 -04:00
Gabriel Forien
8e0f16fade
feat(helm): support different replicaCount (#20883)
* feat(helm): bump chart version

* feat(helm): add separate replicaCount for superset node / worker

* docs: update documentation

* ref(helm): add replicaCount with condition

* ref(helm): edit condition

* ref(helm): enclose replica with if/else

* ref(helm): remove specific replicaCount in values

* revert: "docs: update documentation"

This reverts commit 6ab95a71a2.

* fix(helm): fix typo

* ref(helm): replace condition with default value

* ref(helm): replace replicaCount with per-component replicaCount

Co-authored-by: Gabriel Forien <gforien.externe@bedrockstreaming.com>
2022-08-01 09:03:10 -07:00
Kamil Gabryjelski
6ec164e6a9
feat: Use SPA navigation from datasets list to Explore (#20890)
* feat: Use SPA navigation from datasets list to Explore

* fix lint

* Fix lint

* Fix type

* Make external links work without protocols

* add comment
2022-08-01 16:45:07 +02:00
Kamil Gabryjelski
90e2d82a38
fix(dashboard): Incorrect scopes of cross filters (#20927) 2022-08-01 13:39:42 +02:00
Hugh A. Miles II
bc435e08d0
fix: overwrite update override columns on PUT /dataset (#20862)
* update override columns

* save

* fix overwrite with session.flush

* write test

* write test

* layup

* address concerns

* address concerns
2022-07-29 21:51:35 -04:00
Hugh A. Miles II
67e3dc7c7b
hide modal after overwrite (#20924) 2022-07-29 19:18:11 -04:00
Eric Briscoe
1a8c28db3d
Fixes issue where type query datasource had incorrect time controls when datasource type was 'query' (#20923) 2022-07-29 18:14:03 -04:00
Hugh A. Miles II
0d8889dc9c
fix: Save dataset + chart when Chart source is Query (#20880)
* feat: save dataset savemodal

* fix lint

* add comments

* enable chart power query

* clean up

* added test

* fix overwrite

* add proper error messaging for save datasetModal

* lint

* fix ts lint

* fix

* Disables Save button while network call is in progress, removing second Chart saved toast message

* change naming

* err

* Update superset-frontend/src/explore/components/SaveModal.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Update SaveModal.tsx

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-07-29 17:30:28 -04:00
Elizabeth Thompson
4d29d16b64
fix: make a new entrypoint for deprecated postgres dialect (#20895)
* make a new entrypoint for deprecated postgres dialect

* Update setup.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2022-07-29 13:03:41 -07:00
Geido
06d05394c2
chore: Add Applitools logo to the docs homepage (#20917)
* Add Applitools logo

* Remove space
2022-07-29 20:29:47 +03:00
dependabot[bot]
adf1f5cccf
chore(deps): bump terser from 4.6.3 to 4.8.1 in /superset-frontend (#20787)
Bumps [terser](https://github.com/terser/terser) from 4.6.3 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-29 10:48:15 -06:00
dependabot[bot]
de84186200
chore(deps): bump tox from 3.24.1 to 3.25.1 in /requirements (#20822)
Bumps [tox](https://github.com/tox-dev/tox) from 3.24.1 to 3.25.1.
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/master/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/3.24.1...3.25.1)

---
updated-dependencies:
- dependency-name: tox
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-29 10:47:23 -06:00
Jesse Yang
5ae0e83b8a
fix(sqllab): hide tracking url when fetching (#20905) 2022-07-29 08:47:53 -07:00
Jesse Yang
e739ff5076
feat: allow more HTML tags in report description (#20908) 2022-07-29 08:27:39 -07:00
Cody Leff
e7acb1a79d
chore(explore): update Explore icons and icon colors (#20612)
* Update Explore icons and icon colors.

* Change shade of blue and make blue only appear when fields have never been filled in.

* Fix Cypress test.

* Update non-error validation color from blue to yellow.

* Unpack ternary.

* Replace direct AntD imports with our Icons component.
2022-07-29 09:05:15 -06:00
Cody Leff
90460f1333
Unskip Cypress test. (#20915) 2022-07-29 11:38:04 -03:00
John Bodley
8d0d778d1a
chore(mypy): enable warn_unused_ignores (#20884) 2022-07-29 00:47:53 -07:00
John Bodley
50d2e5a15d
fix: Address performance regression introduced in #11785 (#20893) 2022-07-28 22:56:39 -07:00
Just[in]Do it!
3f124d9d67
fix(plugin-chart-pivot-table): Invalid Formats Date Fields (#20909)
When a custom date field value converted in a string format, some aggregators truncated to the first four digits.
 This is caused by the parseFloat function which converts to first matched number rather than NaN(Not-A-Number) value.
 This commit replaces the parseFloat by Number wrapper to handle this case correctly.
2022-07-28 22:56:08 -07:00
Cody Leff
d50784dd80
feat(dashboard): Add thumbnails to dashboard edit draggable chart list (#20528)
* Add chart thumbnails to dashboard edit draggable charts.

* Reorganize hierarchy and add tests.

* Incorporate review suggestions.

* Update design and add tooltips.

* Fix missing thumbnails.

* Fix tests.

* Fix moving viz type label.

* Convert AddSliceCard to TS, update hierarchy.
2022-07-28 10:46:13 -06:00
cccs-RyanK
fe91974163
chore: Remove unecessary code from async and sync select components (#20690)
* Created AsyncSelect Component
Changed files to reference AsyncSelect if needed

* modified import of AsyncSelect, removed async tests and prefixes from select tests

* fixed various import and lint warnings

* fixing lint errors

* fixed frontend test errors

* fixed alertreportmodel tests

* removed accidental import

* fixed lint errors

* updated async select

* removed code from select component

* fixed select test

* fixed async label value and select initial values

* cleaned up async test

* fixed lint errors

* minor fixes to sync select component

* removed unecessary variables and fixed linting

* fixed npm test errors

* fixed linting issues

* fixed showSearch and storybook

* fixed linting
2022-07-28 10:09:37 -03:00
Yongjie Zhao
718bc3062e
fix: invalid metric should raise an exception (#20882) 2022-07-28 08:15:43 +08:00
Diego Medina
383313b105
fix(sql lab): Syntax errors should return with 422 status (#20491)
* fix(sql lab): Syntax errors should return with 422 status

* refactor
2022-07-27 12:41:17 -06:00
Diego Medina
8b354b4b69
fix: Published Dashboard without charts don't show up for non admin users (#20638) 2022-07-27 12:40:59 -06:00
Umair Pathan Abro
ab415fddd9
chore: adding Bazaar Technologies to Superset Users (#20669)
* adding Bazaar Technologies to Superset Users

At Bazaar, we are working to digitize Pakistan's retail sector. Superset is the  main BI tool that powers the Bazaar Analytics Platform (aka Buraq). Buraq handles petabytes of data from a diverse set of data stores from Hive, S3 Lakes, RDS and Redshift. Superset  allows us to make our business critical dashboards, that drives real time insights and data driven decisions to helping us to provide best in class customer experience.

* Update RESOURCES/INTHEWILD.md

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update INTHEWILD.md

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Srini Kadamati <skadamat@gmail.com>
2022-07-27 12:38:15 -06:00
dependabot[bot]
c77ea1bb6a
chore(deps): bump terser from 5.9.0 to 5.14.2 in /docs (#20786)
Bumps [terser](https://github.com/terser/terser) from 5.9.0 to 5.14.2.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-27 12:37:29 -06:00
Antonio Rivero Martinez
07ce33d142
Reports: (#20753)
- dashboardInfo might be an empty object, in which case we must use the chart info instead so the resourceId is not undefined
2022-07-27 12:33:13 -06:00
Antonio Rivero Martinez
234c44626d
TableChart: (#20833)
- Handle resize properly when only the scrollbar is changing so it doesn't get stuck into an infinite loop.
2022-07-27 12:32:34 -06:00
Antonio Rivero Martinez
99085d583d
fix(viz): Header scrolling for Time Table in dashboard (#20874)
* TimeTable:

- Increase the z-index so the sparkline doesn't overlap when scrolling in the dashboard

* Time TAble:

- Remove testing label
2022-07-27 12:24:47 -06:00
Jesse Yang
77db0651d8
feat(sql lab): display presto and trino tracking url (#20799) 2022-07-26 20:20:08 -07:00
Hugh A. Miles II
35184b2994
fix: create property for schema_perm for Query (#20871)
* create property for schema_perm

* update references
2022-07-26 21:18:59 -04:00
Elizabeth Thompson
cd578d2865
add having_druid back into the schema (#20879) 2022-07-26 17:54:46 -07:00
John Bodley
d327437462
refactor: Improve performance regression introduced in #20473 (#20810)
* refactor: Improve performance regression introduced in #20473

* Update dao.py
2022-07-26 17:47:15 -07:00
Jesse Yang
4d192e6e4d
feat(report): capture dashboard reports in specific states (#20552) 2022-07-26 17:01:56 -07:00
Srini Kadamati
1b577d15c1
chore: updated resources with newer blogs and events (#20858)
* chore: updated resources with newer blogs and events

* incorporated feedback and added missing link to 2.0 release notes

* Update README.md

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-07-26 15:46:11 -04:00
Phillip Kelley-Dotson
2f3e11db66
feat: blankstate metrics columns (#20755)
* add POC ExploreMixin

* Working POC
> columns are loading into page

* Created/tested query dataset dropdown

* Add isValidDatasourceType to @superset-ui/core and hide query dropdown

* Visual updates to explore datasource panel

* Temporarily make Query icon visible

* Remove Query icon visibility

* Removed isValidDatasourceType check

* Added Query preview Modal from DatasourceControl if the data source type is Query [41493]

Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component

* > fix integration point with frontend
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working

* Adjusts conditional logic approach to be extensible for additional types from DatasourceTypes options

* refactor

* set field for sql

* Fixes issue where Missing query parameters error was showing in datasourcePanel

* add query_language

* fix ds main_dttm

* Fixes issue where menu.tsx was blocking access to redux debugging for SqlLab and Explore

* Fixes issue where database id was not available to save query as dataset, adds default metric when chart source is query

* oops

* fix pre-commit to 50 errors now

* fix circuliar dep

* Disables showing Metrics section in DatasourcePanel when Query is the datasource

A follow on separate effort will enable having a default Count metric when Query is the datasource type

* adds condition to use query.columns if query.results is not present enable saving query as a dataset

* down to 26 now

* patch for pre-commit

* one more pre-commit

* added explore_json error

* added error messages

* add for metrics

* add text for columns

* add model open/close method

* add propogation and methods

* change link to span

* lint fix

* Fixes frontend lint and TypeScript errors unit test fixes will be next commit

* Aditional TypeScript error fix

* Fixes unit test failure

* fix some types

* added frontend piece

* fix type

* Fixes bad import caused by merge from master and removes duplicate showSaveDatasetModal check

* Fixes for DartasourceControl Test Suite

* Fix lint error

* Fixes unit test issues due to array instead of a component being passed to modal footer

* Fixes unit test failure for DatasourceControl and simplifies getDatasourceTitle based on PR comment

* fix ts

* pylint

* core_test fix

* Fixes line error post merge from master

* fixed from master

* fixed from master

* Fixes issue where Overwrite dataset does not work due to userid error

SPA refractor changed Redux structure that is used when in explore (which is now within SPA).  user object is at the root of the store now for anything under SPA.

* Resolves TypeScript errors with changes made for SPA merging in and changes needed for overwriting dataset from SaveDatasetModal

* fix: top right panel view query functionality

* remove unneeded code from core.py

* working samples endpoint for query

* add owner check

* update FE for it

* handle columns are dict vs object

* fix exceptions

* fix fe lint

* fix test

* add tab_name to payload

* Enables use of tab name from Query

* fix cypress test

* save columns on execution

* fix frontend build test

* remove parathesis around columns

* changing column types

* fixing samples that has literal_columns

* address comments

* add changes

* fix path

* fix merge

* fix types

* remove console

* add type

* fix linting

* update to enum

* fix test

* remove explore from buttons

* fix logic

* fix logic

* oops

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-07-26 14:32:30 -04:00
Jesse Yang
6e6d4e3169
test: suppress unnecessary fab and sqla logs (#20870) 2022-07-26 10:36:24 -07:00
John Bodley
e1094e2198
fix: Add migration to add created_by_fk as explicit owner for charts and datasets (#20617)
* fix: Add migration to add created_by_fk as owner

* Update 2022-07-05_15-48_409c7b420ab0_add_created_by_fk_as_owner.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-07-26 10:22:19 -07:00
Geido
a69f016bca
chore: Feature flag for embedding charts (#20804)
* Add EMBEDDABLE_CHARTS feature flag

* Pretty

* Update test
2022-07-26 17:55:44 +03:00
Yongjie Zhao
cb9ae38361
fix: switch form_data between different datasource (#20867) 2022-07-26 22:13:17 +08:00
Geido
76f573a4ea
chore: Ignore Applitools by default when running Cypress tests (#20789)
* Exclude applitools by default

* Remove unnecessary check

* Trim
2022-07-26 16:57:45 +03:00
Srini Kadamati
ce1974176f
docs: fix alt image issue (#20856) 2022-07-26 08:25:27 -04:00
Kamil Gabryjelski
46deb79f50
fix: Fix chart title truncating when Chrome is zoomed out (#20847) 2022-07-26 10:21:17 +02:00
Yongjie Zhao
55a89dfac9
feat: a simple LRUCache in frontend (#20842) 2022-07-26 15:02:10 +08:00
Kamil Gabryjelski
5c2c2e8040
feat(explore): UX changes in fast viz switcher (#20848)
* feat(explore): UX changes in fast viz switcher

* Fix test
2022-07-26 08:44:17 +02:00
Diego Medina
5d107b86ab
fix: explore warnings cleanup (#20864) 2022-07-26 13:28:50 +08:00