Commit Graph

5814 Commits

Author SHA1 Message Date
Kasia Kucharczyk
88a671153b
Pylint disabled rule pointless-string-statement is not raising warining anymore - removing (#10975) 2020-09-21 08:45:21 -07:00
Kasia Kucharczyk
9d7b3536e1
fix: pylint disabled rules in dashboard/api.py (#10976)
* Refactored `put` method in dashboards/api.py:
- changed retun statements
- removed lint disabled rule

* `arguments-differ` disabled rule is not anymore valid - put argiments don't differ

* `delete()` method in dashboards/api has now same list of argiments:
- removing unecessary pylint check disabled

* `bulk_delete()` method in dashboards/api has now same list of argiments:
    - removing unecessary pylint check disabled
2020-09-21 16:02:41 +01:00
Kasia Kucharczyk
fd0f6e1541
fix: removed disabled lint rule too-many-locals in connectors/base/models.py (#10958) 2020-09-21 09:13:38 +01:00
Kamil Gabryjelski
4835d3b0a2
ESLint: Re-enable rule no-access-state-in-setstate (#10870)
* Re-enable rule no-access-state-in-setstate

* Move accessing event values out of async functions
2020-09-20 23:48:23 -07:00
Ville Brofeldt
3d8f757ac8
fix: simply is_adhoc_metric (#10964)
* fix: simply is_adhoc_metric

* address comment
2020-09-20 13:22:55 +03:00
Kamil Gabryjelski
557a303cc5
ESLint: Enable rule no-named-as-default (#10879)
* Enable rule no-named-as-default

* Fix wrong import
2020-09-18 13:41:01 -07:00
Kamil Gabryjelski
91fd06e093
ESLint: Remove ts-ignore (#10961)
* Fix prop types of styled

* Fix props in windowed
2020-09-18 13:33:32 -07:00
Srini Kadamati
4a4fdb1e02
docs: set up client-side redirects from previous era docs urls (#10921)
* one simple redirect, as a test

* adding license to header

* painstakingly added SEO redirects!

* addressed feedback and ran lint-fix!

* lets try newline again!

* Revert "lets try newline again!"

This reverts commit 20f89bd23c.

* Revert "Revert "lets try newline again!""

This reverts commit e441edc54a.

* wait... there were TWO newlines?

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-09-18 13:31:22 -07:00
Evan Rusackas
d4f33cc9de
Ignore '/docs' on some GH actions, give docs its own action (#10949)
* ignore docs on several actions, give docs its own action

* Random doc change to see if the new action runs.

* umm... not paths-ignore, paths!

* eof fix

* enabling typescript checking on docs
2020-09-18 12:23:48 -07:00
Jesse Yang
4f607371e5
fix: typo in prefer typescript (#10959)
Prefer TypeScript has stopped working since #10170 because of a [typo](https://github.com/apache/incubator-superset/pull/10170/files#diff-0f1a9bbd1316e385c51f8aba1583bd99R24) in `jq` script.

Also fix the `trilom/file-changes-action` GH Action version so the process can be more predictable.
2020-09-18 12:02:09 -07:00
Kamil Gabryjelski
ccfd293227
ESLint: no-restricted-syntax (#10889)
* Enable no-restricted syntax rule

* Fix webpack.config.js

* Remove unused function from utils/common.js

* Refactor triple nested for loop

* Fix loops in src/explore components

* Fix loops in SqlLab components

* Fix loops in AlteredSliceTag

* Fix loops in FilterableTable

* Add fixtures and uinit tests for findControlItem

* Add license
2020-09-18 09:05:57 -07:00
Kasia Kucharczyk
2003442b32
fix: several disabled pylint rules in models/helpers.py (#10909)
* Removed conflicting lint and isort check in model helpers seems it's not appearing anymore

* Removed disabled linting for accessing private method. `parent_foreign_key_mappings` becomes public because it is accessed by other instance than `self`.

* Updated model's helper - removed unecessary exception and replaced with check while accessing global context to reset ownerships.

* Updated model's helper - renamed unused attribute to private in user link method.

* Updated model's helper - added specific exception for adding extra json column. Removed disabled pylint rule.

* Applied changes after review to `models/helpers.py`:
- removed unecesary function's param rename
- added extra JSON content in exception

* Removed self.extra_json content from exception message.
2020-09-18 16:32:02 +01:00
Daniel Vaz Gaspar
e375ed4678
fix(jinja): make context attrs private on SQL templates (#10934)
* fix(jinja): make SQLAlchemy models private on SQL templates

* add missing privates

* fix test
2020-09-18 12:56:07 +01:00
Kasia Kucharczyk
e21a354b3b
fix: update pylint disabled checks in common/query_context.py (#10941)
* Updated common/query_context.py
- removed disabled pylint rule no-self-use from `df_metrics_to_num` since it has `@staticmethod`
- applied black on the file

* Removed disabled lint check `too-many-locals` in get_df_payload method. Applied black.

* Method `get_data()` has self param:
- removing # pylint: disable=no-self-use
- autoformatting
2020-09-17 21:30:02 -07:00
Kasia Kucharczyk
141ef4a188
Updated type: ignore in model's helper: (#10906)
- added sql alchemy mapper as a type
2020-09-17 13:49:14 -07:00
Elizabeth Thompson
ed9b50be2c
chore: upgrade cypress to use retries (#10923) 2020-09-17 12:54:50 -07:00
ʈᵃᵢ
213b772368
chore: remove SIP_34_DATABASE_UI (#10926) 2020-09-17 12:53:00 -07:00
Kasia Kucharczyk
d6be977d1b
fix: address all disabled pylint checks in charts/api.py (#10932)
* Refactored put in charts/api.py to have less return statement. Removed pylint rule too-many-return-statements

* Refactored data() in charts/api.py to have less return statement. Removed pylint rule too-many-return-statements

* Pylint disabled arguments-differ check is not necessary anymore in put method

* Pylint disabled arguments-differ check is not necessary anymore in delete method

* Pylint disabled arguments-differ check is not necessary anymore in bulk_delete method. Applied black
2020-09-17 17:31:44 +01:00
Kasia Kucharczyk
8735a14ea7
Removed global pylintrc rule: old-ne-operator. Which is not applicable in code anymore. (#10915) 2020-09-17 06:47:52 -07:00
Ville Brofeldt
69081009d3
fix(legacy-druid): undefined filter key (#10931) 2020-09-17 15:10:06 +03:00
Moriah Kreeger
5623cd64ca
feat: update saved query backend routing + add savedquery list (#10922)
* Update saved query backend routing + add savedquery list

* add spec fileg

* add FE flag for SIP_34_SAVED_QUERIES_UI
2020-09-16 21:08:40 -07:00
Kasia Kucharczyk
cd77797802
Removed disabled linting redefined-outer-name. Url parameters are renamed where url was already defined in class attributes (#10911) 2020-09-16 20:22:46 -07:00
Yongjie Zhao
af75bee582
feat: adding dashboard toggle fullscreen button (#10840) 2020-09-16 14:20:52 -07:00
Elizabeth Thompson
a3519b42cb
fix lint errors (#10918)
Co-authored-by: Elizabeth Thompson <elizabeth@preset.io>
2020-09-16 13:42:27 -07:00
Yongjie Zhao
5099dbef6b
fix: babel script broken by format string (#10902) 2020-09-16 13:35:35 -07:00
Rob DiCiuccio
d74044c2e6
Update FOSSA configuration for new requirements layout (#10848)
* Update FOSSA configuration

* test FOSSA failure

* Update FOSSA files changed regex

* Revert "test FOSSA failure"

This reverts commit a97213db78.

* pre-commit linting

* remove docker.txt check
2020-09-16 13:28:04 -07:00
Kamil Gabryjelski
281305e0cf
Enable anchor-has-content rule (#10908) 2020-09-16 13:27:52 -07:00
Evan Rusackas
2a5946d117
docs: Client side redirects (one POC) (#10898)
* one simple redirect, as a test

* adding license to header
2020-09-16 13:24:26 -07:00
Elizabeth Thompson
0d90bc9920
chore: update port that cypress runs on for local vs test (#10847) 2020-09-16 12:31:03 -07:00
Elizabeth Thompson
d3e9c565b7
feat: use svg for checkbox component (#10799)
* use svg for checkbox component

* add vertical align to svg

* use emotion styling

* update import to superset core

Co-authored-by: Elizabeth Thompson <elizabeth@preset.io>
2020-09-16 12:03:14 -07:00
Elizabeth Thompson
13cc1a3d2d
fix: front end CI tests and test runner (#10897) 2020-09-16 11:35:18 -07:00
Bogdan
c3f1720456
fix: superset alerting misc fixes (#10891)
* Superset alerting misc fixes

* Test 0 threshold

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-09-16 11:09:11 -07:00
Evan Rusackas
d4ee073bfe
simplifying/clarifying youtube video code/datastructures (#10882)
* simplifying/clarifying youtube video code/datastructures

* adding role to clickable div
2020-09-16 09:57:04 -07:00
Evan Rusackas
87fc425be9
Fixing docs site home screen mobile layout issues (#10886)
* fixing phone layout issues, "sqlab" -> "SQL Lab"

* fixing docs width/scrolling issues

* Revert "fixing docs width/scrolling issues"

This reverts commit 53c6482083.

* minor cherry on top-> remove nowrap and improve a link in README

Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
2020-09-16 09:56:56 -07:00
Erik Ritter
f9cfb3ed0e
fix: spelling in docs homepage (#10912) 2020-09-16 09:48:08 -07:00
Maxime Beauchemin
0870d3ae2b
docs: add back issue code links (#10903)
* docs: add back issue code links

closes: https://github.com/apache/incubator-superset/issues/10852

* Addressing comments
2020-09-16 09:28:53 -07:00
Jesse Yang
d4291edffa
build: optimize eslint import resolver configs (#10901)
Use `node` resolver and `node` env for `webpack.config.js`, use
`webpack` resolver only for `src`.
2020-09-16 09:26:14 -07:00
Maxime Beauchemin
3b035d2af3
docs: redirect http -> https (#10900)
* docs: redirect http -> https

* fix issues
2020-09-16 08:24:08 -07:00
Daniel Vaz Gaspar
9246c9bdaf
refactor: ASF only dependencies on base.txt (#10875) 2020-09-16 14:57:41 +01:00
Ville Brofeldt
15fe04e3ef
docs: add changelog entries for 0.37.1 (#10893) 2020-09-16 12:29:03 +03:00
Evan Rusackas
1f7301025a
correcting 2 steps in docs deployment readme (#10899) 2020-09-15 22:09:32 -07:00
Jesse Yang
4eeee4c2eb
chore: enable eslint-import-resolver-typescript (#10895)
Let eslint understand tsconfig.json when importing modules, so we
can use `compilerOption.paths` to override where to find ts modules.
2020-09-15 15:33:49 -07:00
Moriah Kreeger
c43992bec8
feat: data menu routing (#10880) 2020-09-15 14:53:31 -07:00
ʈᵃᵢ
fe9f6148d8
fix(cypress): prevent CI failure on codecov failure (#10892) 2020-09-15 14:31:43 -07:00
Jesse Yang
0129c4253d
feat: move ace-editor and mathjs to async modules (#10837)
Follow up on #10831, move brace and mathjs to async modules so that the initial page load for dashboards most pages can be faster.
2020-09-15 14:12:06 -07:00
Evan Rusackas
5d529fd844
fixing broken links (#10885) 2020-09-15 13:18:42 -07:00
John Bodley
b48dd4b7d9
chore: Using cache factory method (#10887)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-09-15 12:48:19 -07:00
Bogdan
9c420d6efe
feat: implement cache invalidation api (#10761)
* Add cache endpoints

* Implement cache endpoint

* Tests and address feedback

* Set cache config

* Address feedback

* Expose only invalidate endpoint

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-09-15 11:17:21 -07:00
Ville Brofeldt
838a70ea8d
docs: fix ubuntu 20.04 installation instructions (#10888) 2020-09-15 21:16:57 +03:00
ʈᵃᵢ
045335a687
fix(cypress): wait for filterValues request (#10884) 2020-09-15 09:52:44 -07:00