pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 13:57:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: bump react-redux to 5.1.2, whittling console noise (#10602)

Browse Source 
* chore: bump react-redux to 5.1.2

* fixing spy, and thus the breaking test.

* relabeling tests to UNSAFE_componentWillReceiveProps because why not.
This commit is contained in:
Evan Rusackas 2020-08-16 21:29:08 -07:00 committed by GitHub
parent ed9b6dbf2b
commit f868580f64
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 150 additions and 147 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

276
superset-frontend/package-lock.json generated
View File

File diff suppressed because it is too large Load Diff

2
superset-frontend/package.json
View File

@ -166,7 +166,7 @@
"react-json-tree": "^0.11.2", "react-json-tree": "^0.11.2",
"react-jsonschema-form": "^1.2.0", "react-jsonschema-form": "^1.2.0",
"react-markdown": "^4.3.1", "react-markdown": "^4.3.1",
"react-redux": "^5.0.2", "react-redux": "^5.1.2",
"react-router-dom": "^5.1.2", "react-router-dom": "^5.1.2",
"react-search-input": "^0.11.3", "react-search-input": "^0.11.3",
"react-select": "^3.1.0", "react-select": "^3.1.0",

2
superset-frontend/spec/javascripts/dashboard/components/Dashboard_spec.jsx
View File

@ -73,7 +73,7 @@ describe('Dashboard', () => {
expect(wrapper.find(DashboardBuilder)).toExist(); expect(wrapper.find(DashboardBuilder)).toExist();
}); });
describe('componentWillReceiveProps', () => { describe('UNSAFE_componentWillReceiveProps', () => {
const layoutWithExtraChart = { const layoutWithExtraChart = {
...props.layout, ...props.layout,
1001: newComponentFactory(CHART_TYPE, { chartId: 1001 }), 1001: newComponentFactory(CHART_TYPE, { chartId: 1001 }),

2
superset-frontend/spec/javascripts/dashboard/components/SliceAdder_spec.jsx
View File

@ -97,7 +97,7 @@ describe('SliceAdder', () => {
props.fetchAllSlices.restore(); props.fetchAllSlices.restore();
}); });
describe('componentWillReceiveProps', () => { describe('UNSAFE_componentWillReceiveProps', () => {
let wrapper; let wrapper;
beforeEach(() => { beforeEach(() => {
wrapper = shallow(<SliceAdder {...props} />); wrapper = shallow(<SliceAdder {...props} />);

4
superset-frontend/spec/javascripts/explore/components/ExploreViewContainer_spec.jsx
View File

@ -79,7 +79,7 @@ describe('ExploreViewContainer', () => {
expect(wrapper.find(ChartContainer)).toExist(); expect(wrapper.find(ChartContainer)).toExist();
}); });
describe('componentWillReceiveProps()', () => { describe('UNSAFE_componentWillReceiveProps()', () => {
it('when controls change, should call resetControls', () => { it('when controls change, should call resetControls', () => {
expect(wrapper.instance().props.controls.viz_type.value).toBe('table'); expect(wrapper.instance().props.controls.viz_type.value).toBe('table');
const resetControls = sinon.stub( const resetControls = sinon.stub(
@ -91,7 +91,7 @@ describe('ExploreViewContainer', () => {
'triggerQuery', 'triggerQuery',
); );
// triggers componentWillReceiveProps // triggers UNSAFE_componentWillReceiveProps
wrapper.setProps({ wrapper.setProps({
controls: { controls: {
viz_type: { viz_type: {

2
superset-frontend/spec/javascripts/explore/components/SelectControl_spec.jsx
View File

@ -145,7 +145,7 @@ describe('SelectControl', () => {
}); });
}); });
describe('componentWillReceiveProps', () => { describe('UNSAFE_componentWillReceiveProps', () => {
it('sets state.options if props.choices has changed', () => { it('sets state.options if props.choices has changed', () => {
const updatedOptions = [ const updatedOptions = [
{ value: 'three', label: 'three' }, { value: 'three', label: 'three' },

2
superset-frontend/spec/javascripts/sqllab/ResultSet_spec.jsx
View File

@ -75,7 +75,7 @@ describe('ResultSet', () => {
const wrapper = shallow(<ResultSet {...mockedProps} />); const wrapper = shallow(<ResultSet {...mockedProps} />);
expect(wrapper.find(FilterableTable)).toExist(); expect(wrapper.find(FilterableTable)).toExist();
}); });
describe('componentWillReceiveProps', () => { describe('UNSAFE_componentWillReceiveProps', () => {
const wrapper = shallow(<ResultSet {...mockedProps} />); const wrapper = shallow(<ResultSet {...mockedProps} />);
let spy; let spy;
beforeEach(() => { beforeEach(() => {

7
superset-frontend/spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx
View File

@ -138,11 +138,14 @@ describe('TabbedSqlEditors', () => {
); );
}); });
}); });
describe('componentWillReceiveProps', () => { describe('UNSAFE_componentWillReceiveProps', () => {
let spy; let spy;
beforeEach(() => { beforeEach(() => {
wrapper = getWrapper(); wrapper = getWrapper();
spy = sinon.spy(TabbedSqlEditors.prototype, 'componentWillReceiveProps'); spy = sinon.spy(
TabbedSqlEditors.prototype,
'UNSAFE_componentWillReceiveProps',
);
wrapper.setProps({ queryEditors, queries, tabHistory, tables }); wrapper.setProps({ queryEditors, queries, tabHistory, tables });
}); });
afterEach(() => { afterEach(() => {