pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-17 11:09:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use Alert for visualization error (#1639)

Browse Source
This commit is contained in:
vera-liu 2016-11-18 13:38:14 -08:00 committed by GitHub
parent a8480f5492
commit f64a205603
1 changed files with 6 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
superset/assets/javascripts/explorev2/components/ChartContainer.jsx
View File

@ -108,28 +108,12 @@ class ChartContainer extends React.Component {
// finished rendering callback // finished rendering callback
}, },
error(msg, xhr) { clearError: () => {
let errorMsg = msg; this.props.actions.removeChartAlert();
let errHtml = ''; },
try {
const o = JSON.parse(msg); error(msg) {
if (o.error) { this.props.actions.chartUpdateFailed(msg);
errorMsg = o.error;
}
} catch (e) {
// pass
}
errHtml = `<div class="alert alert-danger">${errorMsg}</div>`;
if (xhr) {
const extendedMsg = this.getErrorMsg(xhr);
if (extendedMsg) {
errHtml += `<div class="alert alert-danger">${extendedMsg}</div>`;
}
}
$(this.state.selector).html(errHtml);
this.render();
$('span.query').removeClass('disabled');
$('.query-and-save button').removeAttr('disabled');
}, },
d3format: (col, number) => { d3format: (col, number) => {