fix: disable lazy import for line chart and box plot (#82)

* fix: disable lazy import

* fix: lint
This commit is contained in:
Krist Wongsuphasawat 2019-05-07 19:19:41 -07:00 committed by Yongjie Zhao
parent ff7ef2b2b3
commit f1164aece0
5 changed files with 12 additions and 8 deletions

View File

@ -25,7 +25,7 @@ import { createSelector } from 'reselect';
import createTooltip from './createTooltip'; import createTooltip from './createTooltip';
import XYChartLayout from '../utils/XYChartLayout'; import XYChartLayout from '../utils/XYChartLayout';
import WithLegend from '../components/WithLegend'; import WithLegend from '../components/WithLegend';
import ChartLegend from '../components/ChartLegend'; import ChartLegend from '../components/legend/ChartLegend';
import Encoder, { ChannelTypes, Encoding, Outputs } from './Encoder'; import Encoder, { ChannelTypes, Encoding, Outputs } from './Encoder';
import { Dataset, PlainObject } from '../encodeable/types/Data'; import { Dataset, PlainObject } from '../encodeable/types/Data';
@ -52,6 +52,9 @@ type Props = {
export default class BoxPlot extends React.PureComponent<Props> { export default class BoxPlot extends React.PureComponent<Props> {
static defaultProps = defaultProps; static defaultProps = defaultProps;
encoder: Encoder;
private createEncoder: () => void;
constructor(props: Props) { constructor(props: Props) {
super(props); super(props);
@ -68,9 +71,6 @@ export default class BoxPlot extends React.PureComponent<Props> {
this.renderChart = this.renderChart.bind(this); this.renderChart = this.renderChart.bind(this);
} }
encoder: Encoder;
private createEncoder: () => void;
renderChart(dim: Dimension) { renderChart(dim: Dimension) {
const { width, height } = dim; const { width, height } = dim;
const { data, encoding, margin, theme } = this.props; const { data, encoding, margin, theme } = this.props;

View File

@ -19,11 +19,12 @@
import { ChartPlugin } from '@superset-ui/chart'; import { ChartPlugin } from '@superset-ui/chart';
import createMetadata from './createMetadata'; import createMetadata from './createMetadata';
import transformProps from './transformProps'; import transformProps from './transformProps';
import Chart from './BoxPlot';
export default class BoxPlotChartPlugin extends ChartPlugin { export default class BoxPlotChartPlugin extends ChartPlugin {
constructor() { constructor() {
super({ super({
loadChart: () => import('./BoxPlot'), Chart,
metadata: createMetadata(), metadata: createMetadata(),
transformProps, transformProps,
}); });

View File

@ -19,11 +19,12 @@
import { ChartPlugin } from '@superset-ui/chart'; import { ChartPlugin } from '@superset-ui/chart';
import createMetadata from '../createMetadata'; import createMetadata from '../createMetadata';
import transformProps from './transformProps'; import transformProps from './transformProps';
import Chart from '../BoxPlot';
export default class BoxPlotChartPlugin extends ChartPlugin { export default class BoxPlotChartPlugin extends ChartPlugin {
constructor() { constructor() {
super({ super({
loadChart: () => import('../BoxPlot'), Chart,
metadata: createMetadata(true), metadata: createMetadata(true),
transformProps, transformProps,
}); });

View File

@ -3,12 +3,13 @@ import transformProps from './transformProps';
import createMetadata from './createMetadata'; import createMetadata from './createMetadata';
import buildQuery from './buildQuery'; import buildQuery from './buildQuery';
import ChartFormData from './ChartFormData'; import ChartFormData from './ChartFormData';
import Chart from './Line';
export default class LineChartPlugin extends ChartPlugin<ChartFormData> { export default class LineChartPlugin extends ChartPlugin<ChartFormData> {
constructor() { constructor() {
super({ super({
buildQuery, buildQuery,
loadChart: () => import('./Line'), Chart,
metadata: createMetadata(), metadata: createMetadata(),
transformProps, transformProps,
}); });

View File

@ -1,11 +1,12 @@
import { ChartPlugin } from '@superset-ui/chart'; import { ChartPlugin } from '@superset-ui/chart';
import transformProps from './transformProps'; import transformProps from './transformProps';
import createMetadata from '../createMetadata'; import createMetadata from '../createMetadata';
import Chart from '../Line';
export default class LineChartPlugin extends ChartPlugin { export default class LineChartPlugin extends ChartPlugin {
constructor() { constructor() {
super({ super({
loadChart: () => import('../Line'), Chart,
metadata: createMetadata(true), metadata: createMetadata(true),
transformProps, transformProps,
}); });