pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-19 20:19:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: disable lazy import for line chart and box plot (#82)

Browse Source 
* fix: disable lazy import

* fix: lint
This commit is contained in:
Krist Wongsuphasawat 2019-05-07 19:19:41 -07:00 committed by Yongjie Zhao
parent ff7ef2b2b3
commit f1164aece0
5 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/BoxPlot.tsx
View File

@ -25,7 +25,7 @@ import { createSelector } from 'reselect';
import createTooltip from './createTooltip';
import XYChartLayout from '../utils/XYChartLayout';
import WithLegend from '../components/WithLegend';
import ChartLegend from '../components/ChartLegend';
import ChartLegend from '../components/legend/ChartLegend';
import Encoder, { ChannelTypes, Encoding, Outputs } from './Encoder';
import { Dataset, PlainObject } from '../encodeable/types/Data';
@ -52,6 +52,9 @@ type Props = {
export default class BoxPlot extends React.PureComponent<Props> {
static defaultProps = defaultProps;
encoder: Encoder;
private createEncoder: () => void;
constructor(props: Props) {
super(props);
@ -68,9 +71,6 @@ export default class BoxPlot extends React.PureComponent<Props> {
this.renderChart = this.renderChart.bind(this);
}
encoder: Encoder;
private createEncoder: () => void;
renderChart(dim: Dimension) {
const { width, height } = dim;
const { data, encoding, margin, theme } = this.props;

3
superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/index.ts
View File

@ -19,11 +19,12 @@
import { ChartPlugin } from '@superset-ui/chart';
import createMetadata from './createMetadata';
import transformProps from './transformProps';
import Chart from './BoxPlot';
export default class BoxPlotChartPlugin extends ChartPlugin {
constructor() {
super({
loadChart: () => import('./BoxPlot'),
Chart,
metadata: createMetadata(),
transformProps,
});

3
superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/legacy/index.ts
View File

@ -19,11 +19,12 @@
import { ChartPlugin } from '@superset-ui/chart';
import createMetadata from '../createMetadata';
import transformProps from './transformProps';
import Chart from '../BoxPlot';
export default class BoxPlotChartPlugin extends ChartPlugin {
constructor() {
super({
loadChart: () => import('../BoxPlot'),
Chart,
metadata: createMetadata(true),
transformProps,
});

3
superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts
View File

@ -3,12 +3,13 @@ import transformProps from './transformProps';
import createMetadata from './createMetadata';
import buildQuery from './buildQuery';
import ChartFormData from './ChartFormData';
import Chart from './Line';
export default class LineChartPlugin extends ChartPlugin<ChartFormData> {
constructor() {
super({
buildQuery,
loadChart: () => import('./Line'),
Chart,
metadata: createMetadata(),
transformProps,
});

3
superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts
View File

@ -1,11 +1,12 @@
import { ChartPlugin } from '@superset-ui/chart';
import transformProps from './transformProps';
import createMetadata from '../createMetadata';
import Chart from '../Line';
export default class LineChartPlugin extends ChartPlugin {
constructor() {
super({
loadChart: () => import('../Line'),
Chart,
metadata: createMetadata(true),
transformProps,
});