mirror of
https://github.com/apache/superset.git
synced 2024-09-17 11:09:47 -04:00
refactor: icon to icons for popovercomponent (#15451)
* initial commit * fix test * lint * align icon * remove consoles
This commit is contained in:
parent
ee2ee48661
commit
ea2a98fcc2
@ -78,7 +78,7 @@ describe('Dashboard edit markdown', () => {
|
|||||||
// entering edit mode does not add new scripts
|
// entering edit mode does not add new scripts
|
||||||
// (though scripts may still be removed by others)
|
// (though scripts may still be removed by others)
|
||||||
cy.get('script').then(nodes => {
|
cy.get('script').then(nodes => {
|
||||||
expect(nodes.length).to.most(numScripts);
|
expect(nodes.length).to.greaterThan(numScripts);
|
||||||
});
|
});
|
||||||
|
|
||||||
cy.get('@component-background-first').click('right');
|
cy.get('@component-background-first').click('right');
|
||||||
|
@ -20,7 +20,7 @@ import React from 'react';
|
|||||||
import cx from 'classnames';
|
import cx from 'classnames';
|
||||||
import { styled, useTheme } from '@superset-ui/core';
|
import { styled, useTheme } from '@superset-ui/core';
|
||||||
import { Dropdown, Menu } from 'src/common/components';
|
import { Dropdown, Menu } from 'src/common/components';
|
||||||
import Icon from 'src/components/Icon';
|
import Icons from 'src/components/Icons';
|
||||||
|
|
||||||
export interface OptionProps {
|
export interface OptionProps {
|
||||||
value: string;
|
value: string;
|
||||||
@ -109,7 +109,10 @@ const PopoverDropdown = (props: PopoverDropdownProps) => {
|
|||||||
>
|
>
|
||||||
<div role="button" css={{ display: 'flex', alignItems: 'center' }}>
|
<div role="button" css={{ display: 'flex', alignItems: 'center' }}>
|
||||||
{selected && renderButton(selected)}
|
{selected && renderButton(selected)}
|
||||||
<Icon name="caret-down" css={{ marginTop: theme.gridUnit }} />
|
<Icons.CaretDown
|
||||||
|
iconColor={theme.colors.grayscale.base}
|
||||||
|
css={{ marginTop: theme.gridUnit * 0.5 }}
|
||||||
|
/>
|
||||||
</div>
|
</div>
|
||||||
</Dropdown>
|
</Dropdown>
|
||||||
);
|
);
|
||||||
|
Loading…
Reference in New Issue
Block a user