pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 08:39:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

[bugfix] missing redirect when datasource is missing (#352)

Browse Source
This commit is contained in:
Maxime Beauchemin 2016-04-14 20:25:40 -07:00
parent 4b48e9f1e9
commit e6e8ec9620
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
caravel/views.py
View File

@ -449,6 +449,7 @@ class Caravel(BaseView):
@expose("/datasource/<datasource_type>/<datasource_id>/") # Legacy url
@log_this
def explore(self, datasource_type, datasource_id):
error_redirect = '/slicemodelview/list/'
datasource_class = models.SqlaTable \
if datasource_type == "table" else models.DruidDatasource
datasources = (
@ -469,6 +470,7 @@ class Caravel(BaseView):
)
if not datasource:
flash("The datasource seems to have been deleted", "alert")
return redirect(error_redirect)
all_datasource_access = self.appbuilder.sm.has_access(
'all_datasource_access', 'all_datasource_access')
@ -476,7 +478,7 @@ class Caravel(BaseView):
'datasource_access', datasource.perm)
if not (all_datasource_access or datasource_access):
flash("You don't seem to have access to this datasource", "danger")
return redirect('/slicemodelview/list/')
return redirect(error_redirect)
action = request.args.get('action')
if action in ('save', 'overwrite'):