mirror of https://github.com/apache/superset.git
chore: add stats logging to thumbnail api (#16133)
This commit is contained in:
parent
b07c80a839
commit
df50a47777
|
@ -118,6 +118,9 @@ services:
|
|||
depends_on: *superset-depends-on
|
||||
user: *superset-user
|
||||
volumes: *superset-volumes
|
||||
# Bump memory limit if processing selenium / thumbails on superset-worker
|
||||
# mem_limit: 2038m
|
||||
# mem_reservation: 128M
|
||||
|
||||
superset-worker-beat:
|
||||
image: *superset-image
|
||||
|
|
|
@ -29440,6 +29440,7 @@
|
|||
"resolved": "https://registry.npmjs.org/fsevents/-/fsevents-1.2.13.tgz",
|
||||
"integrity": "sha512-oWb1Z6mkHIskLzEJ/XWX0srkpkTQ7vaopMQkyaEIoq0fmtFVxOthb8cCxeT+p3ynTdkk/RZwbgG4brR5BeWECw==",
|
||||
"dev": true,
|
||||
"hasInstallScript": true,
|
||||
"optional": true,
|
||||
"os": [
|
||||
"darwin"
|
||||
|
@ -48774,6 +48775,7 @@
|
|||
"resolved": "https://registry.npmjs.org/fsevents/-/fsevents-1.2.13.tgz",
|
||||
"integrity": "sha512-oWb1Z6mkHIskLzEJ/XWX0srkpkTQ7vaopMQkyaEIoq0fmtFVxOthb8cCxeT+p3ynTdkk/RZwbgG4brR5BeWECw==",
|
||||
"dev": true,
|
||||
"hasInstallScript": true,
|
||||
"optional": true,
|
||||
"os": [
|
||||
"darwin"
|
||||
|
|
|
@ -989,6 +989,7 @@ class ChartRestApi(BaseSupersetModelRestApi):
|
|||
)
|
||||
# If not screenshot then send request to compute thumb to celery
|
||||
if not screenshot:
|
||||
self.incr_stats("async", self.thumbnail.__name__)
|
||||
logger.info(
|
||||
"Triggering thumbnail compute (chart id: %s) ASYNC", str(chart.id)
|
||||
)
|
||||
|
@ -996,11 +997,13 @@ class ChartRestApi(BaseSupersetModelRestApi):
|
|||
return self.response(202, message="OK Async")
|
||||
# If digests
|
||||
if chart.digest != digest:
|
||||
self.incr_stats("redirect", self.thumbnail.__name__)
|
||||
return redirect(
|
||||
url_for(
|
||||
f"{self.__class__.__name__}.thumbnail", pk=pk, digest=chart.digest
|
||||
)
|
||||
)
|
||||
self.incr_stats("from_cache", self.thumbnail.__name__)
|
||||
return Response(
|
||||
FileWrapper(screenshot), mimetype="image/png", direct_passthrough=True
|
||||
)
|
||||
|
|
|
@ -820,10 +820,12 @@ class DashboardRestApi(BaseSupersetModelRestApi):
|
|||
).get_from_cache(cache=thumbnail_cache)
|
||||
# If the screenshot does not exist, request one from the workers
|
||||
if not screenshot:
|
||||
self.incr_stats("async", self.thumbnail.__name__)
|
||||
cache_dashboard_thumbnail.delay(dashboard_url, dashboard.digest, force=True)
|
||||
return self.response(202, message="OK Async")
|
||||
# If digests
|
||||
if dashboard.digest != digest:
|
||||
self.incr_stats("redirect", self.thumbnail.__name__)
|
||||
return redirect(
|
||||
url_for(
|
||||
f"{self.__class__.__name__}.thumbnail",
|
||||
|
@ -831,6 +833,7 @@ class DashboardRestApi(BaseSupersetModelRestApi):
|
|||
digest=dashboard.digest,
|
||||
)
|
||||
)
|
||||
self.incr_stats("from_cache", self.thumbnail.__name__)
|
||||
return Response(
|
||||
FileWrapper(screenshot), mimetype="image/png", direct_passthrough=True
|
||||
)
|
||||
|
|
Loading…
Reference in New Issue