fix: clean up prop type errors in jest tests (#11120)

This commit is contained in:
Elizabeth Thompson 2020-10-02 14:59:04 -07:00 committed by GitHub
parent 662fb43350
commit d95b7c2a73
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 55 additions and 14 deletions

View File

@ -22,14 +22,25 @@ import { SuperChart } from '@superset-ui/core';
import ChartRenderer from 'src/chart/ChartRenderer'; import ChartRenderer from 'src/chart/ChartRenderer';
const requiredProps = {
chartId: 1,
datasource: {},
formData: {},
vizType: 'foo',
};
describe('ChartRenderer', () => { describe('ChartRenderer', () => {
it('should render SuperChart', () => { it('should render SuperChart', () => {
const wrapper = shallow(<ChartRenderer refreshOverlayVisible={false} />); const wrapper = shallow(
<ChartRenderer {...requiredProps} refreshOverlayVisible={false} />,
);
expect(wrapper.find(SuperChart)).toExist(); expect(wrapper.find(SuperChart)).toExist();
}); });
it('should not render SuperChart when refreshOverlayVisible is true', () => { it('should not render SuperChart when refreshOverlayVisible is true', () => {
const wrapper = shallow(<ChartRenderer refreshOverlayVisible />); const wrapper = shallow(
<ChartRenderer {...requiredProps} refreshOverlayVisible />,
);
expect(wrapper.find(SuperChart)).not.toExist(); expect(wrapper.find(SuperChart)).not.toExist();
}); });
}); });

View File

@ -28,6 +28,7 @@ describe('URLShortLinkModal', () => {
url: 'mockURL', url: 'mockURL',
emailSubject: 'Mock Subject', emailSubject: 'Mock Subject',
emailContent: 'mock content', emailContent: 'mock content',
triggerNode: <div />,
}; };
function setup() { function setup() {

View File

@ -67,6 +67,7 @@ describe('DashboardBuilder', () => {
colorScheme: undefined, colorScheme: undefined,
handleComponentDrop() {}, handleComponentDrop() {},
setDirectPathToChild: sinon.spy(), setDirectPathToChild: sinon.spy(),
setMountedTab() {},
}; };
function setup(overrideProps, useProvider = false, store = mockStore) { function setup(overrideProps, useProvider = false, store = mockStore) {

View File

@ -32,6 +32,13 @@ describe('FilterIndicatorGroup', () => {
colorCode: 'badge-1', colorCode: 'badge-1',
name: column, name: column,
values: ['a', 'b', 'c'], values: ['a', 'b', 'c'],
isFilterFieldActive: true,
chartId: 1,
componentId: 'foo',
directPathToFilter: ['foo'],
isDateFilter: false,
isInstantFilter: false,
label: 'foo',
}, },
], ],
setDirectPathToChild: () => {}, setDirectPathToChild: () => {},

View File

@ -32,6 +32,11 @@ describe('FilterIndicator', () => {
name: column, name: column,
label: column, label: column,
values: ['a', 'b', 'c'], values: ['a', 'b', 'c'],
chartId: 1,
componentId: 'foo',
isDateFilter: false,
isFilterFieldActive: true,
isInstantFilter: false,
}, },
setDirectPathToChild: jest.fn(), setDirectPathToChild: jest.fn(),
}; };

View File

@ -29,21 +29,27 @@ describe('HeaderActionsDropdown', () => {
const props = { const props = {
addSuccessToast: () => {}, addSuccessToast: () => {},
addDangerToast: () => {}, addDangerToast: () => {},
dashboardId: 1,
dashboardTitle: 'Title',
hasUnsavedChanges: false,
customCss: '', customCss: '',
onChange: () => {}, dashboardId: 1,
updateCss: () => {}, dashboardInfo: {},
forceRefreshAllCharts: () => {}, dashboardTitle: 'Title',
startPeriodicRender: () => {},
editMode: false, editMode: false,
expandedSlices: {},
filters: {},
forceRefreshAllCharts: () => {},
hasUnsavedChanges: false,
isLoading: false,
layout: {},
onChange: () => {},
onSave: () => {},
refreshFrequency: 200,
setRefreshFrequency: () => {},
shouldPersistRefreshFrequency: true,
showPropertiesModal: () => {},
startPeriodicRender: () => {},
updateCss: () => {},
userCanEdit: false, userCanEdit: false,
userCanSave: false, userCanSave: false,
layout: {},
filters: {},
expandedSlices: {},
onSave: () => {},
}; };
function setup(overrideProps) { function setup(overrideProps) {

View File

@ -51,6 +51,7 @@ function setup(overrides) {
adhocMetric: sumValueAdhocMetric, adhocMetric: sumValueAdhocMetric,
onChange, onChange,
onClose, onClose,
onResize: () => {},
columns, columns,
...overrides, ...overrides,
}; };

View File

@ -34,6 +34,7 @@ describe('DisplayQueryButton', () => {
latestQueryFormData: { latestQueryFormData: {
datasource: '1__table', datasource: '1__table',
}, },
chartHeight: '30px',
}; };
it('is valid', () => { it('is valid', () => {

View File

@ -26,6 +26,7 @@ describe('ExploreActionButtons', () => {
canDownload: 'True', canDownload: 'True',
latestQueryFormData: {}, latestQueryFormData: {},
queryEndpoint: 'localhost', queryEndpoint: 'localhost',
chartHeight: '30px',
}; };
it('renders', () => { it('renders', () => {

View File

@ -25,6 +25,12 @@ describe('ChartContainer', () => {
sliceName: 'Trend Line', sliceName: 'Trend Line',
vizType: 'line', vizType: 'line',
height: '500px', height: '500px',
actions: {},
can_overwrite: false,
can_download: false,
containerId: 'foo',
width: '50px',
isStarred: false,
}; };
it('renders when vizType is line', () => { it('renders when vizType is line', () => {

View File

@ -25,7 +25,7 @@ import Button from 'src/components/Button';
describe('QueryAndSaveButtons', () => { describe('QueryAndSaveButtons', () => {
const defaultProps = { const defaultProps = {
canAdd: 'True', canAdd: true,
onQuery: sinon.spy(), onQuery: sinon.spy(),
}; };

View File

@ -29,6 +29,7 @@ describe('QuerySearch', () => {
const mockedProps = { const mockedProps = {
actions: {}, actions: {},
height: 0, height: 0,
displayLimit: 50,
}; };
it('is valid', () => { it('is valid', () => {
expect(React.isValidElement(<QuerySearch {...mockedProps} />)).toBe(true); expect(React.isValidElement(<QuerySearch {...mockedProps} />)).toBe(true);