pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[bugfix] visualize flow error: 'Metric x is not valid' (#3181) 

The metric name in the frontend doesn't match the one generated on the
backend. It turns out the explore view will default to the first
metric so specifying one isn't needed.
This commit is contained in:
Maxime Beauchemin 2017-07-26 09:22:25 -07:00 committed by GitHub
parent fca982c609
commit cf1d0f38ad
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
superset/assets/javascripts/SqlLab/components/VisualizeModal.jsx
View File

@ -146,7 +146,6 @@ class VisualizeModal extends React.PureComponent {
this.props.actions.createDatasource(this.buildVizOptions(), this)
.done(() => {
const columns = Object.keys(this.state.columns).map(k => this.state.columns[k]);
const mainMetric = columns.filter(d => d.agg)[0];
const mainGroupBy = columns.filter(d => d.is_dim)[0];
const formData = {
datasource: this.props.datasource,
@ -154,10 +153,6 @@ class VisualizeModal extends React.PureComponent {
since: '100 years ago',
limit: '0',
};
if (mainMetric) {
formData.metrics = [mainMetric.name];
formData.metric = mainMetric.name;
}
if (mainGroupBy) {
formData.groupby = [mainGroupBy.name];
}