pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 00:29:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix a bug in 'getMaxLabelSize' and x axis label not shown problem (#2694)

Browse Source 
* fix

* fix code climate
This commit is contained in:
yileic 2017-04-28 15:14:04 -07:00 committed by Alanna Scott
parent c589616883
commit ce705054fa
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
superset/assets/visualizations/nvd3_vis.js
View File

@ -72,7 +72,7 @@ function hideTooltips() {
function getMaxLabelSize(container, axisClass) {
// axis class = .nv-y2 // second y axis on dual line chart
// axis class = .nv-x // x axis on time series line chart
const labelEls = container.find(`.${axisClass} text`);
const labelEls = container.find(`.${axisClass} text`).not('.nv-axislabel');
const labelDimensions = labelEls.map(i => labelEls[i].getComputedTextLength());
return Math.max(...labelDimensions);
}
@ -430,6 +430,9 @@ function nvd3Vis(slice, payload) {
// apply margins
chart.margin(chartMargins);
if (fd.x_axis_label && fd.x_axis_label !== '' && chart.xAxis) {
chart.margin({ bottom: maxXAxisLabelHeight + marginPad + 25 });
}
// render chart
svg