pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid dividing by zero for sparkline in time table viz (#3679)

This commit is contained in:
michellethomas 2017-10-16 16:31:07 -07:00 committed by Maxime Beauchemin
parent d4d4a9b1f1
commit ce5fa379ec
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
superset/assets/visualizations/time_table.jsx
View File

@ -72,7 +72,12 @@ function viz(slice, payload) {
// Period ratio sparkline
sparkData = [];
for (let i = c.timeRatio; i < data.length; i++) {
sparkData.push(data[i][metric] / data[i - c.timeRatio][metric]);
const prevData = data[i - c.timeRatio][metric];
if (prevData && prevData !== 0) {
sparkData.push(data[i][metric] / prevData);
} else {
sparkData.push(null);
}
}
}
const extent = d3.extent(sparkData);