pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimizing the standalone view (#2663) 

The standalone view doesn't need to fetch the datasources asynchronously
to fill in the dataources dropdown, it also doesn't need to render any
of the controls.
This commit is contained in:
Maxime Beauchemin 2017-04-23 22:13:23 -07:00 committed by GitHub
parent eb762c8bfe
commit cdfc4a35b2
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
superset/assets/javascripts/explorev2/components/ExploreViewContainer.jsx
View File

@ -32,8 +32,11 @@ class ExploreViewContainer extends React.Component {
}
componentDidMount() {
this.props.actions.fetchDatasources();
if (!this.props.standalone) {
this.props.actions.fetchDatasources();
}
window.addEventListener('resize', this.handleResize.bind(this));
this.triggerQueryIfNeeded();
}
componentWillReceiveProps(np) {
@ -47,9 +50,7 @@ class ExploreViewContainer extends React.Component {
}
componentDidUpdate() {
if (this.props.triggerQuery && !this.hasErrors()) {
this.runQuery();
}
this.triggerQueryIfNeeded();
}
componentWillUnmount() {
@ -61,7 +62,8 @@ class ExploreViewContainer extends React.Component {
this.props.actions.removeControlPanelAlert();
this.props.actions.removeChartAlert();
this.runQuery();
this.props.actions.triggerQuery();
history.pushState(
{},
document.title,
@ -81,8 +83,10 @@ class ExploreViewContainer extends React.Component {
}
runQuery() {
this.props.actions.runQuery(this.props.form_data);
triggerQueryIfNeeded() {
if (this.props.triggerQuery && !this.hasErrors()) {
this.props.actions.runQuery(this.props.form_data);
}
}
handleResize() {