pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-16 02:29:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Reset dataset name after saving a new dataset in SQL Lab (#21529)

Browse Source
This commit is contained in:
EugeneTorap 2022-09-21 23:56:45 +03:00 committed by GitHub
parent e438c967c9
commit cbadb8773f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx
View File

@ -17,7 +17,7 @@
* under the License. * under the License.
*/ */
import React, { FunctionComponent, useCallback, useState } from 'react'; import React, { useCallback, useState } from 'react';
import { Radio } from 'src/components/Radio'; import { Radio } from 'src/components/Radio';
import { RadioChangeEvent, AsyncSelect } from 'src/components'; import { RadioChangeEvent, AsyncSelect } from 'src/components';
import { Input } from 'src/components/Input'; import { Input } from 'src/components/Input';
@ -140,8 +140,7 @@ const updateDataset = async (
const UNTITLED = t('Untitled Dataset'); const UNTITLED = t('Untitled Dataset');
// eslint-disable-next-line no-empty-pattern export const SaveDatasetModal = ({
export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
visible, visible,
onHide, onHide,
buttonTextOnSave, buttonTextOnSave,
@ -150,7 +149,7 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
datasource, datasource,
openWindow = true, openWindow = true,
formData = {}, formData = {},
}) => { }: SaveDatasetModalProps) => {
const defaultVizType = useSelector<SqlLabRootState, string>( const defaultVizType = useSelector<SqlLabRootState, string>(
state => state.common?.conf?.DEFAULT_VIZ_TYPE || 'table', state => state.common?.conf?.DEFAULT_VIZ_TYPE || 'table',
); );
@ -388,7 +387,7 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
{t('Save as new')} {t('Save as new')}
<Input <Input
className="sdm-input" className="sdm-input"
defaultValue={datasetName} value={datasetName}
onChange={handleDatasetNameChange} onChange={handleDatasetNameChange}
disabled={newOrOverwrite !== 1} disabled={newOrOverwrite !== 1}
/> />