pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[datasource] Ensuring consistent behavior of datasource editing/saving. (#7037) 

* Update datasource.py

* Update datasource.py
This commit is contained in:
John Bodley 2019-03-18 09:56:52 -07:00 committed by GitHub
parent 5137539a86
commit c771625f10
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
superset/views/datasource.py
View File

@ -20,12 +20,11 @@ import json
from flask import request
from flask_appbuilder import expose
from flask_appbuilder.security.decorators import has_access_api
from flask_babel import gettext as __
from superset import appbuilder, db
from superset.connectors.connector_registry import ConnectorRegistry
from superset.models.core import Database
from .base import BaseSupersetView, check_ownership, json_error_response
from .base import BaseSupersetView, json_error_response
class Datasource(BaseSupersetView):
@ -39,14 +38,6 @@ class Datasource(BaseSupersetView):
orm_datasource = ConnectorRegistry.get_datasource(
datasource_type, datasource_id, db.session)
if not check_ownership(orm_datasource, raise_if_false=False):
return json_error_response(
__(
'You are not authorized to modify '
'this data source configuration'),
status='401',
)
if 'owners' in datasource:
datasource['owners'] = db.session.query(orm_datasource.owner_class).filter(
orm_datasource.owner_class.id.in_(datasource['owners'])).all()