pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 00:29:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqllab): Add templateParams on kv store (#22013)

Browse Source
This commit is contained in:
JUST.in DO IT 2022-11-14 10:46:21 -08:00 committed by GitHub
parent 86d52fcbc4
commit c3f1873c43
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
superset-frontend/src/SqlLab/actions/sqlLab.js
View File

@ -1365,6 +1365,7 @@ export function popStoredQuery(urlId) {
schema: json.schema ? json.schema : null, schema: json.schema ? json.schema : null,
autorun: json.autorun ? json.autorun : false, autorun: json.autorun ? json.autorun : false,
sql: json.sql ? json.sql : 'SELECT ...', sql: json.sql ? json.sql : 'SELECT ...',
templateParams: json.templateParams,
}), }),
), ),
) )

1
superset-frontend/src/SqlLab/components/ShareSqlLabQuery/ShareSqlLabQuery.test.tsx
View File

@ -72,6 +72,7 @@ const unsavedQueryEditor = {
schema: 'query_schema_updated', schema: 'query_schema_updated',
sql: 'SELECT * FROM Updated Limit 100', sql: 'SELECT * FROM Updated Limit 100',
autorun: true, autorun: true,
templateParams: '{ "my_value": "foo" }',
}; };
const standardProviderWithUnsaved: React.FC = ({ children }) => ( const standardProviderWithUnsaved: React.FC = ({ children }) => (

16
superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx
View File

@ -48,13 +48,19 @@ function ShareSqlLabQuery({
}: ShareSqlLabQueryPropTypes) { }: ShareSqlLabQueryPropTypes) {
const theme = useTheme(); const theme = useTheme();
const { dbId, name, schema, autorun, sql, remoteId } = useQueryEditor( const { dbId, name, schema, autorun, sql, remoteId, templateParams } =
queryEditorId, useQueryEditor(queryEditorId, [
['dbId', 'name', 'schema', 'autorun', 'sql', 'remoteId'], 'dbId',
); 'name',
'schema',
'autorun',
'sql',
'remoteId',
'templateParams',
]);
const getCopyUrlForKvStore = (callback: Function) => { const getCopyUrlForKvStore = (callback: Function) => {
const sharedQuery = { dbId, name, schema, autorun, sql }; const sharedQuery = { dbId, name, schema, autorun, sql, templateParams };
return storeQuery(sharedQuery) return storeQuery(sharedQuery)
.then(shortUrl => { .then(shortUrl => {