pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-12 08:39:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix misleading SQL Lab timeout error message (#3825)

Browse Source
This commit is contained in:
Maxime Beauchemin 2017-11-09 19:09:16 -08:00 committed by Grace Guo
parent 330926c167
commit be3da6396f
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
superset/views/core.py
View File

@ -2138,14 +2138,12 @@ class Superset(BaseSupersetView):
# Sync request.
try:
SQLLAB_TIMEOUT = config.get("SQLLAB_TIMEOUT")
with utils.timeout(
seconds=SQLLAB_TIMEOUT,
error_message=(
"The query exceeded the {SQLLAB_TIMEOUT} seconds "
"timeout. You may want to run your query as a "
"`CREATE TABLE AS` to prevent timeouts."
).format(**locals())):
timeout = config.get("SQLLAB_TIMEOUT")
timeout_msg = (
"The query exceeded the {timeout} seconds "
"timeout.").format(**locals())
with utils.timeout(seconds=timeout,
error_message=timeout_msg):
# pylint: disable=no-value-for-parameter
data = sql_lab.get_sql_results(
query_id=query_id, return_results=True)