chore: Removes getUiOverrideRegistry (#24330)

This commit is contained in:
Michael S. Molina 2023-06-09 08:35:11 -03:00 committed by GitHub
parent 65bfe2e21d
commit bdb8bbef32
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 7 deletions

View File

@ -33,6 +33,7 @@ assists people when migrating to a new version.
### Breaking Changes
- [24330](https://github.com/apache/superset/pull/24330) Removes `getUiOverrideRegistry` from `ExtensionsRegistry`.
- [23933](https://github.com/apache/superset/pull/23933) Removes the deprecated Multiple Line Charts.
- [23741](https://github.com/apache/superset/pull/23741) Migrates the TreeMap chart and removes the legacy Treemap code.
- [23712](https://github.com/apache/superset/pull/23712) Migrates the Pivot Table v1 chart to v2 and removes v1 code.

View File

@ -29,7 +29,3 @@ class ExtensionsRegistry extends TypedRegistry<Extensions> {
}
export const getExtensionsRegistry = makeSingleton(ExtensionsRegistry, {});
// Exporting this under the old name for backwards compatibility.
// After downstream folks have migrated to `getExtensionsRegistry`, we should remove this.
export const getUiOverrideRegistry = getExtensionsRegistry;

View File

@ -26,7 +26,7 @@ import {
FeatureFlag,
t,
getSharedLabelColor,
getUiOverrideRegistry,
getExtensionsRegistry,
} from '@superset-ui/core';
import { Global } from '@emotion/react';
import { isFeatureEnabled } from 'src/featureFlags';
@ -58,7 +58,7 @@ import { PageHeaderWithActions } from 'src/components/PageHeaderWithActions';
import { DashboardEmbedModal } from '../DashboardEmbedControls';
import OverwriteConfirm from '../OverwriteConfirm';
const uiOverrideRegistry = getUiOverrideRegistry();
const extensionsRegistry = getExtensionsRegistry();
const propTypes = {
addSuccessToast: PropTypes.func.isRequired,
@ -495,7 +495,7 @@ class Header extends React.PureComponent {
dashboardTitleChanged(updates.title);
};
const NavExtension = uiOverrideRegistry.get('dashboard.nav.right');
const NavExtension = extensionsRegistry.get('dashboard.nav.right');
return (
<div