pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: default missing values to zero on area chart (#8678) 

* Add fill_value to area chart pivot

* Only fill for area chart

* Linting
This commit is contained in:
Ville Brofeldt 2019-12-02 18:53:21 +02:00 committed by GitHub
parent b2633a51d4
commit bd91f334d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
superset/viz.py
View File

@ -1086,6 +1086,7 @@ class NVD3TimeSeriesViz(NVD3Viz):
verbose_name = _("Time Series - Line Chart") verbose_name = _("Time Series - Line Chart")
sort_series = False sort_series = False
is_timeseries = True is_timeseries = True
pivot_fill_value: Optional[int] = None
def to_series(self, df, classed="", title_suffix=""): def to_series(self, df, classed="", title_suffix=""):
cols = [] cols = []
@ -1158,7 +1159,10 @@ class NVD3TimeSeriesViz(NVD3Viz):
) )
else: else:
df = df.pivot_table( df = df.pivot_table(
index=DTTM_ALIAS, columns=fd.get("groupby"), values=self.metric_labels index=DTTM_ALIAS,
columns=fd.get("groupby"),
values=self.metric_labels,
fill_value=self.pivot_fill_value,
) )
rule = fd.get("resample_rule") rule = fd.get("resample_rule")
@ -1444,6 +1448,7 @@ class NVD3TimeSeriesStackedViz(NVD3TimeSeriesViz):
viz_type = "area" viz_type = "area"
verbose_name = _("Time Series - Stacked") verbose_name = _("Time Series - Stacked")
sort_series = True sort_series = True
pivot_fill_value = 0
class DistributionPieViz(NVD3Viz): class DistributionPieViz(NVD3Viz):