mirror of
https://github.com/apache/superset.git
synced 2024-09-12 08:39:45 -04:00
fix(native-filters): Assume that temporal columns exist if column_types is undefined (#15324)
* fix(native-filters): Assume that temporal columns exist if column_types is undefined * Allow column_types to be an empty array
This commit is contained in:
parent
6324490dd3
commit
b89ee0cb38
@ -27,6 +27,7 @@ import {
|
|||||||
SupersetApiError,
|
SupersetApiError,
|
||||||
t,
|
t,
|
||||||
GenericDataType,
|
GenericDataType,
|
||||||
|
ensureIsArray,
|
||||||
} from '@superset-ui/core';
|
} from '@superset-ui/core';
|
||||||
import {
|
import {
|
||||||
ColumnMeta,
|
ColumnMeta,
|
||||||
@ -275,9 +276,15 @@ const FILTER_TYPE_NAME_MAPPING = {
|
|||||||
};
|
};
|
||||||
|
|
||||||
// TODO: add column_types field to DatasourceMeta
|
// TODO: add column_types field to DatasourceMeta
|
||||||
|
// We return true if column_types is undefined or empty as a precaution against backend failing to return column_types
|
||||||
const hasTemporalColumns = (
|
const hasTemporalColumns = (
|
||||||
dataset: DatasourceMeta & { column_types: GenericDataType[] },
|
dataset: DatasourceMeta & { column_types: GenericDataType[] },
|
||||||
) => dataset?.column_types?.includes(GenericDataType.TEMPORAL);
|
) => {
|
||||||
|
const columnTypes = ensureIsArray(dataset?.column_types);
|
||||||
|
return (
|
||||||
|
columnTypes.length === 0 || columnTypes.includes(GenericDataType.TEMPORAL)
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* The configuration form for a specific filter.
|
* The configuration form for a specific filter.
|
||||||
|
Loading…
Reference in New Issue
Block a user